Thu, 28 Dec 2017 10:58:29 +0000Merge temporary head for 3.0PR17Q3.2
RM packaging bot <staff.rm@openbravo.com> [Thu, 28 Dec 2017 10:58:29 +0000] rev 33140
Merge temporary head for 3.0PR17Q3.2

Wed, 27 Dec 2017 05:13:38 +0000Added signature for changeset bbeae3078728
RM packaging bot <staff.rm@openbravo.com> [Wed, 27 Dec 2017 05:13:38 +0000] rev 33139
Added signature for changeset bbeae3078728

Wed, 27 Dec 2017 05:13:38 +0000Added tag 3.0PR17Q3.2 for changeset f500d43a59bb
RM packaging bot <staff.rm@openbravo.com> [Wed, 27 Dec 2017 05:13:38 +0000] rev 33138
Added tag 3.0PR17Q3.2 for changeset f500d43a59bb

Wed, 27 Dec 2017 05:13:37 +0000Update AD_MODULE version to 3.0PR17Q3.2 3.0PR17Q3.2
RM packaging bot <staff.rm@openbravo.com> [Wed, 27 Dec 2017 05:13:37 +0000] rev 33137
Update AD_MODULE version to 3.0PR17Q3.2

Tue, 19 Dec 2017 18:46:23 +0100Fixed issue 37421. Added index to improve performance of C_IMPORT_ENTRY_ARCHIVE deletion.
Antonio Moreno <antonio.moreno@openbravo.com> [Tue, 19 Dec 2017 18:46:23 +0100] rev 33136
Fixed issue 37421. Added index to improve performance of C_IMPORT_ENTRY_ARCHIVE deletion.

Tue, 12 Dec 2017 14:59:28 +0530Fixes Issue 37457:Change the role in the ERP has performance
Atul Gaware <atul.gaware@openbravo.com> [Tue, 12 Dec 2017 14:59:28 +0530] rev 33135
Fixes Issue 37457:Change the role in the ERP has performance
problems

** Flush is called before calling fillSessionArguments
** new ConnectionProvider without flush is passed to the
fillSessionArguments method which avoids flush for
every select statement which uses this connection Provider
as flush is not need for select statements.

Mon, 27 Nov 2017 19:16:22 +0100fixes bug 37400: Duplicated DS calls having the tree view shown in a sub-tab
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 27 Nov 2017 19:16:22 +0100] rev 33134
fixes bug 37400: Duplicated DS calls having the tree view shown in a sub-tab

Fix for issue #35545 was intended to force a datasource call when the fetchData does not perform it. This function has a mechanism that avoids DS calls when the grid criteria i not being changed.

But when the criteria indeed changes two DS request was being fired: the one that we are forcing and the other one fired by the fetchData function. To avoid this problem we are forcing the DS call just when the grid criteria has not changed.

Fri, 17 Nov 2017 15:03:14 +0100fixes issue 37312: OB created partially in old processes shown in 3.0 windows
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 17 Nov 2017 15:03:14 +0100] rev 33133
fixes issue 37312: OB created partially in old processes shown in 3.0 windows

With the changes introduced on issue 0035553, the OB object is generated in two stages: it is initialized when the JS static resources are loaded and secondly additional session data is included with the SessionDynamic request.

In old processes inside 3.0 windows, a request to load the JS static resources is done but the SessionDynamic request is not. As a result, the OB object was generated partially. This caused JS errors when referencing to the missing data.

To fix this issue, now when we are in an old process loaded inside a 3.0 window, instead of generating the OB object from scratch, it is cloned from the main OB object of the application which is generated right after logging in.

Thu, 16 Nov 2017 12:36:03 +0100Fixed issue 37294: Deactivated orgs are displayed in the user profile widget
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 16 Nov 2017 12:36:03 +0100] rev 33132
Fixed issue 37294: Deactivated orgs are displayed in the user profile widget

The problem was caused by the "Improve scalability of the login process" project. When improving the performance
of the query that return the complete organizations list for the current user, the OBQuery instance used to generate it was
replaced with a Query instance. The first includes by default the filter by is active.

To fix the problem this filter must be added manually in the query. Now the problem has been resolved by take into
account this filter. Besides the same problem is detected in other query related with deactivated warehouses so it is fixed too.

Tue, 14 Nov 2017 13:55:33 +0100Fixed issue 37282: Deactivated roles are displayed in the user profile widget
Inigo Sanchez <inigo.sanchez@openbravo.com> [Tue, 14 Nov 2017 13:55:33 +0100] rev 33131
Fixed issue 37282: Deactivated roles are displayed in the user profile widget

The problem was caused by the "Improve scalability of the login process" project. When improving the
performance of the query that return the complete role list for the current user, the OBQuery instance
used to generate it was replaced with a Query instance. The first includes by default the filter by
is active.

To fix the problem this filter must be added manually in the query. Now the problem has been resolved
by take into account this filter.

Wed, 08 Nov 2017 18:25:02 +0100related to issue 37262: adapt test cases to the new component's definition
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 08 Nov 2017 18:25:02 +0100] rev 33130
related to issue 37262: adapt test cases to the new component's definition

Wed, 08 Nov 2017 18:22:52 +0100fixes issue 37262: Some labels are not translated after switching the language
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 08 Nov 2017 18:22:52 +0100] rev 33129
fixes issue 37262: Some labels are not translated after switching the language

After the changes introduced on issue #35852 the labels were being cached together with the rest of the static javascript code. Thus, being in an environment not in "in development" status, the labels were being cached in the language of the first login avoiding the translation when switching to another language afterwards.

To fix the problem now the component responsible of collecting the labels has been defined as a session dynamic component. This way the labels will be retrieved on every login. And to avoid querying to the database on each login request, the labels are now being cached in the server per language.

Fri, 22 Dec 2017 17:38:18 -0500Fixes issue 37523:Product selector filters by Non-Stocked products in Goods
Armaignac <collazoandy4@gmail.com> [Fri, 22 Dec 2017 17:38:18 -0500] rev 33128
Fixes issue 37523:Product selector filters by Non-Stocked products in Goods
Movement window

The Stocked field of product select is filtering to true if the window is sales
transaction. The field Default expression was modified to take into account the
Goods Movement window and sets to true the field value

Fri, 22 Dec 2017 14:36:39 +0100Related with issue 37544: Backed out changeset bc2ae3376c86
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 22 Dec 2017 14:36:39 +0100] rev 33127
Related with issue 37544: Backed out changeset bc2ae3376c86

This changeset is backed out because it is part of issue 37437, which causes a regression: https://issues.openbravo.com/view.php?id=37544

Fri, 22 Dec 2017 14:27:16 +0100Related with issue 37544: Backed out changeset 5e390e7d791d
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 22 Dec 2017 14:27:16 +0100] rev 33126
Related with issue 37544: Backed out changeset 5e390e7d791d

This changeset is backed out because it causes a regression: https://issues.openbravo.com/view.php?id=37544

Fri, 15 Dec 2017 03:23:36 +0530Fixes Issue 37473: Sample data (F&B International Group Client) for 3.0PR18Q1
Atul Gaware <atul.gaware@openbravo.com> [Fri, 15 Dec 2017 03:23:36 +0530] rev 33125
Fixes Issue 37473: Sample data (F&B International Group Client) for 3.0PR18Q1

Sample data (F&B International Group Client) for 3.0PR18Q1 for the month of Oct., Nov.
and Dec. 2017. Following the "How to evolve F&B" document instructions transactions
created for 3.0PR18Q1 release.

Thu, 14 Dec 2017 23:34:53 +0530Related To Issue 37473:Sample data (F&B International Group Client) for 3.0PR18Q1
Atul Gaware <atul.gaware@openbravo.com> [Thu, 14 Dec 2017 23:34:53 +0530] rev 33124
Related To Issue 37473:Sample data (F&B International Group Client) for 3.0PR18Q1

Export changes prior to transactional sample data creation

Tue, 19 Dec 2017 08:57:19 +0100related to issue 29622: wrong first/last login value retrieval for warn logging
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 19 Dec 2017 08:57:19 +0100] rev 33123
related to issue 29622: wrong first/last login value retrieval for warn logging

Mon, 18 Dec 2017 17:35:46 +0100Fixed bug 29622: Exception in Heartbeat process having AD_Session table empty.
Javier Armendáriz <javier.armendariz@openbravo.com> [Mon, 18 Dec 2017 17:35:46 +0100] rev 33122
Fixed bug 29622: Exception in Heartbeat process having AD_Session table empty.

The exception was caused when trying to parse the first and
last login date when AD_Session table is empty.

Now we handle this case and return an empty string when parsing a
null Date object.

Fri, 15 Dec 2017 18:09:17 -0500Fixes issue 37479:Account No. is cut when Trial Balance is printed in PDF format
Armaignac <collazoandy4@gmail.com> [Fri, 15 Dec 2017 18:09:17 -0500] rev 33121
Fixes issue 37479:Account No. is cut when Trial Balance is printed in PDF format

When the Trial Balance Report is printed in PDF Format the Account No. was cut

To avoid that the isStretchWithOverflow property was set to true to the testfield

Sat, 16 Dec 2017 13:36:33 +0100Fixed 37481. Fix new unused variable warning.
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 16 Dec 2017 13:36:33 +0100] rev 33120
Fixed 37481. Fix new unused variable warning.

Last commit to this issue accidentally introduced a new unused variable
warning as consequence to deleting other unused code. That has been missed in
testing as try did not flag it because of some logic error in the try logic.

Fri, 15 Dec 2017 13:35:35 +0100Fixed bug 37486: Update ERP copyright year to 2018.
Javier Armendáriz <javier.armendariz@openbravo.com> [Fri, 15 Dec 2017 13:35:35 +0100] rev 33119
Fixed bug 37486: Update ERP copyright year to 2018.

Changed copyright year from 2017 to 2018 in Login and About sections.

Fri, 15 Dec 2017 09:16:47 +0100Fixes bug 36897: Inconsistent date format for default value in String reference
Javier Armendáriz <javier.armendariz@openbravo.com> [Fri, 15 Dec 2017 09:16:47 +0100] rev 33118
Fixes bug 36897: Inconsistent date format for default value in String reference

Depending on which UIDefinition is picked up first, different Date UIDefinitions could be used to format the @#Date@ expression as the default value of a String field. Now we use DateTimeUIDefinition to ensure we always apply the same date format.

Mon, 04 Dec 2017 14:33:36 +0100fixed issue 37230. Fix java9 deprecation warnings.
Stefan Hühner <stefan.huehner@openbravo.com> [Mon, 04 Dec 2017 14:33:36 +0100] rev 33117
fixed issue 37230. Fix java9 deprecation warnings.

Avoid constructors deprecated in java9. When fixing apply the following rules:
- The following applies to new Long, new Integer, new Boolean, ... equally
- new Long(20) -> 20L when needing Long object
just use long literal auto-boxing will auto-convert to Long
- Long l = new Long(String) -> Long.valueOf
- long l = new Long(String) -> Long.parseLong
- sometimes code did new Long(...).longValue
Replace that by directly using parseLong to return primitive instead
- in ReportingUtils.java instead of defining double constant and using it for
only new Float -> change constant to be directly float instead

Thu, 14 Dec 2017 16:23:30 +0100fixed bug 37481: unused PL variables
Stefan Hühner <stefan.huehner@openbravo.com> [Thu, 14 Dec 2017 16:23:30 +0100] rev 33116
fixed bug 37481: unused PL variables

Removed unused variables in platform PL code

Fri, 24 Nov 2017 17:36:51 -0500Fixes issue 37376: Stock Reservation of partially invoiced and not shipped order
Armaignac <collazoandy4@gmail.com> [Fri, 24 Nov 2017 17:36:51 -0500] rev 33115
Fixes issue 37376: Stock Reservation of partially invoiced and not shipped order
line is Closed when closing the sales order and it can be edited

When an order is closed all the reservation's made to lines are closed but you
still can manage the reservation stock from sales order window

Now the Manage Reservation button is shown when the order is not closed

Wed, 13 Dec 2017 09:33:35 +0100fixes bug 37465: problem with process definition in several tabs of same window
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 13 Dec 2017 09:33:35 +0100] rev 33114
fixes bug 37465: problem with process definition in several tabs of same window

When executing a standard process, the view owner of the related action button is used to retrieve the current record information to the server. In this case, to look for that owner view, we were going through all the views in the current window in order to find an action button referencing to the process we are executing. The first view found complying that requirement was considered the owner view. This approach is not valid in case we want to define in several tabs of the same window different buttons referencing to the same process definition.

To fix the problem, now when we are opening the process we send the owner view of the action button as a parameter which is already supported by the infrastructure of the standard window. Thus, when executing the process we do not need anymore to go through all the views in the current window to find the owner view of the action button.

Tue, 12 Dec 2017 19:25:59 +0100related to issue 37465: initial code clean up
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 12 Dec 2017 19:25:59 +0100] rev 33113
related to issue 37465: initial code clean up

- Removed the declaration of some unused variables.

Thu, 30 Nov 2017 16:56:51 -0500Related to issue 37395: Taking into account the is active status in other offers
Armaignac <collazoandy4@gmail.com> [Thu, 30 Nov 2017 16:56:51 -0500] rev 33112
Related to issue 37395: Taking into account the is active status in other offers

The is active status now is take into account in all the offers to properly get
the promotion

Wed, 29 Nov 2017 16:53:46 -0500Fixes issue 37395: Deactivated discounts are applied
Armaignac <collazoandy4@gmail.com> [Wed, 29 Nov 2017 16:53:46 -0500] rev 33111
Fixes issue 37395: Deactivated discounts are applied

When a Discount and Promotions have a Product define the discount was always
applied even if the product offer is deactivated.

An ISACTIVE clause was added to take into account only active product's offers

Tue, 12 Dec 2017 14:56:33 +0530Fixes Issue 37277:Change the role in the ERP has performance
Atul Gaware <atul.gaware@openbravo.com> [Tue, 12 Dec 2017 14:56:33 +0530] rev 33110
Fixes Issue 37277:Change the role in the ERP has performance
problems

** Flush is called before calling fillSessionArguments
** new ConnectionProvider without flush is passed to the
fillSessionArguments method which avoids flush for
every select statement which uses this connection Provider
as flush is not need for select statements.

Tue, 12 Dec 2017 11:20:20 +0100fixed bug 37459: several 2.50 manual pages import unneeded JavaScript files
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 12 Dec 2017 11:20:20 +0100] rev 33109
fixed bug 37459: several 2.50 manual pages import unneeded JavaScript files

Removed js imports for not used resources.

Wed, 01 Nov 2017 14:21:41 +0100[jsimport cleanup] remove search.js import from many more files not using it
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 01 Nov 2017 14:21:41 +0100] rev 33108
[jsimport cleanup] remove search.js import from many more files not using it

None of those files use 2.50 style selector functionality. So importing
search.js is not needed.

Wed, 01 Nov 2017 13:05:58 +0100[jsimport cleanup] Cleanup imports & js code of Export Dataset process
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 01 Nov 2017 13:05:58 +0100] rev 33107
[jsimport cleanup] Cleanup imports & js code of Export Dataset process

That html file is simple OK & Cancel confirmation for running export dataset
aka Export Reference Data.
It does not use any 2.50 style selector, calendar, date text box or ajax.

So remove all those unused imports.

Apart the html has been create by copy'n'pasting from some other file having
datagrid. Copying lots of never used javascript code -> remove that as well.

Also on load + onResize did call resizeAreaCreateFrom which is not defined in
this file so was triggering js errors on load and many on resizing. Remove
those calls.

Wed, 01 Nov 2017 12:46:43 +0100[jsimport cleanup] Removed unused searchs,calendar,messages imports.
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 01 Nov 2017 12:46:43 +0100] rev 33106
[jsimport cleanup] Removed unused searchs,calendar,messages imports.

That file is not a report but small html 'popup' on print button of
Business Partner window.
It does not use any 2.50 style selector or calendar or the message system.
So remove those unused imports. Note that removed DynamicJS import also had
a wrong path so was triggering 404 not found error before also.

Sun, 10 Sep 2017 14:18:01 +0200[jsimport cleanup] remove jscalendar include from some files not using it
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 10 Sep 2017 14:18:01 +0200] rev 33105
[jsimport cleanup] remove jscalendar include from some files not using it

Sun, 10 Sep 2017 13:40:21 +0200[jsimport cleanup] Remove calculator.js import from files not using calculator
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 10 Sep 2017 13:40:21 +0200] rev 33104
[jsimport cleanup] Remove calculator.js import from files not using calculator

Mon, 11 Dec 2017 17:12:23 +0100Fixes issue 37449 and related to issue 29414: Updated browser supported/recommended list for PR18Q1
Pablo Lujan <pablo.lujan@openbravo.com> [Mon, 11 Dec 2017 17:12:23 +0100] rev 33103
Fixes issue 37449 and related to issue 29414: Updated browser supported/recommended list for PR18Q1

* Chrome. Supported 61, Recommended 63 or higher.
* Firefox. Supported 45, Recommended 52 or higher.
* Internet Explorer. Supported 9, Recommended 11 or higher.
* EdgeHTML (MS Edge). Supported 12, Recommended 13 or higher.
* Safari. Supported 8, Recommended 9 or higher.

Wed, 06 Dec 2017 11:49:01 +0100fixed bug 37437: useless session cache of window.isSOTrx
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 06 Dec 2017 11:49:01 +0100] rev 33102
fixed bug 37437: useless session cache of window.isSOTrx

Now isSOTrx propery is not cached in session for each window in the system,
instead its value is obtained from application scoped ADCS when required.

Wed, 06 Dec 2017 11:14:46 +0100related to bug 37437: useless session cache of window.isSOTrx
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 06 Dec 2017 11:14:46 +0100] rev 33101
related to bug 37437: useless session cache of window.isSOTrx

Some code minor clean up:
- Removed some duplicity
- Fixed format in some comments
- ...

Mon, 04 Dec 2017 10:11:14 +0100fixes 37329: implemented a more generic Utility.arrayListToString
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 04 Dec 2017 10:11:14 +0100] rev 33100
fixes 37329: implemented a more generic Utility.arrayListToString

Moved new commaSeparated API from generic Utility to a more specific new class
StringCollectionUtils. This also removes Utility class dependencies allowing to
use new API from central components with limited compilation dependencies.

Mon, 04 Dec 2017 08:24:04 +0100fixed bug 37435: unneeded log when exception thrown by DalBaseProcess
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 04 Dec 2017 08:24:04 +0100] rev 33099
fixed bug 37435: unneeded log when exception thrown by DalBaseProcess

When an exception was thrown by a background DalBaseProcess, 2 traces were logged.
Once with the stack trace of the actual excpetion, another one with a the stack
trace of a new unrelated generated exception.

Now DalBaseProcess just rethrows original exception instead of logging it and
creating a new one, DefaultJob logs it with its stack trace, it also prints a
readable process name.

Sun, 03 Dec 2017 00:20:53 +0100Fixed issue 37404. Added index to improve performance of C_IMPORT_ENTRY_ARCHIVE deletion.
Antonio Moreno <antonio.moreno@openbravo.com> [Sun, 03 Dec 2017 00:20:53 +0100] rev 33098
Fixed issue 37404. Added index to improve performance of C_IMPORT_ENTRY_ARCHIVE deletion.

Fri, 01 Dec 2017 13:45:14 +0100related to bug 37424: export to CSV too slow with high volumes
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 01 Dec 2017 13:45:14 +0100] rev 33097
related to bug 37424: export to CSV too slow with high volumes

Small optimization: selectedProperties field is used to only check whether a
propertie is selected. Use a HashSet that has an O(1) contains instead of
ArrayList, which is O(n).

Fri, 01 Dec 2017 13:39:02 +0100fixed bug 37424: export to CSV too slow with high volumes
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 01 Dec 2017 13:39:02 +0100] rev 33096
fixed bug 37424: export to CSV too slow with high volumes

Wehn exporting to CSV from grid, all the properties of the entity were calculated
even if they weren't included in the final file. This computation added overhead,
specially for computed columns.

Now only those properties that are going to be included in the CSV file are calulated.

Fri, 01 Dec 2017 11:36:50 +0100Related to issue 36466: removed unused variable
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 01 Dec 2017 11:36:50 +0100] rev 33095
Related to issue 36466: removed unused variable

Fri, 01 Dec 2017 11:32:33 +0100Fixed issue 37310. Add support for Amazon PG RDS database.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Fri, 01 Dec 2017 11:32:33 +0100] rev 33094
Fixed issue 37310. Add support for Amazon PG RDS database.

Changes required to support Amazon PG RDS.

*bbdd.user is no longer superuser
*new prescript added in postgresql to execute with bbdd.systemUser to create
requried pg extensions that need superuser privileges to execute.
*uuid_generate_v4 function is now created by creating the full uuid-ossp
instead of just the function.

Thu, 30 Nov 2017 16:38:33 -0500Related to issue 36466: Fixed preferences conflicts with AWO
Mark <markmm82@gmail.com> [Thu, 30 Nov 2017 16:38:33 -0500] rev 33093
Related to issue 36466: Fixed preferences conflicts with AWO

To avoid possible conflicts with other tests using the UomManagement preference
the Copy From Orders tests related with the AUM functionality were adapted to save
the status of the preference at the start of the tests, and restore it after the
all the tests are executed.

Is taken into account if the preference exists in the database, and in case the
preference exists also is restored its value. This way, at the tests ending, it
left the preference status as expected by other tests.

Also was created a new class to manage all the actions related with the preference.
Some of existing methods were moved to it, and other were created.

Tue, 28 Nov 2017 15:42:01 +0100Fixed issue 37407: Error in server when doing a CL of a layaway with a related canceled service
Asier Martirena <asier.martirena@openbravo.com> [Tue, 28 Nov 2017 15:42:01 +0100] rev 33092
Fixed issue 37407: Error in server when doing a CL of a layaway with a related canceled service

Thu, 30 Nov 2017 18:31:38 +0100Related to Issue 37344. Code Review changes.
David Miguelez <david.miguelez@openbravo.com> [Thu, 30 Nov 2017 18:31:38 +0100] rev 33091
Related to Issue 37344. Code Review changes.

Moved query logic into it's own method.

Thu, 30 Nov 2017 18:02:35 +0100Fixes issue 37344: If same product is consumed and produced in same BOM
Nono Carballo <nonofce@gmail.com> [Thu, 30 Nov 2017 18:02:35 +0100] rev 33090
Fixes issue 37344: If same product is consumed and produced in same BOM
Production, produced transaction cost is calculated first

Before calculating the cost of a BOMPart transaction, cost of BOMProduction
transactions for the same product in previous production plans are calculated.

This fix is a contribution of Support Team.

Thu, 30 Nov 2017 10:44:40 +0100Fixes issue 37317: Costing Background Process stopped if the same product is
Nono Carballo <nonofce@gmail.com> [Thu, 30 Nov 2017 10:44:40 +0100] rev 33089
Fixes issue 37317: Costing Background Process stopped if the same product is
produced and consumed in different production run of same work effort

If the product is not consumed by the same work effort, the costing server will
create/update the cost, otherwise, the cost is updated, to be taken into account
for the production run that consumes it.

This fix is a contribution of Support Team.

Thu, 30 Nov 2017 12:08:20 +0100Related to issue 36466: Fixed retail's ci due to duplicate UPC
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 30 Nov 2017 12:08:20 +0100] rev 33088
Related to issue 36466: Fixed retail's ci due to duplicate UPC

Tue, 28 Nov 2017 18:28:16 +0100Related to Issue 37302. Code Review Changes. Improved Java Doc
David Miguelez <david.miguelez@openbravo.com> [Tue, 28 Nov 2017 18:28:16 +0100] rev 33087
Related to Issue 37302. Code Review Changes. Improved Java Doc

Tue, 28 Nov 2017 18:05:00 +0100Fixes issue 37302: Process Price Difference Correction fails with n.p.e. or
Nono Carballo <nonofce@gmail.com> [Tue, 28 Nov 2017 18:05:00 +0100] rev 33086
Fixes issue 37302: Process Price Difference Correction fails with n.p.e. or
create wrong Cost Adjustment Documents when it works

Price Difference Adjustment process is invoked for legal organizations.

When invoked from manual process, the legal organization(s) of selected
organization is retrieved, the process is invoked for that legal organization
in order to the Cost Adjustment Document be created with the legal organization
in the header, and lines for transaction belonging to organizations under it.

When invoked from the background process, the process is invoked for legal
organizations under organization "*".

When invoked from the Costing Background process, the legal organization of the
transaction organization is retrieved, and is used to invoke the process.

Tue, 28 Nov 2017 18:03:42 +0100Related to Issue 37314. Code Review changes.
David Miguelez <david.miguelez@openbravo.com> [Tue, 28 Nov 2017 18:03:42 +0100] rev 33085
Related to Issue 37314. Code Review changes.

If no unit price in the line selected, assign the standard price
to the base gross unit price

Mon, 20 Nov 2017 14:43:52 -0500Fixes issue 37314: Gross Unit Price is updated to 0 if a sales invoice line from
Armaignac <collazoandy4@gmail.com> [Mon, 20 Nov 2017 14:43:52 -0500] rev 33084
Fixes issue 37314: Gross Unit Price is updated to 0 if a sales invoice line from
a Return Material Receipt is modified and price includes taxes

When invoicing from a Return Material Receipt related to a price list with
price include taxes to Y the order line doesn't take into account the base gross
unit price

Now when creating an order line in the Return From Customer process the base
gross unit price value is computed and saved

Thu, 30 Nov 2017 09:04:32 +0100fixed bug 37419: Login does 3 useless db reads in SessionLogin
Stefan Hühner <stefan.huehner@openbravo.com> [Thu, 30 Nov 2017 09:04:32 +0100] rev 33083
fixed bug 37419: Login does 3 useless db reads in SessionLogin

Those db queries were used to load by ID DAL objects that were used just to
create a new object but never used again.

Replaced by getProxy so that no need to fetch them from DB.

Wed, 29 Nov 2017 12:15:58 +0100fixed bug 37411: useless ad_table query in TreeTablesEventHandler.getDataSource
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 29 Nov 2017 12:15:58 +0100] rev 33082
fixed bug 37411: useless ad_table query in TreeTablesEventHandler.getDataSource

Use proxy as table value is never used.

Tue, 28 Nov 2017 18:59:16 +0100related to issue 37238: added test cases
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 28 Nov 2017 18:59:16 +0100] rev 33081
related to issue 37238: added test cases

Tue, 28 Nov 2017 18:01:43 +0100fixes bug 37238: OBMessageUtils fails on vars retrieval if there isn't request
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 28 Nov 2017 18:01:43 +0100] rev 33080
fixes bug 37238: OBMessageUtils fails on vars retrieval if there isn't request

Two main changes:
1- Postponed the vars initialization until it is really needed.
2- If the vars retrieval fails because there is no request then the exception thrown in that case is now catched and then the message is tried to be loaded from database.

Tue, 28 Nov 2017 17:36:39 +0100Related to issue 37310. New dbsourcemanager version to support rds.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Tue, 28 Nov 2017 17:36:39 +0100] rev 33079
Related to issue 37310. New dbsourcemanager version to support rds.

To properly support Amazon RDS it is required to create a prescript that it is
executed with systemAdmin user. This new version of dbms enables that ability.

Tue, 28 Nov 2017 16:44:09 +0100Related to issue 36466: Adapted test to work with AWO
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 28 Nov 2017 16:44:09 +0100] rev 33078
Related to issue 36466: Adapted test to work with AWO

AWO module already defines the UomManagement property.
This changeset modifies the preference inside the module as required by the test flows.
In case no preference is found, the test creates a new one.

Tue, 28 Nov 2017 13:50:04 +0100fixes bug 37079: wrong result when filtering by a range of a DateTime column
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 28 Nov 2017 13:50:04 +0100] rev 33077
fixes bug 37079: wrong result when filtering by a range of a DateTime column

When filtering by a range of dates, the time is set to 0 or 24 hours (depending on the operator) in order to retrieve properly all the records within the same date range.

However, when filtering by range of a column based in a reference that includes the time (DateTime/AbsoluteDateTime), it is also needed to compare and therefore it should not be modified

Tue, 28 Nov 2017 13:38:10 +0100Related to issue 36466: Updated V3 Roles dataset
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 28 Nov 2017 13:38:10 +0100] rev 33076
Related to issue 36466: Updated V3 Roles dataset

Added access to Copy From Orders P&E window

Tue, 28 Nov 2017 13:34:32 +0100Related to issue 36466: modified sampledata
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 28 Nov 2017 13:34:32 +0100] rev 33075
Related to issue 36466: modified sampledata

Added access to new process definition

Tue, 28 Nov 2017 13:20:38 +0100Related to issue 36466: Updated V3 Roles dataset
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 28 Nov 2017 13:20:38 +0100] rev 33074
Related to issue 36466: Updated V3 Roles dataset

Added new process definition to Sales and Finance Roles

Sat, 25 Nov 2017 17:04:05 +0100Related to issue 36466: Code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Sat, 25 Nov 2017 17:04:05 +0100] rev 33073
Related to issue 36466: Code review improvements

Removed onLoad function on process and use the standard Default Expression at field level.
Deleted unnecessary messages
Fixed javadoc in CopyFromOrdersProcessImplementationInterface

Fri, 24 Nov 2017 13:41:43 +0100Related to issue 36466: renamed some fields
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 24 Nov 2017 13:41:43 +0100] rev 33072
Related to issue 36466: renamed some fields

The button has been renamed to Copy from Orders
The organization field in P&E has been renamed to Legal Entity Organization

Fri, 24 Nov 2017 12:59:29 +0100Related to issue 36466: Use Proxy to improve performance
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 24 Nov 2017 12:59:29 +0100] rev 33071
Related to issue 36466: Use Proxy to improve performance

Fri, 24 Nov 2017 12:54:43 +0100Related to issue 36466: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 24 Nov 2017 12:54:43 +0100] rev 33070
Related to issue 36466: code review improvements

CopyFromOrdersProcess.java:
Added order by lineNo when retrieving order lines, so we create lines in the same order as the original Order.
Renamed private method to describe better its purpose.

CopyFromOrdersProcessFilterExpression.java:
Added missed copyright information.
Moved logic to a separate private method.

Fri, 24 Nov 2017 11:40:58 +0100Related to issue 36466: Fixed NPE in some JUnit tests
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 24 Nov 2017 11:40:58 +0100] rev 33069
Related to issue 36466: Fixed NPE in some JUnit tests

Fri, 24 Nov 2017 10:43:09 +0100Related to issue 36466: Avoid overriding setUp()
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 24 Nov 2017 10:43:09 +0100] rev 33068
Related to issue 36466: Avoid overriding setUp()

Fri, 24 Nov 2017 10:37:46 +0100Related to issue 36466: Fixed javadoc
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 24 Nov 2017 10:37:46 +0100] rev 33067
Related to issue 36466: Fixed javadoc

Thu, 23 Nov 2017 18:41:31 +0100Related to issue 36466: Hooks are also run for the core's process
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 23 Nov 2017 18:41:31 +0100] rev 33066
Related to issue 36466: Hooks are also run for the core's process

This allows a simplification in the code, as it doesn't differenciate between internal and external hooks.
Even more, external processes can be injected at any point in the process.

The interface has been extended to provide an execution order for the hooks.

JUnit tests have been adapted:
1. To support CDI with parametrized tests
2. To include all the information required by the test in the CopyLinesFromOrdersTestData object itself

Thu, 23 Nov 2017 13:35:02 +0100Related to issue 36466: Renamed package classes
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 23 Nov 2017 13:35:02 +0100] rev 33065
Related to issue 36466: Renamed package classes

Thu, 23 Nov 2017 13:22:23 +0100Related to issue 36466: Use standard way to detect UOM Management,
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 23 Nov 2017 13:22:23 +0100] rev 33064
Related to issue 36466: Use standard way to detect UOM Management,
This change fixes issues in Oracle

Thu, 23 Nov 2017 13:21:13 +0100Related to issue 36466: Added Copy From Orders tests to AllAntTaskTests
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 23 Nov 2017 13:21:13 +0100] rev 33063
Related to issue 36466: Added Copy From Orders tests to AllAntTaskTests

Wed, 22 Nov 2017 14:23:26 -0500Related to issue 36466: jUnit Automated Tests for Copy From Orders process
Mark <markmm82@gmail.com> [Wed, 22 Nov 2017 14:23:26 -0500] rev 33062
Related to issue 36466: jUnit Automated Tests for Copy From Orders process

Tue, 21 Nov 2017 20:34:55 -0500Related to issue 36466: Fixed operative quantity calculation
Mark <markmm82@gmail.com> [Tue, 21 Nov 2017 20:34:55 -0500] rev 33061
Related to issue 36466: Fixed operative quantity calculation

Recalculated the operative quantity instead based on the ordered quantity.
The ordered quantity can't be changed because it value:
-Was already calculated based on the operative quantity and the defined conversion
rate if AUM preference was enabled.
-Was defined in the order line and the operative quantity is not defined if the
AUM preference was not defined.

Sat, 18 Nov 2017 17:13:32 -0500Related to issue 36466: Validate an attribute instance using Attribute defined
Mark <markmm82@gmail.com> [Sat, 18 Nov 2017 17:13:32 -0500] rev 33060
Related to issue 36466: Validate an attribute instance using Attribute defined
in the Attribute Use List of the attribute set instead of iterate on
the attribute instances list.

Tue, 14 Nov 2017 20:25:18 -0500Related to issue 36466: Avoid NPE when copyFromOrdersProcessHooks isn't defined
Mark <markmm82@gmail.com> [Tue, 14 Nov 2017 20:25:18 -0500] rev 33059
Related to issue 36466: Avoid NPE when copyFromOrdersProcessHooks isn't defined

When the CopyFromOrdersProcess class is instantiated directly, for instance in an
automated test, it is possible that copyFromOrdersProcessHooks wasn't initialized
and a NPE is thrown due that.

Tue, 07 Nov 2017 13:48:45 -0500Related to issue 36466: Synchronize Terminology done
Mark <markmm82@gmail.com> [Tue, 07 Nov 2017 13:48:45 -0500] rev 33058
Related to issue 36466: Synchronize Terminology done

Thu, 02 Nov 2017 10:50:52 -0400Related to issue 36466: JS Beautified.
Mark <markmm82@gmail.com> [Thu, 02 Nov 2017 10:50:52 -0400] rev 33057
Related to issue 36466: JS Beautified.

Tue, 31 Oct 2017 18:49:37 -0400Related to Issue 36466: Removed database references to Copy From Order process
Mark <markmm82@gmail.com> [Tue, 31 Oct 2017 18:49:37 -0400] rev 33056
Related to Issue 36466: Removed database references to Copy From Order process

Removed other database references for old Copy From Order process in Sample datas

Fri, 27 Oct 2017 12:55:15 +0200Related to Issue 36466. Code Review Changes:
David Miguelez <david.miguelez@openbravo.com> [Fri, 27 Oct 2017 12:55:15 +0200] rev 33055
Related to Issue 36466. Code Review Changes:

* Synchronized Terminology and exported database
* Added new non editable Legal Entity Parameter in Process Definition
to be able to show Orders for Organizations that belong to that legal entity
* Copy from Orders Process splitted in Handler, Process and classes that implement
the calculations logic
* Copy From Orders Action Handler handles the request and the response and calls
Copy From Orders Process to perform the logic
* Copy From Orders Process loops through the Orders and through the Order Lines
and calls the classes that implement the logic for the calculations.
It also explodes the non-Stocked BOM Products
* Copy From Orders Implementation Interface is the interface that must be
implemented by the classes that implements the logic for the calculations
* Several classes created to perform the calculations related to amounts, taxes,
prices, etc
* Added a Hook at the end of Copy From Orders Process
* Fixed wrong prices calculation
* Fixed wrong amounts calculation
* Fixed exception handling
* Added times taken for processing the orders in the log
* Added missing fields when copying OrderLines

Sun, 22 Oct 2017 20:42:12 -0400Related to issue 36466: Clean up of old Copy From Order process.
Mark <markmm82@gmail.com> [Sun, 22 Oct 2017 20:42:12 -0400] rev 33054
Related to issue 36466: Clean up of old Copy From Order process.

After refactoring the manual Copy From process to the new Copy From Orders Process
Definition, all the old process references in the database are deleted. Also other
unused files has been removed.

Mon, 23 Oct 2017 15:59:09 -0400Fixes issue 36466: "Copy from order" refactor to Process Definition
Mark <markmm82@gmail.com> [Mon, 23 Oct 2017 15:59:09 -0400] rev 33053
Fixes issue 36466: "Copy from order" refactor to Process Definition

Currently the process "Copy From Order" is defined as a manual process and does
not make use of the benefits of Process Definition. The current process logic
was migrated to a new Process Definition, using the Pick and Edit (PE) pattern
in those windows that currently use it.

Was created a new Pick and Execute window. Defined a new tab with the same fields
that the old process.

Was created a new Process Definition using previously windows as parameter and
updated all the buttons that were using the "Create From Order" process to use
the new process definition "Create From Orders".

Was created a new action handler to process the selection of the orders. It
iterates through all the selected orders and add their lines to the order that
executes the process.

Tue, 28 Nov 2017 10:09:09 +0100fixes issue 37162: wrong spacing for combo with identifiers that use integers
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 28 Nov 2017 10:09:09 +0100] rev 33052
fixes issue 37162: wrong spacing for combo with identifiers that use integers

Having a table with at least one integer as identifier and a combo reference (Table/TableDir) referencing to that table, fields using that reference were printed with some extra blank spaces.

This was happening because the integer values were casted and the to_char(integer) function created for PostgresSQL[1] is adding some formatting which causes to print the result with those extra blank spaces.

To avoid this problem integer identifiers in combo references are handled now in the same way as the rest of numeric references.

[1] https://code.openbravo.com/erp/devel/pi/file/tip/src-db/database/model/prescript-PostgreSql.sql#l272

Tue, 28 Nov 2017 09:48:01 +0100fixed bug 37390: can't compare gt or lt with negative values in display logic
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Nov 2017 09:48:01 +0100] rev 33051
fixed bug 37390: can't compare gt or lt with negative values in display logic

When comparing negative values with gt (>), lt (>), ge (>=) or le (>=) the
generated JavaScript expression was incorrect.

Those operators were not properly parsed because they were not declared in
DynamicExpressionParser.

Mon, 27 Nov 2017 15:04:47 +0100fixed issue 37396: remove support to print fop documents in a different server
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 27 Nov 2017 15:04:47 +0100] rev 33050
fixed issue 37396: remove support to print fop documents in a different server

This feature was not used nor documented.

Mon, 27 Nov 2017 19:16:22 +0100fixes bug 37399: Duplicated DS calls having the tree view shown in a sub-tab
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 27 Nov 2017 19:16:22 +0100] rev 33049
fixes bug 37399: Duplicated DS calls having the tree view shown in a sub-tab

Fix for issue #35545 was intended to force a datasource call when the fetchData does not perform it. This function has a mechanism that avoids DS calls when the grid criteria i not being changed.

But when the criteria indeed changes two DS request was being fired: the one that we are forcing and the other one fired by the fetchData function. To avoid this problem we are forcing the DS call just when the grid criteria has not changed.

Mon, 27 Nov 2017 16:47:46 +0100related to issue 37387: improve readability of fetchNodeChildren method
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 27 Nov 2017 16:47:46 +0100] rev 33048
related to issue 37387: improve readability of fetchNodeChildren method

Mon, 27 Nov 2017 13:45:01 +0100fixes bug 37387: Check the org of the element referenced by the ADTree node
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 27 Nov 2017 13:45:01 +0100] rev 33047
fixes bug 37387: Check the org of the element referenced by the ADTree node

The organization of the element referenced by the AD Tree node should be part of the readable organizations of the current context in order to allow it to be displayed in the tree view.

Mon, 27 Nov 2017 11:47:35 +0100related to issue 37387: initial code improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 27 Nov 2017 11:47:35 +0100] rev 33046
related to issue 37387: initial code improvements

- Add constants that were defined as local variables
- getTree and createTree private methods were defining an unused parameter
- Avoid String concatenation in log messages
- Use diamond operator

Mon, 27 Nov 2017 11:22:37 +0100related to bug 33134: made comment clearer
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 27 Nov 2017 11:22:37 +0100] rev 33045
related to bug 33134: made comment clearer

Mon, 27 Nov 2017 09:22:20 +0100fixes bug 37378: field name Entity Alias should be renamed to Clause Left Part
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 27 Nov 2017 09:22:20 +0100] rev 33044
fixes bug 37378: field name Entity Alias should be renamed to Clause Left Part

Fri, 24 Nov 2017 14:09:22 +0100Related with issue 36406: Fixed error in the condition
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 24 Nov 2017 14:09:22 +0100] rev 33043
Related with issue 36406: Fixed error in the condition

Fri, 24 Nov 2017 11:28:10 +0100Fixed issue 37358: Avoid a query during login under some circumstances
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 24 Nov 2017 11:28:10 +0100] rev 33042
Fixed issue 37358: Avoid a query during login under some circumstances

Avoid query to AttributeData.selectOrgCurrency during login if system does not have any
accounting schema. In cases where customer does not have any accounting schema that we
could skip the selectOrgCurrency query completely. To take into account this improvement,
it is moved the AttributeData.selectOrgCurrency call.

Besides it is applied format properly to several comments.

Fri, 24 Nov 2017 11:15:29 +0100fixes bug 36972: Show error in the UI when there is an error moving a tree node
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 24 Nov 2017 11:15:29 +0100] rev 33041
fixes bug 36972: Show error in the UI when there is an error moving a tree node

Add the ability to display error messages in the UI when there are errors on the update flow of the tree datasource.

Fri, 24 Nov 2017 10:55:40 +0100Fixed issue 33134: ImportEntryProcessor calls initialize() two times
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 24 Nov 2017 10:55:40 +0100] rev 33040
Fixed issue 33134: ImportEntryProcessor calls initialize() two times

ImportEntryProcessor was causing extra db queries because it was calling EntityAccessChecker.initialize()
two times. In order to fix the problem, it has been removed one of the calls to initialize method.

Thu, 23 Nov 2017 12:58:33 +0100related with bug 37363: minor related code improvement
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 23 Nov 2017 12:58:33 +0100] rev 33039
related with bug 37363: minor related code improvement

Use equalsIgnoreCase for the dataOriginType comparison.

Thu, 23 Nov 2017 09:24:29 +0100related with bug 37363: linked items fails in Organization window
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 23 Nov 2017 09:24:29 +0100] rev 33038
related with bug 37363: linked items fails in Organization window

Two minor changes:
* If any of the queries to retrieve linked items fails, don't stop the whole
process, just log it and continue with the rest.
* When looking for available entities, don't iterate over the properties if
the entity is already known not to be valid.

Wed, 22 Nov 2017 16:15:31 +0100fixed bug 37363: linked items fails in Organization window
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 22 Nov 2017 16:15:31 +0100] rev 33037
fixed bug 37363: linked items fails in Organization window

All virtual entities generated for lazy initialization of computed columns include
client/org properties, causing linked items to fail as they were handled as standard
windows.

They are now excluded.

Tue, 21 Nov 2017 17:58:52 +0100Fixed issue 36406: Summary functions do not work in tabs based on Datasources.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Tue, 21 Nov 2017 17:58:52 +0100] rev 33036
Fixed issue 36406: Summary functions do not work in tabs based on Datasources.

The summary functions didn't work in tabs based on Datasources because this
functionality was not developed. The reported datasource hadn't the code to
managed summary functions properly.

To avoid this problem, it has been resolved by blocking the use of the summary
functions in the tabs based on Datasources.

Tue, 21 Nov 2017 13:43:40 +0100fixes bug 36778: Wrong message shown in tree selector when reaching fetch limit
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 21 Nov 2017 13:43:40 +0100] rev 33035
fixes bug 36778: Wrong message shown in tree selector when reaching fetch limit

Added the ability to show an error message in the drop-down of an tree form item when the request fetches a number of nodes higher than the established limit.

Tue, 21 Nov 2017 16:21:53 +0100related to issue 36778: Clean up unused variables
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 21 Nov 2017 16:21:53 +0100] rev 33034
related to issue 36778: Clean up unused variables

Mon, 13 Nov 2017 13:52:55 +0100fixed 37015: contention in DAL proxies with high concurrency
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 13 Nov 2017 13:52:55 +0100] rev 33033
fixed 37015: contention in DAL proxies with high concurrency

Updated javassisit library from 3.14.0-GA to 3.20.0-GA to solve
JASSIST-163: RuntimeSupport.find2Methods perf hotspot when proxy's methods are called at higher concurrency [1].

[1] https://issues.jboss.org/browse/JASSIST-163

Tue, 21 Nov 2017 10:14:28 +0100related to issue 37329: fixes typos
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 21 Nov 2017 10:14:28 +0100] rev 33032
related to issue 37329: fixes typos

Tue, 21 Nov 2017 10:11:54 +0100related to issue 37329: fixes javadoc
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 21 Nov 2017 10:11:54 +0100] rev 33031
related to issue 37329: fixes javadoc

Tue, 21 Nov 2017 09:53:27 +0100related to 37324: added test case for getAllPreferences
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 21 Nov 2017 09:53:27 +0100] rev 33030
related to 37324: added test case for getAllPreferences

Tue, 21 Nov 2017 09:50:10 +0100related to 37324: renamed PreferenceTest methods
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 21 Nov 2017 09:50:10 +0100] rev 33029
related to 37324: renamed PreferenceTest methods

The need to be executed alphabetically because they are inter-dependent.

Replaced letters with numbers to make this sorting easier.

Mon, 20 Nov 2017 14:58:19 +0100related to 37329: use new method where old was used
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 20 Nov 2017 14:58:19 +0100] rev 33028
related to 37329: use new method where old was used

Mon, 20 Nov 2017 14:49:56 +0100related to 37329: implemented a more generic Utility.arrayListToString
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 20 Nov 2017 14:49:56 +0100] rev 33027
related to 37329: implemented a more generic Utility.arrayListToString

Deprecated old arrayListToString method.

Mon, 20 Nov 2017 14:48:56 +0100fixes 37329: implemented a more generic Utility.arrayListToString
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 20 Nov 2017 14:48:56 +0100] rev 33026
fixes 37329: implemented a more generic Utility.arrayListToString

Implemented a more generic alternative to Utility.arrayListToString:

* Receives as parameter a generic Collections instead of limiting it to
ArrayList instances
* Implemented it in a more performant manner based on OpenJDK
AbstractCollection.toString

Mon, 20 Nov 2017 13:24:45 +0100fixed bug 37324: slow login having many preferences - case 2
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 20 Nov 2017 13:24:45 +0100] rev 33025
fixed bug 37324: slow login having many preferences - case 2

When there were thousands of preferences with ad_org visible from current org
but not visible through visible at org field, loading all preferences was slow.

The problem was, all those preferences were loaded as DAL objects to filter
out later in memory those that were not visible.

This gets fixed by filtering out directly in the query so that no unneeded rows
are retrived from DB to instantiate DAL objects that later will be discarded
immediatelly.

Mon, 20 Nov 2017 13:11:31 +0100fixed bug 37324: slow login having many preferences - case 1
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 20 Nov 2017 13:11:31 +0100] rev 33024
fixed bug 37324: slow login having many preferences - case 1

Retrieving all preferences for current role/org was slow having thousands of
visible preferences because of how duplicate preferences with different visibility
were checked. This check was performed by sequentially scanning a list of already
saved preferences to verify whether current one was already in the list.

It has now fixed by keeping a temporary map of preferences where the key defines
if preference is the same or not, in this way it is not necessary to iterate
over all the entries each time.

Mon, 20 Nov 2017 12:01:56 +0100Related to issue 36694. Related to issue 36693
Jorge Garcia <jorge.garcia@openbravo.com> [Mon, 20 Nov 2017 12:01:56 +0100] rev 33023
Related to issue 36694. Related to issue 36693

* Fix problem with log messages in the new API
* Added copyright to ISOCurrencyPrecision
* Added class Javadoc to ISOCurrencyPrecision
* Use getResourceAsStream to read the xml file with the standard
currency precisions.

Mon, 20 Nov 2017 16:38:44 +0100Related with issue 37289: Some minor improvements in test
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 20 Nov 2017 16:38:44 +0100] rev 33022
Related with issue 37289: Some minor improvements in test

Mon, 20 Nov 2017 13:35:24 +0100related to issue 36778: fix jslint error by adding missing semicolon
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 20 Nov 2017 13:35:24 +0100] rev 33021
related to issue 36778: fix jslint error by adding missing semicolon