related to issue 40535: minor code improvements
authorCarlos Aristu <carlos.aristu@openbravo.com>
Fri, 12 Apr 2019 09:15:25 +0200
changeset 35691 ec0386dd0e01
parent 35690 44c6e6baec01
child 35692 c40147ef32b3
related to issue 40535: minor code improvements

- Reorder modifiers of log attribute
- Use diamond operator
src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java
--- a/src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java	Fri Apr 12 08:45:20 2019 +0200
+++ b/src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java	Fri Apr 12 09:15:25 2019 +0200
@@ -47,7 +47,7 @@
  *
  */
 public class HttpServletCalloutInformationProvider implements CalloutInformationProvider {
-  private final static Logger log = LogManager.getLogger();
+  private static final Logger log = LogManager.getLogger();
 
   private List<JSObject> responseElements;
   private String rawResponse;
@@ -116,7 +116,7 @@
     JSObject subelements = (JSObject) getCurrentElementValue(element);
 
     JSONObject jsonobject = new JSONObject();
-    ArrayList<JSONObject> comboEntries = new ArrayList<JSONObject>();
+    ArrayList<JSONObject> comboEntries = new ArrayList<>();
     // If column is not mandatory, we add an initial blank element
     if (!col.isMandatory()) {
       JSONObject entry = new JSONObject();