Tue, 24 May 2016 15:06:23 +0200Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 24 May 2016 15:06:23 +0200] rev 29577
Merge back from main

Mon, 23 May 2016 12:57:23 -0400Fixes issue 32892: Allowed to add goods receipts to a landed cost
Mark <markmm82@gmail.com> [Mon, 23 May 2016 12:57:23 -0400] rev 29576
Fixes issue 32892: Allowed to add goods receipts to a landed cost

Allowed to add goods receipts to a landed cost if the costing rule starting date is empty.

Tue, 24 May 2016 11:51:11 +0200fixed issue 33032: SystemValidatorTest is executed only for modules in dev
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 24 May 2016 11:51:11 +0200] rev 29575
fixed issue 33032: SystemValidatorTest is executed only for modules in dev

Now all modules are set in development before executing the test and reset
on finalization

Tue, 24 May 2016 10:12:04 +0200related to issue 30680: clean up SystemValidatorTest
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 24 May 2016 10:12:04 +0200] rev 29574
related to issue 30680: clean up SystemValidatorTest

Removed unused (ignored) test cases

Tue, 24 May 2016 10:04:46 +0200fixed issue 30680: Weld module does not pass 'ant validate.modules'
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 24 May 2016 10:04:46 +0200] rev 29573
fixed issue 30680: Weld module does not pass 'ant validate.modules'

Created blacklist that allows to define a META-INF directory inside src.

Tue, 24 May 2016 08:50:54 +0200fixes issue 33015: Performance Improvements in Product Selector
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 24 May 2016 08:50:54 +0200] rev 29572
fixes issue 33015: Performance Improvements in Product Selector

Mon, 23 May 2016 16:33:50 +0200[pi-selector-performance] Improved comment
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 23 May 2016 16:33:50 +0200] rev 29571
[pi-selector-performance] Improved comment

Mon, 23 May 2016 14:09:25 +0200[pi-selector-performance] Code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 23 May 2016 14:09:25 +0200] rev 29570
[pi-selector-performance] Code review improvements

Fri, 20 May 2016 11:14:49 +0200[pi-selector-performance] Code improvements in ob-selector-item
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 20 May 2016 11:14:49 +0200] rev 29569
[pi-selector-performance] Code improvements in ob-selector-item

Fri, 20 May 2016 10:49:04 +0200[pi-selector-performance] Mechanism to detect if filter by id is supported
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 20 May 2016 10:49:04 +0200] rev 29568
[pi-selector-performance] Mechanism to detect if filter by id is supported
A new flag has been included in the request when opening the a selector in order to detect if filter by ID can be applied for default filtering. This is because SelectorDefaultFilterActionHandler is used by selectors in classic mode (OBSelectorWidget) also. This way, the changes done to filter by ID are transparent for this kind of selectors.

Thu, 19 May 2016 18:36:38 +0200[pi-selector-performance] Refactor M_PRODUCT_PRICE_WAREHOUSE_V view
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 19 May 2016 18:36:38 +0200] rev 29567
[pi-selector-performance] Refactor M_PRODUCT_PRICE_WAREHOUSE_V view
The M_PRODUCT_PRICE_WAREHOUSE_V has been refactored, instead of joining it with M_PRODUCT_WAREHOUSE_QTYS_V the quantities (available, on hand, reserved and ordered) are calculated with subqueries for each row. This solution performs better in environments with big amount of records specially in M_STORAGE_DETAIL and M_STORAGE_PENDING tables.

Thu, 19 May 2016 18:24:39 +0200[pi-selector-performance] Use inner join when possible
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 19 May 2016 18:24:39 +0200] rev 29566
[pi-selector-performance] Use inner join when possible
Due to performance reasons, entities joined for sorting the query should use an inner join instead of a left join when possible. This is because a left join sometimes prevent using indexes for sorting. This does not happen for inner joins.
Together with this views whose primary key is the result of a concatenation of several columns, should not use that primary key for predictable sorting, because it is not an indexable key. In this type of cases, the id of the referenced entity used as value field is used for predictable sorting.

Thu, 19 May 2016 17:46:36 +0200[pi-selector-perform^Cce] Unneeded query performed when targetRecordId is null
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 19 May 2016 17:46:36 +0200] rev 29565
[pi-selector-perform^Cce] Unneeded query performed when targetRecordId is null
The targetRecordId parameter is used on the DefaultJsonDataService to compute a new startrow based on this paremeter value. If this parameter arrives with a null or empty value, the query to compute the new startrow must not be launched. Until now, this query was fired when targetRecordId parameter was received on the backend without considering its value. For example, this behavior could be reproduced after following these steps:
1- Edit an existing sales order line in form view.
2- Open the product selector pop-up.
3- Remove the default filters.

Thu, 19 May 2016 17:33:29 +0200[pi-selector-performance] Selected properties in selector drop-down requests
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 19 May 2016 17:33:29 +0200] rev 29564
[pi-selector-performance] Selected properties in selector drop-down requests
The requests performed by the drop-down of the selector now include just the needed properties:
1- The fields to be displayed on the pick list are requested using the SELECTED_PROPERTIES parameter.
2- The display field, value field and out fields are requested using the EXTRA_PROPERTIES parameter. This is because this parameter is always used on the requests as it is part of the selector template definition within the view.

Thu, 19 May 2016 17:23:31 +0200[pi-selector-performance] Added filtering by ID for default selector filters
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 19 May 2016 17:23:31 +0200] rev 29563
[pi-selector-performance] Added filtering by ID for default selector filters
Now the SelectorDefaultFilterActionHandler builds the default filtering criteria in order to filter FK columns by ID. Together with this an issue is solved on the openSelectorWindow function of OBSelectorItem, because the scroll was being kept after reopening the selector pop-up, which caused a wrong request after the first pop-up opening.

Thu, 05 May 2016 23:32:13 +0530Fixes issue 32709: Create link to Good Shipment in Create Invoice from Orders
Atul Gaware <atul.gaware@openbravo.com> [Thu, 05 May 2016 23:32:13 +0530] rev 29562
Fixes issue 32709: Create link to Good Shipment in Create Invoice from Orders

Fully shipped lines linked with invoice lines not only in case of POS Order but in any case

Mon, 23 May 2016 14:20:03 +0200related to issue 32932: backed out unrelated changeset
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 23 May 2016 14:20:03 +0200] rev 29561
related to issue 32932: backed out unrelated changeset

Mon, 23 May 2016 14:03:13 +0200related to issue 32932: suppress warns in sqlc generated code
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 23 May 2016 14:03:13 +0200] rev 29560
related to issue 32932: suppress warns in sqlc generated code

Mon, 23 May 2016 13:18:47 +0200related to issue 32932: supress warns in WAD generated code
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 23 May 2016 13:18:47 +0200] rev 29559
related to issue 32932: supress warns in WAD generated code

Mon, 23 May 2016 13:09:23 +0200related to issue 32932: suppress warn for false positives
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 23 May 2016 13:09:23 +0200] rev 29558
related to issue 32932: suppress warn for false positives

Mon, 23 May 2016 13:04:36 +0200related to issue 32932: fix up javadoc warnings
Stefan Hühner <stefan.huehner@openbravo.com> [Mon, 23 May 2016 13:04:36 +0200] rev 29557
related to issue 32932: fix up javadoc warnings

Mon, 23 May 2016 13:02:37 +0200related to issue 32932: removed some other warnings
Stefan Hühner <stefan.huehner@openbravo.com> [Mon, 23 May 2016 13:02:37 +0200] rev 29556
related to issue 32932: removed some other warnings

Thu, 19 May 2016 15:15:02 +0200Fixes issue 32914: Fix properly issue 31457
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 19 May 2016 15:15:02 +0200] rev 29555
Fixes issue 32914: Fix properly issue 31457

Change getOrderedPaymentScheduleDetails method in AddPaymentActionHandler class to order by absolute value of FIN_PaymentScheduleDetail.PROPERTY_AMOUNT property.
Change also the manage negative amounts check to recalculate remainingAmount if it is lower than outstandingAmount in case remainingAmount is negative.

Fri, 20 May 2016 10:08:11 +0200Fixes issue 33002: Stock before costing rule not shown in Valued Stock Report
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 20 May 2016 10:08:11 +0200] rev 29554
Fixes issue 33002: Stock before costing rule not shown in Valued Stock Report

Convert current costing rule starting date with to_timestamp instead of with to_date function to avoid date truncation.
Before, current costing rule starting date was truncated and closing and opening inventories created by costing rule validation were taken, so stock was zero.
Now, current costing rule starting date will not be truncated and only opening inventory created by costing rule validation will be taken, then stock will be the same as before the costing rule.

Fri, 20 May 2016 12:09:23 +0200Related to issue 32992: Update copyright
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 20 May 2016 12:09:23 +0200] rev 29553
Related to issue 32992: Update copyright

Fri, 20 May 2016 10:18:42 +0200Fixed issue 32992: [SER QA 1126] Error when creating a picking list
Aaron Calero <aaron.calero@openbravo.com> [Fri, 20 May 2016 10:18:42 +0200] rev 29552
Fixed issue 32992: [SER QA 1126] Error when creating a picking list

Not possible to create a Picking when either the Product or Storage Bin length is the maximum length

Fri, 20 May 2016 11:08:28 +0200fixed bug 33012: error in Instance Activation when using an expired license
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 20 May 2016 11:08:28 +0200] rev 29551
fixed bug 33012: error in Instance Activation when using an expired license

When using a license within an erroneous state (such as expired), message severity
was incorrectly obtained from the enum, causing an exception to be thrown.

Fixed by using MsgSeverity.forType method instead of valueOf. forType method
was designed with this purpose.

In addition, some other changes have been done on MsgSeverity enum:
* valueOf method is static so no need to invoke it on an instance (to may be
another one, which is weird).
* checking with actual type rather than with toString (which might change)
* reversed comparision order to prevent NPE in case param in null

Thu, 19 May 2016 09:56:37 +0200Fixed issue 32704: Base test for weld has conflicts with analytics module.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 19 May 2016 09:56:37 +0200] rev 29550
Fixed issue 32704: Base test for weld has conflicts with analytics module.

The problem was when a test that uses WeldBaseTest is thrown in an enviroment
with analytics module installed. It is a known issue in Jersey Servlet.

Setting this property to "true" is avoided throwing the error. It is a workaround
implemented in jersey-servlet-1.19.jar (CDIExtension.class) for Weld proxy bug.

Thu, 19 May 2016 11:14:55 +0200Fixed issue 32932: There were a lot of warnings in the code
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 19 May 2016 11:14:55 +0200] rev 29549
Fixed issue 32932: There were a lot of warnings in the code

There were a lot of warnings in the code that have been fixed.
There were some warnings in the PLSQL functions that have been fixed too.

Wed, 18 May 2016 17:51:02 +0200[pi-code-cleaning] "query.list()" re-added to the code
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 18 May 2016 17:51:02 +0200] rev 29548
[pi-code-cleaning] "query.list()" re-added to the code

The list of the query was wrongly removed, so, it has been added again.