Fri, 13 Nov 2015 11:07:02 +0100Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Martin Taal <martin.taal@openbravo.com> [Fri, 13 Nov 2015 11:07:02 +0100] rev 27941
Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Handle the case that the import entry has no role set, use the default in that case

Fri, 13 Nov 2015 10:07:21 +0100fixes issue 28687: IllegalArgumentException in QueryListDataSource
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 13 Nov 2015 10:07:21 +0100] rev 27940
fixes issue 28687: IllegalArgumentException in QueryListDataSource

The exception will not be thrown anymore as we now check if value is null before executing xmlDateFormat.format(value).

Fri, 13 Nov 2015 10:05:37 +0100related to bug 28477: removed debugging code
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 13 Nov 2015 10:05:37 +0100] rev 27939
related to bug 28477: removed debugging code

Fri, 13 Nov 2015 09:02:58 +0100fixed bug 28477: view generation: unneeded queries to trl tables
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 13 Nov 2015 09:02:58 +0100] rev 27938
fixed bug 28477: view generation: unneeded queries to trl tables

When generating view definition for standard windows queries to translation
tables where performed regardless the instance had no translation installed.
This results in several queries that were useless as they should never return
any value.

These queries have been prevented by checking if translations are installed
before executing them.

Fri, 13 Nov 2015 08:43:20 +0100fixes issue 28977: NPE if property field can not reach the complete path
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 13 Nov 2015 08:43:20 +0100] rev 27937
fixes issue 28977: NPE if property field can not reach the complete path

The NPE was thrown when defining a property field in the header tab. The FIC is using the getValueFromPath() method to calculate the value of the property field on NEW mode. It is sending as parameter the reference to the parent record for the cases where the value of the property field can be retrieved using the parent information. As in the header tabs we do not have a reference to a parent record, the parameter is null in these cases.

To solve the problem now we first check in getValueFromPath() method if the bob passed as parameter is null. In that case we return null in order to avoid the NPE.

Thu, 12 Nov 2015 17:03:51 +0100fixes issue 30436: Some columns appear empty when adding them in a saved view
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 12 Nov 2015 17:03:51 +0100] rev 27936
fixes issue 30436: Some columns appear empty when adding them in a saved view

The problem happened when adding a field with a saved view which by defaul is not displayed in the grid. In that case the values for that field are not present in the client side and is necessary to perform a request to the datasource.

To solve the problem a new method has been included for OBViewGrid, viewHasFieldsNotInGrid, which checks if every field added by the saved view is already displayed in the grid. If not then we invalidate the cache to force a request to the datasource through the refreshContents() function.

Thu, 12 Nov 2015 18:42:04 +0100Fixes issue 31387 & Fixes issue 31389: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 12 Nov 2015 18:42:04 +0100] rev 27935
Fixes issue 31387 & Fixes issue 31389: code review improvements

Reverted back the behavior of the Sender field. It shows the Business Partner Name (from the OB object) or the Business Partner Name string as it was doing before.

Wed, 11 Nov 2015 20:01:21 +0100Fixes issue 31387 & Fixes issue 31389: Add two new columns in Match Statement
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 11 Nov 2015 20:01:21 +0100] rev 27934
Fixes issue 31387 & Fixes issue 31389: Add two new columns in Match Statement

Added Business Partner Name and Transaction Description as new fields in Match Statement P&E window. They will not be shown in grid by default.
HQL Query in aprm_matchstatement table has been modified to retrieve this two new columns from FIN_BankStatementLine and FIN_Finacc_Transaction tables, and to retrieve bp.name as businessPartner also in case it is null.

Tue, 10 Nov 2015 19:05:45 +0100Fixes issue 31385: BusinessPartnerName not loaded in AddTransaction description
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 10 Nov 2015 19:05:45 +0100] rev 27933
Fixes issue 31385: BusinessPartnerName not loaded in AddTransaction description

Add Transaction description will be loaded with Business Partner name + Bank Statement Line description, in case Business Partner name is not empty.

Thu, 12 Nov 2015 18:24:03 +0100fixes issue 31104: Lazy filtering feature also affects column sorting
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 12 Nov 2015 18:24:03 +0100] rev 27932
fixes issue 31104: Lazy filtering feature also affects column sorting

- Updated help and description fields for the lazy filtering fields on Grid Configuration windows, explaining that the change affects to the sorting also.
- Updated the lazy filtering button tooltip.

Wed, 04 Nov 2015 10:05:47 +0100Related to issue 31069: Added an automated test in TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 04 Nov 2015 10:05:47 +0100] rev 27931
Related to issue 31069: Added an automated test in TestCosting

Thu, 29 Oct 2015 22:53:04 +0100Related to issue 31069: Added sleep to avoid assert errors in testCostingE1
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 29 Oct 2015 22:53:04 +0100] rev 27930
Related to issue 31069: Added sleep to avoid assert errors in testCostingE1

Wed, 28 Oct 2015 13:40:44 +0100Fixes issue 31069: Wrong cost calculation in Inventory Amount Update
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 28 Oct 2015 13:40:44 +0100] rev 27929
Fixes issue 31069: Wrong cost calculation in Inventory Amount Update

Change the reference of Unit Cost and Current Unit Cost columns from Amount to Number in Inventory Amount Update window, to take into account currency precision.
Remove getInventoryClosingCost method from AverageAlgorithm to calculate inventory closing transactions with Average Algorithm with current average cost, as it is done in getInventoryClosingCost method from CostingAlgorithm.
Set line number correctly to Physical Inventory Lines in InventoryAmountUpdateProcess.
Create a Negative Stock Correction adjustment related to last closing inventory line transaction created by an Inventory Amount Update (the ones that leaves the curent stock to zero) with current valued stock (remaining value) if any.
Retrieve trx and icl from session in CostingRuleProcess to avoid errors when validating a new Costing Rule.

Thu, 12 Nov 2015 17:32:58 +0100Fixes issue 30961: Warehouse rules will now make partial reservations
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 12 Nov 2015 17:32:58 +0100] rev 27928
Fixes issue 30961: Warehouse rules will now make partial reservations

Warehouse rules will now make partial reservations in case it exists stock for the reservation but not enough to cover it completely.

Thu, 12 Nov 2015 13:02:15 +0100Fixes issue 31451: OBException logged when it should not
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 12 Nov 2015 13:02:15 +0100] rev 27927
Fixes issue 31451: OBException logged when it should not

DefaultJsonDataService will check if it is needed to log localThrowable exception, in case it is an OBException.
New method added in OBException to allow throw exceptions without throwable cause and without log them.

Fri, 30 Oct 2015 00:43:32 +0100Related to issue 31202: Added an automated test in TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 30 Oct 2015 00:43:32 +0100] rev 27926
Related to issue 31202: Added an automated test in TestCosting

Thu, 12 Nov 2015 11:48:27 +0100Related to Issue 31202. Code Review changes.
David Miguelez <david.miguelez@openbravo.com> [Thu, 12 Nov 2015 11:48:27 +0100] rev 27925
Related to Issue 31202. Code Review changes.

While looking for existing Processed Transactions for a Product
it now takes into account costing dimensions, such as Warehouse.

Mon, 26 Oct 2015 16:40:52 +0100Related to issue 31202: Run Costing Background process for QA Testing client
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 26 Oct 2015 16:40:52 +0100] rev 27924
Related to issue 31202: Run Costing Background process for QA Testing client

Mon, 26 Oct 2015 15:07:34 +0100Related to issue 31202: Update inventory types created by Costing Rule process
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 26 Oct 2015 15:07:34 +0100] rev 27923
Related to issue 31202: Update inventory types created by Costing Rule process

Mon, 26 Oct 2015 17:00:37 +0100Fixes issue 31202: NSC when you get into 0 stock
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 26 Oct 2015 17:00:37 +0100] rev 27922
Fixes issue 31202: NSC when you get into 0 stock

Negative Stock Correction adjustment should be created when you get into zero stock (only in case you do not get into zero stock by a Closing Inventory), as it is created when you get into negative stock.

Thu, 12 Nov 2015 11:25:47 +0100fixes issue 30825: Show in Status Bar doesn't honour the Active = N flag
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 12 Nov 2015 11:25:47 +0100] rev 27921
fixes issue 30825: Show in Status Bar doesn't honour the Active = N flag

Now the OBViewFieldHandler considers the active flag to decide whether the field should be added to the status bar or not

Thu, 12 Nov 2015 10:20:59 +0100Fixed issue 30721. Fixed issue 30724
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 12 Nov 2015 10:20:59 +0100] rev 27920
Fixed issue 30721. Fixed issue 30724

Now is possible to insert or delete records in product characteristic configuration tab.


When a variant characteristic is added to a generic product all its values are copied in the configuration tab.

Thu, 12 Nov 2015 09:56:28 +0100Fixed issue 30884: Improve Add Products to Characteristic Value
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 12 Nov 2015 09:56:28 +0100] rev 27919
Fixed issue 30884: Improve Add Products to Characteristic Value

Wed, 11 Nov 2015 19:20:24 +0100related to issue 31434: improvement to not execute the same method two times
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 11 Nov 2015 19:20:24 +0100] rev 27918
related to issue 31434: improvement to not execute the same method two times

Wed, 11 Nov 2015 19:12:51 +0100fixes issue 31434: Error after cancel record creation in grid view and refresh
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 11 Nov 2015 19:12:51 +0100] rev 27917
fixes issue 31434: Error after cancel record creation in grid view and refresh

The problem was that when refreshing after cancelling the record creation in grid view, the refresh request was done considering that an existing record was selected. To avoid this problem, now after canceling, the getSelectedRecord() is cleared if the canceled record is a new one.

Wed, 11 Nov 2015 16:42:20 +0100fixes issue 31070: Deleting pop-up is never closed under some circumnstances
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 11 Nov 2015 16:42:20 +0100] rev 27916
fixes issue 31070: Deleting pop-up is never closed under some circumnstances

The problem was that when removing a record that is being editing, the updateTabTitle function was crashing when trying to access to this.viewGrid.getEditForm().isNew because this.viewGrid.getEditForm() is undefined at that point.

Apart from this, the isEditingGrid is not restored to false when removing a record which is being edited. This caused new errors after removing, because the view is not marked as in non-editing state. For this reason, now the isEditingGrid value is set to false for this case also.

Wed, 11 Nov 2015 12:22:58 +0100Merged heads
Martin Taal <martin.taal@openbravo.com> [Wed, 11 Nov 2015 12:22:58 +0100] rev 27915
Merged heads

Tue, 10 Nov 2015 09:05:49 +0100Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Martin Taal <martin.taal@openbravo.com> [Tue, 10 Nov 2015 09:05:49 +0100] rev 27914
Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Added logging statements, add wait in ImportEntryManager loop, also make sure that the wait time computation does not round, add a catch block in ImportEntryProcessorRunnable, moved the inner loop to a separate method for readability

Tue, 10 Nov 2015 17:21:18 +0100fixes issue 31411: Not possible to install modules in Module Mgmt using Edge
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 10 Nov 2015 17:21:18 +0100] rev 27913
fixes issue 31411: Not possible to install modules in Module Mgmt using Edge

The problem is that on MS Edge browser, the window.opener was lost. Now it is recovered in the same way as it was done for IE9. This avoids the javascript error that was being fired when trying to hide the loading screen in that browser.

Together with this the cache revision number has been updated in the required files.

Tue, 10 Nov 2015 16:26:06 +0100fixed bug 29910: exporting grid to csv can fail if audit fields are included
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 10 Nov 2015 16:26:06 +0100] rev 27912
fixed bug 29910: exporting grid to csv can fail if audit fields are included

This error was caused by a partial initialization of audit elements in OBViewUtil,
when this occured and label for one of these elements was tried to be obtained,
LazyInitializationException was thrown.

It has been fixed by forcing complete initialization of the elements and their
translations.