Thu, 08 Jan 2015 17:07:41 +0100Fixes Issue 28544.
David Miguelez <david.miguelez@openbravo.com> [Thu, 08 Jan 2015 17:07:41 +0100] rev 25738
Fixes Issue 28544.

In Reset Unit Cost Process, now takes into account that Organization
parameter can be null in a Query.

Thu, 13 Nov 2014 13:15:11 -0500Fixed bug 27996: Users are able to void invoices in draft status.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Thu, 13 Nov 2014 13:15:11 -0500] rev 25737
Fixed bug 27996: Users are able to void invoices in draft status.

ActionButtonUtility class now also excludes from combo the void option for c_invoice table when process button is clicked and document is in draft status.
Now when processing a just created invoice, it is not possible to void the document.

Wed, 07 Jan 2015 19:31:01 +0100Fixes bug 28531: Fix Backdated fails when backdated from is before starting date.
Unai Martirena <unai.martirena@openbravo.com> [Wed, 07 Jan 2015 19:31:01 +0100] rev 25736
Fixes bug 28531: Fix Backdated fails when backdated from is before starting date.

A check has been added to be sure that fix backdated from date is not earlier than starting date of the costing rule.
Also some code has been changed to handle correctly the error messages and return them properly to the user.
Finally the reference of Fix Backdated From Parameter in Fix Backdated Transactions Process Definitio has been changed from Date to DateTime.

Wed, 07 Jan 2015 18:42:06 +0100Backed out changeset d9352a85fef4
Ander Iraceburu <ander.iraceburu@openbravo.com> [Wed, 07 Jan 2015 18:42:06 +0100] rev 25735
Backed out changeset d9352a85fef4
Breaks retail integration

Wed, 07 Jan 2015 17:52:31 +0100Unit Cost Reference Data & JUnit Test
Ander Iraceburu <ander.iraceburu@openbravo.com> [Wed, 07 Jan 2015 17:52:31 +0100] rev 25734
Unit Cost Reference Data & JUnit Test

Wed, 07 Jan 2015 16:02:36 +0100Fixes issue 28537: Grid is loaded properly after scrolling it and sorting it
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 07 Jan 2015 16:02:36 +0100] rev 25733
Fixes issue 28537: Grid is loaded properly after scrolling it and sorting it

In this changeset [1] a change was done to prevent modifying improperly the totalRows property of the grid after scrolling. This code was meant to be executed after scrolling the grid, and to check it the lastScrollTop property and the getScrollTop() function of the grid body were compared. This check works properly when event that triggered the datasource request was the grid being filtered or a new page being fetched due to scrolling the grid.

The problem was that the check did not work properly when the datasource request was triggered due to having sorted the grid. In this case, the totalRows property should be left as is. To fix this, a new flag is used to control when the datasource request has been triggered by a sorting event.

[1] https://code.openbravo.com/erp/devel/pi/rev/c51dce7e9fd3

Wed, 07 Jan 2015 12:42:34 +0100Fixes issue 28505: Document number field length is not always hardcoded to 20
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 07 Jan 2015 12:42:34 +0100] rev 25732
Fixes issue 28505: Document number field length is not always hardcoded to 20

In this changeset [1], that was included in the first release of Openbravo 3.0, the length of the document number field length for the grids is hardcoded to 20. The length of the form field is taken from the length of the column in the application dictionary.

Having a different length in the grid and form fields resulted in the value of the field being truncated when it is edited in the view with the shortest length. It is not possible to remove the hardcoded code because it is possible that some Openbravo instances depend on it (i.e. if the length of the document number column is set to 0). In order to fix this issue, now the hardcoded code only affects the fields whose length is 0. For all the other cases, the length of the grid field will be taken from the length of the column.

[1] https://code.openbravo.com/erp/devel/pi/rev/ae5c327c567f#l3.14

Wed, 07 Jan 2015 10:18:24 +0100Fixes bug 28519:OrganizationStructureProvider.initialize should be synchronized
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 07 Jan 2015 10:18:24 +0100] rev 25731
Fixes bug 28519:OrganizationStructureProvider.initialize should be synchronized

The method OrganizationStructureProvider.initialize should be synchronized, because otherwise it could be executed concurrently. The first thing the method does it to check if it the OrganizationStructureProvider has been already initialized, but this is not enough to prevent the concurrent initializations.

One of the consequences of the concurrent initializations is that the three maps used in that method (naturalTreesByOrgID, parentByOrganizationID and childByOrganizationID) can be left in an inconsistent state, resulting in the a 100% CPU usage when trying to access them.

Wed, 07 Jan 2015 09:43:52 +0100Merge with latest pi
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Wed, 07 Jan 2015 09:43:52 +0100] rev 25730
Merge with latest pi

Mon, 05 Jan 2015 17:48:58 +0100Fix issue in merge unit cost project.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Mon, 05 Jan 2015 17:48:58 +0100] rev 25729
Fix issue in merge unit cost project.