Wed, 08 Jun 2016 19:52:27 +0530Fixes issue 33066: Fix to recalculateDiscounts issue in C_Order_Post1 function
Sanjota <sanjota.nelagi@promantia.com> [Wed, 08 Jun 2016 19:52:27 +0530] rev 29627
Fixes issue 33066: Fix to recalculateDiscounts issue in C_Order_Post1 function

When passing a pInstance to a c_order_post1 PL funciton, it calculates the discounts automatically, omitting the third parameter of the function.

Fri, 10 Jun 2016 11:53:53 +0200fixed 33186: OBContext.setReadableOrganizations loads Org objects in session
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 10 Jun 2016 11:53:53 +0200] rev 29626
fixed 33186: OBContext.setReadableOrganizations loads Org objects in session

OBContext.setReadableOrganizations, invoked on session creation, loaded full
DAL Organization objects in session. This caused slowness while loading and
in subsequent DAL flushes.

Now instead of loading full DAL objects, only ids are fetched from DB, in this
manner initialization is faster and flushes don't get affected.

Fri, 10 Jun 2016 11:48:56 +0200fixes issue 32815: Direct link to documents in the workspace is not working
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 10 Jun 2016 11:48:56 +0200] rev 29625
fixes issue 32815: Direct link to documents in the workspace is not working
The problem happened having a saved view with a date field as the first one of the grid. In this case the date item was firing an extra datasource call causing the bad behavior.
This extra call was being performed because the date field was detecting wrongly the deletion of its content. Now an extra check is added: the empty filter is applied if the newValue is '' and also if the grid was being filtered by this field.

Fri, 10 Jun 2016 09:58:42 +0200fixed bug 33138: OBCriteria adds standard filters several times
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 10 Jun 2016 09:58:42 +0200] rev 29624
fixed bug 33138: OBCriteria adds standard filters several times

In some cases (ie. in count method), OBCriteria adds the standard filters for
client, org and active several times.

The problem was caused because initialize method can be invoked several times
on the same criteria instance adding each time those filters.

Fixed now by setting a flag on 1st initialization and checking it to prevent
subsequent ones. Note this flag is not thread safe, but in any case OBCriteria
was not safe before it: several parallel initialization could clash.

Fri, 10 Jun 2016 08:49:34 +0200related to issue 33064: changes in help/description
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 10 Jun 2016 08:49:34 +0200] rev 29623
related to issue 33064: changes in help/description

Thu, 09 Jun 2016 18:27:43 +0200Added missed tables to the Client dataset definition
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 09 Jun 2016 18:27:43 +0200] rev 29622
Added missed tables to the Client dataset definition

Thu, 09 Jun 2016 15:27:20 +0200Issue 33126. Improve change by used getProxy variant returning
Stefan Hühner <stefan.huehner@openbravo.com> [Thu, 09 Jun 2016 15:27:20 +0200] rev 29621
Issue 33126. Improve change by used getProxy variant returning
proper Role.class instance directly instead of a bob and needing to cast it.

Tue, 07 Jun 2016 16:57:54 +0200Fixed 33126. Creating c_import_entry use Proxy to avoid reading from ad_role
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 07 Jun 2016 16:57:54 +0200] rev 29620
Fixed 33126. Creating c_import_entry use Proxy to avoid reading from ad_role

Read to ad_role can be avoided by using Proxy object instead.

Thu, 09 Jun 2016 10:27:43 +0200fixed bug 33194: Access not granted to Multiple Selector
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 09 Jun 2016 10:27:43 +0200] rev 29619
fixed bug 33194: Access not granted to Multiple Selector

When a mulitple selector was added to a proccess definition, access to its
enttity was not automatically granted, causing potential data request denial.

Now multiple selector reference is taken into account to grant privileges when
included in a process definition.

Wed, 08 Jun 2016 13:21:55 +0200fixed bug 33192: hidden stack trace on VariablesBase error logging
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 08 Jun 2016 13:21:55 +0200] rev 29618
fixed bug 33192: hidden stack trace on VariablesBase error logging

Tue, 07 Jun 2016 19:59:56 +0530Fixes issue 30281: m_stock_proposed added to log cleanup default configuration
Sanjota <sanjota.nelagi@promantia.com> [Tue, 07 Jun 2016 19:59:56 +0530] rev 29617
Fixes issue 30281: m_stock_proposed added to log cleanup default configuration

m_stock_proposed table data should be cleaned up once the process is finished. So should add the same table to log cleanup default configuration.

Tue, 07 Jun 2016 16:49:18 +0200[JSBeautifier] Fix error in jsbeautifier script
Miguel de Juana <miguel.dejuana@openbravo.com> [Tue, 07 Jun 2016 16:49:18 +0200] rev 29616
[JSBeautifier] Fix error in jsbeautifier script

- Blank lines inside comment block makes the script fail.

Tue, 07 Jun 2016 12:17:33 +0200Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 07 Jun 2016 12:17:33 +0200] rev 29615
Merge back from main

Mon, 06 Jun 2016 16:44:06 +0200Related with issue 33064: Code review improvements.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 06 Jun 2016 16:44:06 +0200] rev 29614
Related with issue 33064: Code review improvements.

It have been added help and description values.
Besides it have been removed some unused methods:
getAvailableWidgetClasses. There is an API changes.

It has been removed unused test in myob module.

Fri, 03 Jun 2016 14:56:32 +0200Related to issue 32032: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 03 Jun 2016 14:56:32 +0200] rev 29613
Related to issue 32032: Code review improvements

Wed, 25 May 2016 00:58:03 +0530Fixes issue 32032: ReportOrderNotShipped report query improved
Atul Gaware <atul.gaware@openbravo.com> [Wed, 25 May 2016 00:58:03 +0530] rev 29612
Fixes issue 32032: ReportOrderNotShipped report query improved

-Replace IN clause for locator using EXISTS
-Remove unwanted C_Order from subquery which compares quantities
-Rearrange the query
-Get stock from m_storage_detail using subquery instead of left join

Fri, 03 Jun 2016 15:32:03 +0200Related to issue 32949: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 03 Jun 2016 15:32:03 +0200] rev 29611
Related to issue 32949: Code review improvements

- Use inner join instead of left join between OrderLine and Order tables.
- Avoid unnecessary join with Tax table.
- Add index in M_MatchPO table to M_InoutLine_Id column.

Wed, 01 Jun 2016 18:31:57 +0530Fixes issue 32949: Improve performance in Return to Vendor Pick and Execute
Atul Gaware <atul.gaware@openbravo.com> [Wed, 01 Jun 2016 18:31:57 +0530] rev 29610
Fixes issue 32949: Improve performance in Return to Vendor Pick and Execute

In order to avoid unnecessary joins to M_InoutLine table, replace ol.goodsShipmentLine = iol with ol.goodsShipmentLine.id = iol.

Fri, 03 Jun 2016 13:58:10 +0200fixed bug 33129: unneeded object initialization for DAL insertion
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 03 Jun 2016 13:58:10 +0200] rev 29609
fixed bug 33129: unneeded object initialization for DAL insertion

When doing DAL insertions, client, org and user objects were initialized if
they were not yet in session. This causes unneded DB queries and object allocation
in memory.

These objects were used to set mandatory client/org and audit fields.

This initialization is now prevented by using hibernate proxies instead.

Thu, 02 Jun 2016 19:27:18 +0200Related with issue 33064: Added default values in widgets.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 02 Jun 2016 19:27:18 +0200] rev 29608
Related with issue 33064: Added default values in widgets.

Thu, 02 Jun 2016 17:14:50 +0200Fixed issue 33064: form widgets cant be added to workspace
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 02 Jun 2016 17:14:50 +0200] rev 29607
Fixed issue 33064: form widgets cant be added to workspace

The problem was related with widgets that can be embedded
into a form. In some cases, these widgets should not be
placed into the workspace.

To resolve this problem in a generic way, it has been
implemented a flag (Available_in_workspace) in the widget
definition that determines when a widget is available to
be shown in the workspace.

Now, any widget that does not have selected the new flag,
will not appear in the list of widgets to place into the
workspace.

Thu, 02 Jun 2016 17:11:55 +0200Related with issue 33064: form widgets cant be added to workspace
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 02 Jun 2016 17:11:55 +0200] rev 29606
Related with issue 33064: form widgets cant be added to workspace

It has implemented a new flag (Available_in_workspace) in the widget
definition that determines when a widget is available to be shown in
the workspace. We have also added the default values to the widgets
that already exist. By default yes.

Thu, 02 Jun 2016 12:51:40 +0200Related to issue 33040: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 02 Jun 2016 12:51:40 +0200] rev 29605
Related to issue 33040: Code review improvements

Wed, 01 Jun 2016 18:31:21 +0530Fixes issue 33040: Accounting info not loaded when login
Sanjota <sanjota.nelagi@promantia.com> [Wed, 01 Jun 2016 18:31:21 +0530] rev 29604
Fixes issue 33040: Accounting info not loaded when login

Unhomogeneous behavior depending on Org Access when role is defined at "Organization" user level.
Accounting info was not loaded when login with a role without access to any general ledger's organization.

Thu, 02 Jun 2016 10:00:49 +0200related to bug 33032: fixed module reset
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 02 Jun 2016 10:00:49 +0200] rev 29603
related to bug 33032: fixed module reset

Wed, 01 Jun 2016 18:14:41 +0200[JSBeautifier] Fix end file new line
Miguel de Juana <miguel.dejuana@openbravo.com> [Wed, 01 Jun 2016 18:14:41 +0200] rev 29602
[JSBeautifier] Fix end file new line

- Remove always last line of beautified file because the python always adds a line at the end
- Remove -Z to take into account white spaces at line end

Wed, 01 Jun 2016 18:12:18 +0200[JSBeautifier] Fix: Use files instead of mercurial changes
Miguel de Juana <miguel.dejuana@openbravo.com> [Wed, 01 Jun 2016 18:12:18 +0200] rev 29601
[JSBeautifier] Fix: Use files instead of mercurial changes

Wed, 01 Jun 2016 09:24:38 +0200fixed bug 32663: request to AlertActionHandler while switching role logs error
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 01 Jun 2016 09:24:38 +0200] rev 29600
fixed bug 32663: request to AlertActionHandler while switching role logs error

Under certain circumstances, it was possible to send alert handler requests while
in process of switching to a different role. This requests might be processes
with a partially created session, logging error messages in openbravo.log.

This has been fixed by preventing to send these requests from client, while
logging in is being processed.

Tue, 31 May 2016 16:15:43 +0200Related with issue 33050: Avoid check jslint errors in AppDynamics.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Tue, 31 May 2016 16:15:43 +0200] rev 29599
Related with issue 33050: Avoid check jslint errors in AppDynamics.

Mon, 30 May 2016 17:26:21 +0200Related to issue 33073: A test has been added.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 30 May 2016 17:26:21 +0200] rev 29598
Related to issue 33073: A test has been added.

A test that checks the correct behavior has been added.