Tue, 18 Jul 2017 10:11:59 +0200[refresh-license] removed unbalanced admin mode
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 18 Jul 2017 10:11:59 +0200] rev 32527
[refresh-license] removed unbalanced admin mode

Thu, 13 Jul 2017 09:42:24 +0200[refresh-license] use same lock to refresh from DB or remote
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 13 Jul 2017 09:42:24 +0200] rev 32526
[refresh-license] use same lock to refresh from DB or remote

Thu, 13 Jul 2017 09:15:11 +0200[refresh-license] don't log on catalina.out
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 13 Jul 2017 09:15:11 +0200] rev 32525
[refresh-license] don't log on catalina.out

Thu, 13 Jul 2017 09:05:41 +0200[refresh-license] removes some duplicities
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 13 Jul 2017 09:05:41 +0200] rev 32524
[refresh-license] removes some duplicities

Thu, 13 Jul 2017 08:57:47 +0200[refresh-license] update timestamp when refreshing online
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 13 Jul 2017 08:57:47 +0200] rev 32523
[refresh-license] update timestamp when refreshing online

Wed, 12 Jul 2017 17:14:05 +0200[refresh-license] updated comments
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 12 Jul 2017 17:14:05 +0200] rev 32522
[refresh-license] updated comments

Wed, 12 Jul 2017 17:02:27 +0200[refresh-license] removed debugging code
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 12 Jul 2017 17:02:27 +0200] rev 32521
[refresh-license] removed debugging code

Wed, 12 Jul 2017 15:23:35 +0200[refresh-license] pi merge
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 12 Jul 2017 15:23:35 +0200] rev 32520
[refresh-license] pi merge

Mon, 10 Jul 2017 09:48:08 +0200[refresh-license] pi merge
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 10 Jul 2017 09:48:08 +0200] rev 32519
[refresh-license] pi merge

Mon, 10 Jul 2017 09:47:45 +0200[refresh-license] butler won't send license if not updated since last refresh
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 10 Jul 2017 09:47:45 +0200] rev 32518
[refresh-license] butler won't send license if not updated since last refresh

Fri, 07 Jul 2017 13:14:54 +0200[refresh-license] don't lock other threads if already refreshing
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 07 Jul 2017 13:14:54 +0200] rev 32517
[refresh-license] don't lock other threads if already refreshing

Fri, 07 Jul 2017 13:09:07 +0200[refresh-license] use constant
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 07 Jul 2017 13:09:07 +0200] rev 32516
[refresh-license] use constant

Thu, 06 Jul 2017 16:50:48 +0200[refresh-license] perform time checks on actual instace
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 06 Jul 2017 16:50:48 +0200] rev 32515
[refresh-license] perform time checks on actual instace

Note if it was refreshed actual instance could differ from current

Thu, 06 Jul 2017 16:48:21 +0200[refresh-license] updated javadoc
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 06 Jul 2017 16:48:21 +0200] rev 32514
[refresh-license] updated javadoc

Thu, 06 Jul 2017 16:46:07 +0200[refresh-license] refresh every 24hr regardless other conditions
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 06 Jul 2017 16:46:07 +0200] rev 32513
[refresh-license] refresh every 24hr regardless other conditions

Mon, 17 Jul 2017 13:02:13 +0200related to issue 36504: removed support for 2.50 community branding
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 17 Jul 2017 13:02:13 +0200] rev 32512
related to issue 36504: removed support for 2.50 community branding

Mon, 17 Jul 2017 11:29:39 +0200fixed 36504: remove references to Basic Edition and Trial Subscription
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 17 Jul 2017 11:29:39 +0200] rev 32511
fixed 36504: remove references to Basic Edition and Trial Subscription

Mon, 17 Jul 2017 08:18:09 +0200related to issue 36373: delete js files related to api-checks code in pi
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 17 Jul 2017 08:18:09 +0200] rev 32510
related to issue 36373: delete js files related to api-checks code in pi

Recover previously removed run.test target and remove unneeded run.api.test.javascript

Fri, 14 Jul 2017 14:42:14 +0200related to bug 36494: patch also dojo.js.uncompressed.js
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 14 Jul 2017 14:42:14 +0200] rev 32509
related to bug 36494: patch also dojo.js.uncompressed.js

Fri, 14 Jul 2017 13:33:10 +0200fixed bug 36167: Tree view is not correctly filtered if tab has where clause
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 14 Jul 2017 13:33:10 +0200] rev 32508
fixed bug 36167: Tree view is not correctly filtered if tab has where clause

In case a tab that can be seen in tree mode, has a where clase with any OR, the
query generated for the tree view, was not applying this wehere clause corretly
because it didn't take into consideration operator precedence.

Fixed by isolating tab's where clause in the genereted query.

Fri, 14 Jul 2017 12:54:19 +0200fixed bug 36494: dojo GET requests have incorrect Content-Type header
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 14 Jul 2017 12:54:19 +0200] rev 32507
fixed bug 36494: dojo GET requests have incorrect Content-Type header

GET requests shouldn't include Content-Type header, which was the case for dojo
grid requests.

Patched dojo to prevent it.

Fri, 14 Jul 2017 12:12:33 +0200fixes 36373: delete js files related to api-checks code in pi
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 14 Jul 2017 12:12:33 +0200] rev 32506
fixes 36373: delete js files related to api-checks code in pi

Removed unused test code

Wed, 12 Jul 2017 12:28:55 +0200fixed 36473, fixed 36475
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 12 Jul 2017 12:28:55 +0200] rev 32505
fixed 36473, fixed 36475

new jar including patches for both issues

Tue, 11 Jul 2017 13:29:02 +0200fixed 36457: inconsistent grid state if cancelling changes before FIC response
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 11 Jul 2017 13:29:02 +0200] rev 32504
fixed 36457: inconsistent grid state if cancelling changes before FIC response

If while editing in grid mode, changes are cancelled before receiving FIC
response, it was possible to:
- Create a new partial and incorrect line with only the data returned from
FIC in case no line was being edited
- Apply changes from FIC to incorrect row if another one was being edited

Both problems are fixed by applying FIC changes only if the record is the same
the request was triggered for, this is checked by ensuring both row number and
record id. If editin a different record, FIC response is simply ignored.

Tue, 11 Jul 2017 09:13:34 +0200fixed bug 36454: in grid can trigger save before FIC response is received
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 11 Jul 2017 09:13:34 +0200] rev 32503
fixed bug 36454: in grid can trigger save before FIC response is received

While editing in grid mode, it is possible to trigger save action by clicking
grid's save button while FIC response is not received yet. If this occurs, the
data sent to backend misses information that FIC should update.

If grid's save button is clicked while in FIC call, postpone save action till
FIC return.

Mon, 10 Jul 2017 17:14:46 -0400Fixes issue 36404: Numbers in Receivables Aging Schedule and Payables Aging
Armaignac <collazoandy4@gmail.com> [Mon, 10 Jul 2017 17:14:46 -0400] rev 32502
Fixes issue 36404: Numbers in Receivables Aging Schedule and Payables Aging
Schedule are exported to Excel as strings

The fields defined in jasper report contains a format method call causing the
cell value be of string type

All the format calls was removed and the field now specified the cell value type
and the output format by the jasper patternExpression specification.

Tue, 11 Jul 2017 12:30:29 +0200Related to issue 36435: Fix warning also in TestCosting.java
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 11 Jul 2017 12:30:29 +0200] rev 32501
Related to issue 36435: Fix warning also in TestCosting.java

Mon, 10 Jul 2017 12:15:53 -0400Fixes issue 36435: Unlikely argument type warnings
Mark <markmm82@gmail.com> [Mon, 10 Jul 2017 12:15:53 -0400] rev 32500
Fixes issue 36435: Unlikely argument type warnings

StockReservationPickAndEditDataSource.java
- Fixed comparison between Empty String and OrderLine object.

LCCostMatchFromInvoiceHandler.java
- Remove the matchToRemove object from localIl.getLandedCostMatchedList() instead
of localIl.getLandedCostCostList() list.

SL_InOut_BPartner.java
- Replaced two nested IFs for only one that includes all conditions of both of them.
- Used StringUtils methods to avoid NPE.

DocFINReconciliation.java
- Used StringUtils methods to avoid NPE.
- Created two new variables to store accounts required for processing, and avoid
calculate them twice.

ProductInfo.java
- Removed comparison with Empty String, because it is not needed.

ConvertQuotationIntoOrder.java
- Removed comparison with Empty String, because it is not needed.
- Use BigDecimal.compareTo to compare two BigDecimal objects.

Tue, 11 Jul 2017 11:38:20 +0200Related to issue 36417: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 11 Jul 2017 11:38:20 +0200] rev 32499
Related to issue 36417: Code review improvements

Call to VariantChDescUpdateProcess after flush to set characteristic description properly.

Mon, 10 Jul 2017 10:37:15 -0400Fixes issue 36417: Characteristic Description is not updated
Armaignac <collazoandy4@gmail.com> [Mon, 10 Jul 2017 10:37:15 -0400] rev 32498
Fixes issue 36417: Characteristic Description is not updated

The Characteristic process from product window doesn't update the product
characteristic description, a new call to Update Product Characteristics
Description process is made to correctly update the product characteristic
description