Tue, 02 Aug 2016 10:49:13 +0200fixes issue 33572: Ability to define a Report Template as default
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 02 Aug 2016 10:49:13 +0200] rev 29827
fixes issue 33572: Ability to define a Report Template as default

A new field is added to the Report Template tab in the Document Type window. It is a checkbox that can be used to mark a template as default. If a template is marked as default, is the one that will be selected when printing the document. Also a new trigger has been created in order to allow just one default template per document type.

Mon, 01 Aug 2016 13:21:44 +0200Related to issue 33508: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 01 Aug 2016 13:21:44 +0200] rev 29826
Related to issue 33508: Code review improvements

Set invoiceTaxCashVAT_V variable as private.
Keep getInvoiceTaxCashVAT_V and setInvoiceTaxCashVAT_V methods as deprecated to avoid API change.
Add distinct to setInvoiceTaxCashVAT_V query to avoid retrieve duplicated ids.

Tue, 26 Jul 2016 14:43:28 -0400Fixes issue 33508: Error posting Cash VAT payment if pays more than one invoice
Mark <markmm82@gmail.com> [Tue, 26 Jul 2016 14:43:28 -0400] rev 29825
Fixes issue 33508: Error posting Cash VAT payment if pays more than one invoice

When trying to post a Cash VAT payment that pays more than one invoice, process was failing and an error was shown. It was caused by a clearing of the session when iterating on the cash vat invoices list. To avoid it, list of cash vat ids are retrieved instead a list of InvoiceTaxCashVAT_V.

Fri, 29 Jul 2016 11:18:31 +0200Fixed issue 33507: Incorrect Audit info was generated sometimes.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Fri, 29 Jul 2016 11:18:31 +0200] rev 29824
Fixed issue 33507: Incorrect Audit info was generated sometimes.

There was a problem when creating audit info data by some sqlc processes, sometimes wrong data was being created. The problem was that when the processes used the getTransactionConnection, the context information table was not correctly set. This table is set by the SessionInfo.setDBSessionInfo method.
To fix this, a call to this method has been added in the ConnectionProviderImpl.getTransactionConnection() and in the DalConnectionProvider.getTransactionConnection().

Fri, 29 Jul 2016 11:40:03 +0200fixes issue 33476: Wrong behavior in created/updated by filter with saved view
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 29 Jul 2016 11:40:03 +0200] rev 29823
fixes issue 33476: Wrong behavior in created/updated by filter with saved view

After applying the saved view, regarding the 'Created By' field, the displayField property ('_identifier') of the filter editor was being replaced with the display field of the field itself ('createdBy'). Therefore, after applying the saved view the values being displayed within the filter drop-down were the 'Created By' values for the entity referenced by the 'Created By' field (User). The same applies for the 'Updated By' field.

The root cause of this problem was that the fkField property for 'Created By' and 'Updated By' fields was not set to true. This allows to configure properly the filterEditorProperties on the client side for those fields, including the displayField whose value is set to '_identifier'.

From now the displayField property is set for the 'Created By' and 'Updated By' on the prepareGridFields() function, this way it will not be overridden after applying the saved view.

Wed, 20 Jul 2016 10:51:23 -0400Fixes issue 33494: Wrong Matched Invoice accounting entry when voiding invoice
Mark <markmm82@gmail.com> [Wed, 20 Jul 2016 10:51:23 -0400] rev 29822
Fixes issue 33494: Wrong Matched Invoice accounting entry when voiding invoice

"Invoice price variance" account was used because an incorrect way of calculate the expenses, multiplying by -1 was generating differences and accounting unbalances.

Wed, 20 Jul 2016 17:22:08 +0200Fixes issue 32906: Cannot process an inventory amount update
Mark <markmm82@gmail.com> [Wed, 20 Jul 2016 17:22:08 +0200] rev 29821
Fixes issue 32906: Cannot process an inventory amount update

The "name" field length in m_inventory table was increased to 100 to avoid errors when records are created or updated if the user is logged in with Spanish (Spain) language and translations have more than 60 characters.

Thu, 21 Jul 2016 09:12:30 +0200fixed 33515: NPE in AQB with associated entities if entity has computed columns
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 21 Jul 2016 09:12:30 +0200] rev 29820
fixed 33515: NPE in AQB with associated entities if entity has computed columns

When AdvancedQueryBuilder was used with the joinAssociatedEntities property set
to true and the queried entity included computed columns, a NPE was trhown.

Fixed by treating computed column property as an special case forcing always
a left join for it.

Tue, 19 Jul 2016 20:20:24 +0530Fixes Issue 33320: Performance problems in Create Lines From process
Atul Gaware <atul.gaware@openbravo.com> [Tue, 19 Jul 2016 20:20:24 +0530] rev 29819
Fixes Issue 33320: Performance problems in Create Lines From process

Problem was with loading invoices and orders in the respective combos.
Changed both queries to improve the performance.

Tue, 19 Jul 2016 19:51:14 +0200Fixes issue 33319: Performance problems in Create Shipments from Orders process
Atul Gaware <atul.gaware@openbravo.com> [Tue, 19 Jul 2016 19:51:14 +0200] rev 29818
Fixes issue 33319: Performance problems in Create Shipments from Orders process

Problem was with use of view m_inout_candidate_v in the query.
Fix implements the data fetching logic in query itself.

Fri, 15 Jul 2016 08:49:04 +0200Fixed issue 33478: Implicit filters were not working fine on updated instances
Naroa Iriarte <naroa.iriarte@openbravo.com> [Fri, 15 Jul 2016 08:49:04 +0200] rev 29817
Fixed issue 33478: Implicit filters were not working fine on updated instances

When a grid configuration was done in one instance and after that the instance was updated, the implicit filters were not working fine. The blue popup expressing that a filter is applied appeared but there was no filter applied.
The problem was in the isFilterClauseApplied function of ob-grid.js. There only was taking into account boolean values. Now, it takes into account any value.

Tue, 19 Jul 2016 09:04:46 +0200fixes issue 33263: Implement Client Side Event Handler Extensions
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 19 Jul 2016 09:04:46 +0200] rev 29816
fixes issue 33263: Implement Client Side Event Handler Extensions

Tue, 19 Jul 2016 08:50:01 +0200[client-event-handlers] Add extra check for registry on getEntries function
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 19 Jul 2016 08:50:01 +0200] rev 29815
[client-event-handlers] Add extra check for registry on getEntries function

Mon, 18 Jul 2016 19:38:43 +0200[client-event-handlers] Define registry at parent level
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 18 Jul 2016 19:38:43 +0200] rev 29814
[client-event-handlers] Define registry at parent level
The registry property is defined at the top of the register hierarchy. Also, it is initialized in the register function because otherwise the it was being shared between all OBFunctionRegistry child objects

Mon, 18 Jul 2016 13:00:27 +0200[client-event-handlers] Code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 18 Jul 2016 13:00:27 +0200] rev 29813
[client-event-handlers] Code review improvements

Fri, 17 Jun 2016 09:08:32 +0200[client-event-handlers] Use me variable in cellEditEnd()
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 17 Jun 2016 09:08:32 +0200] rev 29812
[client-event-handlers] Use me variable in cellEditEnd()

Thu, 16 Jun 2016 13:56:48 +0200[client-event-handlers] Merge with pi
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 16 Jun 2016 13:56:48 +0200] rev 29811
[client-event-handlers] Merge with pi

Thu, 16 Jun 2016 12:54:00 +0200[client-event-handlers] Use me variable in saveRow()
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 16 Jun 2016 12:54:00 +0200] rev 29810
[client-event-handlers] Use me variable in saveRow()

Thu, 16 Jun 2016 12:50:45 +0200[client-event-handlers] Execute pre-save actions when saving grid from keyboard
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 16 Jun 2016 12:50:45 +0200] rev 29809
[client-event-handlers] Execute pre-save actions when saving grid from keyboard
Pre-save actions should be fired also before saving a record in the grid with the up, down, enter or tab keys.

Thu, 16 Jun 2016 10:14:21 +0200[client-event-handlers] Not execute pre-save actions when save is not accepted
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 16 Jun 2016 10:14:21 +0200] rev 29808
[client-event-handlers] Not execute pre-save actions when save is not accepted
Pre-Save actions should not be executed if the answer to the confirmation prompt is negative.

Thu, 16 Jun 2016 09:59:01 +0200[client-event-handlers] Execute pre-save actions after auto-save confirmation
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 16 Jun 2016 09:59:01 +0200] rev 29807
[client-event-handlers] Execute pre-save actions after auto-save confirmation

Thu, 16 Jun 2016 09:20:49 +0200[client-event-handlers] Use existing getDirtyEditForm() to detect changes
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 16 Jun 2016 09:20:49 +0200] rev 29806
[client-event-handlers] Use existing getDirtyEditForm() to detect changes
There is no need to create a new hasChanges() function. The existing getDirtyEditForm() function can be used for the same purpose.

Wed, 15 Jun 2016 19:51:48 +0200[client-event-handlers] Use activeView to detect if exists post-save actions
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 15 Jun 2016 19:51:48 +0200] rev 29805
[client-event-handlers] Use activeView to detect if exists post-save actions

Wed, 15 Jun 2016 19:50:13 +0200[client-event-handlers] Implement pre-save action calling in standard windows
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 15 Jun 2016 19:50:13 +0200] rev 29804
[client-event-handlers] Implement pre-save action calling in standard windows

Wed, 15 Jun 2016 18:27:45 +0200[client-event-handlers] Minor refactor to use new existsAction function
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 15 Jun 2016 18:27:45 +0200] rev 29803
[client-event-handlers] Minor refactor to use new existsAction function

Tue, 14 Jun 2016 19:47:01 +0200[client-event-handlers] Implement post-save actions calling in standard forms
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 14 Jun 2016 19:47:01 +0200] rev 29802
[client-event-handlers] Implement post-save actions calling in standard forms

Tue, 14 Jun 2016 19:31:03 +0200[client-event-handlers] Remove unneeded variable
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 14 Jun 2016 19:31:03 +0200] rev 29801
[client-event-handlers] Remove unneeded variable

Tue, 14 Jun 2016 18:30:55 +0200[client-event-handlers] Use a better name
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 14 Jun 2016 18:30:55 +0200] rev 29800
[client-event-handlers] Use a better name

Tue, 14 Jun 2016 18:17:04 +0200[client-event-handlers] Special grid refresh for client event handlers
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 14 Jun 2016 18:17:04 +0200] rev 29799
[client-event-handlers] Special grid refresh for client event handlers
The refreshGridAfterSave is a new function that can be invoked by the client event handler actions. It passes a callback to the original refreshGrid function which now accepts a third argument. This argument is used to invoke the callback once the filtering performed by the function finishes (this callback invocation is the last statement that will be executed).

Tue, 14 Jun 2016 14:04:23 +0200[client-event-handlers] Implement post-save actions calling in standard grids
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 14 Jun 2016 14:04:23 +0200] rev 29798
[client-event-handlers] Implement post-save actions calling in standard grids