Fixes issue 22766: Information is not lost when saving a record with errors

The problem was that when a record was saved and in the saving process it was returned with validation errors, the record was being cleared from the grid. This happened because the List
Grid recordHasChanges function returned false (the record had changes indeed, in fact it was not yet saved in the database).

This has been fixed by overwritting the recordHasChanges function, so that it always returns true if the record had validation errors. In that case we can be sure that the record has ch
anges, because we know that a record with validation changes can not be saved in the database.

Fixes issue 22715: No error message shown when creating an order

from a sales quotation without payment method defined

Fixes issue 22903: Focus is not lost when changing images in Client window

When the Upload button of the popup was clicked the processEvent function of ob-eventthandler was executed. This function, among other things, tries to set as active view the view that owns the button. The problem was that the view being set as active was not the pop up, but the header tab of the window. This has been fixed by preventing this from happening where the window where the event originates is a popup.

Fixes issue 22932: Computed columns are ignored in the linked items

Computed columns (columns with sqllogic not null) are ignored in the linked items, to prevent trying to search for its physical column (they don't have one).

Fixes issue 22821: Triggers executed after entering full identifier in selector

The problem was that if the full identifier of the selector option was entered and then another field was clicked, the pickValue() method of the selector was not called and the triggers were not executed. This has been fixed by detecting the case where the whole identifier has been entered and if the user blurs out of that field, the setValueFromRecord is executed and the callouts were executed accordingly.

Fixes issue 22351: Quotation: error when trying to convert quotation to order

Fixes issue 22166: Wrong behaviour in the multiple product selector.
- Sales Dimensional Report.
- Shipments Dimensional Report
- Sales Order Report.

Fixes Issue 0022761: The first character disappears in Product selector (Invoice Lines)

Made sure even after filtering results, the character is not erased.

Related to issue 22761 : Backed out changeset 3c2ce42bad77

0022761: The first character disappears in Product selector (Invoice Lines)

Made sure even after filtering results, the character is not erased.

Related to Issue 22838 : Updated copyright year

Fixes Issue 0022838: DAL should not be used to update session last ping

Changed DAL update code to xsql.

Related to issue 22874: Implement rich and masked text field
Added mask validation using reg exp

Fixes issue 23000: It will be interesting to have the Clone orders button in window Purchase Orders

Fixes issue 22561: Incoming/Outgoing shipment: screens should be hidden

Fixes Issue 22626: Error in Payment using credit for negative invoices

Fixes issue 22971: Columns with null values can be exported to CSV

The problem was that the convertPrimitiveValue method of the DataToJsonConverter class was returning null when a null object was provided. If then that null object is used in the JSONObject.put(key, value) in the value field, the field was not added at all.

This has been fixed by returning an empty string instead of a null object.

Fixes issue 22650: NPE not thrown if login is done without 'User-Agent'

The isMobileBrowser of the Utility class was not taking into account that the 'User-Agent' property of the requeste could be null.

Fixes issue 23001: Clearing the filter works properly in P&E windows

The problem was that if in a P&E window the user entered something in a filter and then deleted that filter, the application considered that there were no filter active, so clearing the filter did not even try to call the datasource. The problem is that even though there were no filter, that window had a filter clause that needs to be cleared if the user clicks on the Clear Filter button.

This has been fixed by forcing a reload when the user clicks on the Clear Filter button by adding a dummy criterion to the criteria.

Fixes Issue 23031. Fixes Description.

Fixes issue 22625: Fixes autosave in grid for new records

The problem was that the new and proper record id (which is not available until the row has been saved in the database) was already available when the context info was retrieved, but was being overwritten by the old dummy in this line [1]. This happened because the old id was not being cleared, due to the fact that smartclient does not clear the values of the primary keys [2].

This is fixed by replacing the dummy id with the proper one if:
- The id returned by viewGrid.getEditValues (old one) begins with '_' (is dummy)
- The id returned by viewGrid.getRecord (new one) does not begin with '_' (is not dummy)

[1] https://code.openbravo.com/erp/devel/pi/file/fe46ee66e77a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js#l1993
[2] https://code.openbravo.com/erp/mods/org.openbravo.userinterface.smartclient.dev/file/8c2bc26694da/web/org.openbravo.userinterface.smartclient/isomorphic/client/widgets/ListGrid.js#l28859

Fixes issue 22636: Process monitor does not show errors

Fixes issue 23023: NPE no longer thrown when using REST webservices to add rows

In the resolve function of the EntityResolver class, OBDal.getInstance().get(entityName, id) was being executed without checking if the id was null.

Fixes Issue 22819: Some tabs have more than one field configured as first focused

Fixed issue 23029: Added capabilities to set a 'Role' as 'Portal' role

Fixes issue 22584: When changing the organization for a price list,
this change is not applied into their child lists

Fixes issue 22628: It should not be possible to verify a BOM product
without lines on Bill of Materials tab

Fixes issue 22976: Invoice Tax Report should be hidden

Fixes issue 22983: Wrong query in Valued Stock Report

Fixes issue 22969: SE_ORDER_Bpartner callout does not work perfectly