Fri, 29 Apr 2016 09:09:58 +0200[pi-code-cleaning] Some warnings of unused code have been fixed
Naroa Iriarte <naroa.iriarte@openbravo.com> [Fri, 29 Apr 2016 09:09:58 +0200] rev 29527
[pi-code-cleaning] Some warnings of unused code have been fixed

There was some unused code that has been deleted.

Thu, 28 Apr 2016 12:54:39 +0200[pi-code-cleaning] Possible unintentional assignations warnings fixed
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 28 Apr 2016 12:54:39 +0200] rev 29526
[pi-code-cleaning] Possible unintentional assignations warnings fixed

There were two assignations inside an if condition, this rised a warning.
To fix this, the value of the variable is previously assigned and it is
not done inside the if condition. The if condition now only checks if the
value of the parameter is true or false.

Thu, 28 Apr 2016 12:20:43 +0200[pi-code-cleaning] @SuppressWarnings("serial") have been added
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 28 Apr 2016 12:20:43 +0200] rev 29525
[pi-code-cleaning] @SuppressWarnings("serial") have been added

Some @SuppressWarnings("serial") have been added to avoid warnigs
of serializable classes that do not have serialVersionUID.

Thu, 28 Apr 2016 11:28:26 +0200[pi-code-cleaning] Finally blocks does not complete normally warnings fixed.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 28 Apr 2016 11:28:26 +0200] rev 29524
[pi-code-cleaning] Finally blocks does not complete normally warnings fixed.

There were some warnings about finally blocks not completing normally, that was
caused because the return statement was inside them. These warnings have been fixed.

Thu, 28 Apr 2016 10:33:34 +0200[pi-code-cleaning] Some Dead Code removed from the code
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 28 Apr 2016 10:33:34 +0200] rev 29523
[pi-code-cleaning] Some Dead Code removed from the code

There was some dead code that has been removed.

Wed, 27 Apr 2016 17:10:09 +0200[pi-code-cleaning] The unnecessary @supressWarnings of the code removed
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 27 Apr 2016 17:10:09 +0200] rev 29522
[pi-code-cleaning] The unnecessary @supressWarnings of the code removed

There were some unnecessary @supressWarnings that have been erased
to clean up the code.

Wed, 27 Apr 2016 16:12:38 +0200[pi-code-cleaning] Merge with latest pi
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 27 Apr 2016 16:12:38 +0200] rev 29521
[pi-code-cleaning] Merge with latest pi

Wed, 27 Apr 2016 16:05:53 +0200[pi-code-cleaning] The hex_to_int function deleted from postscript-DB2.sql
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 27 Apr 2016 16:05:53 +0200] rev 29520
[pi-code-cleaning] The hex_to_int function deleted from postscript-DB2.sql

The hex_to_int function has been deleted from postscript-DB2.sql.

Wed, 27 Apr 2016 15:43:05 +0200[pi-code-cleaning] hex_to_int and is_trigger_enabled deleted from filters
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 27 Apr 2016 15:43:05 +0200] rev 29519
[pi-code-cleaning] hex_to_int and is_trigger_enabled deleted from filters

The hex_to_in and the is_trigger_enabled functions have been deleted from the
excluding filters.

Wed, 27 Apr 2016 15:31:16 +0200[pi-code-cleaning] Casting added to to_number function
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 27 Apr 2016 15:31:16 +0200] rev 29518
[pi-code-cleaning] Casting added to to_number function

A casting to convert a string variable to numeric has been added
in the "to_number" function.

Wed, 27 Apr 2016 14:44:37 +0200[pi-code-cleaning] The to_date function newly added and modified
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 27 Apr 2016 14:44:37 +0200] rev 29517
[pi-code-cleaning] The to_date function newly added and modified

The previously deleted to_date function, has been newly added and
modified to get a charater argument instead of a timestam argument in the
to_timestamp function invocation.

Tue, 26 Apr 2016 17:15:29 +0200[pi-code-cleaning] The hex_to_int function removed from oracle
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 26 Apr 2016 17:15:29 +0200] rev 29516
[pi-code-cleaning] The hex_to_int function removed from oracle

The hex_to_int function has been removed from postscrips-Oracle.sql.

Tue, 26 Apr 2016 16:19:46 +0200[pi-code-cleaning] The is_trigger_enabled function has been deleted
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 26 Apr 2016 16:19:46 +0200] rev 29515
[pi-code-cleaning] The is_trigger_enabled function has been deleted

Tue, 26 Apr 2016 16:01:20 +0200[pi-code-cleaning] the hex_to_int functions have been deleted.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 26 Apr 2016 16:01:20 +0200] rev 29514
[pi-code-cleaning] the hex_to_int functions have been deleted.

Tue, 26 Apr 2016 15:52:47 +0200[pi-code-cleaning] One of to_date function has been deleted
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 26 Apr 2016 15:52:47 +0200] rev 29513
[pi-code-cleaning] One of to_date function has been deleted

The to_date(timestam without timezone, charcter varying) function
has been deleted.

Tue, 26 Apr 2016 10:02:19 +0200[pi-code-cleaning] The ad_shortname function has been deleted.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 26 Apr 2016 10:02:19 +0200] rev 29512
[pi-code-cleaning] The ad_shortname function has been deleted.

The ad_shortname function was not working properly, so it has been deleted.

Mon, 25 Apr 2016 17:54:17 +0200[pi-code-cleaning] Clean up of the hex_to_int pl function
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 25 Apr 2016 17:54:17 +0200] rev 29511
[pi-code-cleaning] Clean up of the hex_to_int pl function

The hex_to_int pl function has been cleaned up.

Thu, 19 May 2016 11:15:28 +0200related to bug 32995: force browser cache refresh
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 19 May 2016 11:15:28 +0200] rev 29510
related to bug 32995: force browser cache refresh

Thu, 19 May 2016 11:10:41 +0200fixed bug 32995: some 2.50 style selectors do not work on JBoss
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 19 May 2016 11:10:41 +0200] rev 29509
fixed bug 32995: some 2.50 style selectors do not work on JBoss

JBoss AS 7.1.1 is stricter than Tomcat when parsing request parameters. Some
2.50 style selectors where sending as part of the request an unnamed parameter
(which, btw, was incorrect), this was not problematic for Tocmat but it is for
JBoss.

Fixed by removing unnamed parameters from the generated request in client side.

Mon, 16 May 2016 15:57:17 +0200Fixed issue 32923: There was a NPE in the SelectorFieldPropertyCallout
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 16 May 2016 15:57:17 +0200] rev 29508
Fixed issue 32923: There was a NPE in the SelectorFieldPropertyCallout

There was a NullpointerException in the SelectorFieldPropertyCallout because
in the printPage method, there was not being taken into account the fact of
having a property of a computed column and the entity was not correctly retrieved.
This have been fixed checking if it is a computed column and generating the entity
correctly if so.

Wed, 11 May 2016 21:13:35 +0530Fixes Issue 32678:Wrong schedule details when purchase order is not fully
Atul Gaware <atul.gaware@openbravo.com> [Wed, 11 May 2016 21:13:35 +0530] rev 29507
Fixes Issue 32678:Wrong schedule details when purchase order is not fully
invoiced and related invoices have partial payment terms

While getting related order schedule, sign of quantity is checked

Sun, 15 May 2016 21:28:20 +0200Related with issue 32769: Codereview improvements.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Sun, 15 May 2016 21:28:20 +0200] rev 29506
Related with issue 32769: Codereview improvements.

Fri, 13 May 2016 11:26:47 +0200Fixed issue 32950.Use HashSet instead of ArrayList to avoid duplicates
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Fri, 13 May 2016 11:26:47 +0200] rev 29505
Fixed issue 32950.Use HashSet instead of ArrayList to avoid duplicates

The product ids are now stored using HashSet as this implementation does not
allow duplicates.

The method to create the vars in some scenarios is throwing a OBException that
is properly catch. It has been changed the try to avoid the OBException and
remove the error message from the logs.

Fri, 13 May 2016 07:18:46 +0200JSBeautifier license
Miguel de Juana <miguel.dejuana@openbravo.com> [Fri, 13 May 2016 07:18:46 +0200] rev 29504
JSBeautifier license

Thu, 12 May 2016 17:14:39 +0200Related to issue 32912: The test has been improved
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 12 May 2016 17:14:39 +0200] rev 29503
Related to issue 32912: The test has been improved

The test has been improved.

Wed, 11 May 2016 15:19:19 -0400Fixes issue 32933: Changed "Taiwan, Province of China" to "Taiwan, R.O.C"
Mark <markmm82@gmail.com> [Wed, 11 May 2016 15:19:19 -0400] rev 29502
Fixes issue 32933: Changed "Taiwan, Province of China" to "Taiwan, R.O.C"

Changed "Taiwan, Province of China" country and region to "Taiwan, R.O.C"

Thu, 12 May 2016 11:32:36 +0200Related to issue 32912: The test has been improved
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 12 May 2016 11:32:36 +0200] rev 29501
Related to issue 32912: The test has been improved

The test now checks the correct behavior of the Storage Bin subtab
(of the Warehouse and Storage Bins window).
It has now a private method which is the one that fills up the parameters map.

Thu, 12 May 2016 13:59:40 +0200fixes issue 32940: allow iEquals operator in Custom Query Selectors
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 12 May 2016 13:59:40 +0200] rev 29500
fixes issue 32940: allow iEquals operator in Custom Query Selectors
The criteria is being sent properly by the client side, but the iEquals operator was not being considered by the CustomQuerySelectorDatasource. It was filtering using a contains criteria instead.

Wed, 11 May 2016 12:36:52 +0200Related to issue 32504: Add one more sleep in MCC1 costing test.
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 11 May 2016 12:36:52 +0200] rev 29499
Related to issue 32504: Add one more sleep in MCC1 costing test.

Wed, 11 May 2016 12:28:00 +0200Related to issue 32912: Test added to check the correct behavior when refresh
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 11 May 2016 12:28:00 +0200] rev 29498
Related to issue 32912: Test added to check the correct behavior when refresh

When the WHERE_AND_FILTER_CLAUSE parameter was an empty string, the
behavior was wrong, it was adding an "and" at the beginning of the
where clause and this was not corret. This behavior has been fixed and this
test has been added to check that the datasource response is now correct.
The parameters used in the datasource of this test are the same paramertes
that where used in the datasource of the child tab of the "Price List" window
after refreshing the browser.
This is to imitate the behavior of refreshing the browser having a child tab opened.
The fact of having these parameters, makes that the WHERE_AND_FILTER_CLAUSE parameter
is the empty string, so we can now check that the request works fine now.