Mon, 27 Apr 2020 05:28:08 +0000Update AD_MODULE version to 3.0PR19Q4.4 3.0PR19Q4.4
RM packaging bot <staff.rm@openbravo.com> [Mon, 27 Apr 2020 05:28:08 +0000] rev 37237
Update AD_MODULE version to 3.0PR19Q4.4

Thu, 26 Mar 2020 07:43:14 +0100fixed BUG-43585: alerts not counted in main top bar widget
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Mar 2020 07:43:14 +0100] rev 37236
fixed BUG 43585: alerts not counted in main top bar widget

Alerts defined whose alert rule was defined in an organization
different than * were not counted in main top bar widget.

Parameter to set filter out not readeable organizations was
incorrectly setting clients instead of organizations.

Thu, 26 Mar 2020 12:25:43 +0100fixed BUG-43592: jrxml translate build step fails if using jasperreport.dtd
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Mar 2020 12:25:43 +0100] rev 37235
fixed BUG 43592: jrxml translate build step fails if using jasperreport.dtd

Translate makes use of a custom EntityResolver to handle jasperreport.dtd
resolving it locally instead of getting it from Internet. This local
resolution is implemented making use of Class.getResourceAsStream
method. The class the method was invoked from was java.lang.System.

Starting from JDK 9, getResourceAsStream invoked in classes within named
Modules looks for the resources only in those modules rather than in the
whole classpath [1]:

> If this class is in a named Module then this method will attempt to find
> the resource in the module. This is done by delegating to the module's class
> loader findResource(String,String) method, invoking it with the module name
> and the absolute name of the resource. Resources in named modules are subject
> to the rules for encapsulation specified in the Module getResourceAsStream
> method and so this method returns null when the resource is a non-".class"
> resource in a package that is not open to the caller's module.
>
> Otherwise, if this class is not in a named module then the rules for searching
> resources associated with a given class are implemented by the defining class
> loader of the class. This method delegates to this object's class loader. If
> this object was loaded by the bootstrap class loader, the method delegates to
> ClassLoader.getSystemResourceAsStream(java.lang.String).

As java.lang.System is in a named Module, dtd's resource was tried to be found within
it and not found.

Fixed by invoking getResourceAsStream on LocalEntityResolver.class which
is not in a named module.

[1] https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Class.html#getResourceAsStream(java.lang.String)

Wed, 01 Apr 2020 13:47:13 +0000CI: update AD_MODULE to version 37233
RM packaging bot <staff.rm@openbravo.com> [Wed, 01 Apr 2020 13:47:13 +0000] rev 37234
CI: update AD_MODULE to version 37233

Thu, 26 Mar 2020 10:34:28 +0100fixes BUG-43573:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Thu, 26 Mar 2020 10:34:28 +0100] rev 37233
fixes BUG 43573:Applied new HQL Style

Tue, 31 Mar 2020 17:44:01 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 31 Mar 2020 17:44:01 +0000] rev 37232
CI: merge back from main

Tue, 31 Mar 2020 17:30:19 +0000CI: update AD_MODULE to version 37230
RM packaging bot <staff.rm@openbravo.com> [Tue, 31 Mar 2020 17:30:19 +0000] rev 37231
CI: update AD_MODULE to version 37230

Tue, 31 Mar 2020 12:58:39 +0200fixed BUG-43581: Create Lines From support for trigger exceptions
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 31 Mar 2020 12:58:39 +0200] rev 37230
fixed BUG 43581: Create Lines From support for trigger exceptions

In case of errors during the process we rollback and close the current transaction. This is a general improvement that makes sense to the process.

In the JSONObject returned to the UI in case of exceptions, we try to get the message text to display to the end user. This is only possible because the previous locked transaction is closed, so DAL opens a new one to retrieve the error message.

Note that this code works for both db and java exceptions

Mon, 30 Mar 2020 14:54:30 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 30 Mar 2020 14:54:30 +0000] rev 37229
CI: merge back from main

Thu, 26 Mar 2020 12:25:43 +0100fixed BUG-43532: jrxml translate build step fails if using jasperreport.dtd
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Mar 2020 12:25:43 +0100] rev 37228
fixed BUG 43532: jrxml translate build step fails if using jasperreport.dtd

Translate makes use of a custom EntityResolver to handle jasperreport.dtd
resolving it locally instead of getting it from Internet. This local
resolution is implemented making use of Class.getResourceAsStream
method. The class the method was invoked from was java.lang.System.

Starting from JDK 9, getResourceAsStream invoked in classes within named
Modules looks for the resources only in those modules rather than in the
whole classpath [1]:

> If this class is in a named Module then this method will attempt to find
> the resource in the module. This is done by delegating to the module's class
> loader findResource(String,String) method, invoking it with the module name
> and the absolute name of the resource. Resources in named modules are subject
> to the rules for encapsulation specified in the Module getResourceAsStream
> method and so this method returns null when the resource is a non-".class"
> resource in a package that is not open to the caller's module.
>
> Otherwise, if this class is not in a named module then the rules for searching
> resources associated with a given class are implemented by the defining class
> loader of the class. This method delegates to this object's class loader. If
> this object was loaded by the bootstrap class loader, the method delegates to
> ClassLoader.getSystemResourceAsStream(java.lang.String).

As java.lang.System is in a named Module, dtd's resource was tried to be found within
it and not found.

Fixed by invoking getResourceAsStream on LocalEntityResolver.class which
is not in a named module.

[1] https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Class.html#getResourceAsStream(java.lang.String)