Thu, 06 Jun 2013 10:13:24 +0200[pw2] identify parameter in selectors by its id
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 06 Jun 2013 10:13:24 +0200] rev 20557
[pw2] identify parameter in selectors by its id

Thu, 06 Jun 2013 09:55:51 +0200[pw2] send context info in param windows when opening selector popup
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 06 Jun 2013 09:55:51 +0200] rev 20556
[pw2] send context info in param windows when opening selector popup

Tue, 04 Jun 2013 16:06:58 +0200[pw2] send param window field values to selector datasource
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 04 Jun 2013 16:06:58 +0200] rev 20555
[pw2] send param window field values to selector datasource

Tue, 04 Jun 2013 14:51:11 +0200[pw2] AD infrastructure for val rule in parameter
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 04 Jun 2013 14:51:11 +0200] rev 20554
[pw2] AD infrastructure for val rule in parameter

Tue, 04 Jun 2013 14:47:03 +0200[pw2] adding HQL type to val rule
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 04 Jun 2013 14:47:03 +0200] rev 20553
[pw2] adding HQL type to val rule

Mon, 03 Jun 2013 10:34:56 +0200[pw-2] disable unimplemented validation types
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 03 Jun 2013 10:34:56 +0200] rev 20552
[pw-2] disable unimplemented validation types

Mon, 10 Jun 2013 12:50:49 +0200Related with issue 23990: Backed out changeset 0762572868aa
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 10 Jun 2013 12:50:49 +0200] rev 20551
Related with issue 23990: Backed out changeset 0762572868aa

The fix has been backed out because it break the automated tests

Mon, 10 Jun 2013 11:48:00 +0200Fixes issue 23990: XML is imported properly using Initial Org Setup
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 10 Jun 2013 11:48:00 +0200] rev 20550
Fixes issue 23990: XML is imported properly using Initial Org Setup

This is what was happening when an object with id #id was being imported from a dataset to a organization. #id is the id of the object in the dataset
- The first time the object is imported to a organization (org1), the original #id is used
- When the same record was being imported to a sister organization (org2), a query for that object with the id #id was done. The organization filter was not being applied, so the object that was imported in the previous step was found. This object was related with other objects that belonged to org1, but was being referenced too from other objects that were belonged to org2. org1 is not part of the natural tree of org2, so an exception was thrown.

This has been fixed by adding a parameter to the resolve method that will force to apply the organization filter. The default value of this parameter is false, and it will only be true then is called from the InitialSetupUtility class.

Mon, 10 Jun 2013 09:49:30 +0530Fixes Issue 24021, Fixes Issue 23756 : Inhomogeneous behavior of some filters
Shankar Balachandran <shankar.balachandran@openbravo.com> [Mon, 10 Jun 2013 09:49:30 +0530] rev 20549
Fixes Issue 24021, Fixes Issue 23756 : Inhomogeneous behavior of some filters

Some filters after refresh or process completion did not retain the filter properly and other records were shown.
In refreshGrid, the newRecordsToBeIncluded array contains rows that do not adhere to the current filter.
The array is now compared with the data in the grid and the records are added only if its present in the current grid filter.
This change will not affect records opened using openDirectTab. Those records will be displayed even if not part of current filter.

Fri, 07 Jun 2013 12:31:18 +0200Fixed bug 24010 Generate receipt from invoices fails
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 07 Jun 2013 12:31:18 +0200] rev 20548
Fixed bug 24010 Generate receipt from invoices fails

Fri, 07 Jun 2013 09:28:08 +0200Fixed issue 24017. Remove continue statement.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Fri, 07 Jun 2013 09:28:08 +0200] rev 20547
Fixed issue 24017. Remove continue statement.

Mon, 03 Jun 2013 16:41:29 +0200Fixed bug 23196 add ad_org_id to c_paymentterm_name constraint
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 03 Jun 2013 16:41:29 +0200] rev 20546
Fixed bug 23196 add ad_org_id to c_paymentterm_name constraint

Mon, 03 Jun 2013 11:01:15 +0530Fixes Issue 23947: Recalculate amortization process
Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan@openbravo.com> [Mon, 03 Jun 2013 11:01:15 +0530] rev 20545
Fixes Issue 23947: Recalculate amortization process
When searching for existing amortization lines starting date should be ignored

Thu, 30 May 2013 12:38:25 +0530Fixes Issue 23928: Copy from Order in Purchase Order
Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan@openbravo.com> [Thu, 30 May 2013 12:38:25 +0530] rev 20544
Fixes Issue 23928: Copy from Order in Purchase Order

Mon, 03 Jun 2013 11:29:35 +0530Fixes issue 23844: Invalid Record Identifier for Conversion Rates
Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan@openbravo.com> [Mon, 03 Jun 2013 11:29:35 +0530] rev 20543
Fixes issue 23844: Invalid Record Identifier for Conversion Rates

Mon, 03 Jun 2013 12:09:33 +0530Fixes issue 23843: Invalid fields in Element Value tab on Account Tree window
Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan@openbravo.com> [Mon, 03 Jun 2013 12:09:33 +0530] rev 20542
Fixes issue 23843: Invalid fields in Element Value tab on Account Tree window

Thu, 06 Jun 2013 17:34:38 +0200Fixes Issue 23620: In Costing Migration Process fixes issue with
David Miguelez <david.miguelez@openbravo.com> [Thu, 06 Jun 2013 17:34:38 +0200] rev 20541
Fixes Issue 23620: In Costing Migration Process fixes issue with
negative Inventories.

Thu, 06 Jun 2013 17:34:05 +0200Fixes Issue 23911. Fixes division by zero.
David Miguelez <david.miguelez@openbravo.com> [Thu, 06 Jun 2013 17:34:05 +0200] rev 20540
Fixes Issue 23911. Fixes division by zero.

Thu, 06 Jun 2013 14:51:21 +0200Fixes issue 24012: Query list widgets with boolean parameters works
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 06 Jun 2013 14:51:21 +0200] rev 20539
Fixes issue 24012: Query list widgets with boolean parameters works

Before trying to convert a 'Y' or 'N' string to boolean in this line [1], check that the value is a string, because sometimes at that point the value attribute can already be a boolean.

[1] https://code.openbravo.com/erp/devel/pi/file/4cd557c40816/modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java#l221

Wed, 05 Jun 2013 19:45:05 +0200Fixes issue 0023929: In FIN_Financia_Account table the sequence number of the
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 05 Jun 2013 19:45:05 +0200] rev 20538
Fixes issue 0023929: In FIN_Financia_Account table the sequence number of the
identifier columns are not correctly defined

Undo backout done in commit: ec1c4db1c441, thus redoing commit: f5a58673fad6

Wed, 05 Jun 2013 17:14:58 +0200Fixes issue 23605: Error matching business
Javier Etxarri <javier.echarri@openbravo.com> [Wed, 05 Jun 2013 17:14:58 +0200] rev 20537
Fixes issue 23605: Error matching business
partner when importing bank statement, under some circumstances

Wed, 05 Jun 2013 15:57:57 +0200Fixes issue 23996: String is compared in constraint after being upper cased
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 05 Jun 2013 15:57:57 +0200] rev 20536
Fixes issue 23996: String is compared in constraint after being upper cased

Wed, 05 Jun 2013 14:03:22 +0200Fixes issue 23996: An event handler has been replaced with database constraints
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 05 Jun 2013 14:03:22 +0200] rev 20535
Fixes issue 23996: An event handler has been replaced with database constraints

The event handler TableDataOriginEventHandler has been replaced with database constraints. This is a better approach because it is simpler and easier to maint
ain.

The name of two of the messages has been updated so that it is the name as the constraint that throw them. The message used to warn the user that the table_name must be set if the data origin is 'Table' has been removed because now the table_name is mandatory again in the database.

Wed, 05 Jun 2013 12:36:15 +0200Fixes issue 23991: table_name column of ad_table table is mandatory again
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 05 Jun 2013 12:36:15 +0200] rev 20534
Fixes issue 23991: table_name column of ad_table table is mandatory again

At one point durint the development of the Datasource Based Tables project the table_name column of the ad_table table was set not mandatory, because this field was meant to be left empty for tables based on datasources. Later in the project it was decided to use the column 'name' (the name column of the Table table) to set the 'table_name' column for datasource based tables. This was we avoided having to change the table identifier (table_name).

After this change the table_name column must be mandatory in the database.

Tue, 04 Jun 2013 10:40:25 +0200Fixes issue 23503: Several jxml files are using isSplitAllowed which is deprecated.
Ioritz Cia <ioritz.cia@openbravo.com> [Tue, 04 Jun 2013 10:40:25 +0200] rev 20533
Fixes issue 23503: Several jxml files are using isSplitAllowed which is deprecated.

Tue, 04 Jun 2013 16:10:08 +0200fixes issue 23517: No error message shown when trying to import a file
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 04 Jun 2013 16:10:08 +0200] rev 20532
fixes issue 23517: No error message shown when trying to import a file
with a line without date or amount defined

Tue, 04 Jun 2013 12:33:00 +0200Fixes issue 23975: Changes are only done when getValue() returns a string
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 04 Jun 2013 12:33:00 +0200] rev 20531
Fixes issue 23975: Changes are only done when getValue() returns a string

The numeric handling only needed to be done when getValue() returns a string, that is, when the user has entered a new value or modified the existing one. The textualValue needed to be set also.

Tue, 04 Jun 2013 10:20:19 +0200Fixes issue 23975: Number handling works using ',' as decimal separator
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 04 Jun 2013 10:20:19 +0200] rev 20530
Fixes issue 23975: Number handling works using ',' as decimal separator

In the fix of the issue 23758 [1] it was wrongly assumed that the function getValue() of a OBNumberItem was going to return a javascript number. When the an existing record has just been opened getValue() will return a number, but when the user edits it, it will return the string representation of the number using the format specified by the user.

Now this has been taken into account, so the value is treated differently if getValue returns a string or a javascript number.

[1] https://code.openbravo.com/erp/devel/pi/rev/2e4eccaa3cc8fc8ac434cb0d386166558d1ee686

Mon, 03 Jun 2013 11:02:19 +0200Fixes issue 23858: v_Message variable in m_generate_average_costs function.
Ioritz Cia <ioritz.cia@openbravo.com> [Mon, 03 Jun 2013 11:02:19 +0200] rev 20529
Fixes issue 23858: v_Message variable in m_generate_average_costs function.

Sun, 02 Jun 2013 18:37:50 +0530Fixes Issue 0023925: Filter does not work properly when using ^
Shankar Balachandran <shankar.balachandran@openbravo.com> [Sun, 02 Jun 2013 18:37:50 +0530] rev 20528
Fixes Issue 0023925: Filter does not work properly when using ^

Applied code review changes to improves performance.
* Retrived list of operators once before looping instead of fetching it every time in the for loop.
* Instead of running a for loop on the list of operators, performed search based on the criteria operator.