Wed, 24 Aug 2016 14:54:57 -0400Fixes issue 33636: Error should be raised when running "Modify Payment Plan"
Rafael Queralta Pozo <rqueralta@nauta.cu> [Wed, 24 Aug 2016 14:54:57 -0400] rev 29904
Fixes issue 33636: Error should be raised when running "Modify Payment Plan"

Now "The invoice is already included in a Remittance." message is shown when running Modify Payment Plan process from an invoice included in a remittance.

Wed, 24 Aug 2016 20:46:44 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 20:46:44 +0000] rev 29903
CI: merge back from main

Wed, 24 Aug 2016 20:32:36 +0000CI: update AD_MODULE to version 29901
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 20:32:36 +0000] rev 29902
CI: update AD_MODULE to version 29901

Wed, 24 Aug 2016 15:49:21 +0200related to issue 33706: code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 24 Aug 2016 15:49:21 +0200] rev 29901
related to issue 33706: code review improvements

Wed, 24 Aug 2016 12:59:17 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 12:59:17 +0000] rev 29900
CI: merge back from main

Wed, 24 Aug 2016 14:39:03 +0200Fixed 33771. Avoid double .list() call to not run query twice.
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 14:39:03 +0200] rev 29899
Fixed 33771. Avoid double .list() call to not run query twice.

Old code ran following a OBCriteria
if (obc.list() == null || obc.list().size() == 0) {

However .list() does not return null as per Hibernate javadoc but empty or
non-empty list (of method raising an exception).

So remove the extra null check to avoid double .list() call.

Also improve .list().size() check slightly by using .list().isEmpty()

Add note that filter is on unique constraint so .list().size()<=1 also

Wed, 24 Aug 2016 14:23:41 +0200Fixed 33794. Avoid double .list() call by using .uniqueResult() instead.
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 14:23:41 +0200] rev 29898
Fixed 33794. Avoid double .list() call by using .uniqueResult() instead.

Code did check for >1 result rows while reading from obserds_datasource.
However as the filter is on the name column and that column has an unique
constraint that case of >1 cannot happen.

So simplify to just call .uniqueResult() removing both .list() calls.

Wed, 24 Aug 2016 13:54:17 +0200Issue 33774. Apply review feedback, change .size() > 0 to !isEmpty()
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 13:54:17 +0200] rev 29897
Issue 33774. Apply review feedback, change .size() > 0 to !isEmpty()

Wed, 24 Aug 2016 13:51:59 +0200Issue 33773. Apply review feedback replace .size() >0 with !isEmpty()
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 13:51:59 +0200] rev 29896
Issue 33773. Apply review feedback replace .size() >0 with !isEmpty()

Tue, 23 Aug 2016 17:58:45 +0200Fixed 33774. Fixed accidental double query by not calling .list() twice
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 17:58:45 +0200] rev 29895
Fixed 33774. Fixed accidental double query by not calling .list() twice