Mon, 04 May 2015 10:33:08 +0200Related to issue 29168. Missing copyright update
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Mon, 04 May 2015 10:33:08 +0200] rev 26527
Related to issue 29168. Missing copyright update

Fri, 01 May 2015 11:56:45 +0200Related to issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Fri, 01 May 2015 11:56:45 +0200] rev 26526
Related to issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Refactor query to use named parameters to avoid this piece to be used as template for other developers as this could be a risky practice due to injections.

Thu, 30 Apr 2015 19:24:38 +0200Related to issue 29353: Refactor of class in FIN_Utility so it can be used in core. This is now used in Initial Client Setup
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Thu, 30 Apr 2015 19:24:38 +0200] rev 26525
Related to issue 29353: Refactor of class in FIN_Utility so it can be used in core. This is now used in Initial Client Setup

Mon, 23 Mar 2015 16:09:38 +0100Fixed bug 29353: ICS implemented indirect dataset dependencies
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 23 Mar 2015 16:09:38 +0100] rev 26524
Fixed bug 29353: ICS implemented indirect dataset dependencies

When getting the module dependencies we take into account all the modules installed in the instance instead of only the one selected by the user.
We use the UpdateReferenceDataData.selectModules() method, which is used by the Enterprise Module Management process too, to get the right order.
The UpdateReferenceDataData class is now public to be called from InitialClientSetup.java.
Added missed ProcessingDataset message

Wed, 29 Apr 2015 16:35:18 +0200Related to issue 29720: Modify TestCosting tests
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 29 Apr 2015 16:35:18 +0200] rev 26523
Related to issue 29720: Modify TestCosting tests

Modify GM11, GM12, GM13 and GM5 tests, where cost adjustments from goods movements are created, to update accounting amounts

Wed, 29 Apr 2015 13:56:15 +0200Fixes issue 29720: Wrong accounting in Cost Adjusment
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 29 Apr 2015 13:56:15 +0200] rev 26522
Fixes issue 29720: Wrong accounting in Cost Adjusment

Wrong accounting of the cost adjusment lines in case of Goods Movement From.
In this case, accounting should consider negative amounts, in order to have a net effect of the goods movement adjustment accounting as 0.

Wed, 04 Mar 2015 16:09:45 +0100Fixed bug 28592: Added alerts and callout to manage Tax Location
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 04 Mar 2015 16:09:45 +0100] rev 26521
Fixed bug 28592: Added alerts and callout to manage Tax Location

Implemented 2 alerts:
+ Business Partner with no Tax Location Address
+ Business Partner with several Tax Location Addresses

Implemented callout over Location and Tax Location fields (Business Partner | Location/Address tab) that raises a warning if any of these conditions is fulfilled for the business partner:
+ More than 1 country set as Tax Location
+ Other country is declared as Tax Location and the user is trying to set a new country as Tax Location
+ The business partner has several countries and neither of them is declared as Tax Location

Wed, 29 Apr 2015 17:33:40 +0200Fixes issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Wed, 29 Apr 2015 17:33:40 +0200] rev 26520
Fixes issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Cancel button has been removed as it was considered confusing. Now there are two buttons, one for closing the window called 'OK', as it was before, and another one called 'Reconcile'.

Both triggers refresh. Messages have been added to improve user understanding on how the window works. New message to inform the user any change will be persisted. This message can be disabled once clear and will not popup again. Message to run algorithm as well improved.

Wed, 29 Apr 2015 18:21:34 +0200Related to issue 29687: Added QUnit test cases - Fixed JSLint problem
David Baz Fayos <david.baz@openbravo.com> [Wed, 29 Apr 2015 18:21:34 +0200] rev 26519
Related to issue 29687: Added QUnit test cases - Fixed JSLint problem

Wed, 29 Apr 2015 09:31:14 +0200Related to bug 28927: Fix unmatching error
Unai Martirena <unai.martirena@openbravo.com> [Wed, 29 Apr 2015 09:31:14 +0200] rev 26518
Related to bug 28927: Fix unmatching error

An error was being raised while doing unmatch when using 'addSelectedIDsToCriteria' method. The call to this method has been removed because it is not necessary as the criteria already has the selected ids.

Wed, 29 Apr 2015 17:45:24 +0200related to issue 29719: fixed property store test
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 29 Apr 2015 17:45:24 +0200] rev 26517
related to issue 29719: fixed property store test

CCU property is expected to be present

Wed, 29 Apr 2015 16:24:29 +0200Related to issue 29687: Added QUnit test cases
David Baz Fayos <david.baz@openbravo.com> [Wed, 29 Apr 2015 16:24:29 +0200] rev 26516
Related to issue 29687: Added QUnit test cases

Thu, 26 Feb 2015 17:46:48 +0100Fixed issue 28513: Error message wrongly shown when processing an inventory.
Jorge Garcia <jorge.garcia@openbravo.com> [Thu, 26 Feb 2015 17:46:48 +0100] rev 26515
Fixed issue 28513: Error message wrongly shown when processing an inventory.

The error message when processing an inventory is wrongly shown with a product
with % in its name and a negative stock.

The issue occurs when we are parsing the error message and detects the % symbol
and try to find the string format in the next character.

The proposal solution is to eliminate the String.format() method from the
code.

Now, the error message is shown properly with the correct name.

Tue, 28 Apr 2015 14:05:35 +0530Fixes Issue 28895:Cannot process an invoice if the role does not have access
Atul Gaware <atul.gaware@openbravo.com> [Tue, 28 Apr 2015 14:05:35 +0530] rev 26514
Fixes Issue 28895:Cannot process an invoice if the role does not have access
to FIN_Payment and the business partner has credit left

Changed OBContext to Admin mode when accessing Description field of Payment
and lastly restored it back again.

Tue, 28 Apr 2015 17:08:24 +0200Fixes issue 29338: Payment navigation from Transaction tab is working wrong
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 28 Apr 2015 17:08:24 +0200] rev 26513
Fixes issue 29338: Payment navigation from Transaction tab is working wrong

Issotrx auxiliary input query in Transaction tab has been changed to get into account related payment isreceipt field, when navigating from it to Payment In/Out window
Also, SE_Payment_Transaction and SE_Trxtype_Transaction callouts have been changed to overwrite issotrx session value when updating payment or transactiontype fields

Wed, 29 Apr 2015 10:22:24 +0200Related to bug 29091: Code Review
Unai Martirena <unai.martirena@openbravo.com> [Wed, 29 Apr 2015 10:22:24 +0200] rev 26512
Related to bug 29091: Code Review

[1]: Fix copyright
[2]: Change != for <>

Mon, 02 Mar 2015 11:02:02 +0100Fixed issue 29091: Fully depreciated field is not updated
Jorge Garcia <jorge.garcia@openbravo.com> [Mon, 02 Mar 2015 11:02:02 +0100] rev 26511
Fixed issue 29091: Fully depreciated field is not updated

The process didn't update the Fully Depreciated field when one or more
asset amortization lines were unprocessed.

The problem was in the amortization process.

Now the process changes the isFullyDepreciated field if the Depreciated
Value and the Depreciated Plan fields are differents.

Wed, 29 Apr 2015 08:55:42 +0200fixes issue 29667: NPE Error when a child tab is based on an HQL Query table
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 29 Apr 2015 08:55:42 +0200] rev 26510
fixes issue 29667: NPE Error when a child tab is based on an HQL Query table

The NPE was raised because the code was retrieving the entity for a table not based on a db table. This kind of tables do not have BaseOBObjects.
The FIC was already controlling this when the tab has a related table of this type but it was not considering the case when the parent table is related to a table of this type.

Wed, 29 Apr 2015 08:53:03 +0200fixes issue 29665: NP Error raised when using HQL Based Tables on a level 2 tab
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 29 Apr 2015 08:53:03 +0200] rev 26509
fixes issue 29665: NP Error raised when using HQL Based Tables on a level 2 tab

A unnecessary request was being done when accessing to the HQL query based subtab. This was caused because the tab was not being identified properly as a subtab.
The view.parentProperty was used to identify if we are on a child tab. This property could be undefined depending on the configuration of the tab in the application dictionary.
Now view.parentView is used instead of view.parentProperty because it does not return undefined in this cases

Wed, 29 Apr 2015 08:44:27 +0200related to issue 29719: fixed jsLint
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 29 Apr 2015 08:44:27 +0200] rev 26508
related to issue 29719: fixed jsLint

- Do not use global functions exposed by QUnit but use the ones defined within
the QUnit global object
- Define QUnit as /*global*/ directive JSLint not to complain about it use

Tue, 28 Apr 2015 16:56:17 +0200fixed issue 29270: prevent table recreation in update.database
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 16:56:17 +0200] rev 26507
fixed issue 29270: prevent table recreation in update.database

When adding or removing columns to existing tables update.database does not
recreate the table but just appends the new columns. In order to do this,
column phyisical position wihtin the table is no longer important, being relative
only to the time they were created but not to the module they belong to.

Tue, 28 Apr 2015 16:54:06 +0200[recreation] prevent table recreation
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 16:54:06 +0200] rev 26506
[recreation] prevent table recreation

Tue, 28 Apr 2015 07:39:15 +0200[recreation] added parameter to update.database to force recreation i
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 07:39:15 +0200] rev 26505
[recreation] added parameter to update.database to force recreation i


All/specific tables can be forced to be recreated when database is updated in
case they have model changes.

Tue, 28 Apr 2015 16:36:59 +0200fixed issue 29719: Recover QUnit JavaSript test cases
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 16:36:59 +0200] rev 26504
fixed issue 29719: Recover QUnit JavaSript test cases

QUnit test cases are now ready to be included in CI:
-QUnit library has been updated to latest version (1.1.18)
-JavaScript files are loaded in a proper order to guarantee dependencies
-Test cases create an Openbravo session not requiring to use a 2nd tab
-Results are kept in a js object so Selenium can easily access

Tue, 28 Apr 2015 16:24:55 +0200[jsTest] reorganize OBTest object to be easier managed by Selenium
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 16:24:55 +0200] rev 26503
[jsTest] reorganize OBTest object to be easier managed by Selenium

Tue, 28 Apr 2015 11:13:04 +0200[jsTest] fixed test cases
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 11:13:04 +0200] rev 26502
[jsTest] fixed test cases

Tue, 28 Apr 2015 11:08:15 +0200[jsTest] fixed test case
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 11:08:15 +0200] rev 26501
[jsTest] fixed test case

Tue, 28 Apr 2015 10:16:28 +0200[jsTest] proper js load and execution, create session before StaticResources
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 10:16:28 +0200] rev 26500
[jsTest] proper js load and execution, create session before StaticResources

Tue, 28 Apr 2015 10:12:29 +0200[jsTest] adapted tests to new QUnit version
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 10:12:29 +0200] rev 26499
[jsTest] adapted tests to new QUnit version

Tue, 28 Apr 2015 10:08:55 +0200[jsTest] Updated QUnit to 1.18.0
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 10:08:55 +0200] rev 26498
[jsTest] Updated QUnit to 1.18.0