Sat, 01 Jun 2013 02:14:15 +0200CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Sat, 01 Jun 2013 02:14:15 +0200] rev 20527
CI: merge back from main

Wed, 19 Jun 2013 04:18:52 +0000Added signature for changeset b0634b11086a
RM packaging bot <staff.rm@openbravo.com> [Wed, 19 Jun 2013 04:18:52 +0000] rev 20526
Added signature for changeset b0634b11086a

Wed, 19 Jun 2013 04:18:52 +0000Added tag 3.0MP24 for changeset 692d465ddec5
RM packaging bot <staff.rm@openbravo.com> [Wed, 19 Jun 2013 04:18:52 +0000] rev 20525
Added tag 3.0MP24 for changeset 692d465ddec5

Wed, 19 Jun 2013 04:18:51 +0000Update AD_MODULE version to 3.0MP24 3.0MP24
RM packaging bot <staff.rm@openbravo.com> [Wed, 19 Jun 2013 04:18:51 +0000] rev 20524
Update AD_MODULE version to 3.0MP24

Wed, 19 Jun 2013 04:17:17 +0000dummy commit to raise ci-obx version
RM packaging bot <staff.rm@openbravo.com> [Wed, 19 Jun 2013 04:17:17 +0000] rev 20523
dummy commit to raise ci-obx version

Tue, 18 Jun 2013 19:54:08 +0200Fixes issue 24120: Widgets embedded in tabs are supported again
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 18 Jun 2013 19:54:08 +0200] rev 20522
Fixes issue 24120: Widgets embedded in tabs are supported again

In this changeset [1] some logic was added to restrict the access to the widgets. One of the checks consisted in throwing an exception if the widget class did not have any widget instance class associated. This makes sense for workspace widgets, but widgets embedded in tabs do not have widget instance classes.

Now, this check is only done if the widget is not embedded in a window accessible by the user.


[1] https://code.openbravo.com/erp/devel/pi/rev/08d5a13b722bbc496c640a976d5bb319a1db44bc

Thu, 13 Jun 2013 18:13:37 +0200Fixed bug 24062 price limit suffix is wrong in product simple selector
Sandra Huguet <sandra.huguet@openbravo.com> [Thu, 13 Jun 2013 18:13:37 +0200] rev 20521
Fixed bug 24062 price limit suffix is wrong in product simple selector

Wed, 05 Jun 2013 19:45:05 +0200Fixes issue 0023929: In FIN_Financia_Account table the sequence number of the
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 05 Jun 2013 19:45:05 +0200] rev 20520
Fixes issue 0023929: In FIN_Financia_Account table the sequence number of the
identifier columns are not correctly defined

Undo backout done in commit: ec1c4db1c441, thus redoing commit: f5a58673fad6

Mon, 10 Jun 2013 18:19:16 +0200Fixed bug 23936 Product reference was changed to ProductSimple in invoices
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 10 Jun 2013 18:19:16 +0200] rev 20519
Fixed bug 23936 Product reference was changed to ProductSimple in invoices

Tue, 11 Jun 2013 17:32:55 +0200fixed bug 24005: incomplete audit trail info in processes
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 11 Jun 2013 17:32:55 +0200] rev 20518
fixed bug 24005: incomplete audit trail info in processes

Audit trail information was missing process and/or user in the following cases:

1. Java processes using DAL invoked from generated windows
2. Java processes using DAL invoked from menu
3. Process definition

In cases 1 and 2, the problem was audit info was set in ThreadLocal after the
DB temporary table was updated.

In case 3, it was not set at all.

Tue, 18 Jun 2013 12:05:47 +0200Fixed bug 24055 system allows unpost a document in a period closed
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 18 Jun 2013 12:05:47 +0200] rev 20517
Fixed bug 24055 system allows unpost a document in a period closed

Thu, 06 Jun 2013 14:51:21 +0200Fixes issue 24012: Query list widgets with boolean parameters works
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 06 Jun 2013 14:51:21 +0200] rev 20516
Fixes issue 24012: Query list widgets with boolean parameters works

Before trying to convert a 'Y' or 'N' string to boolean in this line [1], check that the value is a string, because sometimes at that point the value attribute can already be a boolean.

[1] https://code.openbravo.com/erp/devel/pi/file/4cd557c40816/modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java#l221

Fri, 07 Jun 2013 09:28:08 +0200Fixed issue 24017. Remove continue statement.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Fri, 07 Jun 2013 09:28:08 +0200] rev 20515
Fixed issue 24017. Remove continue statement.

Fri, 07 Jun 2013 12:31:18 +0200Fixed bug 24010 Generate receipt from invoices fails
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 07 Jun 2013 12:31:18 +0200] rev 20514
Fixed bug 24010 Generate receipt from invoices fails

Tue, 11 Jun 2013 15:59:34 +0530Fixes Issue 24036: The Expected date filter is not working in add payment popup
Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan@openbravo.com> [Tue, 11 Jun 2013 15:59:34 +0530] rev 20513
Fixes Issue 24036: The Expected date filter is not working in add payment popup

Wed, 05 Jun 2013 15:57:57 +0200Fixes issue 23996: String is compared in constraint after being upper cased
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 05 Jun 2013 15:57:57 +0200] rev 20512
Fixes issue 23996: String is compared in constraint after being upper cased

Wed, 05 Jun 2013 14:03:22 +0200Fixes issue 23996: An event handler has been replaced with database constraints
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 05 Jun 2013 14:03:22 +0200] rev 20511
Fixes issue 23996: An event handler has been replaced with database constraints

The event handler TableDataOriginEventHandler has been replaced with database constraints. This is a better approach because it is simpler and easier to maint
ain.

The name of two of the messages has been updated so that it is the name as the constraint that throw them. The message used to warn the user that the table_name must be set if the data origin is 'Table' has been removed because now the table_name is mandatory again in the database.

Wed, 05 Jun 2013 12:36:15 +0200Fixes issue 23991: table_name column of ad_table table is mandatory again
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 05 Jun 2013 12:36:15 +0200] rev 20510
Fixes issue 23991: table_name column of ad_table table is mandatory again

At one point durint the development of the Datasource Based Tables project the table_name column of the ad_table table was set not mandatory, because this field was meant to be left empty for tables based on datasources. Later in the project it was decided to use the column 'name' (the name column of the Table table) to set the 'table_name' column for datasource based tables. This was we avoided having to change the table identifier (table_name).

After this change the table_name column must be mandatory in the database.

Tue, 04 Jun 2013 12:33:00 +0200Fixes issue 23975: Changes are only done when getValue() returns a string
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 04 Jun 2013 12:33:00 +0200] rev 20509
Fixes issue 23975: Changes are only done when getValue() returns a string

The numeric handling only needed to be done when getValue() returns a string, that is, when the user has entered a new value or modified the existing one. The textualValue needed to be set also.

Tue, 04 Jun 2013 10:20:19 +0200Fixes issue 23975: Number handling works using ',' as decimal separator
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 04 Jun 2013 10:20:19 +0200] rev 20508
Fixes issue 23975: Number handling works using ',' as decimal separator

In the fix of the issue 23758 [1] it was wrongly assumed that the function getValue() of a OBNumberItem was going to return a javascript number. When the an existing record has just been opened getValue() will return a number, but when the user edits it, it will return the string representation of the number using the format specified by the user.

Now this has been taken into account, so the value is treated differently if getValue returns a string or a javascript number.

[1] https://code.openbravo.com/erp/devel/pi/rev/2e4eccaa3cc8fc8ac434cb0d386166558d1ee686

Sat, 01 Jun 2013 01:56:07 +0200CI: update AD_MODULE to version 20506
RM packaging bot <staff.rm@openbravo.com> [Sat, 01 Jun 2013 01:56:07 +0200] rev 20507
CI: update AD_MODULE to version 20506

Fri, 31 May 2013 18:19:45 +0200Issue 23385: , Backed out: 6792989a9124
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 31 May 2013 18:19:45 +0200] rev 20506
Issue 23385: , Backed out: 6792989a9124
As is breaks OrgSetup when using the optional 'Location' field.

Fri, 31 May 2013 12:44:01 +0200Backout issue 0023929: In FIN_Financia_Account table the sequence number of
Jon Alegría <jon.alegria@openbravo.com> [Fri, 31 May 2013 12:44:01 +0200] rev 20505
Backout issue 0023929: In FIN_Financia_Account table the sequence number of
the identifier columns are not correctly defined

Fri, 31 May 2013 12:25:02 +0200Fixes issue 23385: Organization is generated even
Javier Etxarri <javier.echarri@openbravo.com> [Fri, 31 May 2013 12:25:02 +0200] rev 20504
Fixes issue 23385: Organization is generated even
if the Initial Org Setup ends with errors

Fri, 31 May 2013 12:13:27 +0200related to issue 23936: backout changeset 80ca7ee3ac68
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 31 May 2013 12:13:27 +0200] rev 20503
related to issue 23936: backout changeset 80ca7ee3ac68

Thu, 30 May 2013 16:56:01 +0200Related to issue 23770: Backed out change, some warning should be logged
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 30 May 2013 16:56:01 +0200] rev 20502
Related to issue 23770: Backed out change, some warning should be logged

The approach used in this fix (modifying the template so only the jasper error are logged by default) should be improved. Instead of not logging any warning, we should try to reduce the number of warnings logged by fixing them. I.e. lots of warnings are related to the use of deprecated methods, those can be avoided by using the @supresswarnings annotation or by using a not deprecated method.

Thu, 30 May 2013 18:06:34 +0530Related to Issue 23925 : Jslint changes
Shankar Balachandran <shankar.balachandran@openbravo.com> [Thu, 30 May 2013 18:06:34 +0530] rev 20501
Related to Issue 23925 : Jslint changes

added condition to ignore regex criteria while setting symbol and made modifications in code for jslint compliance

Thu, 30 May 2013 13:35:27 +0200Fixes issue 23078: Child tabs use parent ad_module_id as default
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 30 May 2013 13:35:27 +0200] rev 20500
Fixes issue 23078: Child tabs use parent ad_module_id as default

The module column of child tabs should not be defaulted to the module flagged as default, but to the module of the record parent. This has been fixed for the module columns for the Menu - Menu Parameters and the Reference - User Interface Definition tabs.

Thu, 30 May 2013 13:35:55 +0200Fixed issue 23946. The backend restriction will not be checked if there is no way to retrieve the role.
Antonio Moreno <antonio.moreno@openbravo.com> [Thu, 30 May 2013 13:35:55 +0200] rev 20499
Fixed issue 23946. The backend restriction will not be checked if there is no way to retrieve the role.

Thu, 30 May 2013 16:13:40 +0530Related to Issue 23913 : Code review changes
Shankar Balachandran <shankar.balachandran@openbravo.com> [Thu, 30 May 2013 16:13:40 +0530] rev 20498
Related to Issue 23913 : Code review changes