Fixes Issue 0040323: Manage pre-reservation not possible
authorAtul Gaware <atul.gaware@openbravo.com>
Tue, 05 Mar 2019 19:04:20 +0530
changeset 35609 038c8b681054
parent 35608 a6f6f363f490
child 35610 1f23318a7a81
Fixes Issue 0040323: Manage pre-reservation not possible

** Do not use strict join on storage bin in query used to
get selected lines to avoid skipping of reservation stock
(pre-reservation) as they do not have storage bins, hence
used left join in place.
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
--- a/src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java	Thu Feb 28 11:24:05 2019 +0530
+++ b/src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java	Tue Mar 05 19:04:20 2019 +0530
@@ -11,7 +11,7 @@
  * under the License.
  * The Original Code is Openbravo ERP.
  * The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2014-2018 Openbravo SLU
+ * All portions are Copyright (C) 2014-2019 Openbravo SLU
  * All Rights Reserved. 
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -962,7 +962,7 @@
     final StringBuilder hqlString = new StringBuilder();
     hqlString.append("select rs from MaterialMgmtReservationStock rs ");
     hqlString.append(" join rs.reservation as r");
-    hqlString.append(" join rs.storageBin as sb");
+    hqlString.append(" left join rs.storageBin as sb");
     hqlString.append(" where rs.reservation = :reservation ");
 
     if (reservation.getAttributeSetValue() != null) {