[pi-code-cleaning] Some warnings of unused code have been fixed
authorNaroa Iriarte <naroa.iriarte@openbravo.com>
Fri, 29 Apr 2016 09:09:58 +0200
changeset 29527 69cad195ca3c
parent 29526 f0da01713483
child 29528 676952180c0d
[pi-code-cleaning] Some warnings of unused code have been fixed

There was some unused code that has been deleted.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDisplayLogics.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonToDataConverter.java
src-test/src/org/openbravo/test/accounting/PostDocumentTest.java
src-test/src/org/openbravo/test/db/model/functions/Ad_isorgincludedTest.java
src-test/src/org/openbravo/test/security/AllowedOrganizationsTest.java
src-test/src/org/openbravo/test/xml/ClientExportImportTest.java
src/org/openbravo/base/model/ModelProvider.java
src/org/openbravo/base/secureApp/OrgTreeNode.java
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
src/org/openbravo/dal/xml/EntityResolver.java
src/org/openbravo/erpCommon/ad_callouts/SL_Payment_Amounts.java
src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
src/org/openbravo/erpCommon/ad_forms/FactLine.java
src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
src/org/openbravo/erpCommon/ad_reports/ReportTrialBalanceDetail.java
src/org/openbravo/erpCommon/businessUtility/EMailAuthenticator.java
src/org/openbravo/erpCommon/info/LocatorMultiple.java
src/org/openbravo/erpCommon/modules/VersionUtility.java
src/org/openbravo/erpCommon/security/SessionLogin.java
src/org/openbravo/erpCommon/utility/Alert.java
src/org/openbravo/erpCommon/utility/ComboTableData.java
src/org/openbravo/erpCommon/utility/OBPrintStream.java
src/org/openbravo/financial/ResetAccounting.java
src/org/openbravo/service/system/ModuleValidator.java
--- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDisplayLogics.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDisplayLogics.java	Fri Apr 29 09:09:58 2016 +0200
@@ -11,7 +11,7 @@
  * under the License.
  * The Original Code is Openbravo ERP.
  * The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2014-2015 Openbravo SLU
+ * All portions are Copyright (C) 2014-2016 Openbravo SLU
  * All Rights Reserved.
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -30,7 +30,6 @@
 import org.openbravo.model.common.businesspartner.BusinessPartner;
 import org.openbravo.model.common.currency.Currency;
 import org.openbravo.model.common.enterprise.Organization;
-import org.openbravo.model.financialmgmt.payment.FIN_FinaccTransaction;
 
 @ComponentProvider.Qualifier(APRMConstants.TRANSACTION_WINDOW_ID)
 public class TransactionAddPaymentDisplayLogics extends AddPaymentDisplayLogicsHandler {
@@ -80,21 +79,6 @@
     }
   }
 
-  private FIN_FinaccTransaction getTransaction(Map<String, String> requestMap) throws JSONException {
-    // Current Payment
-    JSONObject context = new JSONObject(requestMap.get("context"));
-    String strFinFinaccTransactionIdd = "";
-    if (context.has("inpfinFinaccTransactionId") && !context.isNull("inpfinFinaccTransactionId")) {
-      strFinFinaccTransactionIdd = context.getString("inpfinFinaccTransactionId");
-    }
-    if (context.has("Fin_Finacc_Transaction_ID") && !context.isNull("Fin_Finacc_Transaction_ID")) {
-      strFinFinaccTransactionIdd = context.getString("Fin_Finacc_Transaction_ID");
-    }
-    FIN_FinaccTransaction transaction = OBDal.getInstance().get(FIN_FinaccTransaction.class,
-        strFinFinaccTransactionIdd);
-    return transaction;
-  }
-
   BigDecimal getDefaultGeneratedCredit(Map<String, String> requestMap) throws JSONException {
     return BigDecimal.ZERO;
   }
--- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java	Fri Apr 29 09:09:58 2016 +0200
@@ -74,7 +74,6 @@
   private Tab tab;
   private List<String> statusBarFields;
 
-  private List<String> windowEntities = null;
   private List<OBViewFieldDefinition> fields;
   private List<String> propertiesInButtonFieldDisplayLogic = new ArrayList<String>();
   private List<String> hiddenPropertiesInDisplayLogic = new ArrayList<String>();
@@ -2254,16 +2253,6 @@
     }
   }
 
-  private List<String> getWindowEntities() {
-    if (windowEntities == null) {
-      windowEntities = new ArrayList<String>();
-      for (Tab localTab : tab.getWindow().getADTabList()) {
-        windowEntities.add(localTab.getTable().getName());
-      }
-    }
-    return windowEntities;
-  }
-
   public List<Field> getIgnoredFields() {
     getFields(); // initializes stuff
     return ignoredFields;
--- a/modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonToDataConverter.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonToDataConverter.java	Fri Apr 29 09:09:58 2016 +0200
@@ -127,7 +127,6 @@
 
   private final static SimpleDateFormat xmlDateFormat = JsonUtils.createDateFormat();
   private final static SimpleDateFormat xmlDateTimeFormat = JsonUtils.createDateTimeFormat();
-  private final static SimpleDateFormat xmlTimeFormat = JsonUtils.createTimeFormat();
   private final static SimpleDateFormat jsTimeFormat = JsonUtils.createJSTimeFormat();
 
   private final List<JsonConversionError> errors = new ArrayList<JsonConversionError>();
--- a/src-test/src/org/openbravo/test/accounting/PostDocumentTest.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src-test/src/org/openbravo/test/accounting/PostDocumentTest.java	Fri Apr 29 09:09:58 2016 +0200
@@ -11,7 +11,7 @@
  * under the License. 
  * The Original Code is Openbravo ERP. 
  * The Initial Developer of the Original Code is Openbravo SLU 
- * All portions are Copyright (C) 2015 Openbravo SLU 
+ * All portions are Copyright (C) 2015-2016 Openbravo SLU 
  * All Rights Reserved. 
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -66,8 +66,6 @@
   private static final String ORGANIZATION_SPAIN_ID = "357947E87C284935AD1D783CF6F099A1";
   // Organization USA
   private static final String ORGANIZATION_USA_ID = "5EFF95EB540740A3B10510D9814EFAD5";
-  // Role QA Testing Admin
-  private final String ROLE_ID = "4028E6C72959682B01295A071429011E";
   // Table INVOICE
   private static final String TABLE_INVOICE = "318";
   // Table GL_JOURNAL
@@ -91,8 +89,6 @@
   private static final String GLJOURNAL_TEST7 = "F284DBAF46F244EB8CCA145A0CC47ACD";
   // G/L Journal Test with documentNo: 1003
   private static final String GLJOURNAL_TEST8 = "12857A9C03AD49D795F05A889CBEC0F2";
-  // G/L Journal Test with documentNo: 1004
-  private static final String GLJOURNAL_TEST9 = "8F27C4F6393A4457AA07E8D7754CEDF9";
   // ACCOUNTS USED FOR TEST RESULTS
   private static String TAX_RECEIVABLES = "FABD8D6CF3F04EE7A0389C2BAA1D620E";
   private static String SERVICE_COST = "F7B96292FB5842FBB51143BA659008B0";
--- a/src-test/src/org/openbravo/test/db/model/functions/Ad_isorgincludedTest.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src-test/src/org/openbravo/test/db/model/functions/Ad_isorgincludedTest.java	Fri Apr 29 09:09:58 2016 +0200
@@ -11,7 +11,7 @@
  * under the License.
  * The Original Code is Openbravo ERP.
  * The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2015 Openbravo SLU
+ * All portions are Copyright (C) 2015-2016 Openbravo SLU
  * All Rights Reserved.
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -53,11 +53,6 @@
   private static final String ORG_A1 = "357947E87C284935AD1D783CF6F099A1";
 
   /**
-   * USA Organization
-   */
-  private static final String ORG_A2 = "5EFF95EB540740A3B10510D9814EFAD5";
-
-  /**
    * F&B International Group Client
    */
   private static final String CLIENT_B = "23C59575B9CF467C9620760EB255B389";
--- a/src-test/src/org/openbravo/test/security/AllowedOrganizationsTest.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src-test/src/org/openbravo/test/security/AllowedOrganizationsTest.java	Fri Apr 29 09:09:58 2016 +0200
@@ -25,6 +25,7 @@
 
 import java.util.Set;
 
+import org.junit.Ignore;
 import org.junit.Test;
 import org.openbravo.base.exception.OBException;
 import org.openbravo.dal.core.OBContext;
@@ -50,27 +51,24 @@
    * Tests valid organizations trees for different organizations.
    */
   @Test
+  @Ignore("Fix test with new org tree map")
   public void testOrganizationTree() {
     setTestAdminContext();
-    // FIXME: Fix test with new org tree map
 
-    // final OrganizationStructureProvider osp = new OrganizationStructureProvider();
-    // osp.setClientId(TEST_CLIENT_ID);
-    //
-    // checkResult("1000001", osp, new String[] { "1000001" });
-    // checkResult("1000002", osp, new String[] { "1000003", "1000004", "1000000", "0", "1000002"
-    // });
-    // checkResult("1000003", osp, new String[] { "1000003", "1000000", "0", "1000002" });
-    // checkResult("1000004", osp, new String[] { "1000004", "1000000", "0", "1000002" });
-    // checkResult("1000005", osp, new String[] { "1000009", "1000006", "0", "1000000", "1000008",
-    // "1000005", "1000007" });
-    // checkResult("1000006", osp, new String[] { "1000009", "1000006", "0", "1000000", "1000008",
-    // "1000005" });
-    // checkResult("1000007", osp, new String[] { "1000000", "0", "1000005", "1000007" });
-    // checkResult("1000008", osp, new String[] { "1000000", "1000006", "0", "1000008", "1000005"
-    // });
-    // checkResult("1000009", osp, new String[] { "1000009", "1000006", "0", "1000000", "1000005"
-    // });
+    final OrganizationStructureProvider osp = new OrganizationStructureProvider();
+    osp.setClientId(TEST_CLIENT_ID);
+
+    checkResult("1000001", osp, new String[] { "1000001" });
+    checkResult("1000002", osp, new String[] { "1000003", "1000004", "1000000", "0", "1000002" });
+    checkResult("1000003", osp, new String[] { "1000003", "1000000", "0", "1000002" });
+    checkResult("1000004", osp, new String[] { "1000004", "1000000", "0", "1000002" });
+    checkResult("1000005", osp, new String[] { "1000009", "1000006", "0", "1000000", "1000008",
+        "1000005", "1000007" });
+    checkResult("1000006", osp, new String[] { "1000009", "1000006", "0", "1000000", "1000008",
+        "1000005" });
+    checkResult("1000007", osp, new String[] { "1000000", "0", "1000005", "1000007" });
+    checkResult("1000008", osp, new String[] { "1000000", "1000006", "0", "1000008", "1000005" });
+    checkResult("1000009", osp, new String[] { "1000009", "1000006", "0", "1000000", "1000005" });
   }
 
   private void checkResult(String id, OrganizationStructureProvider osp, String[] values) {
--- a/src-test/src/org/openbravo/test/xml/ClientExportImportTest.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src-test/src/org/openbravo/test/xml/ClientExportImportTest.java	Fri Apr 29 09:09:58 2016 +0200
@@ -108,6 +108,7 @@
    * 
    * Also tests mantis 9000: https://issues.openbravo.com/view.php?id=9000
    */
+  @SuppressWarnings("deprecation")
   @Ignore("This test has been temporarily disabled until the following issue related to the export client functionality is fixed: https://issues.openbravo.com/view.php?id=14848")
   @Test
   public void testExportImportClient1000000() {
@@ -115,12 +116,11 @@
     // This test has been temporarily disabled until the following issue related to the export
     // client functionality is fixed:
     // https://issues.openbravo.com/view.php?id=14848
-
-    // final String newClientId = exportImport(TEST_CLIENT_ID);
-    // testMantis8509(newClientId);
-    // testAccountingFactMantis9000(newClientId);
-    // testTreeNodesMantis9000(newClientId);
-    // SystemService.getInstance().removeAllClientData(newClientId);
+    final String newClientId = exportImport(TEST_CLIENT_ID);
+    testMantis8509(newClientId);
+    testAccountingFactMantis9000(newClientId);
+    testTreeNodesMantis9000(newClientId);
+    SystemService.getInstance().removeAllClientData(newClientId);
   }
 
   private void testTreeNodesMantis9000(String newClientID) {
--- a/src/org/openbravo/base/model/ModelProvider.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/base/model/ModelProvider.java	Fri Apr 29 09:09:58 2016 +0200
@@ -89,7 +89,6 @@
   private List<Module> modules;
   private Session initsession;
 
-  private static final String DATASOURCEBASEDTABLE = "Datasource";
   private static final String TABLEBASEDTABLE = "Table";
 
   /**
--- a/src/org/openbravo/base/secureApp/OrgTreeNode.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/base/secureApp/OrgTreeNode.java	Fri Apr 29 09:09:58 2016 +0200
@@ -1,6 +1,6 @@
 /*
  ************************************************************************************
- * Copyright (C) 2008-2010 Openbravo S.L.U.
+ * Copyright (C) 2008-2016 Openbravo S.L.U.
  * Licensed under the Apache Software License version 2.0
  * You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to  in writing,  software  distributed
@@ -30,7 +30,6 @@
   private String value;
   private String isReady;
   private OrganizationType orgType;
-  private String serializedOrgTypeId;
 
   /**
    * Creates a node from data related to it
@@ -65,7 +64,6 @@
   // only be deserialized if they are connected to the db because some
   // of the references maybe a cglib proxy
   private void writeObject(ObjectOutputStream out) throws IOException {
-    serializedOrgTypeId = orgType.getId();
     orgType = null;
     out.defaultWriteObject();
   }
--- a/src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java	Fri Apr 29 09:09:58 2016 +0200
@@ -1628,21 +1628,6 @@
     return (BigDecimal) query.uniqueResult();
   }
 
-  private BigDecimal getQtyReserved(Reservation reservation, StorageDetail sd) {
-    final StringBuilder hqlString = new StringBuilder();
-    hqlString
-        .append("select coalesce(sum(rs.quantity - coalesce(rs.released,0)),0) from MaterialMgmtReservationStock rs ");
-    hqlString.append("join rs.reservation as r ");
-    hqlString.append(" where r.rESStatus not in ('CL', 'DR') ");
-    hqlString.append(" and rs.storageDetail = :storageDetail ");
-    hqlString.append(" and r <> :reservation ");
-    final Session session = OBDal.getInstance().getSession();
-    Query query = session.createQuery(hqlString.toString());
-    query.setParameter("storageDetail", sd);
-    query.setParameter("reservation", reservation);
-    return (BigDecimal) query.uniqueResult();
-  }
-
   private BigDecimal getQtyReserved(Reservation reservation, Product product,
       AttributeSetInstance attribute, Locator storageBin) {
     final StringBuilder hqlString = new StringBuilder();
--- a/src/org/openbravo/dal/xml/EntityResolver.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/dal/xml/EntityResolver.java	Fri Apr 29 09:09:58 2016 +0200
@@ -94,7 +94,6 @@
   private Organization organization;
   private String[] orgNaturalTree;
   private ResolvingMode resolvingMode = ResolvingMode.ALLOW_NOT_EXIST;
-  private boolean lookForTranslatedIDs;
 
   private OrganizationStructureProvider organizationStructureProvider;
 
@@ -442,7 +441,7 @@
       boolean filterByClient) {
     PreparedStatement ps = null;
     try {
-      String st = "Select specific_id, generic_id, ad_client_id, ad_org_id from ad_ref_data_loaded where ad_client_id in ('"
+      String st = "Select specific_id, ad_client_id, ad_org_id from ad_ref_data_loaded where ad_client_id in ('"
           + client.getId()
           + "', '0') and generic_id='"
           + id
@@ -455,11 +454,11 @@
       while (rs.next()) {
         RefDataLoaded rfl = new RefDataLoaded();
         rfl.setSpecificId(rs.getString(1));
-        rfl.setGenericId(rs.getString(2));
-        rfl.setClientId(rs.getString(3));
-        rfl.setOrgId(rs.getString(4));
+        rfl.setClientId(rs.getString(2));
+        rfl.setOrgId(rs.getString(3));
         refDataLoadeds.add(rfl);
       }
+
       return refDataLoadeds;
     } catch (Exception e) {
       throw new OBException("Error while accessing the ad_ref_data_loaded table", e);
@@ -474,18 +473,9 @@
 
   private class RefDataLoaded {
     private String specificId;
-    private String genericId;
     private String clientId;
     private String orgId;
 
-    public String getGenericId() {
-      return genericId;
-    }
-
-    public void setGenericId(String genericId) {
-      this.genericId = genericId;
-    }
-
     public String getSpecificId() {
       return specificId;
     }
@@ -746,9 +736,4 @@
     return entityName + id;
   }
 
-  @Deprecated
-  public void setLookForTranslatedIDs(boolean lookForTranslatedIDs) {
-    this.lookForTranslatedIDs = lookForTranslatedIDs;
-  }
-
 }
\ No newline at end of file
--- a/src/org/openbravo/erpCommon/ad_callouts/SL_Payment_Amounts.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/ad_callouts/SL_Payment_Amounts.java	Fri Apr 29 09:09:58 2016 +0200
@@ -39,8 +39,6 @@
 public class SL_Payment_Amounts extends HttpSecureAppServlet {
   private static final long serialVersionUID = 1L;
 
-  private static final BigDecimal ZERO = new BigDecimal(0.0);
-
   public void init(ServletConfig config) {
     super.init(config);
     boolHist = false;
--- a/src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java	Fri Apr 29 09:09:58 2016 +0200
@@ -304,23 +304,6 @@
     return true;
   }
 
-  private String isperiodOpen(ConnectionProvider conn, String periodId) {
-    if ("".equals(periodId)) {
-      return "";
-    }
-    try {
-      DocGLJournalData[] data = DocGLJournalData.periodOpen(conn, periodId);
-      if (data != null && data.length > 0) {
-        return periodId;
-      } else {
-        return "";
-      }
-    } catch (ServletException e) {
-      e.printStackTrace();
-      return "";
-    }
-  }
-
   public String getServletInfo() {
     return "Servlet for the accounting";
   } // end of getServletInfo() method
--- a/src/org/openbravo/erpCommon/ad_forms/FactLine.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/FactLine.java	Fri Apr 29 09:09:58 2016 +0200
@@ -1117,29 +1117,6 @@
     }
   }
 
-  /**
-   * Convert a BigDecimal to a BigDecimal with a specified number of decimal places
-   * 
-   * @param in
-   *          BigDecimal to set the precision
-   * @param precision
-   *          (Max) Number of decimal places to output Note: precision generally refers to the total
-   *          number of digits in a number, but within Openbravo it refers to the number of
-   *          significant digits after the decimal point.
-   * @return BigDecimal with specified number of significant decimal places
-   */
-  private BigDecimal toNumberWithPrecision(BigDecimal in, long precision) {
-    if (in == null) {
-      return null;
-    }
-    try {
-      return in.setScale((int) precision, RoundingMode.HALF_UP);
-    } catch (ArithmeticException e) {
-      log4jFactLine.error(e.getMessage(), e);
-      return null;
-    }
-  }
-
   public String getCurrency() {
     return m_C_Currency_ID;
   }
--- a/src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java	Fri Apr 29 09:09:58 2016 +0200
@@ -108,7 +108,6 @@
               .init(connectionProvider);
           Map<String, Object> params = bundle.getParams();
           params.put("action", "DECLINE");
-          final String beatExecutionId = new ProcessRunner(bundle).execute(connectionProvider);
         }
 
         // Deactivating the process at SystemInfo
--- a/src/org/openbravo/erpCommon/ad_reports/ReportTrialBalanceDetail.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/ad_reports/ReportTrialBalanceDetail.java	Fri Apr 29 09:09:58 2016 +0200
@@ -29,8 +29,6 @@
 import org.openbravo.base.filter.IsIDFilter;
 import org.openbravo.base.secureApp.HttpSecureAppServlet;
 import org.openbravo.base.secureApp.VariablesSecureApp;
-import org.openbravo.base.structure.BaseOBObject;
-import org.openbravo.dal.service.OBDal;
 import org.openbravo.erpCommon.businessUtility.Tree;
 import org.openbravo.erpCommon.businessUtility.WindowTabs;
 import org.openbravo.erpCommon.utility.DateTimeData;
--- a/src/org/openbravo/erpCommon/businessUtility/EMailAuthenticator.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/businessUtility/EMailAuthenticator.java	Fri Apr 29 09:09:58 2016 +0200
@@ -49,12 +49,4 @@
       return "EMailAuthenticator[" + m_pass.getUserName() + "/" + m_pass.getPassword() + "]";
   }
 
-  private String getUserName() {
-    return m_pass.getUserName();
-  }
-
-  private String getPassword() {
-    return m_pass.getPassword();
-  }
-
 }
--- a/src/org/openbravo/erpCommon/info/LocatorMultiple.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/info/LocatorMultiple.java	Fri Apr 29 09:09:58 2016 +0200
@@ -339,83 +339,6 @@
     out.close();
   }
 
-  /**
-   * Prints the response for the getRowsIds action. It returns the rowkey for the identifier column
-   * for the list of selected rows [minOffset..maxOffset]
-   * 
-   */
-  private void printGridDataSelectedRows(HttpServletResponse response, VariablesSecureApp vars,
-      String strKey, String strName, String strProductCategory, String strOrg, String strOrderCols,
-      String strOrderDirs, boolean isSoTrx) throws IOException, ServletException {
-    int minOffset = new Integer(vars.getStringParameter("minOffset")).intValue();
-    int maxOffset = new Integer(vars.getStringParameter("maxOffset")).intValue();
-    log4j.debug("Output: print page ids, minOffset: " + minOffset + ", maxOffset: " + maxOffset);
-    String type = "Hidden";
-    String title = "";
-    String description = "";
-    FieldProvider[] data = null;
-    FieldProvider[] res = null;
-    try {
-      // build sql orderBy clause
-      String strOrderBy = SelectorUtility.buildOrderByClause(strOrderCols, strOrderDirs);
-      String strPage = vars.getSessionValue("LocatorMultiple|currentPage", "0");
-      int page = Integer.valueOf(strPage);
-
-      int oldMinOffset = minOffset;
-      int oldMaxOffset = maxOffset;
-      minOffset = (page * TableSQLData.maxRowsPerGridPage) + minOffset;
-      maxOffset = (page * TableSQLData.maxRowsPerGridPage) + maxOffset;
-      log4j.debug("relativeMinOffset: " + oldMinOffset + " absoluteMinOffset: " + minOffset);
-      log4j.debug("relativeMaxOffset: " + oldMaxOffset + " absoluteMaxOffset: " + maxOffset);
-      // Filtering result
-      if (this.myPool.getRDBMS().equalsIgnoreCase("ORACLE")) {
-        String oraLimit1 = String.valueOf(maxOffset);
-        String oraLimit2 = (minOffset + 1) + " AND " + oraLimit1;
-        data = LocatorMultipleData.select(this, "ROWNUM", strKey, strName, strProductCategory,
-            (isSoTrx) ? "Y" : null,
-            Utility.getContext(this, vars, "#User_Client", "LocatorMultiple"),
-            Utility.getSelectorOrgs(this, vars, strOrg), strOrderBy, "", oraLimit1, oraLimit2);
-      } else {
-        // minOffset and maxOffset are zero based so pageSize is difference +1
-        int pageSize = maxOffset - minOffset + 1;
-        String pgLimit = pageSize + " OFFSET " + minOffset;
-        data = LocatorMultipleData.select(this, "1", strKey, strName, strProductCategory,
-            (isSoTrx) ? "Y" : null,
-            Utility.getContext(this, vars, "#User_Client", "LocatorMultiple"),
-            Utility.getSelectorOrgs(this, vars, strOrg), strOrderBy, pgLimit, "", "");
-
-      }
-
-      // result field has to be named id -> rename by copy the list
-      res = new FieldProvider[data.length];
-      for (int i = 0; i < data.length; i++) {
-        SQLReturnObject sqlReturnObject = new SQLReturnObject();
-        String resValue = "<![CDATA[" + data[i].getField("rowkey") + "]]>";
-        sqlReturnObject.setData("id", resValue);
-        res[i] = sqlReturnObject;
-      }
-    } catch (Exception e) {
-      log4j.error("Error obtaining id-list for getIdsInRange", e);
-      type = "Error";
-      title = "Error";
-      if (!e.getMessage().startsWith("<![CDATA["))
-        description = "<![CDATA[" + e.getMessage() + "]]>";
-    }
-
-    XmlDocument xmlDocument = xmlEngine.readXmlTemplate(
-        "org/openbravo/erpCommon/utility/DataGridID").createXmlDocument();
-    xmlDocument.setParameter("type", type);
-    xmlDocument.setParameter("title", title);
-    xmlDocument.setParameter("description", description);
-    xmlDocument.setData("structure1", res);
-    response.setContentType("text/xml; charset=UTF-8");
-    response.setHeader("Cache-Control", "no-cache");
-    PrintWriter out = response.getWriter();
-    log4j.debug(xmlDocument.print());
-    out.println(xmlDocument.print());
-    out.close();
-  }
-
   public String getServletInfo() {
     return "Servlet that presents the multiple locators seeker";
   } // end of getServletInfo() method
--- a/src/org/openbravo/erpCommon/modules/VersionUtility.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/modules/VersionUtility.java	Fri Apr 29 09:09:58 2016 +0200
@@ -54,20 +54,16 @@
     String name;
     String availableMinVer;
     String availableMaxVer;
-    String type;
     HashMap<String, Ver> versions;
   }
 
   private static class Ver {
-    String verId;
     String version;
     HashMap<String, Dep> dependencies;
     HashMap<String, Dep> includes;
   }
 
   private static class Dep {
-    String depId;
-    String version;
     String minVer;
     String maxVer;
     String modId;
@@ -325,7 +321,6 @@
         Mod mod = new Mod();
         mod.modId = data[i].adModuleId;
         mod.name = data[i].name;
-        mod.type = data[i].type;
         mod.versions = fillVersions(data[i], mod, "Y".equals(data[i].installed));
         modules.put(data[i].adModuleId, mod);
       }
@@ -384,7 +379,6 @@
     HashMap<String, Dep> hashDep = new HashMap<String, Dep>();
     for (int i = 0; i < data.length; i++) {
       Dep dep = new Dep();
-      dep.depId = data[i].adModuleDependencyId;
       dep.minVer = data[i].startversion;
       dep.maxVer = data[i].endversion;
       dep.modId = data[i].adDependentModuleId;
@@ -566,7 +560,6 @@
     for (int i = 0; i < modules.length; i++) {
       Mod mod = mods.get(modules[i].getModuleID());
       Ver ver = new Ver();
-      ver.verId = modules[i].getModuleVersionID();
       ver.version = modules[i].getVersionNo();
       if (mod.availableMinVer == null || versionCompare(ver.version, mod.availableMinVer) == -1) {
         mod.availableMinVer = ver.version;
--- a/src/org/openbravo/erpCommon/security/SessionLogin.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/security/SessionLogin.java	Fri Apr 29 09:09:58 2016 +0200
@@ -11,7 +11,7 @@
  * under the License. 
  * The Original Code is Openbravo ERP. 
  * The Initial Developer of the Original Code is Openbravo SLU 
- * All portions are Copyright (C) 2001-2014 Openbravo SLU 
+ * All portions are Copyright (C) 2001-2016 Openbravo SLU 
  * All Rights Reserved. 
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -203,10 +203,6 @@
     return ((this.org == null) ? "" : this.org);
   }
 
-  private void setIsActive(String newValue) {
-    this.isactive = (newValue == null) ? "Y" : newValue;
-  }
-
   private boolean getIsActive() {
     return (this.isactive.equals("Y"));
   }
@@ -243,10 +239,6 @@
     return ((this.remoteHost == null) ? "" : this.remoteHost);
   }
 
-  private void setProcessed(String newValue) {
-    this.processed = (newValue == null) ? "" : newValue;
-  }
-
   private boolean getProcessed() {
     return ((this.processed == null) ? false : this.processed.equals("Y"));
   }
--- a/src/org/openbravo/erpCommon/utility/Alert.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/utility/Alert.java	Fri Apr 29 09:09:58 2016 +0200
@@ -11,7 +11,7 @@
  * under the License. 
  * The Original Code is Openbravo ERP. 
  * The Initial Developer of the Original Code is Openbravo SLU 
- * All portions are Copyright (C) 2008-2010 Openbravo SLU 
+ * All portions are Copyright (C) 2008-2016 Openbravo SLU 
  * All Rights Reserved. 
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -29,8 +29,6 @@
   private String referencekeyId = "0";
 
   private static Logger log4j = Logger.getLogger(Alert.class);
-  private static final char DATA_DRIVEN = 'D';
-  private static final char EXTERNAL = 'E';
 
   public Alert() {
     this(0);
--- a/src/org/openbravo/erpCommon/utility/ComboTableData.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/utility/ComboTableData.java	Fri Apr 29 09:09:58 2016 +0200
@@ -427,21 +427,6 @@
   }
 
   /**
-   * Adds a new parameter to the select section of the query.
-   * 
-   * @param _parameter
-   *          String with the parameter.
-   * @param _fieldName
-   *          String with the name of the field.
-   */
-  private void addSelectParameter(String _parameter, String _fieldName) {
-    if (this.paramSelect == null)
-      this.paramSelect = new Vector<QueryParameterStructure>();
-    QueryParameterStructure aux = new QueryParameterStructure(_parameter, _fieldName, "SELECT");
-    paramSelect.addElement(aux);
-  }
-
-  /**
    * Gets all the defined parameters for the select section.
    * 
    * @return Vector with the parameters.
@@ -628,15 +613,6 @@
   }
 
   /**
-   * Getter for the table alias index.
-   * 
-   * @return Integer with the index.
-   */
-  private int getIndex() {
-    return this.index;
-  }
-
-  /**
    * Main method to build the query.
    * 
    * @throws Exception
--- a/src/org/openbravo/erpCommon/utility/OBPrintStream.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/erpCommon/utility/OBPrintStream.java	Fri Apr 29 09:09:58 2016 +0200
@@ -40,7 +40,6 @@
   private PrintStream psout;
   public static final int TEXT_HTML = 1;
   public static final int TEXT_PLAIN = 2;
-  private File logFile;
   private PrintWriter logWriter;
 
   /**
@@ -69,7 +68,6 @@
   }
 
   public void setLogFile(File f) {
-    logFile = f;
     try {
       logWriter = new PrintWriter(f);
 
--- a/src/org/openbravo/financial/ResetAccounting.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/financial/ResetAccounting.java	Fri Apr 29 09:09:58 2016 +0200
@@ -251,7 +251,6 @@
       updateBalanced.setString("tableId", tableId);
       updateBalanced.setParameterList("transactions", transactions);
       updateBalanced.setString("clientId", client);
-      int balancedUpdated = updateBalanced.executeUpdate();
       Table table = OBDal.getInstance().get(Table.class, tableId);
       if (!table.isView()) {
         tableName = table.getDBTableName();
--- a/src/org/openbravo/service/system/ModuleValidator.java	Thu Apr 28 12:54:39 2016 +0200
+++ b/src/org/openbravo/service/system/ModuleValidator.java	Fri Apr 29 09:09:58 2016 +0200
@@ -24,10 +24,7 @@
 import java.util.List;
 
 import org.hibernate.criterion.Restrictions;
-import org.openbravo.base.model.Entity;
-import org.openbravo.base.model.ModelProvider;
 import org.openbravo.base.model.NamingUtil;
-import org.openbravo.base.model.Property;
 import org.openbravo.base.session.OBPropertiesProvider;
 import org.openbravo.base.structure.BaseOBObject;
 import org.openbravo.dal.service.OBCriteria;
@@ -173,55 +170,6 @@
     }
   }
 
-  // checks https://issues.openbravo.com/view.php?id=7905
-  // Add to validation: module artifacts shouldn't use id's in the range of 100.000-799.999 as these
-  // are used for old customizations
-  private void checkHasIllegalId(Module module, SystemValidationResult result) {
-    for (Entity entity : ModelProvider.getInstance().getModel()) {
-      Property moduleProperty = null;
-      for (Property property : entity.getProperties()) {
-        if (property.getTargetEntity() != null && property.getTargetEntity() == module.getEntity()) {
-          moduleProperty = property;
-          break;
-        }
-      }
-      // check the artifacts pointing to a module
-      if (moduleProperty != null) {
-        final OBCriteria<BaseOBObject> obCriteria = OBDal.getInstance().createCriteria(
-            entity.getName());
-        obCriteria.setFilterOnActive(false);
-        obCriteria.setFilterOnReadableClients(false);
-        obCriteria.setFilterOnReadableOrganization(false);
-        obCriteria.add(Restrictions.eq(moduleProperty.getName(), module));
-        for (BaseOBObject baseOBObject : obCriteria.list()) {
-          checkIllegalId(baseOBObject, result, module);
-        }
-      }
-    }
-  }
-
-  private void checkIllegalId(BaseOBObject baseOBObject, SystemValidationResult result,
-      Module module) {
-    final String id = (String) baseOBObject.getId();
-    if (id.compareTo("100000") > 0 && id.compareTo("799999") < 0 && id.length() == 6) {
-      result.addError(SystemValidationType.CUSTOMIZATION_ID, "Module " + module.getName()
-          + " has an artifact (" + baseOBObject
-          + ") with an id in the customization range 100000 to 799999. This is not allowed.");
-    }
-
-    // also check the children
-    for (Property property : baseOBObject.getEntity().getProperties()) {
-      if (property.isOneToMany() && property.isChild()) {
-        @SuppressWarnings("unchecked")
-        final List<BaseOBObject> children = (List<BaseOBObject>) baseOBObject.get(property
-            .getName());
-        for (BaseOBObject child : children) {
-          checkIllegalId(child, result, module);
-        }
-      }
-    }
-  }
-
   private <T extends BaseOBObject> boolean hasArtifact(Class<T> clz, Module module) {
     final OBCriteria<T> obc = OBDal.getInstance().createCriteria(clz);
     obc.add(Restrictions.eq("module", module));