Mon, 21 May 2018 10:50:06 +0200related to issue 38520: disable the warning temporarily to make CI stable
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 21 May 2018 10:50:06 +0200] rev 33993
related to issue 38520: disable the warning temporarily to make CI stable

Fri, 18 May 2018 13:37:54 +0200fixes issue 38520: Deprecate OBDal.registerSQLFunction
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 18 May 2018 13:37:54 +0200] rev 33992
fixes issue 38520: Deprecate OBDal.registerSQLFunction

Thu, 17 May 2018 09:19:04 +0200[registersql] Expose the SQL functions map in the API instead of the controller
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 17 May 2018 09:19:04 +0200] rev 33991
[registersql] Expose the SQL functions map in the API instead of the controller

Wed, 16 May 2018 18:55:35 +0200[registersql] Fix registry failure in Oracle
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 May 2018 18:55:35 +0200] rev 33990
[registersql] Fix registry failure in Oracle

APRMSQLFunctionRegister can not use DAL to check whether the functions to be registered exist, because DAL layer is not initialized yet. Therefore, we should use sqlc instead

Wed, 16 May 2018 14:21:12 +0200[registersql] Log warn with stack trace when using deprecated method
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 May 2018 14:21:12 +0200] rev 33989
[registersql] Log warn with stack trace when using deprecated method

Wed, 16 May 2018 13:38:39 +0200[registersql] Minor code improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 May 2018 13:38:39 +0200] rev 33988
[registersql] Minor code improvements

Wed, 16 May 2018 11:21:43 +0200[registersql] Add missing method javadoc
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 May 2018 11:21:43 +0200] rev 33987
[registersql] Add missing method javadoc

Wed, 16 May 2018 11:15:04 +0200[registersql] Use StandardBasicTypes to provide the SQL function type
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 May 2018 11:15:04 +0200] rev 33986
[registersql] Use StandardBasicTypes to provide the SQL function type

Wed, 16 May 2018 10:37:12 +0200[registersql] Add comment
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 May 2018 10:37:12 +0200] rev 33985
[registersql] Add comment

Wed, 16 May 2018 10:34:38 +0200[registersql] Test infrastructure improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 May 2018 10:34:38 +0200] rev 33984
[registersql] Test infrastructure improvements

Allow to define a custom DalSessionFactoryController for the DAL Layer initialization per test case. This way it is possible to register the set of SQL functions in Hibernate that each test requires

Tue, 15 May 2018 08:35:48 +0200[registersql] Fix compilation error
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 15 May 2018 08:35:48 +0200] rev 33983
[registersql] Fix compilation error

Fix compilation error by adding the location for the WeldUtils class in the compilation performed by the compile.apply.module task

Mon, 14 May 2018 17:03:33 +0200[registersql] Adapt changes for the test infrastructure
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 May 2018 17:03:33 +0200] rev 33982
[registersql] Adapt changes for the test infrastructure

Mon, 14 May 2018 12:24:41 +0200[registersql] Deprecate OBDal.registerSQLFunction
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 May 2018 12:24:41 +0200] rev 33981
[registersql] Deprecate OBDal.registerSQLFunction

Mon, 14 May 2018 12:22:30 +0200[registersql] Replace OBDal.registerSQLFunction usage
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 May 2018 12:22:30 +0200] rev 33980
[registersql] Replace OBDal.registerSQLFunction usage

Mon, 14 May 2018 11:54:17 +0200[registersql] Fix compilation error
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 May 2018 11:54:17 +0200] rev 33979
[registersql] Fix compilation error

Allow to use WeldUtils in DalLayerInitializer class by including the WeldUtils path on the compilation performed in ant.generate.entities task

Mon, 14 May 2018 09:07:29 +0200[registersql] Provide new mechanism to register SQL functions in Hibernate
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 May 2018 09:07:29 +0200] rev 33978
[registersql] Provide new mechanism to register SQL functions in Hibernate

Fri, 18 May 2018 13:36:23 +0200related to issue 38518: improve javadoc
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 18 May 2018 13:36:23 +0200] rev 33977
related to issue 38518: improve javadoc

Fri, 18 May 2018 12:42:38 +0200fixes issue 38518: Compile subreports with HttpSecureAppServlet.renderJR
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 18 May 2018 12:42:38 +0200] rev 33976
fixes issue 38518: Compile subreports with HttpSecureAppServlet.renderJR

It has been deprecate the ability of specifying to the reporting API if the sub-reports should be compiled or not. Instead the API is smart enough to find the subreports (if any) and compile them. Besides, note that this subreport search will be performed just once per report, because the compilation results are cached since[1].

With this change, reports generated both with HttpSecureAppServlet and BaseReportActionHandler will compile the subreports in a transparent way, i.e., without the need of explicitly specifying it.


[1] https://issues.openbravo.com/view.php?id=37741

Thu, 17 May 2018 19:30:38 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 17 May 2018 19:30:38 +0000] rev 33975
CI: merge back from main

Thu, 17 May 2018 19:16:40 +0000CI: update AD_MODULE to version 33972
RM packaging bot <staff.rm@openbravo.com> [Thu, 17 May 2018 19:16:40 +0000] rev 33974
CI: update AD_MODULE to version 33972

Thu, 17 May 2018 18:44:14 +0200related to issue 38548: added test case
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 17 May 2018 18:44:14 +0200] rev 33973
related to issue 38548: added test case

Thu, 17 May 2018 17:22:21 +0200fixed bug 38567: can get stuck forever sending emails
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 17 May 2018 17:22:21 +0200] rev 33972
fixed bug 38567: can get stuck forever sending emails

Added a fixed 10 minutes timeout for communications with smtp servers, this
same timeout is applied to connection creation as well as reading responses
from server. Note it is not applied to writing operations.

Thu, 17 May 2018 13:14:16 +0200Related to issue 38307: Remove unused prices in TestCostingLandedCost.java
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 17 May 2018 13:14:16 +0200] rev 33971
Related to issue 38307: Remove unused prices in TestCostingLandedCost.java

Wed, 16 May 2018 18:30:19 +0200Fixes issue 38307: Wrong NSC when trx has no unit cost adjustments
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 16 May 2018 18:30:19 +0200] rev 33970
Fixes issue 38307: Wrong NSC when trx has no unit cost adjustments

When calculating the trxPrice we should take into account every adjustment amount (unit cost or not unit cost), but negative stock corrections.

Thu, 17 May 2018 10:28:43 +0200related to issue 38548: minor code improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 17 May 2018 10:28:43 +0200] rev 33969
related to issue 38548: minor code improvements

Using the correct alternative when applies:
- Use isEmpty() to check whether the collection is empty or not
- Use diamond operator
- Iterate over the "entrySet" instead of the "keySet"

Thu, 17 May 2018 10:05:57 +0200fixes issue 38548: Default Expression in Selector Field does not work properly
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 17 May 2018 10:05:57 +0200] rev 33968
fixes issue 38548: Default Expression in Selector Field does not work properly

After the changes introduced with[1] the request data is send to the SelectorDefaultFilterActionHandler as part of the POST payload rather than in the query string. This caused that the selector id was not being found in that handler, avoiding the correct processing of the data.

The problem has been fixed by retrieving the data to process both from the request parameters and content.

[1] https://code.openbravo.com/erp/devel/pi/rev/2a79f597da83870d152ee3176ffa679a01ac19d5

Wed, 16 May 2018 17:16:05 +0530Fixes Issue 0038558: Cannot add an orphan line in Return
Atul Gaware <atul.gaware@openbravo.com> [Wed, 16 May 2018 17:16:05 +0530] rev 33967
Fixes Issue 0038558: Cannot add an orphan line in Return
From Customer window if the role does not have access to
Product window

Use setAdminMode prior to access product object in
insert RM orphan line process.

Wed, 16 May 2018 23:01:26 +0530Fixes Issue 0038557:Cannot select an orphan line in Return Material
Atul Gaware <atul.gaware@openbravo.com> [Wed, 16 May 2018 23:01:26 +0530] rev 33966
Fixes Issue 0038557:Cannot select an orphan line in Return Material
Receipt if product has Alternate UOM defined

While inserting orphan line when uom management is enable, set
return qty as operative qty and uom as operative uom

Wed, 16 May 2018 11:13:21 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 16 May 2018 11:13:21 +0000] rev 33965
CI: merge back from main

Wed, 16 May 2018 10:59:19 +0000CI: update AD_MODULE to version 33963
RM packaging bot <staff.rm@openbravo.com> [Wed, 16 May 2018 10:59:19 +0000] rev 33964
CI: update AD_MODULE to version 33963

Wed, 16 May 2018 08:54:42 +0200fixes issue 38555: JS Error after opening a window under some circumstances
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 May 2018 08:54:42 +0200] rev 33963
fixes issue 38555: JS Error after opening a window under some circumstances

When opening a window having the lazy filtering enabled, the funnel icon is hidden automatically. But when opening a window with some particular configuration it is possible to reach the code that hides the funnel icon without having it initialized yet. In this case a JS error was thrown avoiding the correct loading of the window.

To fix the problem we just check whether the funnel icon has been initialized before trying to hide it.

Tue, 15 May 2018 18:32:09 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 15 May 2018 18:32:09 +0000] rev 33962
CI: merge back from main

Tue, 15 May 2018 18:18:15 +0000CI: update AD_MODULE to version 33960
RM packaging bot <staff.rm@openbravo.com> [Tue, 15 May 2018 18:18:15 +0000] rev 33961
CI: update AD_MODULE to version 33960

Tue, 15 May 2018 15:33:25 +0530Related to issue 38386: Same search key can be used twice in
Atul Gaware <atul.gaware@openbravo.com> [Tue, 15 May 2018 15:33:25 +0530] rev 33960
Related to issue 38386: Same search key can be used twice in
warehouse definition

A build validation to check whether there exists a warehouse
with same value within client to avoid failure of build
when adding a unique constraint for client and value in
m_warehouse table.

Tue, 01 May 2018 18:01:20 -0400Fixes issue 38386: Same search key can be used twice in warehouse definition
Armaignac <collazoandy4@gmail.com> [Tue, 01 May 2018 18:01:20 -0400] rev 33959
Fixes issue 38386: Same search key can be used twice in warehouse definition

The same Search Key in warehouse and storage bin can be used twice because a missing
constraint

An unique constraints was added to warehouse definition.

Mon, 14 May 2018 19:29:02 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 14 May 2018 19:29:02 +0000] rev 33958
CI: merge back from main

Mon, 14 May 2018 19:15:03 +0000CI: update AD_MODULE to version 33954
RM packaging bot <staff.rm@openbravo.com> [Mon, 14 May 2018 19:15:03 +0000] rev 33957
CI: update AD_MODULE to version 33954

Mon, 14 May 2018 18:21:41 +0200Related to issue 38521: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 14 May 2018 18:21:41 +0200] rev 33956
Related to issue 38521: Code review improvements

Mon, 14 May 2018 18:13:00 +0530Fixes Issue 38521: Operative quantity in goods shipment line
Atul Gaware <atul.gaware@openbravo.com> [Mon, 14 May 2018 18:13:00 +0530] rev 33955
Fixes Issue 38521: Operative quantity in goods shipment line
field gets overridden when using Create Lines From
functionality

Modifying AUM qty as per on hand qty in product selector
to be done only when receipt/shipment line is not linked
with order line

Mon, 14 May 2018 17:18:34 +0200Related to bug 38422: Characteristic desc. selector not working with filter.
Javier Armendáriz <javier.armendariz@openbravo.com> [Mon, 14 May 2018 17:18:34 +0200] rev 33954
Related to bug 38422: Characteristic desc. selector not working with filter.

Adding null check and applied formatter.

Mon, 14 May 2018 10:58:55 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 14 May 2018 10:58:55 +0000] rev 33953
CI: merge back from main

Mon, 14 May 2018 10:44:59 +0000CI: update AD_MODULE to version 33951
RM packaging bot <staff.rm@openbravo.com> [Mon, 14 May 2018 10:44:59 +0000] rev 33952
CI: update AD_MODULE to version 33951

Mon, 14 May 2018 08:50:07 +0200related to issue 38518: use diamond operator
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 May 2018 08:50:07 +0200] rev 33951
related to issue 38518: use diamond operator

Fri, 11 May 2018 15:30:31 +0200related to issue 38518: use renderJR to compile the subreport
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 11 May 2018 15:30:31 +0200] rev 33950
related to issue 38518: use renderJR to compile the subreport

Refactored the report generation to demonstrate how renderJR method can be used to compile the sub-reports.

Fri, 11 May 2018 15:03:03 +0200fixes issue 38518: Ability of compiling subreports with HttpSecureAppServlet.renderJR
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 11 May 2018 15:03:03 +0200] rev 33949
fixes issue 38518: Ability of compiling subreports with HttpSecureAppServlet.renderJR

Fri, 11 May 2018 00:45:46 +0530Fixes Issue 0038490: Empty error message is shown when processing a
Atul Gaware <atul.gaware@openbravo.com> [Fri, 11 May 2018 00:45:46 +0530] rev 33948
Fixes Issue 0038490: Empty error message is shown when processing a
stock reservation without available stock and without attribute set
value

Use COALESCE(TO_CHAR(cur_not_available.attributeName), '') to avoid null
value in the description of attribute set instance with id 0

Tue, 08 May 2018 22:32:12 +0530Fixes Issue 0038487:"Suspense balancing" account used when
Atul Gaware <atul.gaware@openbravo.com> [Tue, 08 May 2018 22:32:12 +0530] rev 33947
Fixes Issue 0038487:"Suspense balancing" account used when
invoice's total is zero and prepayment exists

Prepayment Amount and Different amount should be posted to
respective customer / vendor prepayment and receivable/payable
accounts when there is difference in between invoice grossamt
(grandtotal) and prepayment amount. Prior to this solution it
was done only when grossamt is greater than prepayment amt.

Fri, 11 May 2018 10:13:35 +0200Related to issue 36280: Remove SL_Payment_Amounts_data.xsql
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 11 May 2018 10:13:35 +0200] rev 33946
Related to issue 36280: Remove SL_Payment_Amounts_data.xsql

Wed, 02 May 2018 23:46:36 +0530Fixes Issue 36280:Several unused + probably unusable callouts exists and are
Atul Gaware <atul.gaware@openbravo.com> [Wed, 02 May 2018 23:46:36 +0530] rev 33945
Fixes Issue 36280:Several unused + probably unusable callouts exists and are
candidates to be deleted.

** All the below callouts are not used in internal and external class and
has a low risk to remove them.
** Removed java files for SE_Years_For_Calendar, SE_Calendar_For_Org and
registers in ad_callout.
** Removed java files for SL_Payment_No_Verify, SL_MovementAll_Locator,
SL_Payment_DocType & data xsql file, SL_Payment_Amounts,
SL_WorkRequirement_Sequence & xsql file, SL_Invoice_Tax,
SL_InOutLine_Locator & data xsql file.

Mon, 07 May 2018 18:21:59 -0400Fixes issue 38469:Wrong Total Movement Quantity and Stock Valuation resulting in
Armaignac <collazoandy4@gmail.com> [Mon, 07 May 2018 18:21:59 -0400] rev 33944
Fixes issue 38469:Wrong Total Movement Quantity and Stock Valuation resulting in
wrong average cost if Costing Rule 'Fix Backdated From' is empty

Thu, 10 May 2018 16:03:18 +0200Fixed issue 38517: Test fails sometimes when translation pack is installed.
Javier Armendáriz <javier.armendariz@openbravo.com> [Thu, 10 May 2018 16:03:18 +0200] rev 33943
Fixed issue 38517: Test fails sometimes when translation pack is installed.

Requesting the first language retrieved by OBDal with no criteria or order may
return a language that is already installed. This leads to an exception as the
FormTrl object was already created when saving Form and there cannot be 2 form
translations with the same associated Form ID and language.

Wed, 09 May 2018 17:18:45 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 09 May 2018 17:18:45 +0000] rev 33942
CI: merge back from main

Wed, 09 May 2018 17:04:26 +0000CI: update AD_MODULE to version 33940
RM packaging bot <staff.rm@openbravo.com> [Wed, 09 May 2018 17:04:26 +0000] rev 33941
CI: update AD_MODULE to version 33940

Wed, 09 May 2018 13:30:44 +0200Related to issue 38459: Use currency standard precision instead of costing precision
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 09 May 2018 13:30:44 +0200] rev 33940
Related to issue 38459: Use currency standard precision instead of costing precision

Wed, 09 May 2018 12:25:30 +0200Related to issue 38459: Update copyright
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 09 May 2018 12:25:30 +0200] rev 33939
Related to issue 38459: Update copyright

Fri, 04 May 2018 10:13:22 -0400Fixes issue 38459:Total Stock Valuation should be rounded to 2 in Costing tab
Armaignac <collazoandy4@gmail.com> [Fri, 04 May 2018 10:13:22 -0400] rev 33938
Fixes issue 38459:Total Stock Valuation should be rounded to 2 in Costing tab
as it is the sum of the cost of the transactions

The Total Stock Valuation is now rounded to currency cost precision

Wed, 09 May 2018 10:46:34 +0200Related to issue 38422: Characteristic desc. selector not working with filter.
Javier Armendáriz <javier.armendariz@openbravo.com> [Wed, 09 May 2018 10:46:34 +0200] rev 33937
Related to issue 38422: Characteristic desc. selector not working with filter.

Adding filtering by ProductWithCharacteristicValue when no filter is applied in
the parent grid. This makes the characteristics selector behavior coherent with
the rest of selectors: if no filtering is performed, shows only the
characteristics present in the grid entries instead of all available values,
same as if we were filtering.

Wed, 09 May 2018 05:00:42 +0000Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 09 May 2018 05:00:42 +0000] rev 33936
Merge back from main

Wed, 09 May 2018 04:45:48 +0000Merge temporary head for 3.0PR18Q2
RM packaging bot <staff.rm@openbravo.com> [Wed, 09 May 2018 04:45:48 +0000] rev 33935
Merge temporary head for 3.0PR18Q2

Tue, 08 May 2018 09:30:19 +0000Added signature for changeset dc2ef98dc38f
RM packaging bot <staff.rm@openbravo.com> [Tue, 08 May 2018 09:30:19 +0000] rev 33934
Added signature for changeset dc2ef98dc38f

Tue, 08 May 2018 09:30:19 +0000Added tag 3.0PR18Q2 for changeset 307b23f7635f
RM packaging bot <staff.rm@openbravo.com> [Tue, 08 May 2018 09:30:19 +0000] rev 33933
Added tag 3.0PR18Q2 for changeset 307b23f7635f

Tue, 08 May 2018 09:30:18 +0000Update AD_MODULE version to 3.0PR18Q2 3.0PR18Q2
RM packaging bot <staff.rm@openbravo.com> [Tue, 08 May 2018 09:30:18 +0000] rev 33932
Update AD_MODULE version to 3.0PR18Q2

Tue, 08 May 2018 08:56:25 +0200fixes 38499: raise minimum required ant version to 1.9.2
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 08 May 2018 08:56:25 +0200] rev 33931
fixes 38499: raise minimum required ant version to 1.9.2

Check on init task current version is at least 1.9.2

Thu, 26 Apr 2018 07:46:08 +0200fixes 38449: compilation warnings in src-core + buildvalidations with JDK10
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Apr 2018 07:46:08 +0200] rev 33930
fixes 38449: compilation warnings in src-core + buildvalidations with JDK10

JDK version validation is now performed directly in ant without need of executing
and build validation (note checking only if it is 6 as before core was only compiled
with 6, so it would have failed anyway if running with an older one).

This allows to compile core and build validations with the same JDK as the rest.

Wed, 25 Apr 2018 16:14:22 +0200related to issue 38451: apply the logic on "Download All" also
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 25 Apr 2018 16:14:22 +0200] rev 33929
related to issue 38451: apply the logic on "Download All" also

Wed, 25 Apr 2018 15:50:10 +0200fixes bug 38451: Remove temp file's directory used to download the attachment
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 25 Apr 2018 15:50:10 +0200] rev 33928
fixes bug 38451: Remove temp file's directory used to download the attachment

Now the AttachImplementationManager deletes also the temp file's directory used to download the attachment. This change only affects to those attach implementations which return the downloaded attachment inside a temporary file.

With this change now that attach implementations are able generate those temporary files with any name by creating them inside folders with random names. This is intended to avoid concurrency problems in case two users download the same attachment at the same time.

Thu, 19 Apr 2018 12:09:11 +0200fixes 38408: error message activating heartbeat in PG10
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 19 Apr 2018 12:09:11 +0200] rev 33927
fixes 38408: error message activating heartbeat in PG10

Starting from PostgreSQL 10, server version string includes also package, being
a longer String it doesn't fit current column size.

Fixed by getting just the first word of the version (which is the actual server
version) skipping the rest that refers to the package.

Examples:

9.3.21 -> 9.3.21
10.3 (Ubuntu 10.3-1.pgdg16.04+1) -> 10.3
11devel (Debian 11~~devel~20180418.2231-1~573.git5372c2c.pgdg90+1) -> 11devel

Thu, 12 Apr 2018 17:04:43 +0200fixes issue 38358: Unused connection pool created on module installation
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 12 Apr 2018 17:04:43 +0200] rev 33926
fixes issue 38358: Unused connection pool created on module installation

Thu, 12 Apr 2018 16:28:17 +0200fixes issue 38346: Restart tomcat 8.0 through MMC using JDK9 is not working
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 12 Apr 2018 16:28:17 +0200] rev 33925
fixes issue 38346: Restart tomcat 8.0 through MMC using JDK9 is not working

The "tomcat.restart.do" task used to restart tomcat from MMC is starting tomcat with the -Djava.endorsed.dirs= system property setting. The endorsed feature is no longer supported with Java 9[1] and we are not making use of it with previous JDKs. For this reason we are directly removing it.

[1] https://docs.oracle.com/javase/9/migrate/toc.htm#JSMIG-GUID-8E83E51A-88A3-4E9A-8E2A-66E1D66A966C

Wed, 11 Apr 2018 13:08:31 +0200Fixes issue 38331: Fix 18Q2 conversion rate in sampledata
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 11 Apr 2018 13:08:31 +0200] rev 33924
Fixes issue 38331: Fix 18Q2 conversion rate in sampledata

Mon, 07 May 2018 11:27:06 -0400Related to issue 38316: Removed unused xsql file.
Armaignac <collazoandy4@gmail.com> [Mon, 07 May 2018 11:27:06 -0400] rev 33923
Related to issue 38316: Removed unused xsql file.

The OrgTree_data xsql file is not used at all after the OrgTreeData.select removal

Tue, 08 May 2018 08:56:25 +0200fixes 38500: raise minimum required ant version to 1.9.2
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 08 May 2018 08:56:25 +0200] rev 33922
fixes 38500: raise minimum required ant version to 1.9.2

Check on init task current version is at least 1.9.2

Fri, 04 May 2018 11:31:32 +0530Fixes Issue 38375: Attribute selector in Task Window has problems
Atul Gaware <atul.gaware@openbravo.com> [Fri, 04 May 2018 11:31:32 +0530] rev 33921
Fixes Issue 38375: Attribute selector in Task Window has problems
with Role with limited access

Set Admin mode to include piece of code which
accesses AttributeSet objects.

Mon, 30 Apr 2018 14:07:14 +0200Fixed bug 38422: Characteristic description selector not working with filter.
Javier Armendáriz <javier.armendariz@openbravo.com> [Mon, 30 Apr 2018 14:07:14 +0200] rev 33920
Fixed bug 38422: Characteristic description selector not working with filter.

Product characteristics filter assumes the parentGridEntity is always a Product,
but for the Add Product dialog, it is a ProductWithCharacteristics entity. In this
case it is needed to add a reference to a Product instance to make filtering
work as expected.

Fri, 04 May 2018 09:13:06 +0200Related to Issue 38205, 38206. Code Review changes
David Miguelez <david.miguelez@openbravo.com> [Fri, 04 May 2018 09:13:06 +0200] rev 33919
Related to Issue 38205, 38206. Code Review changes

* Removed new variable and methods in tests API

Fri, 04 May 2018 09:09:56 +0200Related to Issue 38205, 38206. Code Review changes
David Miguelez <david.miguelez@openbravo.com> [Fri, 04 May 2018 09:09:56 +0200] rev 33918
Related to Issue 38205, 38206. Code Review changes

* Extracted query into different method
* Use proper API for tests assertions
* Added missing brackets in if-else clauses

Wed, 25 Apr 2018 21:37:01 -0400Fixes issue 38206: Cost Adjustment Process generates too much lines
Armaignac <collazoandy4@gmail.com> [Wed, 25 Apr 2018 21:37:01 -0400] rev 33917
Fixes issue 38206: Cost Adjustment Process generates too much lines

When adjusting a product used as Raw Material in a Production the same
m_transaction can be added several times in different cost adjustment lines.

Now when exists a non processed cost adjustment line for the same transaccion,
currency, accounting date and source the adjusted amount is added instance of
create a new adjustment line.

Thu, 12 Apr 2018 11:27:33 -0400Related to issue 38205: Cost Adjustment Process very slow
Armaignac <collazoandy4@gmail.com> [Thu, 12 Apr 2018 11:27:33 -0400] rev 33916
Related to issue 38205: Cost Adjustment Process very slow

A Cost Adjustment on an environment with 16k transactions and adjusting 11.5k
takes almost 10h to complete.

A refactor was made in order to improve the performance in the Cost Adjustment process
* Removed unnecessary flush
* Changed ScrollableResults to query
* Code refactor

Thu, 12 Apr 2018 10:29:51 -0400Fixes issue 38205: Cost Adjustment Process very slow
Armaignac <collazoandy4@gmail.com> [Thu, 12 Apr 2018 10:29:51 -0400] rev 33915
Fixes issue 38205: Cost Adjustment Process very slow

A Cost Adjustment on an environment with 16k transactions and adjusting 11.5k
takes almost 10h to complete.

This patch does changes in following core files reducing the time to 2.5h:

AverageCostAdjustment:
- Logger using wrong class.
- Remove not needed save() from updated objects.
CostAdjustmentProcess:
- Remove not needed save() from updated objects.
generateTransactionCosts():
-- Do the flush() only once at the end.
-- Evict the trx object on each iteration as it is not modified. Or instead of loading the full trx change to a query retrieving only the required properties.
-- Even better change the method to use a unique insert statement.

CostAdjustementUtils:
- getNewLineNo() method consumes too much time when many lines are added on a single adjustment.
-- Change order and get first by a get max(line) -> when there is no index on the order column it performs better.
-- Add a new insertCostAdjustmentLine() with a lineNo parameter so it is not required to call the getNewLineNo() method.

CostingAlgorithmAdjustmentImp:
- Add new field nextLineNo to store last LineNo used to use new API in CostAdjustmentUtils and avoid the query to get the max lineno.

Mon, 30 Apr 2018 08:23:08 -0400Fixes issue 38316:Warehouse in context (session) is different from the warehouse
Armaignac <collazoandy4@gmail.com> [Mon, 30 Apr 2018 08:23:08 -0400] rev 33914
Fixes issue 38316:Warehouse in context (session) is different from the warehouse
on the login in some circumstances, could affect tax selection

Under some circumstances the warehouse in the session is different from the warehouse
on the login that could affect tax selection

Now in case there does not exist any warehouse defined for the specific organization
one is selected from the organization natural tree

Thu, 03 May 2018 10:58:06 +0200Fixed issue 38350: Unmark in development modules in production instances
Javier Armendáriz <javier.armendariz@openbravo.com> [Thu, 03 May 2018 10:58:06 +0200] rev 33913
Fixed issue 38350: Unmark in development modules in production instances

Thu, 03 May 2018 10:51:18 +0200[ndmp] Minor code improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 03 May 2018 10:51:18 +0200] rev 33912
[ndmp] Minor code improvements

Thu, 03 May 2018 10:35:59 +0200[ndmp] Code review fixes.
Javier Armendáriz <javier.armendariz@openbravo.com> [Thu, 03 May 2018 10:35:59 +0200] rev 33911
[ndmp] Code review fixes.

- Fixed java file formatting.

Wed, 02 May 2018 17:46:47 +0200[ndmp] Code review fixes.
Javier Armendáriz <javier.armendariz@openbravo.com> [Wed, 02 May 2018 17:46:47 +0200] rev 33910
[ndmp] Code review fixes.

- Improved comment in trigger
- Added a failsafe action in ActiveInstanceProcess when ADCS is not available
(ant activate.instance)

Wed, 02 May 2018 10:55:43 +0200[ndmp] Code review fixes.
Javier Armendáriz <javier.armendariz@openbravo.com> [Wed, 02 May 2018 10:55:43 +0200] rev 33909
[ndmp] Code review fixes.

- Changed error message
- Java format fixes
- Change public API method names
- Checking if there are modules as "In Development" in the initializer
- Moving initializer logic to KernelApplicationInitializer

Mon, 23 Apr 2018 10:56:11 +0200[ndmp] Merge with pi
Javier Armendáriz <javier.armendariz@openbravo.com> [Mon, 23 Apr 2018 10:56:11 +0200] rev 33908
[ndmp] Merge with pi

Fri, 20 Apr 2018 12:56:41 +0200[ndmp] Simplified ADCS logic
Javier Armendáriz <javier.armendariz@openbravo.com> [Fri, 20 Apr 2018 12:56:41 +0200] rev 33907
[ndmp] Simplified ADCS logic

Fri, 20 Apr 2018 09:03:56 +0200[ndmp] Fixed trigger for Oracle
Javier Armendáriz <javier.armendariz@openbravo.com> [Fri, 20 Apr 2018 09:03:56 +0200] rev 33906
[ndmp] Fixed trigger for Oracle

Thu, 19 Apr 2018 11:24:48 +0200[ndmp] Moved logic to ADCS and merged trigger with an existing one
Javier Armendáriz <javier.armendariz@openbravo.com> [Thu, 19 Apr 2018 11:24:48 +0200] rev 33905
[ndmp] Moved logic to ADCS and merged trigger with an existing one

Wed, 18 Apr 2018 17:44:22 +0200[ndmp] InstancePurpose process requires to receive the purpose as parameter.
Javier Armendáriz <javier.armendariz@openbravo.com> [Wed, 18 Apr 2018 17:44:22 +0200] rev 33904
[ndmp] InstancePurpose process requires to receive the purpose as parameter.

Wed, 18 Apr 2018 16:46:15 +0200[ndmp] Refactored repeated code
Javier Armendáriz <javier.armendariz@openbravo.com> [Wed, 18 Apr 2018 16:46:15 +0200] rev 33903
[ndmp] Refactored repeated code

Wed, 18 Apr 2018 10:54:39 +0200[ndmp] Created an initializer that checks purpose and modules at initialization
Javier Armendáriz <javier.armendariz@openbravo.com> [Wed, 18 Apr 2018 10:54:39 +0200] rev 33902
[ndmp] Created an initializer that checks purpose and modules at initialization

Tue, 17 Apr 2018 17:12:19 +0200[ndmp] Created a trigger that ensures modules cannot be set as in development.
Javier Armendáriz <javier.armendariz@openbravo.com> [Tue, 17 Apr 2018 17:12:19 +0200] rev 33901
[ndmp] Created a trigger that ensures modules cannot be set as in development.

Tue, 17 Apr 2018 09:36:06 +0200[ndmp] merge with pi
Javier Armendáriz <javier.armendariz@openbravo.com> [Tue, 17 Apr 2018 09:36:06 +0200] rev 33900
[ndmp] merge with pi

Mon, 16 Apr 2018 12:47:04 +0200[ndmp] Removing development flag in modules when registering for production.
Javier Armendáriz <javier.armendariz@openbravo.com> [Mon, 16 Apr 2018 12:47:04 +0200] rev 33899
[ndmp] Removing development flag in modules when registering for production.

Fri, 27 Apr 2018 19:14:34 -0400Fixes issue 38302:Tax tab info is not correctly recalculated when negative child
Armaignac <collazoandy4@gmail.com> [Fri, 27 Apr 2018 19:14:34 -0400] rev 33898
Fixes issue 38302:Tax tab info is not correctly recalculated when negative child
tax defined as "cascade" is modified

When an orderlinetax is removed and the line order it's not take into account
the triggers calculations can be incorrect.

Now the orderlinetax are removed in the proper order (lineno asc) to avoid
wrong calculations in the triggers.

Wed, 02 May 2018 09:55:08 +0200Related to issue 33650: updated modulescript version limit
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 02 May 2018 09:55:08 +0200] rev 33897
Related to issue 33650: updated modulescript version limit

Fri, 27 Apr 2018 12:20:39 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 27 Apr 2018 12:20:39 +0200] rev 33896
Related to issue 33650: code review improvements
Improvements in JUnit tests:
Avoid duplication of code
Remove useless javadoc or comments
Reorganize methods
Remove useless log
Improve asserts
Renamed some classes
Reduced classes and methods visibility where possible

Fri, 27 Apr 2018 10:59:04 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 27 Apr 2018 10:59:04 +0200] rev 33895
Related to issue 33650: code review improvements
Updated sampledata for QA Testing client

Fri, 27 Apr 2018 10:55:13 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 27 Apr 2018 10:55:13 +0200] rev 33894
Related to issue 33650: code review improvements
Properly format modulescript
Removed info message in module script
Increased limits
Ensure we don't work with * org and any organization where the persist org is already available

Fri, 27 Apr 2018 09:59:55 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 27 Apr 2018 09:59:55 +0200] rev 33893
Related to issue 33650: code review improvements
Renamed field group to Inherited Information
Reordered fields

Fri, 27 Apr 2018 09:51:48 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 27 Apr 2018 09:51:48 +0200] rev 33892
Related to issue 33650: code review improvements
Improved functions documentation and comments

Thu, 26 Apr 2018 16:25:58 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 26 Apr 2018 16:25:58 +0200] rev 33891
Related to issue 33650: code review improvements
Removed new reference Organization Selector for Persist Information and use instead existing Organization Simple Selector

Fri, 27 Apr 2018 07:58:20 +0530Related to issue 33650:Make use of persist org info column
Atul Gaware <atul.gaware@openbravo.com> [Fri, 27 Apr 2018 07:58:20 +0530] rev 33890
Related to issue 33650:Make use of persist org info column

Use ad_inheritedcalendar_id

Thu, 26 Apr 2018 22:17:42 +0530Related to issue 33650:Sample data updated with persist org info
Atul Gaware <atul.gaware@openbravo.com> [Thu, 26 Apr 2018 22:17:42 +0530] rev 33889
Related to issue 33650:Sample data updated with persist org info

Existing organization are updated with persist org info as part
of sample data.

Thu, 26 Apr 2018 22:49:57 +0530Related to issue 33650:Added junit test cases for persist org info task
Atul Gaware <atul.gaware@openbravo.com> [Thu, 26 Apr 2018 22:49:57 +0530] rev 33888
Related to issue 33650:Added junit test cases for persist org info task

** Added junit tests to verify persist info data in organization
for corner case orgs (*, null, org that does not exists)
** Added junit tests which creates a complex org tree, sets org as ready
with cascade Yes and No option and verifies persist org info.
** Added junit tests which create single org, two orgs one under another,
sets org as ready with cascade = Yes, Cascade = No option.

Thu, 26 Apr 2018 23:45:59 +0530Related to issue 33650:Modulescript to set persist org info
Atul Gaware <atul.gaware@openbravo.com> [Thu, 26 Apr 2018 23:45:59 +0530] rev 33887
Related to issue 33650:Modulescript to set persist org info

** Added Modulescript to populate AD_Org persist info columns
** Variables are used to get persist org info and then sent
to update method to avoid trigger mutating error in orcl
instance

Thu, 26 Apr 2018 18:54:30 +0530Fixes Issue 33650:Add columns in AD_Org table to persist data in order
Atul Gaware <atul.gaware@openbravo.com> [Thu, 26 Apr 2018 18:54:30 +0530] rev 33886
Fixes Issue 33650:Add columns in AD_Org table to persist data in order
to improve performance

** Add columns to store calendar owner org, period control allowed org,
legal entity org, business unit org and calendar of the period
control allowed org of the organization, Add field group and ready only
fields in organization window tab to show persist org information.
Field group is collapse by default.
** Added new function AD_ORG_GETCALENDAROWNERTN and
AD_ORG_GETPERIODCONTROLALLOWTN, AD_GET_ORG_LE_BU_TREENODE
from the original one with performance issues notes in it to only use
when organization are not set ready else use persist info from AD_Org
directly.
** Refactor AD_ORG_GETCALENDAROWNER, AD_ORG_GETPERIODCONTROLALLOW and
AD_GET_ORG_LE_BU to make use of respective new columns to use
AD_CALENDAROWNER_ORG_ID, AD_PERIODCONTROLALLOWED_ORG_ID,
AD_LEGALENTITY_ORG_ID or AD_BUSINESSUNIT_ORG_ID from AD_ORG directly.
** Modified AD_ORG_READY to set persist info columns in AD_ORG.
** To avoid triggers mutating error in oracle instance, instead of
calling directly functions to get persist org info in
update query, variables are used to get persist org info from ad_org
and then ad_org is updated.
** Modified AD_GET_ORG_LE_BU_TREENODE, remove condition
v_org_header_id<>'0' from while clause in p_type='BU' block.

Mon, 23 Apr 2018 09:17:37 +0200Related to Issue 38288. Code review changes
David Miguelez <david.miguelez@openbravo.com> [Mon, 23 Apr 2018 09:17:37 +0200] rev 33885
Related to Issue 38288. Code review changes

* Moved validation of Payment Plan before performing any logic
* Changed logic to retrieve messages, it now usses API from OBMessageUtils

Tue, 10 Apr 2018 17:12:31 -0400Fixes issue 38288: Sales Invoice Payment Plan Due date can be modified when
Armaignac <collazoandy4@gmail.com> [Tue, 10 Apr 2018 17:12:31 -0400] rev 33884
Fixes issue 38288: Sales Invoice Payment Plan Due date can be modified when
related payment is in Remitted status

Remittances only accept documents with due date prior to their expected date,
the due date of a payment plan can be increased because the process doesn't
properly check the that condition

A new hook is created to check the edited payment schedule lines and avoid validation
issues

Fri, 27 Apr 2018 09:53:25 +0200Related to issue 38437: Scheduled process launches one time more than expected.
Javier Armendáriz <javier.armendariz@openbravo.com> [Fri, 27 Apr 2018 09:53:25 +0200] rev 33883
Related to issue 38437: Scheduled process launches one time more than expected.

Improved description and help text to make fields intention clearer.

Thu, 26 Apr 2018 13:41:32 +0200fixes 38299: Heartbeat config popup points to 2.50 user manual
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Apr 2018 13:41:32 +0200] rev 33882
fixes 38299: Heartbeat config popup points to 2.50 user manual

Thu, 26 Apr 2018 10:44:10 +0200issue 37500. removed ad_module/ad_module_install version_id columns
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Apr 2018 10:44:10 +0200] rev 33881
issue 37500. removed ad_module/ad_module_install version_id columns

As they are no longer populated

Thu, 26 Apr 2018 10:27:38 +0200issue 37500. Removed ad_heartbeat_log.code_revision column
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Apr 2018 10:27:38 +0200] rev 33880
issue 37500. Removed ad_heartbeat_log.code_revision column

Sun, 08 Apr 2018 18:47:05 +0200Fixed 37500. Remove calling hg id during build.
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 08 Apr 2018 18:47:05 +0200] rev 33879
Fixed 37500. Remove calling hg id during build.

Final user of hg.id value is package.core task writing the value to
config/instance.revision inside the created obx file.
However only user of that file was the src/build.xml code writing it into
ad_module.version_id. That code is remove din earlier commit of this issue.

So with this commit present nobody will read that file.
Assuming package.core is used to create obx file to be used with older
version not having that change this should still be fine as the code
had a code-path used when the file was missing anyway.

With that last user gone finally delete calling "hg id" call and related code:
- checking for .hg
- calling hg id
- ant properties, is.hg, hg.id, code.revision

Note: There is another call of "hg id -n" present in package.core but that one
is unrelated and as only called when running that specific ant target does not
have any global performance impacts.

Sun, 08 Apr 2018 18:37:51 +0200Issue 37500. Remove ad_system_info.code_revision column completely.
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 08 Apr 2018 18:37:51 +0200] rev 33878
Issue 37500. Remove ad_system_info.code_revision column completely.

As the column is now completely unused delete it from database and
ad_column & ad_field (was shown only in System information window)

Sun, 08 Apr 2018 18:29:43 +0200Issue 37500. Stop updating ad_system_info.code_revision field during builds
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 08 Apr 2018 18:29:43 +0200] rev 33877
Issue 37500. Stop updating ad_system_info.code_revision field during builds

Stop touching that field which is going to be deleted during create.database
and update.database which where both updating it.

Apart stop passing code.revision ant variable to export.database task which
was already not using it.

Sun, 08 Apr 2018 18:05:16 +0200Issue 37500. Remove setting ad_module.version_id for module 0 during compile.
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 08 Apr 2018 18:05:16 +0200] rev 33876
Issue 37500. Remove setting ad_module.version_id for module 0 during compile.

src/build.xml had code to update that field during compilation. As part of that
removal stop updating that field.

That allows to delete quite a chunk of src/build.xml as it had 3 ways of getting
the info:
- indirectly from hg id ran via "init" of main build.xml
- from file config/instance.revision (set from rm,ci or package.core)
- ' - ' if none of first 2 was possible

Sun, 08 Apr 2018 17:50:45 +0200Issue 37500. Stop sending ad_module.version_id of module 0 in heartbeat
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 08 Apr 2018 17:50:45 +0200] rev 33875
Issue 37500. Stop sending ad_module.version_id of module 0 in heartbeat

That is is not useful as only tracking core revision (and not any modules).
As part of its removal stop sending the field in data of heartbeat.

Butler code (HeartbeatServlet.java) is using getStringParameter and setting
value for dal insert into ad_heartbeat. But as that column is nullable should
be fine to push this pi change without change to butler code.

This change also stops calling setCodeRevision for the local insert into
ad_heartbeat_log. That column is mandatory but has a default value of '0'
so should work unmodified.

Sun, 08 Apr 2018 17:25:09 +0200Issue 37500. Remove public businessUtility.Heartbeat_data.xsql file
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 08 Apr 2018 17:25:09 +0200] rev 33874
Issue 37500. Remove public businessUtility.Heartbeat_data.xsql file

That file only had single xsql method used from ad_process.HeartbeatProcess.
Move that xsql method to already existing (non-public) SystemInfo_data.xsql
file in that other java package (and slim down to the 2 fields required).

That allows removal of the Heartbeat_data.xsql file.
Checking all public modules via getAllModules did not show any users in
modules.