Related with issue 34823: Improve comments
authorInigo Sanchez <inigo.sanchez@openbravo.com>
Fri, 30 Dec 2016 10:43:15 +0100
changeset 31055 261174abcf4c
parent 31054 987dedc02635
child 31056 7f58c9165bf6
Related with issue 34823: Improve comments
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
src/org/openbravo/dal/security/EntityAccessChecker.java
--- a/src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java	Fri Dec 30 04:46:16 2016 +0000
+++ b/src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java	Fri Dec 30 10:43:15 2016 +0100
@@ -404,8 +404,8 @@
       // Moving a tree node : https://issues.openbravo.com/view.php?id=32833
       testCases.add(new Object[] { type, DataSource.AccountTreeMovement, accessForAdminOnly });
 
-      // Testing a problem detected in how permissions for the entities of the complex selectors are
-      // calculated. See regression issue https://issues.openbravo.com/view.php?id=34823
+      // Testing a problem detected in how permissions for the entities of the selectors with Search
+      // parent reference are calculated. See issue https://issues.openbravo.com/view.php?id=34823
       testCases.add(new Object[] { type, DataSource.ProductStockView,
           accessForAdminAndSystemAndEmployee });
     }
--- a/src/org/openbravo/dal/security/EntityAccessChecker.java	Fri Dec 30 04:46:16 2016 +0000
+++ b/src/org/openbravo/dal/security/EntityAccessChecker.java	Fri Dec 30 10:43:15 2016 +0100
@@ -235,7 +235,7 @@
           }
         }
 
-        // and take into account entities of complex defined selectors
+        // and take into account entities of the selectors with Search parent reference
         final String selectorsOfSearchReference = "select distinct(s.table.id) from OBUISEL_Selector s "
             + "left join s.reference r left join r.aDColumnReferenceSearchKeyList c "
             + "where r.parentReference='" + SEARCH_REFERENCE + "' and c.table.id in " + inTables;