Thu, 02 Mar 2017 09:22:31 +0100fixes issue 35398: Check readable clients for child properties using DAL WS
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 02 Mar 2017 09:22:31 +0100] rev 31448
fixes issue 35398: Check readable clients for child properties using DAL WS

Fix for issue #29683 was introducing a security check to avoid showing child properties which belong to a client different from the current client. But this fix was preventing to display some readable objects like master data defined at system level (client 0).

Therefore this security check has been improved and now it is verified if the child property is defined for a client which is readable for the current role.

Tue, 28 Feb 2017 08:00:23 +0100Fixed issue 35373. Reenable automatic discounts in purchase flows.
Antonio Moreno <antonio.moreno@openbravo.com> [Tue, 28 Feb 2017 08:00:23 +0100] rev 31447
Fixed issue 35373. Reenable automatic discounts in purchase flows.

Tue, 28 Feb 2017 08:00:11 +0100Fixed issue 35373. Reenable automatic discounts in purchase flows.
Antonio Moreno <antonio.moreno@openbravo.com> [Tue, 28 Feb 2017 08:00:11 +0100] rev 31446
Fixed issue 35373. Reenable automatic discounts in purchase flows.

Mon, 27 Feb 2017 10:46:35 +0100Fixed issue 35349:Callout problem when working with comma as decimal separator
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 27 Feb 2017 10:46:35 +0100] rev 31445
Fixed issue 35349:Callout problem when working with comma as decimal separator

The problem was raised when a default format were switched, it means, when
decimal and group separator were switched. In this situation, when
SimpleCalloutInformationProvider class was used to obtain the current element
value and this current element was a BigDecimal, the format was not managed
properly. This occurred because getCurrentElementValue method always retrieved
a String element instead of Object element, in tyhis case BigDecimal.

In this situation, managesUpdatedValuesForCallout method of FIC class compare
if element is a String or not. If a BigDecimal is retrieved as String element,
in this part of the code the format is not managed properly when decimal separator
is comma. The code manage the comma separator as group separator and removed it.

When the decimal separator is dot (.) the format is managed as expected although
this method retrieves a String object (e.g. "1.23"). When decimal separator is
comma (,) this BigDecimal (e.g. 1,24) is retrieved by getCurrentElementValue method
as String value and the format is missed.

This problem has been fixed by take into account type of current element inside
getCurrentElementValue method. Now this method retrieves an object value. In this
case, a BigDecimal is retrieved. Now the format is managed properly.

Tue, 21 Feb 2017 14:16:33 +0100fixes issue 35318: documents were not being attached after send them by e-mail
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 21 Feb 2017 14:16:33 +0100] rev 31444
fixes issue 35318: documents were not being attached after send them by e-mail

The CoreAttachImplementation class is deleting the original report file after completing the upload process. When attaching a document using the e-mail pop-up this is done before attaching the document into the e-mail. This explains why the document was not being received on the e-mail.

To avoid this problem, now a copy of the original document is sent to the AttachImplementationManager, this way the original file will never be deleted by an upload process handler.

Together with this, now when attaching a document after printing (not by e-mail) we have to delete the original file because in other case it will be kept on disk.

Thu, 16 Feb 2017 11:42:21 -0500Fixes issue 35276: General Ledger filter changes with pagination in JE Report
Armaignac <collazoandy4@gmail.com> [Thu, 16 Feb 2017 11:42:21 -0500] rev 31443
Fixes issue 35276: General Ledger filter changes with pagination in JE Report

Selected General Ledger filter value changes when pagination is executed in the
Journal Entries report

The General Ledger filter is not kept in the session to make use in the pagination.
For the solution, was saved the General Ledger Filter in the session every time
the search is executed (FIND action). By default, if there is any GL in the
session, the GL field will use the defaulted for the selected org. When paginating
always is used the account schema id stored in the session.

Wed, 15 Feb 2017 19:43:11 -0500Fix for issue 35273: General Ledger filter removed when paginating in GL Report
Armaignac <collazoandy4@gmail.com> [Wed, 15 Feb 2017 19:43:11 -0500] rev 31442
Fix for issue 35273: General Ledger filter removed when paginating in GL Report

The General Ledger filter was removed when paginating in General Ledger Report
in HTML view

Now the General Ledger filter it's save in the session by the FIND action and get in the DEFAULT action
for showing in the report page

Fri, 27 Jan 2017 14:38:19 +0100related to bug 35060: prevent double execution in DefaultJsonDataService
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 27 Jan 2017 14:38:19 +0100] rev 31441
related to bug 35060: prevent double execution in DefaultJsonDataService

Fri, 27 Jan 2017 11:03:47 +0100related to bug 35060: updated tests cases to use new API
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 27 Jan 2017 11:03:47 +0100] rev 31440
related to bug 35060: updated tests cases to use new API

Fri, 27 Jan 2017 11:02:07 +0100fixed bug 35060: Observers are executed twice on commitAndClose
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 27 Jan 2017 11:02:07 +0100] rev 31439
fixed bug 35060: Observers are executed twice on commitAndClose

DAL observes got executed twice on commitAndClose because session.isDirty check
was causing them to be called.

Now, session dirtiness shouldn't be checked using directly session.isDirty method
but through the new OBDal.isSessionDirty, which allows OBInterceptor to know if
session is being checked so that it can prevent observes execution.