Mon, 19 Sep 2016 11:14:46 +0200Related to issue 33989: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 19 Sep 2016 11:14:46 +0200] rev 30552
Related to issue 33989: Code review improvements

- Avoid setting admin mode in getOrgLedgerRecursive() and getClientLedger() methods as it is already done in getOrgLedger() method in OBLedgerUtils class.
- Retrieve first, general ledger of login organization in LoginUtils class. If no result is retrieved, we will retrieve general ledger of rest of context organizations.

Wed, 14 Sep 2016 13:39:12 +0200Fixed issue 33989. Removed slow query getting Organization Ledger.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Wed, 14 Sep 2016 13:39:12 +0200] rev 30551
Fixed issue 33989. Removed slow query getting Organization Ledger.

The method to get the default General Ledget was using a query that filtered
and sorted the results using ad_isorgincluded procedure. In case of having a
large number of organizations this query was slow.

The method is now using the OrganizationStructureProvider to get the parent
organization List of the required org to search the default General Ledger.

Thu, 15 Sep 2016 12:14:10 -0400Fixes issue 33838: Correct Stock Reservation when created from a closed order
Mark <markmm82@gmail.com> [Thu, 15 Sep 2016 12:14:10 -0400] rev 30550
Fixes issue 33838: Correct Stock Reservation when created from a closed order

When voiding a shipment related to a reserved order, if order is closed, new reservation will not be created (in case order was fully shipped) and existing reservation will not be updated (in case order was partially shipped).
Besides, when closing an order, related reservation will be also closed.

Thu, 15 Sep 2016 14:04:47 +0200Related to issue 33879: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 15 Sep 2016 14:04:47 +0200] rev 30549
Related to issue 33879: Code review improvements

Tue, 13 Sep 2016 11:43:16 -0400Fixes issue 33879: Avoid error when closing reservation from Stock Reservation
Mark <markmm82@gmail.com> [Tue, 13 Sep 2016 11:43:16 -0400] rev 30548
Fixes issue 33879: Avoid error when closing reservation from Stock Reservation

Avoided exception when the quantity of reservation stock lines have null value.
When the ManageReservationActionHandler processed the stock reservation it stores the realesed quantity with ZERO value instead of null.

Tue, 13 Sep 2016 18:24:02 +0200Related to issue 24191: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 13 Sep 2016 18:24:02 +0200] rev 30547
Related to issue 24191: Code review improvements

- Move AcctSchemaStructureProvider.java to same folder as OrganizationStructureProvider.java.
- Rename acctSchemaSP variable to acctSchemaProvider in OBContext.java.
- Remove unused data variable in AcctSchema.java.
- Add commentary to explain why we send limit manually to xsql query in AcctServer.java.
- Do not send numberRegisters parameter to AcctServerData.select as we are already sending the limit.
- Undo changes in AcctServerData.periodOpen method and create new AcctServerData.selectPeriodOpen method to avoid a functional API change.

Thu, 08 Sep 2016 16:36:16 +0200Fixes Issue 24191. Improves performance for Accounting Background Process.
David Miguelez <david.miguelez@openbravo.com> [Thu, 08 Sep 2016 16:36:16 +0200] rev 30546
Fixes Issue 24191. Improves performance for Accounting Background Process.

Adds Index in FIN_FINACC_TRANSACTION Table.
Modifies query in AcctServer_data to properly limit the results returned.
Modifies query in AcctServer_data to remove the order clause.
Persist information about Accounting Schemas in Java code so it is no longer
necessary to access the Database everytime to retrive that information.

Wed, 14 Sep 2016 15:36:20 +0530Fixes issue 33859: Wrong Total Gross Amount in orders and invoices
Atul Gaware <atul.gaware@openbravo.com> [Wed, 14 Sep 2016 15:36:20 +0530] rev 30545
Fixes issue 33859: Wrong Total Gross Amount in orders and invoices

Wrong Total Gross Amount in orders and invoices as the changes made in tax tab records do not recalculate it.

For Purchase Order and Sales Order, Tax tab is made read only so only record are created, modified and deleted only through order lines.
Manual insertion, updation and deletion is not possible.

In case of Sales Invoice and Purchase Invoices, records created by invoice line are marked with recalculate flag = Yes.
Read Only logic based on this flag does not allow user to modify fields tax, tax amount and taxable amount of invoice tax records.
Event handler restricts user to delete invoice tax records with recalculate flag = Yes.
To avoid event handlers interference with ReorderCascadingChildDeletionsHandler.java, on Invoice deletetion, before deleting invoice tax records, flag recalculate is set = No

Thu, 15 Sep 2016 16:56:55 +0200Merged from PI
Unai Martirena <unai.martirena@openbravo.com> [Thu, 15 Sep 2016 16:56:55 +0200] rev 30544
Merged from PI

Wed, 14 Sep 2016 13:37:45 +0200[Cancel and Replace] Add 'Enable Cancel and Replace' preference in order to activate C&R in Openbravo backend
Unai Martirena <unai.martirena@openbravo.com> [Wed, 14 Sep 2016 13:37:45 +0200] rev 30543
[Cancel and Replace] Add 'Enable Cancel and Replace' preference in order to activate C&R in Openbravo backend