Tue, 17 Jan 2017 09:45:53 +0000Update AD_MODULE version to 3.0PR16Q3.4 3.0PR16Q3.4
RM packaging bot <staff.rm@openbravo.com> [Tue, 17 Jan 2017 09:45:53 +0000] rev 31494
Update AD_MODULE version to 3.0PR16Q3.4

Wed, 11 Jan 2017 15:27:22 +0100Fixed issue 34893: The GL item section of add payment was not working fine
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 11 Jan 2017 15:27:22 +0100] rev 31493
Fixed issue 34893: The GL item section of add payment was not working fine

The grid of the G/L item section of the Add payment process was not workinf fine. The problem was that it was shown as sortable and as filterable and it must not be filterable nor sortable. This has been caused by the changeset[1]. This proyect set every column as sortable and as filterable and so was the problem.
To fix this the values of "canSort" and "canFilter" have been changed in the needed cases, which are the ones that satisfy the condition of having the canDelete property or the canAdd property set to yes and are in Pick and Execute window.
The code which handles the logic has been moved from the OBViewFieldHandler.getGridFieldProperties() to UIDefinition.getGridFieldProperties().

[1]http://code.openbravo.com/erp/devel/pi/rev/afa165be3e5900d1114d33e5106114d0e089876a

Fri, 30 Dec 2016 00:38:50 +0100Fixed issue 34830: Product selector of the Requisition subtab appears empty
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 30 Dec 2016 00:38:50 +0100] rev 31492
Fixed issue 34830: Product selector of the Requisition subtab appears empty

The problem was introduced in a refactor of checkFetchDatasourceAccess() method of
BaseDataSourceService class. This refactor change the way in wich entities of
selectors were calculated. It is important to note that the refactor is not bad in
itself. The problem was appeared because it was forgotten to do an additional thing.

Before this refactor in some cases entities were not calculated properly. For example
in the subtab of Requisition window there are a complex selector of product. (Reference:
Product Complete - Parent Reference: Search). In this example, checkFetchDatasourceAccess
method was checked Product entity instead of ProductStockView. The refactor fixed this
problem.

Otherwise, the refactor missed to take into account entities of complex defined selectors
as derivedReadableEntities. To solve the problem now, when initialize() method of
EntityAccessChecker class calculates permissions, it will take into account this entities.

Fri, 06 Jan 2017 16:40:10 -0500Related to issue 34806: Updated copyright
Mark <markmm82@gmail.com> [Fri, 06 Jan 2017 16:40:10 -0500] rev 31491
Related to issue 34806: Updated copyright

Tue, 17 Jan 2017 10:05:09 -0500Related to issue 34874: Backed out changeset a09d6ae570dd
Mark <markmm82@gmail.com> [Tue, 17 Jan 2017 10:05:09 -0500] rev 31490
Related to issue 34874: Backed out changeset a09d6ae570dd

This patch contains an incorrect definition for the partial index, and there is no need to create a multi-column index. Just one column (FIN_REV_PAYMENT_ID) would be enough

Tue, 17 Jan 2017 09:56:58 -0500Related to issue 34806: Backed out changeset 3d0a5d2000e4
Mark <markmm82@gmail.com> [Tue, 17 Jan 2017 09:56:58 -0500] rev 31489
Related to issue 34806: Backed out changeset 3d0a5d2000e4

Backed out this patch due to some code formats errors.

Fri, 13 Jan 2017 12:25:24 -0500Fixed issue 34874: Added an index in fin_payment.fin_rev_payment_id
Andy <collazoandy4@gmail.com> [Fri, 13 Jan 2017 12:25:24 -0500] rev 31488
Fixed issue 34874: Added an index in fin_payment.fin_rev_payment_id

Added an index in fin_payment.fin_rev_payment_id to improve the performance

Mon, 16 Jan 2017 13:15:25 -0500Related to issue 34345: Code review improvements
Mark <markmm82@gmail.com> [Mon, 16 Jan 2017 13:15:25 -0500] rev 31487
Related to issue 34345: Code review improvements

Some code review improvements to check the amounts are GREATER THAN (not equals)
and/or LESS THAN (not equals) the filters provided in the UI. If there is not any
amount filter defined then it is not necessary to include a "HAVING" clause to the
query.

Applied these changes to Sales and Purchase Orders reports.

Mon, 02 Jan 2017 17:15:14 -0500Fixed issue 34345:Sales Dimensional Report is not showing SO with 0 net amount
Rafael Queralta Pozo <rqueralta@nauta.cu> [Mon, 02 Jan 2017 17:15:14 -0500] rev 31486
Fixed issue 34345:Sales Dimensional Report is not showing SO with 0 net amount

Having clause was changed to show Sales Order lines with 0 line net amount

Mon, 16 Jan 2017 09:46:35 +0100Fixed issue 34950: A null check condition added
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 16 Jan 2017 09:46:35 +0100] rev 31485
Fixed issue 34950: A null check condition added


There was the following condition in ob-parameter-window-view.js "if(this.button.multiProcess)...". The problem here is that there is no a null check for the "this.button" and in the cases of opening other pick and execute window inside another one was failing because the view could not be refreshed.