Tue, 02 Feb 2016 14:11:27 +0100[Change Password] Code review applied:
Alberto Santos <alberto.santos@openbravo.com> [Tue, 02 Feb 2016 14:11:27 +0100] rev 28799
[Change Password] Code review applied:
Rename property Lastupdatepassworddate to lastPasswordUpdate.
Be consistent in naming: change expiry to expiration.
Use 'userID' instead of username in getUpdatePasswordDate function.
Check sameOldPassword in the rigth place.

Thu, 28 Jan 2016 12:40:57 +0100[ChangePassword] Solved security problem, added check to change user password
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 28 Jan 2016 12:40:57 +0100] rev 28798
[ChangePassword] Solved security problem, added check to change user password

Thu, 28 Jan 2016 10:58:07 +0100[ChangePassword] Fixed code after code review.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 28 Jan 2016 10:58:07 +0100] rev 28797
[ChangePassword] Fixed code after code review.

Username is not cleaned in case of invalid user/password.
Added check in LoginHandler to avoid security problem when changing password.
Deleted unused params in getUpdatePasswordDate method.
Login param changed to username in getUpdatePasswordDate method.
Deleted UserLock delay because has been already done (getUpdatePasswordDate and updatePassword methods).
Updated javadoc in getUpdatePasswordDate method.
Corrections in OBCriteria, using eq instead of like, using property of User PROPERTY_USERNAME.
Refactor in Dates in getUpdatePasswordDate method.
Deleted comments.
Now gets the pasword value from password field instead of user field (Both have the same content when updating the password).
Removed strange vars names like strUser and strPass.
setAdminMode and restorePreviousMode moved to updatePassword method.
Replaced vars.getLanguage() with language var where possible.
Updated javadoc in updatePassword method.
getUpdatePasswordDate method moved to DefaultAuthenticationManager and changed visibility to private.
updatePassword method moved to LoginHandler and changed visibility to private.
AuthenticationExpiryPasswordException is now a subclass of authentication exception.
Strings compared with === in js(Login.html).
Using single quotes '' for js strings.

Fri, 22 Jan 2016 12:22:19 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 22 Jan 2016 12:22:19 +0100] rev 28796
[ChangePassword] Merge with pi

Fri, 22 Jan 2016 12:16:40 +0100[ChangePassword] Fixed trigger to work with oracle
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 22 Jan 2016 12:16:40 +0100] rev 28795
[ChangePassword] Fixed trigger to work with oracle

Changed logic of trigger

Fri, 22 Jan 2016 10:19:07 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 22 Jan 2016 10:19:07 +0100] rev 28794
[ChangePassword] Merge with pi

Fri, 22 Jan 2016 09:15:57 +0100[ChangePassword] Fixed trigger to work with oracle
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 22 Jan 2016 09:15:57 +0100] rev 28793
[ChangePassword] Fixed trigger to work with oracle

Deleted return new;

Thu, 21 Jan 2016 10:56:25 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 21 Jan 2016 10:56:25 +0100] rev 28792
[ChangePassword] Merge with pi

Thu, 21 Jan 2016 10:17:24 +0100[ChangePassword] Fixed trigger to work with oracle
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 21 Jan 2016 10:17:24 +0100] rev 28791
[ChangePassword] Fixed trigger to work with oracle

Wed, 20 Jan 2016 13:38:41 +0100[ChangePassword] Solved null value in users fields, added columns from last merge
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 20 Jan 2016 13:38:41 +0100] rev 28790
[ChangePassword] Solved null value in users fields, added columns from last merge