Fixed 30050: cleanup javadoc warnings
authorStefan Hühner <stefan.huehner@openbravo.com>
Sat, 30 May 2015 19:19:54 +0200
changeset 26834 35c004afbdca
parent 26833 85e792e6b36a
child 26835 a6e31121bf79
Fixed 30050: cleanup javadoc warnings
This commit clean up all javadoc warnings as shown by eclipse or
ant generate.java.doc
Exception are 3 warnings inside CSSMinimizer.java which is external code
and will should be fixed differently (upstream)

Most fixes are:
- Deleting useless java doc tags (useless as not documenting anything)
- Fixing up paramater references and link target
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/ReorderCascadingChildDeletionsHandler.java
modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOBUtils.java
modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/LinkToParentTreeDatasourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
src/org/openbravo/base/secureApp/LoginUtils.java
src/org/openbravo/base/secureApp/OrgTree.java
src/org/openbravo/base/session/HostNameTask.java
src/org/openbravo/configuration/ConfigureOption.java
src/org/openbravo/costing/CostAdjustmentProcess.java
src/org/openbravo/erpCommon/ad_forms/About.java
src/org/openbravo/erpCommon/ad_forms/AcctServer.java
src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
src/org/openbravo/erpCommon/ad_forms/Registration.java
src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java
src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
src/org/openbravo/erpCommon/businessUtility/AuditTrailDeletedRecords.java
src/org/openbravo/erpCommon/businessUtility/COAUtility.java
src/org/openbravo/erpCommon/modules/ImportModule.java
src/org/openbravo/erpCommon/modules/ModuleTree.java
src/org/openbravo/erpCommon/modules/ModuleUtiltiy.java
src/org/openbravo/erpCommon/obps/ActivationKey.java
src/org/openbravo/erpCommon/utility/ComboTableData.java
src/org/openbravo/erpCommon/utility/UsedByLink.java
src/org/openbravo/erpCommon/utility/Utility.java
src/org/openbravo/erpCommon/utility/poc/EmailManager.java
src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
src/org/openbravo/scheduling/OBScheduler.java
--- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.java	Sat May 30 19:19:54 2015 +0200
@@ -833,8 +833,8 @@
    * 
    * @param vars
    *          VariablseSecureApp with the session data.
-   * @param selectedPaymentScheduleDetails
-   *          List of FIN_PaymentScheduleDetails that need to be included in the HashMap.
+   * @param _strSelectedScheduledPaymentDetailIds
+   *          List of id's of FIN_PaymentScheduleDetails that need to be included in the HashMap.
    * @return A HashMap mapping the FIN_PaymentScheduleDetail's Id with the corresponding amount.
    */
   private HashMap<String, BigDecimal> getSelectedPaymentDetailsAndAmount(VariablesSecureApp vars,
@@ -876,7 +876,6 @@
    *          : amount to split among the set
    * @param psdSet
    *          : set of payment schedule details where to allocate the amount
-   * @return
    */
   private HashMap<String, BigDecimal> calculateAmounts(BigDecimal recordAmount, Set<String> psdSet) {
     BigDecimal remainingAmount = recordAmount;
--- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java	Sat May 30 19:19:54 2015 +0200
@@ -329,10 +329,6 @@
 
   /**
    * Order by selectedPSDs, scheduled date and document number
-   * 
-   * @param selectedPSDs
-   * @param transactionType
-   * @return
    */
   protected StringBuffer getOrderByClause(String transactionType, List<String> selectedPSDs,
       Map<String, String> requestParameters) {
@@ -391,13 +387,6 @@
     return hqlQuery;
   }
 
-  /**
-   * @param _hqlQuery
-   * @param transactionType
-   * @param criteria
-   * @param queryNamedParameters
-   * @return
-   */
   protected String calculateHavingClause(String _hqlQuery, String transactionType,
       JSONObject criteria, Map<String, Object> queryNamedParameters) {
     String hqlQuery = _hqlQuery;
@@ -527,13 +516,6 @@
     return hqlQuery;
   }
 
-  /**
-   * @param _hqlQuery
-   * @param transactionType
-   * @param selectedPSDs
-   * @param orderByClause
-   * @return
-   */
   protected String appendOrderByClause(String _hqlQuery, StringBuffer orderByClause,
       boolean justCount) {
     String hqlQuery = _hqlQuery;
@@ -570,10 +552,6 @@
     buildCriteria.put("criteria", newCriteriaArray);
   }
 
-  /**
-   * @param expression
-   * @return
-   */
   protected String getAggregatorFunction(String expression) {
     return " hqlagg(" + expression + ")";
   }
--- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java	Sat May 30 19:19:54 2015 +0200
@@ -1276,9 +1276,6 @@
 
   /**
    * Returns the date in which last payment for this invoice took place
-   * 
-   * @param invoice
-   * @return
    */
   private static Date getFinalSettlementDate(Invoice invoice) {
     final OBCriteria<FIN_PaymentSchedInvV> obc = OBDal.getInstance().createCriteria(
@@ -1526,7 +1523,7 @@
    *          Payment Schedule Detail amount.
    * @param paymentAmount
    *          Amount selected to be collected. Always less or equal than scheduleDetailAmount.
-   * @param doubtfulDebtAmount
+   * @param doubtfulDebtTotalAmount
    *          Payment Schedule Detail doubtFulDebt amount.
    * @return resultant doubtful debt amount. Zero if no doubtful debt amount was present.
    */
--- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java	Sat May 30 19:19:54 2015 +0200
@@ -191,9 +191,6 @@
 
   /**
    * Returns the date in which last payment for this invoice took place
-   * 
-   * @param invoice
-   * @return
    */
   private static Date getFinalSettlementDate(Invoice invoice) {
     final OBCriteria<FIN_PaymentSchedInvV> obc = OBDal.getInstance().createCriteria(
--- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java	Sat May 30 19:19:54 2015 +0200
@@ -262,7 +262,7 @@
    * 
    * If the value is enclosed between brackets, it is extracted, translated and enclosed again
    * 
-   * @see DynamicExpressionParserTest
+   * There is a junit test in the class: DynamicExpressionParserTest
    * 
    * @param value
    *          A string expression like <b>'Y'</b>
--- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/event/ReorderCascadingChildDeletionsHandler.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/event/ReorderCascadingChildDeletionsHandler.java	Sat May 30 19:19:54 2015 +0200
@@ -45,7 +45,8 @@
  * following deletion fails as the record is not longer present. This class works around that by
  * explicitely deleting c_ordertax entries on delete of c_order. (Same for c_invoicetax)
  * 
- * @link https://issues.openbravo.com/view.php?id=17199
+ * {@link "https://issues.openbravo.com/view.php?id=17199"}
+ * 
  * @author shuehner
  */
 public class ReorderCascadingChildDeletionsHandler extends EntityPersistenceEventObserver {
--- a/modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOBUtils.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOBUtils.java	Sat May 30 19:19:54 2015 +0200
@@ -68,12 +68,12 @@
    * Computes the widget title using the user's language, if no translation is available then the
    * {@link WidgetClass#getWidgetTitle()} is used.
    * 
-   * @param widgetInstance
+   * @param widgetClass
    *          the widget class of this instance is used to read the title
    * @return the title of the widget read from the widgetclass
-   * @see WidgetInstance#getOBKMOWidgetClass()
+   * @see WidgetInstance#getWidgetClass()
    * @see WidgetClassTrl
-   * @see WidgetClass#getTitle()
+   * @see WidgetClass#getWidgetTitle()
    */
   static String getWidgetTitle(WidgetClass widgetClass) {
     final String userLanguageId = OBContext.getOBContext().getLanguage().getId();
--- a/modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java	Sat May 30 19:19:54 2015 +0200
@@ -318,9 +318,9 @@
    * fields. If the HQL query already contains order by fields, the new fields are appended for the
    * existing fields.
    * 
-   * @param hQL
+   * @param hql
    *          original HQL query
-   * @param sortByParametersString
+   * @param sortBy
    *          parameter that contains sortBy field values
    * @return an updated HQL query that will set the order by fields
    */
--- a/modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java	Sat May 30 19:19:54 2015 +0200
@@ -1199,9 +1199,6 @@
    * This method combines the information from the transactions list and the last element inserted
    * into grouped data into total data.
    * 
-   * @param fieldProvider
-   * @param transactionsList
-   * @param totalData
    * @throws OBException
    */
   private boolean insertIntoTotal(FieldProvider data,
@@ -1223,8 +1220,6 @@
   /**
    * This method creates a field provider with the information of the transaction
    * 
-   * @param fin_FinaccTransaction
-   * @return
    * @throws OBException
    */
   private FieldProvider createFieldProviderForTransaction(FIN_FinaccTransaction transaction,
@@ -1471,11 +1466,6 @@
 
   /**
    * This method compares the status and the order criteria of the transactions and data
-   * 
-   * @param transaction
-   * @param data
-   * @param strOrdCrit
-   * @return
    */
   private boolean isBeforeStatusAndOrder(FIN_FinaccTransaction transaction, FieldProvider data,
       String strOrdCrit, String BPName, String BPCategory, String strProject) {
@@ -1495,11 +1485,6 @@
 
   /**
    * This method compares recursively the order criteria of the transactions and data
-   * 
-   * @param transaction
-   * @param data
-   * @param strOrdCrit
-   * @return
    */
   private boolean isBeforeOrder(FIN_FinaccTransaction transaction, FieldProvider data,
       String[] strOrdCritList, int i, String BPName, String BPCategory, String strProject) {
@@ -1646,10 +1631,6 @@
   /**
    * Compares two DIFFERENT payment status. If the first one goes before the second it returns true,
    * elsewise it returns false
-   * 
-   * @param firstValue
-   * @param secondValue
-   * @return
    */
   private boolean isBeforeStatus(String firstValue, String secondValue) {
     String[] strStatus = { firstValue, secondValue };
@@ -2209,9 +2190,6 @@
 
   /**
    * Given a String of organizations this method returns an array of organizations
-   * 
-   * @param strOrgFamily
-   * @return
    */
   private Organization[] getOrganizations(Set<String> strOrgFamily) {
     Iterator<String> orgChildTreeIter = strOrgFamily.iterator();
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java	Sat May 30 19:19:54 2015 +0200
@@ -485,9 +485,6 @@
 
   /**
    * Checks if a tree is ordered
-   * 
-   * @param tree
-   * @return
    */
   private boolean isOrdered(Tree tree) {
     Table table = tree.getTable();
@@ -502,10 +499,6 @@
 
   /**
    * Returns a Tree given the referencedTableId and the parentRecordId
-   * 
-   * @param referencedTableId
-   * @param parentRecordId
-   * @return
    */
   private Tree getTree(String referencedTableId) {
     Table referencedTable = OBDal.getInstance().get(Table.class, referencedTableId);
@@ -522,10 +515,6 @@
    * Returns a Tree given the referencedTableId and a jsonobject that contains the node properties
    * This is called from the EventHandler, because the parentRecordId is not avaiable in the
    * parameters
-   * 
-   * @param referencedTableId
-   * @param parentRecordId
-   * @return
    */
   private Tree getTree(Table table, JSONObject bobProperties) {
     Tree tree = null;
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java	Sat May 30 19:19:54 2015 +0200
@@ -231,11 +231,6 @@
    * Returns a hibernate query object based on the hql query, if the justCount parameter is true,
    * the query will just return the number of records that fulfill the criteria. If justCount is
    * false, the query will return all the actual records that fulfill the criteria
-   * 
-   * @param table
-   * @param parameters
-   * @param justCount
-   * @return
    */
   private Query getQuery(Table table, Map<String, String> parameters, boolean justCount) {
     OBContext.setAdminMode(true);
@@ -561,7 +556,6 @@
    *          filter created from the grid criteria
    * @param parameters
    *          parameters used for this request
-   * @return
    */
   private String addAdditionalFilters(Table table, String hqlQuery, String filterWhereClause,
       Map<String, String> parameters) {
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/LinkToParentTreeDatasourceService.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/LinkToParentTreeDatasourceService.java	Sat May 30 19:19:54 2015 +0200
@@ -187,7 +187,6 @@
    *          hql where clase of the tab/selector
    * @param hqlWhereClauseRootNodes
    *          hql where clause that define what nodes are roots
-   * @return
    * @throws JSONException
    * @throws TooManyTreeNodesException
    *           if the number of returned nodes were to be too high
@@ -404,7 +403,6 @@
    *          bob with the node properties
    * @param hqlWhereClause
    *          where clause to be applied to the children
-   * @return
    */
   private boolean nodeHasChildren(Entity entity, Property linkToParentProperty,
       Property nodeIdProperty, BaseOBObject node, String hqlWhereClause) {
@@ -537,7 +535,6 @@
    *          id of the node to be checked
    * @param hqlWhereClause
    *          hql where clause to be applied
-   * @return
    */
   @Override
   protected boolean nodeConformsToWhereClause(TableTree tableTree, String nodeId,
@@ -639,8 +636,6 @@
   }
 
   /**
-   * @param parameters
-   * @param nodeId
    * @return returns a json object with the definition of a node give its record id
    */
   @Override
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java	Sat May 30 19:19:54 2015 +0200
@@ -685,7 +685,6 @@
    *          hqlWhereClause that defines the root nodes
    * @param tableTree
    *          tableTree that defines the tree category that defines the tree
-   * @return
    */
   private boolean isRoot(JSONObject node, String hqlTreeWhereClauseRootNodes, TableTree tableTree) {
     try {
@@ -715,7 +714,6 @@
    *          id of the node to be checked
    * @param hqlWhereClause
    *          hql where clause to be applied
-   * @return
    */
   protected abstract boolean nodeConformsToWhereClause(TableTree tableTree, String nodeId,
       String hqlWhereClause);
@@ -785,7 +783,6 @@
    *          hql where clase of the tab/selector
    * @param hqlWhereClauseRootNodes
    *          hql where clause that define what nodes are roots
-   * @return
    * @throws JSONException
    * @throws TooManyTreeNodesException
    *           if the number of returned nodes were to be too high
@@ -848,8 +845,7 @@
    *          previous values of the node, including its previous parent
    * @param prevNodeId
    * @param nextNodeId
-   *          new position of the node amont its peers
-   * @return
+   *          new position of the node amount its peers
    * @throws Exception
    */
   private String processNodeMovement(Map<String, String> parameters, JSONObject data,
--- a/modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java	Fri May 29 15:21:50 2015 +0000
+++ b/modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java	Sat May 30 19:19:54 2015 +0200
@@ -163,7 +163,8 @@
    * These include a filter clause:
    * <ul>
    * <li>for the main entity's client by the context's client.</li>
-   * <li>for the main entity's organization by an organization list see {@link #getOrgs(String)}</li>
+   * <li>for the main entity's organization by an organization list see
+   * {@link DataSourceUtils#getOrgs(String)}</li>
    * <li>with Selector's default filter expression.</li>
    * <li>for each default expression defined on the selector fields.</li>
    * <li>for each selector field in case exists a value for it on the parameters param.</li>
--- a/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java	Sat May 30 19:19:54 2015 +0200
@@ -1214,7 +1214,7 @@
    * Render a jrxml based report using a {@link ScrollableFieldProvider} as its datasource.
    * 
    * @see #renderJR(VariablesSecureApp, HttpServletResponse, String, String, String, HashMap,
-   *      JRDatasource, HashMap)
+   *      JRDataSource, Map, boolean)
    */
   protected void renderJR(VariablesSecureApp variables, HttpServletResponse response,
       String strReportName, String strFileName, String strOutputType,
--- a/src/org/openbravo/base/secureApp/LoginUtils.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/base/secureApp/LoginUtils.java	Sat May 30 19:19:54 2015 +0200
@@ -414,10 +414,7 @@
   /**
    * Validates if a selected default value is null or empty String
    * 
-   * @param strValue
-   * @param strKey
-   * @param strError
-   * @throws Exeption
+   * @throws DefaultValidationException
    * */
   private static void validateDefault(String strValue, String strKey, String strError)
       throws DefaultValidationException {
--- a/src/org/openbravo/base/secureApp/OrgTree.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/base/secureApp/OrgTree.java	Sat May 30 19:19:54 2015 +0200
@@ -303,9 +303,6 @@
 
   /**
    * Returns the node matching the id, in case it does not exists it returns null
-   * 
-   * @param id
-   * @return
    */
   private OrgTreeNode getNodeById(String id) {
     if (nodes == null)
@@ -318,9 +315,6 @@
 
   /**
    * In case the node id is in the tree it returns true, if not false.
-   * 
-   * @param id
-   * @return
    */
   private boolean isNodeInTree(String id) {
     if (nodes == null)
@@ -333,9 +327,6 @@
 
   /**
    * Returns the list of the nodes that have a determinate node.
-   * 
-   * @param parentId
-   * @return
    */
   private List<OrgTreeNode> getNodesWithParent(String parentId) {
     List<OrgTreeNode> vecNodes = new ArrayList<OrgTreeNode>();
--- a/src/org/openbravo/base/session/HostNameTask.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/base/session/HostNameTask.java	Sat May 30 19:19:54 2015 +0200
@@ -36,7 +36,7 @@
  * It can be executed by <code>ant host.name</code> command.
  * </p>
  * 
- * @See ConfigParameters.overrideProperties
+ * @see org.openbravo.base.ConfigParameters#overrideProperties
  * 
  * @author alostale
  *
--- a/src/org/openbravo/configuration/ConfigureOption.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/configuration/ConfigureOption.java	Sat May 30 19:19:54 2015 +0200
@@ -90,8 +90,6 @@
 
   /**
    * This function setChosenString() set a choose string option.
-   * 
-   * @param String
    */
   void setChosenString(String line) {
     chosenString = line;
--- a/src/org/openbravo/costing/CostAdjustmentProcess.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/costing/CostAdjustmentProcess.java	Sat May 30 19:19:54 2015 +0200
@@ -63,13 +63,12 @@
   /**
    * Method to process a cost adjustment.
    * 
-   * @param costAdj
+   * @param _costAdjustment
    *          the cost adjustment to be processed.
    * @return the message to be shown to the user properly formatted and translated to the user
    *         language.
    * @throws OBException
    *           when there is an error that prevents the cost adjustment to be processed.
-   * @throws JSONException
    */
   private JSONObject processCostAdjustment(CostAdjustment _costAdjustment) throws OBException {
     CostAdjustment costAdjustment = _costAdjustment;
--- a/src/org/openbravo/erpCommon/ad_forms/About.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/About.java	Sat May 30 19:19:54 2015 +0200
@@ -114,8 +114,6 @@
 
   /**
    * Obtains a list of all modules installed in the instance.
-   * 
-   * @return
    */
   private FieldProvider[] getInstalledModules() {
     List<HashMap<String, String>> installedModules = new ArrayList<HashMap<String, String>>();
--- a/src/org/openbravo/erpCommon/ad_forms/AcctServer.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/AcctServer.java	Sat May 30 19:19:54 2015 +0200
@@ -875,7 +875,7 @@
   /**
    * Save to Disk - set posted flag
    * 
-   * @param con
+   * @param conn
    *          connection
    * @param strUser
    *          AD_User_ID
@@ -2797,8 +2797,6 @@
   /**
    * If there is any template active for current document in any accounting schema, it returns true
    * to skip this step as getDocumentConfirmation can lock template
-   * 
-   * @return
    */
   boolean disableDocumentConfirmation() {
     C_DocType_ID = objectFieldProvider[0].getField("cDoctypeId");
--- a/src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java	Sat May 30 19:19:54 2015 +0200
@@ -334,9 +334,6 @@
   /**
    * Returns an HTML with the available notifications which can be: *Unapplied changes: rebuild
    * system *Available updates: install them
-   * 
-   * @param lang
-   * @return
    */
   private JSONObject getNotificationsJSON(String lang) {
     String updatesRebuildHTML = "";
@@ -1839,12 +1836,6 @@
   /**
    * Executes a search query in the web service and returns a HTML with the list of modules
    * retrieved from the query. This list is HTML with styles.
-   * 
-   * @param request
-   * @param response
-   * @param vars
-   * @param text
-   * @return
    */
   private String getSearchResults(HttpServletRequest request, HttpServletResponse response,
       VariablesSecureApp vars, String text) {
@@ -1939,8 +1930,6 @@
   /**
    * Returns String[] with the installed modules, this is used for perform the search in the
    * webservice and not to obtain in the list the already installed ones.
-   * 
-   * @return
    */
   private String[] getInstalledModules() {
     try {
--- a/src/org/openbravo/erpCommon/ad_forms/Registration.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/Registration.java	Sat May 30 19:19:54 2015 +0200
@@ -81,16 +81,6 @@
   /**
    * Removes the Registration pop-up from the page history so when Openbravo back arrow is pressed,
    * Registration window has no chance of being shown.
-   * 
-   * @param request
-   *          the HttpServletRequest object
-   * 
-   *          public void removeFromPageHistory(HttpServletRequest request) { final Variables
-   *          variables = new Variables(request); final String sufix =
-   *          variables.getCurrentHistoryIndex(); variables.removeSessionValue("reqHistory.servlet"
-   *          + sufix); variables.removeSessionValue("reqHistory.path" + sufix);
-   *          variables.removeSessionValue("reqHistory.command" + sufix);
-   *          variables.downCurrentHistoryIndex(); }
    */
 
   private void printPageDataSheet(HttpServletResponse response, VariablesSecureApp vars)
--- a/src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java	Sat May 30 19:19:54 2015 +0200
@@ -198,7 +198,6 @@
 
   /**
    * @return the system info as properties
-   * @throws ServletException
    */
   private Properties getSystemInfo() {
     logger.logln(logger.messageDb("HB_GATHER", ctx.getLanguage()));
@@ -208,7 +207,6 @@
   /**
    * Converts properties into a UTF-8 encoded query string.
    * 
-   * @param props
    * @return the UTF-8 encoded query string
    */
   private String createQueryStr(String beatType) {
--- a/src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java	Sat May 30 19:19:54 2015 +0200
@@ -646,7 +646,7 @@
    * 
    * @param startDate
    *          Start date.
-   * @param endDate
+   * @param _endDate
    *          End date.
    * @param isYearly
    *          Is yearly amortization.
--- a/src/org/openbravo/erpCommon/businessUtility/AuditTrailDeletedRecords.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/businessUtility/AuditTrailDeletedRecords.java	Sat May 30 19:19:54 2015 +0200
@@ -36,7 +36,7 @@
 
   /**
    * Same as
-   * {@link AuditTrailDeletedRecords#getDeletedRecords(ConnectionProvider, VariablesSecureApp, String, String, String, int, int)}
+   * {@link #getDeletedRecords(ConnectionProvider, VariablesSecureApp, String, String, String, int, int, boolean, String, String, String)}
    * without parent filtering.
    * 
    */
--- a/src/org/openbravo/erpCommon/businessUtility/COAUtility.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/businessUtility/COAUtility.java	Sat May 30 19:19:54 2015 +0200
@@ -645,7 +645,6 @@
    * @param strClientName
    * @param strAccountString
    *          Translated name of the column Account_ID
-   * @return
    */
   private OBError insertElement(String strClientName, String strAccountString) {
 
--- a/src/org/openbravo/erpCommon/modules/ImportModule.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/modules/ImportModule.java	Sat May 30 19:19:54 2015 +0200
@@ -362,9 +362,6 @@
 
   /**
    * Obtains the text to show for merged modules about the module that is merged within.
-   * 
-   * @param moduleId
-   * @return
    */
   private String getMergedWith(String moduleId) {
     boolean found = false;
@@ -1259,8 +1256,6 @@
   /**
    * Reads an ZipInputStream and returns it as a ByteArrayInputStream
    * 
-   * @param obxInputStream
-   * @return
    * @throws Exception
    */
   private ByteArrayInputStream getCurrentEntryStream(ZipInputStream obxInputStream)
@@ -1448,8 +1443,6 @@
   /**
    * Reads a ZipInputStream and returns a Vector<DynaBean> with its modules
    * 
-   * @param obxInputStream
-   * @return
    * @throws Exception
    */
   private Vector<DynaBean> getEntryDynaBeans(byte[] obxEntryBytes) throws Exception {
--- a/src/org/openbravo/erpCommon/modules/ModuleTree.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/modules/ModuleTree.java	Sat May 30 19:19:54 2015 +0200
@@ -241,9 +241,6 @@
 
   /**
    * Returns true in case one of the descendant of the current node has an update available
-   * 
-   * @param node
-   * @return
    */
   private boolean hasChildUpdate(String node) {
     try {
--- a/src/org/openbravo/erpCommon/modules/ModuleUtiltiy.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/modules/ModuleUtiltiy.java	Sat May 30 19:19:54 2015 +0200
@@ -156,8 +156,6 @@
 
   /**
    * Returns all directories and files that are part of core
-   * 
-   * @return
    */
   static List<File> getCore(String obDir) {
     List<File> core = new ArrayList<File>();
--- a/src/org/openbravo/erpCommon/obps/ActivationKey.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/obps/ActivationKey.java	Sat May 30 19:19:54 2015 +0200
@@ -1196,9 +1196,6 @@
    * Same as {@link ActivationKey#getSubscribedModules()} with the includeDisabled parameter. When
    * this parameter is true, disabled modules are returned with the DISABLED status, other way they
    * are returned with the status they would have if they were not disabled.
-   * 
-   * @param includeDisabled
-   * @return
    */
   private HashMap<String, CommercialModuleStatus> getSubscribedModules(boolean includeDisabled) {
     HashMap<String, CommercialModuleStatus> moduleList = new HashMap<String, CommercialModuleStatus>();
--- a/src/org/openbravo/erpCommon/utility/ComboTableData.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/utility/ComboTableData.java	Sat May 30 19:19:54 2015 +0200
@@ -840,8 +840,6 @@
    *          end index of the records.
    * @param conn
    *          Connection provider
-   * @param filterByValue
-   *          Keyword to be filtered
    * @return String with the query.
    */
   private String getQuery(boolean onlyId, String[] discard, String recordId, Integer startRow,
--- a/src/org/openbravo/erpCommon/utility/UsedByLink.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/utility/UsedByLink.java	Sat May 30 19:19:54 2015 +0200
@@ -423,8 +423,6 @@
 
   /**
    * Gets the linked items for the given category.
-   * 
-   * @param tableId
    */
   private SearchResult getLinkedItems(VariablesSecureApp vars, UsedByLinkData[] data,
       String strWindow, String keyColumn, String keyId, String adTabId, String adTableName,
--- a/src/org/openbravo/erpCommon/utility/Utility.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/utility/Utility.java	Sat May 30 19:19:54 2015 +0200
@@ -2277,9 +2277,6 @@
    * @param logo
    *          The name of the logo to display This can be one of the following: yourcompanylogin,
    *          youritservicelogin, yourcompanymenu, yourcompanybig or yourcompanydoc
-   * @param org
-   *          The organization id used to get the logo In the case of requesting the yourcompanydoc
-   *          logo you can indicate the organization used to request the logo.
    * @return The image requested
    */
   private static String getDefaultImageLogo(String logo) {
--- a/src/org/openbravo/erpCommon/utility/poc/EmailManager.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/utility/poc/EmailManager.java	Sat May 30 19:19:54 2015 +0200
@@ -298,7 +298,9 @@
   }
 
   /**
-   * Since Openbravo 3.0MP9 only {@link #sendEmail()} is used for the full email sending cycle
+   * Since Openbravo 3.0MP9 only
+   * {@link #sendEmail(String, boolean, String, String, String, int, String, String, String, String, String, String, String, String, List, Date, List)}
+   * is used for the full email sending cycle
    */
   @Deprecated
   private InternetAddress[] getAddressesFrom(String[] textualAddresses) {
--- a/src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java	Sat May 30 19:19:54 2015 +0200
@@ -1270,10 +1270,6 @@
 
   /**
    * @author gmauleon
-   * @param pocData
-   * @param vars
-   * @param vector
-   * @return
    */
   private String[] getHiddenTags(PocData[] pocData, Vector<Object> vector, VariablesSecureApp vars,
       HashMap<String, Boolean> checks) {
@@ -1389,8 +1385,6 @@
 
   /**
    * @author gmauleon
-   * @param content
-   * @return
    * @throws ServletException
    */
   private File prepareFile(AttachContent content, String documentId) throws ServletException {
--- a/src/org/openbravo/scheduling/OBScheduler.java	Fri May 29 15:21:50 2015 +0000
+++ b/src/org/openbravo/scheduling/OBScheduler.java	Sat May 30 19:19:54 2015 +0200
@@ -301,7 +301,6 @@
      *          The Openbravo process bundle.
      * @param jobClass
      *          The class to be executed when Job.execute is called.
-     * @return
      * @throws SchedulerException
      */
     private static JobDetail newInstance(String name, ProcessBundle bundle,
@@ -366,8 +365,6 @@
     /**
      * Loads the trigger details from AD_PROCESS_REQUEST and converts them into a schedulable Quartz
      * Trigger instance.
-     * 
-     * @return
      */
     private static Trigger newInstance(String name, ProcessBundle bundle, ConnectionProvider conn)
         throws ServletException {
@@ -571,9 +568,6 @@
      * 
      * Expected format for dates: 'dd-MM-yyyy' Expected format for times: 'HH24:MI:SS'
      * 
-     * @param date
-     * @param time
-     * @return
      * @throws ParseException
      */
     private static Calendar timestamp(String date, String time) throws ParseException {