Issue 30053. Part 1: Cleanup unnecessary serialVersionUID variables.
authorStefan Hühner <stefan.huehner@openbravo.com>
Sat, 30 May 2015 20:07:50 +0200
changeset 26839 adda5d230a5e
parent 26838 56776f691f4b
child 26840 4408556e4cb4
Issue 30053. Part 1: Cleanup unnecessary serialVersionUID variables.

Those definitions are not useful in this cases and the classes they are in
are not serializable.

So instead of special feature related to Serialization in this cases just a
local unused variable.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServiceProvider.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ModelDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/QueryBuilder.java
src/org/openbravo/base/provider/OBProviderConfigReader.java
src/org/openbravo/erpCommon/ad_forms/DocAmortizationTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocBankTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocCashTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocDPManagementTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebt.java
src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebtTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java
src/org/openbravo/erpCommon/ad_forms/DocFINBankStatementTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransactionTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
src/org/openbravo/erpCommon/ad_forms/DocFINPaymentTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
src/org/openbravo/erpCommon/ad_forms/DocFINReconciliationTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocGLJournalTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocInOutTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocInventoryTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocInvoiceTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocLCCostTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocLandedCostTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocMatchInvTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocMovementTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocOrderTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocPaymentTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocProductionTemplate.java
src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java
src/org/openbravo/service/rest/DalWebService.java
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java	Sat May 30 19:57:13 2015 +0200
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java	Sat May 30 20:07:50 2015 +0200
@@ -37,8 +37,6 @@
 public abstract class BaseDataSourceService implements DataSourceService {
   private static final Logger log = Logger.getLogger(BaseDataSourceService.class);
 
-  private static final long serialVersionUID = 1L;
-
   private String name;
   private Template template;
 
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServiceProvider.java	Sat May 30 19:57:13 2015 +0200
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServiceProvider.java	Sat May 30 20:07:50 2015 +0200
@@ -44,8 +44,6 @@
 @ApplicationScoped
 public class DataSourceServiceProvider {
 
-  private static final long serialVersionUID = 1L;
-
   private Map<String, DataSourceService> dataSources = new ConcurrentHashMap<String, DataSourceService>();
 
   @Inject
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java	Sat May 30 19:57:13 2015 +0200
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java	Sat May 30 20:07:50 2015 +0200
@@ -57,7 +57,6 @@
  * @author mtaal
  */
 public class DefaultDataSourceService extends BaseDataSourceService {
-  private static final long serialVersionUID = 1L;
   private static final Logger log4j = Logger.getLogger(DefaultDataSourceService.class);
 
   /*
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ModelDataSourceService.java	Sat May 30 19:57:13 2015 +0200
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ModelDataSourceService.java	Sat May 30 20:07:50 2015 +0200
@@ -47,7 +47,6 @@
   private static final String DATASOURCE_FIELD = "property";
   private static final String FORM_FIELD = "inpadTableId";
 
-  private static final long serialVersionUID = 1L;
   private static final Logger log = Logger.getLogger(ModelDataSourceService.class);
   private static final Property identifier = new Property();
 
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java	Sat May 30 19:57:13 2015 +0200
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java	Sat May 30 20:07:50 2015 +0200
@@ -45,8 +45,6 @@
 public abstract class ReadOnlyDataSourceService extends DefaultDataSourceService {
   private static final Logger log = Logger.getLogger(ReadOnlyDataSourceService.class);
 
-  private static final long serialVersionUID = 1L;
-
   /*
    * (non-Javadoc)
    * 
--- a/modules/org.openbravo.service.json/src/org/openbravo/service/json/QueryBuilder.java	Sat May 30 19:57:13 2015 +0200
+++ b/modules/org.openbravo.service.json/src/org/openbravo/service/json/QueryBuilder.java	Sat May 30 20:07:50 2015 +0200
@@ -58,8 +58,6 @@
 
   private static final Logger log = Logger.getLogger(QueryBuilder.class);
 
-  private static final long serialVersionUID = 1L;
-
   private Map<String, String> filterParameters = new HashMap<String, String>();
   private List<Object> typedParameters = new ArrayList<Object>();
   private Entity entity;
--- a/src/org/openbravo/base/provider/OBProviderConfigReader.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/base/provider/OBProviderConfigReader.java	Sat May 30 20:07:50 2015 +0200
@@ -39,8 +39,6 @@
 class OBProviderConfigReader {
   private static final Logger log = Logger.getLogger(OBProviderConfigReader.class);
 
-  private static final long serialVersionUID = 1L;
-
   void read(String prefix, InputStream is) {
     try {
       final SAXReader reader = new SAXReader();
--- a/src/org/openbravo/erpCommon/ad_forms/DocAmortizationTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocAmortizationTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocAmortizationTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocAmortization = Logger.getLogger(DocAmortization.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocBankTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocBankTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocBankTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocBank = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocCashTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocCashTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocCashTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocCash = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocDPManagementTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocDPManagementTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocDPManagementTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocDPManagement = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebt.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebt.java	Sat May 30 20:07:50 2015 +0200
@@ -39,7 +39,6 @@
 import org.openbravo.model.financialmgmt.payment.DoubtfulDebt;
 
 public class DocDoubtfulDebt extends AcctServer {
-  private static final long serialVersionUID = 1L;
   private String SeqNo = "0";
 
   public DocDoubtfulDebt() {
--- a/src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebtTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebtTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocDoubtfulDebtTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocAccDefPlan = Logger.getLogger(DocDoubtfulDebtTemplate.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java	Sat May 30 20:07:50 2015 +0200
@@ -47,8 +47,6 @@
 
 public class DocFINBankStatement extends AcctServer {
 
-  private static final long serialVersionUID = 1L;
-
   String SeqNo = "0";
   BigDecimal totalAmount = BigDecimal.ZERO;
 
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINBankStatementTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINBankStatementTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocFINBankStatementTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocFINReconciliation = Logger.getLogger(DocFINReconciliationTemplate.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java	Sat May 30 20:07:50 2015 +0200
@@ -71,7 +71,6 @@
   BigDecimal generatedCredit = ZERO;
   boolean exceptionPosting = false;
 
-  private static final long serialVersionUID = 1L;
   private static final Logger log4j = Logger.getLogger(DocFINFinAccTransaction.class);
 
   String SeqNo = "0";
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransactionTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransactionTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocFINFinAccTransactionTemplate {
-  private static final long serialVersionUID = 1L;
   private static final Logger log4jDocFINFinAccTransactionTemplate = Logger
       .getLogger(DocFINFinAccTransactionTemplate.class);
 
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java	Sat May 30 20:07:50 2015 +0200
@@ -59,7 +59,6 @@
 import org.openbravo.model.financialmgmt.payment.FinAccPaymentMethod;
 
 public class DocFINPayment extends AcctServer {
-  private static final long serialVersionUID = 1L;
   static Logger log4j = Logger.getLogger(DocFINPayment.class);
 
   String SeqNo = "0";
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINPaymentTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINPaymentTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocFINPaymentTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocAccDefPlan = Logger.getLogger(DocFINPayment.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java	Sat May 30 20:07:50 2015 +0200
@@ -71,7 +71,6 @@
   public static final String TRXTYPE_BPWithdrawal = "BPW";
   public static final String TRXTYPE_BankFee = "BF";
 
-  private static final long serialVersionUID = 1L;
   private static final Logger log4j = Logger.getLogger(DocFINReconciliation.class);
 
   String SeqNo = "0";
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINReconciliationTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINReconciliationTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocFINReconciliationTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocFINReconciliation = Logger.getLogger(DocFINReconciliationTemplate.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocGLJournalTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocGLJournalTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocGLJournalTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocGLJournal = Logger.getLogger(DocGLJournal.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocInOutTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInOutTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocInOutTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocInOut = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocInventoryTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInventoryTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocInventoryTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocInventory = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocInvoiceTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInvoiceTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -26,7 +26,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocInvoiceTemplate {
-  private static final long serialVersionUID = 1L;
 
   /**
    * Constructor
--- a/src/org/openbravo/erpCommon/ad_forms/DocLCCostTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocLCCostTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocLCCostTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocLCCost = Logger.getLogger(DocLCCost.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocLandedCostTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocLandedCostTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocLandedCostTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocLandedCost = Logger.getLogger(DocLandedCost.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocMatchInvTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocMatchInvTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -25,7 +25,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocMatchInvTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocMatchInv = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocMovementTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocMovementTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocMovementTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocMovement = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocOrderTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocOrderTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocOrderTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocOrder = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocPaymentTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocPaymentTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocPaymentTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocPayment = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/DocProductionTemplate.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocProductionTemplate.java	Sat May 30 20:07:50 2015 +0200
@@ -27,7 +27,6 @@
 import org.openbravo.database.ConnectionProvider;
 
 public abstract class DocProductionTemplate {
-  private static final long serialVersionUID = 1L;
   static Logger log4jDocProduction = Logger.getLogger(DocInvoice.class);
 
   /**
--- a/src/org/openbravo/erpCommon/ad_forms/TranslationManager.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/TranslationManager.java	Sat May 30 20:07:50 2015 +0200
@@ -60,7 +60,6 @@
  * 
  */
 public class TranslationManager {
-  private static final long serialVersionUID = 1L;
 
   /** XML Element Tag */
   static final String XML_TAG = "compiereTrl";
--- a/src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java	Sat May 30 20:07:50 2015 +0200
@@ -59,7 +59,6 @@
 
 public class InitialClientSetup {
   private static final Logger log4j = Logger.getLogger(InitialClientSetup.class);
-  private static final long serialVersionUID = 1L;
   private static final String NEW_LINE = "<br />\n";
   private static final String STRMESSAGEOK = "Success";
   private static final String STRMESSAGEERROR = "Error";
--- a/src/org/openbravo/service/rest/DalWebService.java	Sat May 30 19:57:13 2015 +0200
+++ b/src/org/openbravo/service/rest/DalWebService.java	Sat May 30 20:07:50 2015 +0200
@@ -71,8 +71,6 @@
 
 public class DalWebService implements WebService {
 
-  private static final long serialVersionUID = 1L;
-
   public static final String PARAMETER_WHERE = "where";
   public static final String PARAMETER_ORDERBY = "orderBy";
   public static final String PARAMETER_FIRSTRESULT = "firstResult";