Wed, 14 Nov 2018 08:52:36 +0100Merge with PI default tip
Eduardo Becerra <ebec70@yahoo.com> [Wed, 14 Nov 2018 08:52:36 +0100] rev 34969
Merge with PI

Tue, 13 Nov 2018 18:11:23 +0100Related to issue 39617: TestUtils declared as public to be used by AWO tests
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 13 Nov 2018 18:11:23 +0100] rev 34968
Related to issue 39617: TestUtils declared as public to be used by AWO tests

Mon, 12 Nov 2018 19:38:38 +0100Fixed issue 39617: Code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 12 Nov 2018 19:38:38 +0100] rev 34967
Fixed issue 39617: Code review improvements

Fixed db consistency.
Avoid useless usage of flush() and commitAndClose(). Refreshing needed objects instead.
TestUtils class declared at package level.
Refactor InvoiceGeneratorFromGoodsShipment class to improve code cleanliness.
- Pass Process Invoice as parameter
- Declare enum with the list of supported Invoice Terms
- Avoid to store hibernate objects as class variables
- Properly manage memory consumption by evicting useless objects
- Simplify exception management
- Validate order line is returned by C_Invoice_Candidate_V
- Take into account only completed invoices
- Properly calculate pending qty to invoice
- Reduce complexity in several methods
- Get the invoice document type using the standard AD_GET_DOCTYPE
HTML/XML/Java related to ProcessGoods:
- It now follows Openbravo standards (parse dates and checkbox, remove useless catch)
- Added default display logic hidden to invoice related fields

Thu, 25 Oct 2018 17:59:27 -0400Fixed issue 39617: Java doc to Invoice from Goods Shipment action handler
Nono Carballo <nonofce@gmail.com> [Thu, 25 Oct 2018 17:59:27 -0400] rev 34966
Fixed issue 39617: Java doc to Invoice from Goods Shipment action handler

Thu, 25 Oct 2018 15:40:15 -0400Fixed issue 39617: Added new features
Nono Carballo <nonofce@gmail.com> [Thu, 25 Oct 2018 15:40:15 -0400] rev 34965
Fixed issue 39617: Added new features

- Three new fields were added to "Request Process" pop up window. The fields
are only visible in Goods Shipment window if the selected document is in
draft status. The fields hold the Invoice Date, the Price List and whether
the invoice generated will be processed or not.
- The ProcessGoods process was modified to consider the new fields added.
- The success message in Process Goods process shows the document number
of the generated invoice and its status.
- Three new parameters were added to Generate Invoice from Goods Shipment
process definition. The fields hold the Invoice Date, the Price List and
whether the invoice generated will be processed or not.
- The Generate Invoice from Goods Shipment action handler was modified to
consider the new fields added.
- Code was refactored. Some classes were renamed, java documentation was
improved.
- Automated test were updated
- Two new automated test were added

Thu, 04 Oct 2018 15:59:12 -0400Fixed issue 39617: Allows Automatic Invoice from Goods Shipment
Nono Carballo <nonofce@gmail.com> [Thu, 04 Oct 2018 15:59:12 -0400] rev 34964
Fixed issue 39617: Allows Automatic Invoice from Goods Shipment

- A new field was added to "Request Process" pop up window. The field is only
visible in Goods Shipment window if the selected document is in draft status.
- A new class was created for automatically creating invoices from Goods
Shipment, considering the invoice terms of the order linked to the shipment
lines, when exists.
- The ProcessGoods process was modified to invoke the new API after complete the
document, if the field in the pop up window is checked.
- A new button was added to Goods Shipment window to allow generate invoice
from Goods Shipment. The button is only visible if the document is in status
"CO" and is not completely invoiced.
- Automated tests were created.

Tue, 13 Nov 2018 12:08:14 +0100[Reprint Invoices] Merge with PI
Eduardo Becerra <ebec70@yahoo.com> [Tue, 13 Nov 2018 12:08:14 +0100] rev 34963
[Reprint Invoices] Merge with PI

Tue, 13 Nov 2018 09:24:05 +0100fixed bug 39614: random unique constraint violation message
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 13 Nov 2018 09:24:05 +0100] rev 34962
fixed bug 39614: random unique constraint violation message

Get name to generate error message from actual element associated to the column
in the table we are looking for instead of getting it from any element with that
same name assuming it is unique.

Mon, 12 Nov 2018 13:00:12 +0100related to issue 39415 prepaymentamt is wrong calculated
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 12 Nov 2018 13:00:12 +0100] rev 34961
related to issue 39415 prepaymentamt is wrong calculated
prepayment amout is wrong calculated when two order lines
are added in to the invoice.

Wed, 07 Nov 2018 07:45:34 +0530Fixes Issue 39415:Payment Plan should not be removed
Atul Gaware <atul.gaware@openbravo.com> [Wed, 07 Nov 2018 07:45:34 +0530] rev 34960
Fixes Issue 39415:Payment Plan should not be removed
from a invoice of 0 that includes a prepaid order

** When invoice has grandtotal zero and has prepayment
linked with its associated order then consider this
criteria for creating schedule & its details for
such invoices.
** Handle divide by zero in FIN_AddPayment.java