Fri, 25 Jul 2014 10:55:58 +0200Removes nullpointerexception error from CI
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Fri, 25 Jul 2014 10:55:58 +0200] rev 24090
Removes nullpointerexception error from CI

Mon, 03 Nov 2014 12:37:29 +0100fixed bug 28045: pop up in selectors filter by starts with instead of contains
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 03 Nov 2014 12:37:29 +0100] rev 24089
fixed bug 28045: pop up in selectors filter by starts with instead of contains

Setting all selectors in ERP to filter by contains instead of starts with in order
to preserve the same behavior as in Q2, when this setting was not taken into account
list of affected selectors:

Reservation
Invoice Line Selector
Product UOM Selector
Product
Invoice Selector
Product
StorageBin Selector without warehouse
Process Run
Tab Access Selector
Portal Role Selector
Business Partner not filtered by default by customer/vendor
Orderline selector
Product Complete
Table Tree Category
Payment Selector
Element Selector
Storage Bin Selector
Process Plan Version
Business Partner with contact and location
Physical Inventory line selector
Process Request
Project
Product Multiple
Transaction
Reservation Stock Selector
Region Selector
Product
Reservation Selector
Payment Schedule
MRP_ProductionRunLineSelector
Asset Selector
Business Partner with contact and location
Currency
Receipts
ProductSimple
Organization Selector not *
Currency Selector
Financial Account
Transactions link
Financial Account Selector
GL Item selector
Business Partner
Organization
Payment Method Selector
Payment Method
Payment Selector Transaction for Parameter Window
Doctype Selector
Activity selector
Campaign selector
Sales region selector
Project Selector
Product selector
APRM_ActionDocumentSelector
Multi Business Partner Selector
Selector Field Property Selector
Model Selector

Fri, 24 Oct 2014 09:38:26 +0200Fixes issue 27957: Grid button don't get stuck after autosaving new record
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 24 Oct 2014 09:38:26 +0200] rev 24088
Fixes issue 27957: Grid button don't get stuck after autosaving new record

In the fix [1] of this issue [2], a change was made to force reselecting a new record even if it was already selected, because otherwise when a record was created in grid mode while a filter was applied, when the record was saved the selection was lost.

The problem is that that change should only be applied when the editCompletionEvent is 'programmatic'. In the other cases (i.e. 'tab', 'enter', etc), the focus goes to another record, so it did not apply to [2]. In fact when the editCompletion event is not 'programmatic' not only reselecting the record was not needed, but also it caused the grid buttons to get stuck.

[1] https://code.openbravo.com/erp/devel/pi/rev/dfda65fa925f89a21eee64f35d7aadb252c90dab
[2] https://issues.openbravo.com/view.php?id=26702

Thu, 23 Oct 2014 17:31:32 +0000Update AD_MODULE version to 3.0PR14Q3.2
RM packaging bot <staff.rm@openbravo.com> [Thu, 23 Oct 2014 17:31:32 +0000] rev 24087
Update AD_MODULE version to 3.0PR14Q3.2

Wed, 15 Oct 2014 13:40:56 +0200Fixed bug 27872: NPE when reactivating payment for BPartner without currency
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 15 Oct 2014 13:40:56 +0200] rev 24086
Fixed bug 27872: NPE when reactivating payment for BPartner without currency

When reactivating the payment, the FIN_PaymentProcess was getting the business partner currency's ID where, in some strange circunstances, it may not be defined yet.
Moreover, getting the BP currency ID at this point is not needed at all, so these lines have been removed.

Finally, in another part of the code, we have done a trivial refactor to use Currency objects instead of Strings to have a better control over NPE.

Wed, 22 Oct 2014 10:35:37 +0200Related to issue 27887.Implement filtering by Allocated field.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Wed, 22 Oct 2014 10:35:37 +0200] rev 24085
Related to issue 27887.Implement filtering by Allocated field.

Tue, 21 Oct 2014 18:48:07 +0200Fixed issue 27887.Set required fields as show in grid true.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Tue, 21 Oct 2014 18:48:07 +0200] rev 24084
Fixed issue 27887.Set required fields as show in grid true.

Tue, 21 Oct 2014 16:18:05 +0200Fixes issue 27918: Removes tree structure from table that is not a tree
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 21 Oct 2014 16:18:05 +0200] rev 24083
Fixes issue 27918: Removes tree structure from table that is not a tree

In the initial changeset for fixing 27918, the tree type of the FinancialMgmtAccountingReport table was set to null because that table is not really a tree. The problem was that the cleaning up of the table was not complete, the Is Tree flag should be set to false, and its Tree Table Category subtab should be empty. This has been done now.

The Initial Client Setup was failing because of the incomplete cleanup. The Tree Table Category of FinancialMgmtAccountingReport had a record called Accounting Report, which is the same name as the tree of the FinancialMgmtAccountingRptElement table.

Tue, 21 Oct 2014 13:09:51 +0200Fixes issue 27918, fixes issue 27930. Prevents breaking the int-inc tests
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 21 Oct 2014 13:09:51 +0200] rev 24082
Fixes issue 27918, fixes issue 27930. Prevents breaking the int-inc tests

The problem was that due to this design defect [1], the oracle and postgres int-inc tests were failing. This is because a value 'AR' was being set to the treetype of a table and then being set to null in other table whose treetype was also 'AR'. Treetype has a unique constraint that was enabled when the application data was updated, so the constraint failed.

To prevent this error, the treetype of the second table is going to be set to null in a modulescript, that is executed before updating the application data.

[1] https://issues.openbravo.com/view.php?id=12577

Tue, 21 Oct 2014 11:28:25 +0200Fixes issue 27918: User Defined Accounting Report Setup shows tree view
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 21 Oct 2014 11:28:25 +0200] rev 24081
Fixes issue 27918: User Defined Accounting Report Setup shows tree view

The problem was that the tree configuration previous to the new tree implementation was wrong. The Table table had a field called Type Area which was originally used to specify the Tree type of the table. The FinancialMgmtAccountingRptElement table had this field empty, and instead the FinancialMgmtAccountingReport had this field set to Accounting Report, which is the value that should have been assigned to FinancialMgmtAccountingRptElement.

The configuration of the new implementation was done based on the Tree Type field, so it was wrong for the FinancialMgmtAccountingRptElement table. Now it has been properly done (it has been flagged as Is Tree, a record has been added to the Table Tree Category subtab and a value has been selected in the Table Tree Category field of the Tab tab.

Also, a module script has been modified to fix the data of ad_tree. The ad_tree table has a column called ad_table_id, which points to the table that the tree belongs to. The accounting report tree was mistakenly pointing to FinancialMgmtAccountingReport, and the updated modulescript fixes it so that now it points to FinancialMgmtAccountingRptElement.