Added generate.java.doc task, solved javadoc warnings
authorMartin Taal <martin.taal@openbravo.com>
Mon, 04 May 2009 11:15:38 +0200
changeset 3794 0ace4de08524
parent 3793 cc54bc4c5bde
child 3795 afae9719930f
Added generate.java.doc task, solved javadoc warnings
build.xml
src-test/org/openbravo/test/ant/CallWadTest.java
src-test/org/openbravo/test/dal/AllTests.java
src-test/org/openbravo/test/javascript/JavaScriptParser.java
src-test/org/openbravo/test/webservice/WSReadTest.java
src-test/org/openbravo/test/xml/EntityXMLImportTestBusinessObject.java
src/org/openbravo/base/model/Entity.java
src/org/openbravo/base/model/Property.java
src/org/openbravo/base/secureApp/DefaultValidationException.java
src/org/openbravo/base/secureApp/OrgTree.java
src/org/openbravo/base/secureApp/VariablesSecureApp.java
src/org/openbravo/base/util/Check.java
src/org/openbravo/dal/core/DalUtil.java
src/org/openbravo/dal/core/OBInstantiator.java
src/org/openbravo/dal/core/OBInterceptor.java
src/org/openbravo/dal/core/SessionHandler.java
src/org/openbravo/dal/security/SecurityChecker.java
src/org/openbravo/dal/service/OBCriteria.java
src/org/openbravo/dal/service/OBDal.java
src/org/openbravo/dal/xml/EntityXMLConverter.java
src/org/openbravo/dal/xml/StaxXMLEntityConverter.java
src/org/openbravo/dal/xml/XMLEntityConverter.java
src/org/openbravo/erpCommon/ad_forms/AcctServer.java
src/org/openbravo/erpCommon/ad_forms/DocAmortization.java
src/org/openbravo/erpCommon/ad_forms/DocBank.java
src/org/openbravo/erpCommon/ad_forms/DocCash.java
src/org/openbravo/erpCommon/ad_forms/DocCashTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocDPManagement.java
src/org/openbravo/erpCommon/ad_forms/DocDPManagementTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
src/org/openbravo/erpCommon/ad_forms/DocGLJournalTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocInOut.java
src/org/openbravo/erpCommon/ad_forms/DocInOutTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocInventory.java
src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
src/org/openbravo/erpCommon/ad_forms/DocInvoiceTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocLine_Bank.java
src/org/openbravo/erpCommon/ad_forms/DocLine_Cash.java
src/org/openbravo/erpCommon/ad_forms/DocMovement.java
src/org/openbravo/erpCommon/ad_forms/DocMovementTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocOrder.java
src/org/openbravo/erpCommon/ad_forms/DocOrderTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocPayment.java
src/org/openbravo/erpCommon/ad_forms/DocPaymentTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocProduction.java
src/org/openbravo/erpCommon/ad_forms/DocProductionTemplate.java
src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java
src/org/openbravo/erpCommon/ad_forms/InitialOrgSetup.java
src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java
src/org/openbravo/erpCommon/ad_process/AcctServerProcess.java
src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java
src/org/openbravo/erpCommon/businessUtility/AccountTree.java
src/org/openbravo/erpCommon/businessUtility/WindowTabs.java
src/org/openbravo/erpCommon/modules/ImportModule.java
src/org/openbravo/erpCommon/modules/ModuleReferenceDataClientTree.java
src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree.java
src/org/openbravo/erpCommon/modules/ModuleTree.java
src/org/openbravo/erpCommon/modules/UninstallModule.java
src/org/openbravo/erpCommon/modules/VersionUtility.java
src/org/openbravo/erpCommon/utility/FieldProviderFactory.java
src/org/openbravo/erpCommon/utility/GenericTree.java
src/org/openbravo/erpCommon/utility/SystemInfo.java
src/org/openbravo/erpCommon/utility/TableSQLData.java
src/org/openbravo/erpCommon/utility/Utility.java
src/org/openbravo/erpCommon/utility/VerticalMenu.java
src/org/openbravo/scheduling/DefaultJob.java
src/org/openbravo/scheduling/OBScheduler.java
src/org/openbravo/scheduling/ProcessBundle.java
src/org/openbravo/scheduling/ProcessContext.java
src/org/openbravo/scheduling/ProcessLogger.java
src/org/openbravo/scheduling/ProcessMonitor.java
src/org/openbravo/scheduling/ProcessRunner.java
src/org/openbravo/service/dataset/DataSetService.java
src/org/openbravo/service/db/ClientImportEntityResolver.java
src/org/openbravo/service/db/ClientImportProcessor.java
src/org/openbravo/service/db/DataExportService.java
src/org/openbravo/service/db/DataImportService.java
--- a/build.xml	Sun May 03 22:10:02 2009 -0400
+++ b/build.xml	Mon May 04 11:15:38 2009 +0200
@@ -72,6 +72,7 @@
 
   <property name="base.config" location="config" />
   <property name="base.src" location="src" />
+  <property name="base.src.test" location="src-test" />
   <property name="base.src.core" location="src-core" />
   <property name="base.src.db" location="src-db" />
   <property name="base.src.trl" location="src-trl" />
@@ -356,6 +357,15 @@
     <ant dir="${base.src}" target="compile.src.gen" inheritAll="true" inheritRefs="true" />
   </target>
 
+  <target name="generate.java.doc">
+    <javadoc sourcepath="${base.src}:${base.src.test}:${base.src.gen}" Windowtitle="Openbravo ERP 2.50" access="public" Header="Openbravo ERP 2.50" Footer="Openbravo ERP 2.50" destdir="${build.docs}" maxmemory="${build.maxmemory}">
+      <classpath>
+        <path refid="project.class.path"/>
+        <pathelement path="lib/build/js.jar" />
+      </classpath>
+    </javadoc>
+  </target>
+
   <target name="generate.entities">
     <ant dir="${base.src}" target="generate.entities" inheritAll="true" inheritRefs="true" />
   </target>
--- a/src-test/org/openbravo/test/ant/CallWadTest.java	Sun May 03 22:10:02 2009 -0400
+++ b/src-test/org/openbravo/test/ant/CallWadTest.java	Mon May 04 11:15:38 2009 +0200
@@ -24,17 +24,14 @@
 import org.openbravo.wad.Wad;
 
 /**
- * An example of calling Wad directly with command line arguments.
- * 
- * @see Wad
+ * An example test of calling Wad directly with command line arguments.
  * 
  * @author mtaal
  */
-
 public class CallWadTest extends BaseAntTest {
 
   /**
-   * Calls {@link Wad#main(String[])} with a number of commandline arguments.
+   * Calls Wad.main(String[]) with a number of commandline arguments.
    */
   public void testWad() {
     PropertyConfigurator.configure(this.getClass().getResource("/log4j.properties"));
--- a/src-test/org/openbravo/test/dal/AllTests.java	Sun May 03 22:10:02 2009 -0400
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,42 +0,0 @@
-/*
- *************************************************************************
- * The contents of this file are subject to the Openbravo  Public  License
- * Version  1.0  (the  "License"),  being   the  Mozilla   Public  License
- * Version 1.1  with a permitted attribution clause; you may not  use this
- * file except in compliance with the License. You  may  obtain  a copy of
- * the License at http://www.openbravo.com/legal/license.html 
- * Software distributed under the License  is  distributed  on  an "AS IS"
- * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
- * License for the specific  language  governing  rights  and  limitations
- * under the License. 
- * The Original Code is Openbravo ERP. 
- * The Initial Developer of the Original Code is Openbravo SL 
- * All portions are Copyright (C) 2008 Openbravo SL 
- * All Rights Reserved. 
- * Contributor(s):  ______________________________________.
- ************************************************************************
- */
-
-package org.openbravo.test.dal;
-
-import junit.framework.Test;
-import junit.framework.TestSuite;
-
-public class AllTests {
-
-  public static Test suite() {
-    final TestSuite suite = new TestSuite("Test for org.openbravo.test.dal");
-    suite.addTestSuite(DalComplexQueryRequisitionTest.class);
-    suite.addTestSuite(DalComplexQueryTestOrderLine.class);
-    suite.addTestSuite(DalPerformanceInventoryLineTest.class);
-    suite.addTestSuite(DalPerformanceProductTest.class);
-    suite.addTestSuite(DalQueryTest.class);
-    suite.addTestSuite(DalTest.class);
-    suite.addTestSuite(DynamicEntityTest.class);
-    suite.addTestSuite(HiddenUpdateTest.class);
-    suite.addTestSuite(MappingGenerationTest.class);
-    suite.addTestSuite(ValidationTest.class);
-    return suite;
-  }
-
-}
--- a/src-test/org/openbravo/test/javascript/JavaScriptParser.java	Sun May 03 22:10:02 2009 -0400
+++ b/src-test/org/openbravo/test/javascript/JavaScriptParser.java	Mon May 04 11:15:38 2009 +0200
@@ -56,9 +56,7 @@
   }
 
   /**
-   * Returns a tree representation of the parsed JavaScript file
-   * 
-   * @return
+   * @return a tree representation of the parsed JavaScript file
    * @throws IOException
    */
   public ScriptOrFnNode parse() throws IOException {
@@ -85,9 +83,7 @@
   }
 
   /**
-   * Returns a string with the global variables and function definitions
-   * 
-   * @return
+   * @return a string with the global variables and function definitions
    */
   public String getStringDetails() {
     if (jsFile == null) {
@@ -126,13 +122,14 @@
   /**
    * Write the details of the js file into a file
    * 
-   * @param f
+   * @param file
+   *          the file to write to
    */
-  public void toFile(File fileName) throws IOException {
+  public void toFile(File file) throws IOException {
     if (jsFile == null) {
       throw new RuntimeException("You need to specify the file to parse");
     }
-    BufferedWriter out = new BufferedWriter(new FileWriter(fileName));
+    BufferedWriter out = new BufferedWriter(new FileWriter(file));
     out.write(getStringDetails());
     out.close();
   }
--- a/src-test/org/openbravo/test/webservice/WSReadTest.java	Sun May 03 22:10:02 2009 -0400
+++ b/src-test/org/openbravo/test/webservice/WSReadTest.java	Mon May 04 11:15:38 2009 +0200
@@ -26,6 +26,7 @@
 import org.hibernate.mapping.PersistentClass;
 import org.openbravo.base.model.Entity;
 import org.openbravo.base.session.SessionFactoryController;
+import org.openbravo.model.ad.datamodel.Table;
 
 /**
  * Test the DAL rest webservices in read-mode. The test cases here require that there is a running
--- a/src-test/org/openbravo/test/xml/EntityXMLImportTestBusinessObject.java	Sun May 03 22:10:02 2009 -0400
+++ b/src-test/org/openbravo/test/xml/EntityXMLImportTestBusinessObject.java	Mon May 04 11:15:38 2009 +0200
@@ -40,8 +40,8 @@
 import org.openbravo.service.db.ImportResult;
 
 /**
- * Test import of data with a business object ({@link PaymentTerm) and {@link PaymentTermLine},
- * adding and removing childs
+ * Test import of data with a business object ({@link PaymentTerm} and {@link PaymentTermLine}),
+ * adding and removing childs.
  * 
  * @author mtaal
  */
--- a/src/org/openbravo/base/model/Entity.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/base/model/Entity.java	Mon May 04 11:15:38 2009 +0200
@@ -218,7 +218,7 @@
   /**
    * Validates the passed object using the property validators of this Entity.
    * 
-   * @param o
+   * @param obj
    *          the object to validate
    * @see EntityValidator
    * @see PropertyValidator
--- a/src/org/openbravo/base/model/Property.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/base/model/Property.java	Mon May 04 11:15:38 2009 +0200
@@ -248,9 +248,8 @@
    * which this property refers. Returns null if there is no referenced property this occurs in case
    * of a reference to the primary key of the referenced Entity.
    * 
-   * @return
+   * @return the associated property on the other side of the association.
    */
-  // 
   public Property getReferencedProperty() {
     return referencedProperty;
   }
--- a/src/org/openbravo/base/secureApp/DefaultValidationException.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/base/secureApp/DefaultValidationException.java	Mon May 04 11:15:38 2009 +0200
@@ -31,7 +31,7 @@
   /**
    * Method used to determine the field for which the default setting failed
    * 
-   * @return
+   * @return the field for which the default setting failed.
    */
   public String getDefaultField() {
     return defaultField;
--- a/src/org/openbravo/base/secureApp/OrgTree.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/base/secureApp/OrgTree.java	Mon May 04 11:15:38 2009 +0200
@@ -125,7 +125,7 @@
    * 
    * @param conn
    * @param strRole
-   * @return
+   * @return the created {@link OrgTree}
    */
   public OrgTree getAccessibleTree(ConnectionProvider conn, String strRole, boolean withZero) {
     // TODO: this method with boolean should be removed.
--- a/src/org/openbravo/base/secureApp/VariablesSecureApp.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/base/secureApp/VariablesSecureApp.java	Mon May 04 11:15:38 2009 +0200
@@ -234,7 +234,7 @@
    * @param inKey1
    *          The string to compare Command parameter to.
    * @return Boolean indicating the equality of the Command and the inKey1 parameter.
-   * @see getCommand
+   * @see #getCommand()
    */
   public boolean commandIn(String inKey1) {
     if (command.equals(inKey1))
@@ -252,7 +252,7 @@
    * @param inKey2
    *          The second string to compare the Command parameter to.
    * @return Boolean indicating the equality of the Command and either of the inKeyX parameters.
-   * @see getCommand
+   * @see #getCommand()
    */
   public boolean commandIn(String inKey1, String inKey2) {
     if (command.equals(inKey1) || command.equals(inKey2))
@@ -272,7 +272,7 @@
    * @param inKey3
    *          The third string to compare the Command parameter to .
    * @return Boolean indicating the equality of the Command and either of the inKeyX parameters.
-   * @see getCommand
+   * @see #getCommand()
    */
   public boolean commandIn(String inKey1, String inKey2, String inKey3) {
     if (command.equals(inKey1) || command.equals(inKey2) || command.equals(inKey3))
@@ -294,7 +294,7 @@
    * @param inKey4
    *          The fourth string to compare the Command parameter to.
    * @return Boolean indicating the equality of the Command and either of the inKeyX parameters.
-   * @see getCommand
+   * @see #getCommand()
    */
   public boolean commandIn(String inKey1, String inKey2, String inKey3, String inKey4) {
     if (command.equals(inKey1) || command.equals(inKey2) || command.equals(inKey3)
@@ -319,7 +319,7 @@
    * @param inKey5
    *          The fifth string to compare the Command parameter to.
    * @return Boolean indicating the equality of the Command and either of the inKeyX parameters.
-   * @see getCommand
+   * @see #getCommand()
    */
   public boolean commandIn(String inKey1, String inKey2, String inKey3, String inKey4, String inKey5) {
     if (command.equals(inKey1) || command.equals(inKey2) || command.equals(inKey3)
@@ -376,8 +376,8 @@
    *          table.
    * @return Deserialized OBError object retrieved from the session. Null if no error message exists
    *         for this tab.
-   * @see setMessage
-   * @see removeMessage
+   * @see #setMessage(String, OBError)
+   * @see #removeMessage(String)
    */
   public OBError getMessage(String AD_Tab_ID) {
     return ((OBError) getSessionObject(AD_Tab_ID + "|message"));
@@ -392,8 +392,8 @@
    *          table.
    * @param error
    *          The OBError object that needs to be set.
-   * @see getMessage
-   * @see removeMessage
+   * @see #setMessage(String, OBError)
+   * @see #removeMessage(String)
    */
   public void setMessage(String AD_Tab_ID, OBError error) {
     setSessionObject(AD_Tab_ID + "|message", error);
@@ -406,8 +406,8 @@
    * @param AD_Tab_ID
    *          String with the primary key (ID) of the tab as entered within the AD_TAB database
    *          table.
-   * @see setMessage
-   * @see getMessage
+   * @see #setMessage(String, OBError)
+   * @see #getMessage(String)
    */
   public void removeMessage(String AD_Tab_ID) {
     removeSessionValue(AD_Tab_ID + "|message");
--- a/src/org/openbravo/base/util/Check.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/base/util/Check.java	Mon May 04 11:15:38 2009 +0200
@@ -124,7 +124,7 @@
   /**
    * Checks if the passed object is of the class specified, null values are ignored.
    * 
-   * @param value
+   * @param obj
    *          should be instanceof the expClass
    * @param expClass
    *          the class used for the check
--- a/src/org/openbravo/dal/core/DalUtil.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/core/DalUtil.java	Mon May 04 11:15:38 2009 +0200
@@ -158,7 +158,7 @@
   }
 
   /**
-   * Returns the entity name (see {@link Entity@getName()} without loading/resolving the object. If
+   * Returns the entity name (see {@link Entity#getName()} without loading/resolving the object. If
    * the object is a Hibernate proxy then the entity name is retrieved through the proxy and not
    * directly from the object. This prevent unwanted loading of the object.
    * 
--- a/src/org/openbravo/dal/core/OBInstantiator.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/core/OBInstantiator.java	Mon May 04 11:15:38 2009 +0200
@@ -24,6 +24,7 @@
 import org.apache.log4j.Logger;
 import org.hibernate.mapping.PersistentClass;
 import org.hibernate.tuple.Instantiator;
+import org.openbravo.base.model.Entity;
 import org.openbravo.base.provider.OBProvider;
 import org.openbravo.base.structure.DynamicOBObject;
 import org.openbravo.base.structure.Identifiable;
--- a/src/org/openbravo/dal/core/OBInterceptor.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/core/OBInterceptor.java	Mon May 04 11:15:38 2009 +0200
@@ -35,6 +35,7 @@
 import org.openbravo.base.exception.OBException;
 import org.openbravo.base.exception.OBSecurityException;
 import org.openbravo.base.model.Entity;
+import org.openbravo.base.model.Property;
 import org.openbravo.base.structure.BaseOBObject;
 import org.openbravo.base.structure.ClientEnabled;
 import org.openbravo.base.structure.OrganizationEnabled;
--- a/src/org/openbravo/dal/core/SessionHandler.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/core/SessionHandler.java	Mon May 04 11:15:38 2009 +0200
@@ -97,7 +97,7 @@
   // at the end
   private boolean doRollback = false;
 
-  /** @returns the session */
+  /** @return the session */
   public Session getSession() {
     return session;
   }
--- a/src/org/openbravo/dal/security/SecurityChecker.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/security/SecurityChecker.java	Mon May 04 11:15:38 2009 +0200
@@ -34,8 +34,11 @@
 /**
  * This class combines all security checks which are performed on entity level:
  * <ul>
- * <li>Delete: is the entity deletable (@see {@link Entity#isDeletable()) and does the user have write access to the entity.</li>
- * <li>Write: is done in case of create and update actions. The following checks are performed: is the organization writable, is the client of the object the same as  is the entity writable (@see EntityAccessChecker#isWritable(Entity)) 
+ * <li>Delete: is the entity deletable (@see {@link Entity#isDeletable()}) and does the user have
+ * write access to the entity.</li>
+ * <li>Write: is done in case of create and update actions. The following checks are performed: is
+ * the organization writable, is the client of the object the same as is the entity writable (@see
+ * EntityAccessChecker#isWritable(Entity))
  * 
  * @author mtaal
  */
--- a/src/org/openbravo/dal/service/OBCriteria.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/service/OBCriteria.java	Mon May 04 11:15:38 2009 +0200
@@ -26,7 +26,6 @@
 import java.util.List;
 
 import org.apache.log4j.Logger;
-import org.hibernate.Criteria;
 import org.hibernate.HibernateException;
 import org.hibernate.ScrollMode;
 import org.hibernate.ScrollableResults;
@@ -80,7 +79,9 @@
   }
 
   /**
-   * @see Criteria#list()
+   * See the list() method of the Hibernate Criteria class.
+   * 
+   * @return the list of Objects retrieved through this Criteria object
    */
   @SuppressWarnings("unchecked")
   public List<E> list() throws HibernateException {
@@ -102,7 +103,7 @@
   }
 
   /**
-   * @see Criteria#scroll()
+   * See the scroll method on the Hibernate Criteria class.
    */
   public ScrollableResults scroll() throws HibernateException {
     initialize();
@@ -110,7 +111,7 @@
   }
 
   /**
-   * @see Criteria#scroll(ScrollMode)
+   * See the scroll method on the Hibernate Criteria class.
    */
   public ScrollableResults scroll(ScrollMode scrollMode) throws HibernateException {
     initialize();
@@ -118,7 +119,7 @@
   }
 
   /**
-   * @see Criteria#uniqueResult()
+   * See the uniqueResult() method on the Hibernate Criteria class.
    */
   public Object uniqueResult() throws HibernateException {
     initialize();
--- a/src/org/openbravo/dal/service/OBDal.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/service/OBDal.java	Mon May 04 11:15:38 2009 +0200
@@ -244,7 +244,7 @@
    *          the HQL where and orderby clause
    * @param parameters
    *          the parameters to use in the query
-   * @return
+   * @return a new instance of {@link OBQuery}.
    */
   public OBQuery<BaseOBObject> createQuery(String entityName, String whereOrderByClause,
       List<Object> parameters) {
--- a/src/org/openbravo/dal/xml/EntityXMLConverter.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/xml/EntityXMLConverter.java	Mon May 04 11:15:38 2009 +0200
@@ -183,9 +183,7 @@
   }
 
   /**
-   * Processes one business object and adds it to the dom4j document which is present in the
-   * EntityXMLConverter. After this call the xml can be retrieved by calling the
-   * {@link #getDocument()} or the {@link #getProcessResult()} method.
+   * Processes one business object and outputs it to the writer ({@link #setOutput(Writer)}).
    * 
    * @param bob
    *          the business object to convert to xml (dom4j)
@@ -200,12 +198,11 @@
   }
 
   /**
-   * Processes a collection of business objects and adds their xml to the dom4j document which is
-   * present in the EntityXMLConverter. After this call the xml can be retrieved by calling the
-   * {@link #getDocument()} or the {@link #getProcessResult()} method.
+   * Processes a collection of business objects and outputs them to the writer (
+   * {@link #setOutput(Writer)}).
    * 
-   * @param bob
-   *          the business object to convert to xml (dom4j)
+   * @param bobs
+   *          the business objects to convert to xml (dom4j)
    */
   public void process(Collection<BaseOBObject> bobs) {
     // set the export list
@@ -516,9 +513,6 @@
   /**
    * This option controls if children are exported within the parent or in the root of the xml. The
    * default is embedded (default value is true).
-   * 
-   * @return true (default) children are embedded in the parent, false children are exported in the
-   *         root of the xml
    */
   public void setOptionEmbedChildren(boolean optionEmbedChildren) {
     this.optionEmbedChildren = optionEmbedChildren;
--- a/src/org/openbravo/dal/xml/StaxXMLEntityConverter.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/xml/StaxXMLEntityConverter.java	Mon May 04 11:15:38 2009 +0200
@@ -78,8 +78,8 @@
   }
 
   /**
-   * The main entry point. This method creates a Dom4j Document and then calls
-   * {@link #process(Document)}.
+   * The main entry point. This method creates a XMLStreamReader and then calls
+   * process(XMLStreamReader).
    * 
    * @param reader
    *          the xml
--- a/src/org/openbravo/dal/xml/XMLEntityConverter.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/dal/xml/XMLEntityConverter.java	Mon May 04 11:15:38 2009 +0200
@@ -98,8 +98,8 @@
    * {@link #getToInsert()} method and the to-be-updated objects through the {@link #getToUpdate()}
    * method.
    * 
-   * @param xml
-   *          the xml string
+   * @param doc
+   *          the dom4j Document to process
    * @return the list of BaseOBObject present in the root of the xml. This list contains the
    *         to-be-updated, to-be-inserted as well as the unchanged business objects
    */
--- a/src/org/openbravo/erpCommon/ad_forms/AcctServer.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/AcctServer.java	Mon May 04 11:15:38 2009 +0200
@@ -236,7 +236,7 @@
 
   /**
    * Cosntructor
-   *
+   * 
    * @param m_AD_Client_ID
    *          Client ID of these Documents
    * @param connectionProvider
@@ -256,7 +256,8 @@
   }
 
   public void run(VariablesSecureApp vars) throws IOException, ServletException {
-    if (AD_Client_ID.equals("")) AD_Client_ID = vars.getClient();
+    if (AD_Client_ID.equals(""))
+      AD_Client_ID = vars.getClient();
     try {
       Connection con = connectionProvider.getTransactionConnection();
       String strIDs = "";
@@ -290,7 +291,7 @@
 
   /**
    * Factory - Create Posting document
-   *
+   * 
    * @param AD_Table_ID
    *          Table ID of Documents
    * @param AD_Client_ID
@@ -533,7 +534,7 @@
 
   /**
    * Post Commit. Save Facts & Document
-   *
+   * 
    * @param status
    *          status
    * @return Posting Status
@@ -579,7 +580,7 @@
 
   /**
    * Save to Disk - set posted flag
-   *
+   * 
    * @param con
    *          connection
    * @return true if saved
@@ -788,7 +789,7 @@
 
   /**
    * Posting logic for Accounting Schema index
-   *
+   * 
    * @param index
    *          Accounting Schema index
    * @return posting status/error code
@@ -846,7 +847,7 @@
 
   /**
    * Is the Source Document Balanced
-   *
+   * 
    * @return true if (source) baanced
    */
   public boolean isBalanced() {
@@ -865,7 +866,7 @@
 
   /**
    * Is Document convertible to currency and Conversion Type
-   *
+   * 
    * @param acctSchema
    *          accounting schema
    * @return true, if vonvertable to accounting currency
@@ -925,7 +926,7 @@
 
   /**
    * Get the Amount (loaded in loadDocumentDetails)
-   *
+   * 
    * @param AmtType
    *          see AMTTYPE_*
    * @return Amount
@@ -938,7 +939,7 @@
 
   /**
    * Get Amount with index 0
-   *
+   * 
    * @return Amount (primary document amount)
    */
   public String getAmount() {
@@ -947,7 +948,7 @@
 
   /**
    * Convert an amount
-   *
+   * 
    * @param CurFrom_ID
    *          The C_Currency_ID FROM
    * @param CurTo_ID
@@ -1006,7 +1007,7 @@
 
   /**
    * Is Period Open
-   *
+   * 
    * @return true if period is open
    */
   public boolean isPeriodOpen() {
@@ -1052,7 +1053,7 @@
 
   /**
    * Get fully qualified Account Combination
-   *
+   * 
    * @param AD_Client_ID
    *          client
    * @param AD_Org_ID
@@ -1160,7 +1161,7 @@
 
   /**
    * Matching
-   *
+   * 
    * <pre>
    *  Derive Invoice-Receipt Match from PO-Invoice and PO-Receipt
    *  Purchase Order (20)
@@ -1174,10 +1175,10 @@
    *  (b) Creates Indirects
    *      - Invoice1 - Receipt2 (5)
    *  (Not imlemented)
-   *
-   *
+   * 
+   * 
    * </pre>
-   *
+   * 
    * @return number of records created
    */
   public int match(VariablesSecureApp vars, ConnectionProvider conn, Connection con) {
@@ -1232,7 +1233,7 @@
 
   /**
    * Create MatchInv record
-   *
+   * 
    * @param AD_Client_ID
    *          Client
    * @param AD_Org_ID
@@ -1270,7 +1271,7 @@
 
   /**
    * Get the account for Accounting Schema
-   *
+   * 
    * @param AcctType
    *          see ACCTTYPE_*
    * @param as
@@ -1426,14 +1427,14 @@
 
   /**
    * Get Source Currency Balance - subtracts line (and tax) amounts from total - no rounding
-   *
+   * 
    * @return positive amount, if total header is bigger than lines
    */
   public abstract BigDecimal getBalance();
 
   /**
    * Create Facts (the accounting logic)
-   *
+   * 
    * @param as
    *          accounting schema
    * @return Fact
@@ -1471,7 +1472,7 @@
 
   /**
    * @param language
-   * @return
+   * @return a String representing the result of created
    */
   public String getInfo(String language) {
     return (Utility.messageBD(connectionProvider, "Created", language) + "=" + success);
--- a/src/org/openbravo/erpCommon/ad_forms/DocAmortization.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocAmortization.java	Mon May 04 11:15:38 2009 +0200
@@ -56,7 +56,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          AD_Client_ID
    */
@@ -109,9 +109,7 @@
 
   /**
    * Load Specific Document Details
-   *
-   * @param rs
-   *          result set
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -126,7 +124,7 @@
 
   /**
    * Load AmortizationLine Line.
-   *
+   * 
    * @return DocLine Array
    */
   private DocLine[] loadLines(ConnectionProvider conn) {
@@ -159,7 +157,7 @@
 
   /**
    * Get Source Currency Balance - always zero
-   *
+   * 
    * @return Zero (always balanced)
    */
   public BigDecimal getBalance() {
@@ -170,7 +168,7 @@
 
   /**
    * Create Facts (the accounting logic) for
-   *
+   * 
    * @param as
    *          accounting schema
    * @return Fact
@@ -189,7 +187,7 @@
             .newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-      	log4j.error("Error while creating new instance for DocAmortizationTemplate - " + e);
+        log4j.error("Error while creating new instance for DocAmortizationTemplate - " + e);
       }
     }
     // create Fact Header
@@ -222,8 +220,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
@@ -231,7 +229,7 @@
 
   /**
    * Line Account from Asset
-   *
+   * 
    * @param AcctType
    *          see ACCTTYPE_* (1..8)
    * @param as
--- a/src/org/openbravo/erpCommon/ad_forms/DocBank.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocBank.java	Mon May 04 11:15:38 2009 +0200
@@ -73,7 +73,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          AD_Client_ID
    */
@@ -88,9 +88,7 @@
 
   /**
    * Load Specific Document Details
-   *
-   * @param rs
-   *          result set
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -139,7 +137,7 @@
 
   /**
    * Load Invoice Line. 4 amounts AMTTYPE_Payment AMTTYPE_Statement2 AMTTYPE_Charge AMTTYPE_Interest
-   *
+   * 
    * @return DocLine Array
    */
   private DocLine[] loadLines(ConnectionProvider conn) {
@@ -178,7 +176,7 @@
 
   /**
    * Get Source Currency Balance - subtracts line amounts from total - no rounding
-   *
+   * 
    * @return positive amount, if total invoice is bigger than lines
    */
   public BigDecimal getBalance() {
@@ -201,14 +199,14 @@
 
   /**
    * Create Facts (the accounting logic) for CMB.
-   *
+   * 
    * <pre>
    *      BankAsset       DR      CR  (Statement)
    *      BankInTransit   DR      CR              (Payment)
    *      Charge          DR          (Charge)
    *      Interest        DR      CR  (Interest)
    * </pre>
-   *
+   * 
    * @param as
    *          accounting schema
    * @return Fact
@@ -225,7 +223,7 @@
         DocBankTemplate newTemplate = (DocBankTemplate) Class.forName(strClassname).newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-    	log4j.error("Error while creating new instance for DocBankTemplate - " + e);
+        log4j.error("Error while creating new instance for DocBankTemplate - " + e);
       }
     }
     log4jDocBank.debug("createFact - Inicio");
@@ -313,8 +311,8 @@
 
   /**
    * Get the account for Accounting Schema
-   *
-   * @param BankStatementline_Id
+   * 
+   * @param strcBankstatementlineId
    * @param as
    *          accounting schema
    * @return Account
@@ -360,8 +358,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     String strCount = "";
--- a/src/org/openbravo/erpCommon/ad_forms/DocCash.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocCash.java	Mon May 04 11:15:38 2009 +0200
@@ -74,7 +74,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          AD_Client_ID
    */
@@ -90,9 +90,7 @@
 
   /**
    * Load Specific Document Details
-   *
-   * @param rs
-   *          result set
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -137,7 +135,7 @@
 
   /**
    * Load Cash Line
-   *
+   * 
    * @return DocLine Array
    */
   private DocLine[] loadLines(ConnectionProvider conn) {
@@ -172,7 +170,7 @@
 
   /**
    * Get Source Currency Balance - subtracts line amounts from total - no rounding
-   *
+   * 
    * @return positive amount, if total invoice is bigger than lines
    */
   public BigDecimal getBalance() {
@@ -195,7 +193,7 @@
 
   /**
    * Create Facts (the accounting logic) for CMC.
-   *
+   * 
    * <pre>
    *  Expense
    *          CashExpense     DR
@@ -220,7 +218,7 @@
    *          BankInTransit   DR
    *          CashAsset               CR
    * </pre>
-   *
+   * 
    * @param as
    *          account schema
    * @return Fact
@@ -242,7 +240,7 @@
         DocCashTemplate newTemplate = (DocCashTemplate) Class.forName(strClassname).newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-      	log4j.error("Error while creating new instance for DocCashTemplate - " + e);
+        log4j.error("Error while creating new instance for DocCashTemplate - " + e);
       }
     }
     // create Fact Header
@@ -426,13 +424,13 @@
 
   /**
    * Get the account for Accounting Schema
-   *
+   * 
    * @param AcctType
    *          see ACCTTYPE_*
    * @param as
    *          accounting schema
    * @return Account
-   *
+   * 
    *         public final Account getAccountCashInTransit(String strcCashlineId, AcctSchema as,
    *         ConnectionProvider conn){ DocCashData [] data=null; try{ data =
    *         DocCashData.selectCashLineAcct(conn, strcCashlineId, as.getC_AcctSchema_ID());
@@ -447,8 +445,8 @@
 
   /**
    * Get the account for Accounting Schema
-   *
-   * @param Bank
+   * 
+   * @param strcBankAccountId
    *          Account
    * @param as
    *          accounting schema
@@ -494,8 +492,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
--- a/src/org/openbravo/erpCommon/ad_forms/DocCashTemplate.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocCashTemplate.java	Mon May 04 11:15:38 2009 +0200
@@ -30,9 +30,6 @@
 
   /**
    * Constructor
-   * 
-   * @param AD_Client_ID
-   *          AD_Client_ID
    */
   public DocCashTemplate() {
   }
--- a/src/org/openbravo/erpCommon/ad_forms/DocDPManagement.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocDPManagement.java	Mon May 04 11:15:38 2009 +0200
@@ -75,7 +75,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          AD_Client_ID
    */
@@ -91,9 +91,7 @@
 
   /**
    * Load Specific Document Details
-   *
-   * @param rs
-   *          result set
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -108,7 +106,7 @@
 
   /**
    * Load AmortizationLine Line.
-   *
+   * 
    * @return DocLine Array
    */
   private DocLine[] loadLines(ConnectionProvider conn) {
@@ -143,7 +141,7 @@
 
   /**
    * Get Source Currency Balance - always zero
-   *
+   * 
    * @return Zero (always balanced)
    */
   public BigDecimal getBalance() {
@@ -154,7 +152,7 @@
 
   /**
    * Create Facts (the accounting logic) for
-   *
+   * 
    * @param as
    *          accounting schema
    * @return Fact
@@ -172,7 +170,7 @@
             .newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-       	log4j.error("Error while creating new instance for DocDPManagementTemplate - " + e);
+        log4j.error("Error while creating new instance for DocDPManagementTemplate - " + e);
       }
     }
     log4j.debug("createFact - Inicio");
@@ -216,8 +214,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
@@ -225,11 +223,7 @@
 
   /**
    * Line Account from Asset
-   *
-   * @param AcctType
-   *          see ACCTTYPE_* (1..8)
-   * @param as
-   *          Accounting Schema
+   * 
    * @return Requested Asset Account
    */
   public Account getAccount(String Isreceipt, String partnerID, AcctSchema as, String status,
--- a/src/org/openbravo/erpCommon/ad_forms/DocDPManagementTemplate.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocDPManagementTemplate.java	Mon May 04 11:15:38 2009 +0200
@@ -30,9 +30,6 @@
 
   /**
    * Constructor
-   * 
-   * @param AD_Client_ID
-   *          AD_Client_ID
    */
   public DocDPManagementTemplate() {
   }
--- a/src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java	Mon May 04 11:15:38 2009 +0200
@@ -36,7 +36,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          client
    */
@@ -62,9 +62,7 @@
 
   /**
    * Load Specific Document Details
-   *
-   * @param rs
-   *          result set
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -81,7 +79,7 @@
 
   /**
    * Load Invoice Line
-   *
+   * 
    * @return DocLine Array
    */
   private DocLine[] loadLines(ConnectionProvider conn) {
@@ -130,7 +128,7 @@
 
   /**
    * Get Source Currency Balance - subtracts line and tax amounts from total - no rounding
-   *
+   * 
    * @return positive amount, if total invoice is bigger than lines
    */
   public BigDecimal getBalance() {
@@ -149,11 +147,11 @@
 
   /**
    * Create Facts (the accounting logic) for GLJ. (only for the accounting scheme, it was created)
-   *
+   * 
    * <pre>
    *      account     DR          CR
    * </pre>
-   *
+   * 
    * @param as
    *          acct schema
    * @return Fact
@@ -171,7 +169,7 @@
             .newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-       	log4j.error("Error while creating new instance for DocGLJournalTemplate - " + e);
+        log4j.error("Error while creating new instance for DocGLJournalTemplate - " + e);
       }
     }
     // create Fact Header
@@ -257,8 +255,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
--- a/src/org/openbravo/erpCommon/ad_forms/DocGLJournalTemplate.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocGLJournalTemplate.java	Mon May 04 11:15:38 2009 +0200
@@ -30,9 +30,6 @@
 
   /**
    * Constructor
-   * 
-   * @param AD_Client_ID
-   *          AD_Client_ID
    */
   public DocGLJournalTemplate() {
   }
--- a/src/org/openbravo/erpCommon/ad_forms/DocInOut.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInOut.java	Mon May 04 11:15:38 2009 +0200
@@ -37,7 +37,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          AD_Client_ID
    */
@@ -52,9 +52,7 @@
 
   /**
    * Load Document Details
-   *
-   * @param rs
-   *          result set
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -72,7 +70,7 @@
 
   /**
    * Load Invoice Line
-   *
+   * 
    * @return DocLine Array
    */
   public DocLine[] loadLines(ConnectionProvider conn) {
@@ -107,7 +105,7 @@
 
   /**
    * Get Balance
-   *
+   * 
    * @return Zero (always balanced)
    */
   public BigDecimal getBalance() {
@@ -117,7 +115,7 @@
 
   /**
    * Create Facts (the accounting logic) for MMS, MMR.
-   *
+   * 
    * <pre>
    *  Shipment
    *      CoGS            DR
@@ -129,7 +127,7 @@
    *      Inventory       DR
    *      NotInvoicedReceipt      CR
    * </pre>
-   *
+   * 
    * @param as
    *          accounting schema
    * @return Fact
@@ -146,7 +144,7 @@
         DocInOutTemplate newTemplate = (DocInOutTemplate) Class.forName(strClassname).newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-       	log4j.error("Error while creating new instance for DocInOutTemplate - " + e);
+        log4j.error("Error while creating new instance for DocInOutTemplate - " + e);
       }
     }
     C_Currency_ID = as.getC_Currency_ID();
@@ -274,8 +272,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
--- a/src/org/openbravo/erpCommon/ad_forms/DocInOutTemplate.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInOutTemplate.java	Mon May 04 11:15:38 2009 +0200
@@ -30,9 +30,6 @@
 
   /**
    * Constructor
-   * 
-   * @param AD_Client_ID
-   *          AD_Client_ID
    */
   public DocInOutTemplate() {
   }
--- a/src/org/openbravo/erpCommon/ad_forms/DocInventory.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInventory.java	Mon May 04 11:15:38 2009 +0200
@@ -36,7 +36,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          client
    */
@@ -51,9 +51,7 @@
 
   /**
    * Load Document Details
-   *
-   * @param rs
-   *          result
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -69,7 +67,7 @@
 
   /**
    * Load Invoice Line
-   *
+   * 
    * @return DocLine Array
    */
   private DocLine[] loadLines(ConnectionProvider conn) {
@@ -112,7 +110,7 @@
 
   /**
    * Get Balance
-   *
+   * 
    * @return Zero (always balanced)
    */
   public BigDecimal getBalance() {
@@ -122,13 +120,13 @@
 
   /**
    * Create Facts (the accounting logic) for MMI.
-   *
+   * 
    * <pre>
    *  Inventory
    *      Inventory       DR      CR
    *      InventoryDiff   DR      CR   (or Charge)
    * </pre>
-   *
+   * 
    * @param as
    *          account schema
    * @return Fact
@@ -146,7 +144,7 @@
             .newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-       	log4j.error("Error while creating new instance for DocInventoryTemplate - " + e);
+        log4j.error("Error while creating new instance for DocInventoryTemplate - " + e);
       }
     }
     // Log.trace(Log.l4_Data, "Doc.Inventory.createFact");
@@ -234,8 +232,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
--- a/src/org/openbravo/erpCommon/ad_forms/DocInvoice.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInvoice.java	Mon May 04 11:15:38 2009 +0200
@@ -37,7 +37,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          AD_Client_ID
    */
@@ -217,7 +217,7 @@
 
   /**
    * Create Facts (the accounting logic) for ARI, ARC, ARF, API, APC.
-   *
+   * 
    * <pre>
    *  ARI, ARF
    *      Receivables     DR
@@ -240,7 +240,7 @@
    *      TaxCredit               CR
    *      Expense                 CR
    * </pre>
-   *
+   * 
    * @param as
    *          accounting schema
    * @return Fact
@@ -258,7 +258,7 @@
             .newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-       	log4j.error("Error while creating new instance for DocInvoiceTemplate - " + e);
+        log4j.error("Error while creating new instance for DocInvoiceTemplate - " + e);
       }
     }
     log4jDocInvoice.debug("Starting create fact");
@@ -469,7 +469,7 @@
 
   /**
    * Update Product Info. - Costing (PriceLastInv) - PO (PriceLastInv)
-   *
+   * 
    * @param C_AcctSchema_ID
    *          accounting schema
    */
@@ -496,7 +496,7 @@
 
   /**
    * Get Source Currency Balance - subtracts line and tax amounts from total - no rounding
-   *
+   * 
    * @return positive amount, if total invoice is bigger than lines
    */
   public BigDecimal getBalance() {
@@ -535,9 +535,9 @@
 
   /**
    * Get the account for Accounting Schema
-   *
-   * @param AcctType
-   *          see ACCTTYPE_*
+   * 
+   * @param cBPartnerId
+   *          business partner id
    * @param as
    *          accounting schema
    * @return Account
@@ -582,8 +582,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
--- a/src/org/openbravo/erpCommon/ad_forms/DocInvoiceTemplate.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInvoiceTemplate.java	Mon May 04 11:15:38 2009 +0200
@@ -30,9 +30,6 @@
 
   /**
    * Constructor
-   * 
-   * @param AD_Client_ID
-   *          AD_Client_ID
    */
   public DocInvoiceTemplate() {
   }
--- a/src/org/openbravo/erpCommon/ad_forms/DocLine_Bank.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocLine_Bank.java	Mon May 04 11:15:38 2009 +0200
@@ -45,8 +45,6 @@
    * 
    * @param StmtAmt
    *          statement amt
-   * @param InterestAmt
-   *          interest amount
    * @param TrxAmt
    *          transaction amount
    */
--- a/src/org/openbravo/erpCommon/ad_forms/DocLine_Cash.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocLine_Cash.java	Mon May 04 11:15:38 2009 +0200
@@ -75,11 +75,6 @@
 
   /**
    * Set References
-   * 
-   * @param C_BankAccount_ID
-   *          bank account
-   * @param C_Invoice_ID
-   *          invoice
    */
   public void setReference(String C_Order_ID, String C_Debt_Payment_ID, ConnectionProvider conn) {
     m_C_Order_Id = C_Order_ID;
--- a/src/org/openbravo/erpCommon/ad_forms/DocMovement.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocMovement.java	Mon May 04 11:15:38 2009 +0200
@@ -36,7 +36,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          client
    */
@@ -51,9 +51,7 @@
 
   /**
    * Load Document Details
-   *
-   * @param rs
-   *          result set
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -70,7 +68,7 @@
 
   /**
    * Load Invoice Line
-   *
+   * 
    * @return document lines (DocLine_Material)
    */
   public DocLine[] loadLines(ConnectionProvider conn) {
@@ -100,7 +98,7 @@
 
   /**
    * Get Balance
-   *
+   * 
    * @return balance (ZERO) - always balanced
    */
   public BigDecimal getBalance() {
@@ -110,13 +108,13 @@
 
   /**
    * Create Facts (the accounting logic) for MMM.
-   *
+   * 
    * <pre>
    *  Movement
    *      Inventory       DR      CR
    *      InventoryTo     DR      CR
    * </pre>
-   *
+   * 
    * @param as
    *          account schema
    * @return Fact
@@ -135,7 +133,7 @@
             .newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-       	log4j.error("Error while creating new instance for DocInvoiceTemplate - " + e);
+        log4j.error("Error while creating new instance for DocInvoiceTemplate - " + e);
       }
     }
     // create Fact Header
@@ -217,8 +215,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
--- a/src/org/openbravo/erpCommon/ad_forms/DocMovementTemplate.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocMovementTemplate.java	Mon May 04 11:15:38 2009 +0200
@@ -30,9 +30,6 @@
 
   /**
    * Constructor
-   * 
-   * @param AD_Client_ID
-   *          AD_Client_ID
    */
   public DocMovementTemplate() {
   }
--- a/src/org/openbravo/erpCommon/ad_forms/DocOrder.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocOrder.java	Mon May 04 11:15:38 2009 +0200
@@ -36,7 +36,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          client
    */
@@ -51,9 +51,7 @@
 
   /**
    * Load Specific Document Details
-   *
-   * @param rs
-   *          result set
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -81,7 +79,7 @@
 
   /**
    * Load Invoice Line
-   *
+   * 
    * @return DocLine Array
    */
   public DocLine[] loadLines(ConnectionProvider conn) {
@@ -115,7 +113,7 @@
 
   /**
    * Load Invoice Taxes
-   *
+   * 
    * @return DocTax Array
    */
   public DocTax[] loadTaxes(ConnectionProvider conn) {
@@ -147,7 +145,7 @@
 
   /**
    * Get Source Currency Balance - subtracts line and tax amounts from total - no rounding
-   *
+   * 
    * @return positive amount, if total invoice is bigger than lines
    */
   public BigDecimal getBalance() {
@@ -181,10 +179,10 @@
 
   /**
    * Create Facts (the accounting logic) for SOO, POO, POR.
-   *
+   * 
    * <pre>
    * </pre>
-   *
+   * 
    * @param as
    *          accounting schema
    * @return Fact
@@ -201,7 +199,7 @@
         DocOrderTemplate newTemplate = (DocOrderTemplate) Class.forName(strClassname).newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-       	log4j.error("Error while creating new instance for DocOrderTemplate - " + e);
+        log4j.error("Error while creating new instance for DocOrderTemplate - " + e);
       }
     }
     // Purchase Order
@@ -252,7 +250,7 @@
 
   /**
    * Update Product Info. - Costing (PriceLastPO) - PO (PriceLastPO)
-   *
+   * 
    * @param C_AcctSchema_ID
    *          accounting schema
    */
@@ -279,8 +277,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
--- a/src/org/openbravo/erpCommon/ad_forms/DocOrderTemplate.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocOrderTemplate.java	Mon May 04 11:15:38 2009 +0200
@@ -30,9 +30,6 @@
 
   /**
    * Constructor
-   * 
-   * @param AD_Client_ID
-   *          AD_Client_ID
    */
   public DocOrderTemplate() {
   }
--- a/src/org/openbravo/erpCommon/ad_forms/DocPayment.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocPayment.java	Mon May 04 11:15:38 2009 +0200
@@ -40,7 +40,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          AD_Client_ID
    */
@@ -55,7 +55,7 @@
 
   /**
    * Load Specific Document Details
-   *
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -71,7 +71,7 @@
 
   /**
    * Load Payment Line. Settlement Cancel
-   *
+   * 
    * @return DocLine Array
    */
   private DocLine[] loadLines(ConnectionProvider conn) {
@@ -124,7 +124,7 @@
 
   /**
    * Get Source Currency Balance - always zero
-   *
+   * 
    * @return Zero (always balanced)
    */
   public BigDecimal getBalance() {
@@ -134,9 +134,9 @@
 
   /**
    * Create Facts (the accounting logic) for STT, APP.
-   *
+   * 
    * <pre>
-   *
+   * 
    *  Flow:
    *    1. Currency conversion variations
    *    2. Non manual DPs in settlement
@@ -147,9 +147,9 @@
    *    4. Conceptos contables (manual sett and cancelation DP)
    *    5. Writeoff
    *    6. Bank in transit
-   *
+   * 
    * </pre>
-   *
+   * 
    * @param as
    *          accounting schema
    * @return Fact
@@ -167,7 +167,7 @@
             .newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-       	log4j.error("Error while creating new instance for DocPaymentTemplate - " + e);
+        log4j.error("Error while creating new instance for DocPaymentTemplate - " + e);
       }
     }
     if (log4j.isDebugEnabled())
@@ -444,9 +444,9 @@
 
   /**
    * Get the account for Accounting Schema
-   *
-   * @param AcctType
-   *          see ACCTTYPE_*
+   * 
+   * @param cBPartnerId
+   *          business partner id
    * @param as
    *          accounting schema
    * @return Account
@@ -491,8 +491,8 @@
 
   /**
    * Get the account for Accounting Schema
-   *
-   * @param BankStatement
+   * 
+   * @param strcBankstatementlineId
    *          Line
    * @param as
    *          accounting schema
@@ -531,8 +531,8 @@
 
   /**
    * Get the account for Accounting Schema
-   *
-   * @param Cash
+   * 
+   * @param strcCashlineId
    *          Line Id
    * @param as
    *          accounting schema
@@ -580,8 +580,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
--- a/src/org/openbravo/erpCommon/ad_forms/DocPaymentTemplate.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocPaymentTemplate.java	Mon May 04 11:15:38 2009 +0200
@@ -30,9 +30,6 @@
 
   /**
    * Constructor
-   * 
-   * @param AD_Client_ID
-   *          AD_Client_ID
    */
   public DocPaymentTemplate() {
   }
--- a/src/org/openbravo/erpCommon/ad_forms/DocProduction.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocProduction.java	Mon May 04 11:15:38 2009 +0200
@@ -38,7 +38,7 @@
 
   /**
    * Constructor
-   *
+   * 
    * @param AD_Client_ID
    *          AD_Client_ID
    */
@@ -53,9 +53,7 @@
 
   /**
    * Load Specific Document Details
-   *
-   * @param rs
-   *          result set
+   * 
    * @return true if loadDocumentType was set
    */
   public boolean loadDocumentDetails(FieldProvider[] data, ConnectionProvider conn) {
@@ -72,7 +70,7 @@
 
   /**
    * Load Lines.
-   *
+   * 
    * @return DocLine Array
    */
   private DocLine[] loadLines(ConnectionProvider conn) {
@@ -108,7 +106,7 @@
 
   /**
    * Get Source Currency Balance - always zero
-   *
+   * 
    * @return Zero (always balanced)
    */
   public BigDecimal getBalance() {
@@ -119,7 +117,7 @@
 
   /**
    * Create Facts (the accounting logic) for
-   *
+   * 
    * @param as
    *          accounting schema
    * @return Fact
@@ -137,7 +135,7 @@
             .newInstance();
         return newTemplate.createFact(this, as, conn, con, vars);
       } catch (Exception e) {
-       	log4j.error("Error while creating new instance for DocProductionTemplate - " + e);
+        log4j.error("Error while creating new instance for DocProductionTemplate - " + e);
       }
     }
     log4j.debug("createFact - Inicio");
@@ -220,8 +218,8 @@
 
   /**
    * Get the account for Accounting Schema
-   *
-   * @param as
+   * 
+   * @param M_Warehouse_ID
    *          warehouse
    * @param as
    *          accounting schema
@@ -255,8 +253,8 @@
 
   /**
    * Get Document Confirmation
-   *
-   * @not used
+   * 
+   * not used
    */
   public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
     return true;
--- a/src/org/openbravo/erpCommon/ad_forms/DocProductionTemplate.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/DocProductionTemplate.java	Mon May 04 11:15:38 2009 +0200
@@ -30,9 +30,6 @@
 
   /**
    * Constructor
-   * 
-   * @param AD_Client_ID
-   *          AD_Client_ID
    */
   public DocProductionTemplate() {
   }
--- a/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java	Mon May 04 11:15:38 2009 +0200
@@ -1429,7 +1429,7 @@
    * @param hasMCampaign
    * @param hasSRegion
    * @param bCreateAccounting
-   * @return
+   * @return the error. "" if there is no error
    */
 
   public String createReferenceData(Connection conn, VariablesSecureApp vars, String strClient,
--- a/src/org/openbravo/erpCommon/ad_forms/InitialOrgSetup.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/InitialOrgSetup.java	Mon May 04 11:15:38 2009 +0200
@@ -1036,7 +1036,7 @@
    * @param hasMCampaign
    * @param hasSRegion
    * @param strCreateAccounting
-   * @return
+   * @return the error. "" if there is no error
    */
   public String createReferenceData(VariablesSecureApp vars, String strOrganization,
       String strClient, String strModules, boolean hasProduct, boolean hasBPartner,
--- a/src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java	Mon May 04 11:15:38 2009 +0200
@@ -33,9 +33,6 @@
 public class TranslationHandler extends DefaultHandler {
   /**
    * Translation Handler
-   * 
-   * @param AD_Client_ID
-   *          only certain client if id >= 0
    */
 
   public TranslationHandler(ConnectionProvider cDB) {
--- a/src/org/openbravo/erpCommon/ad_process/AcctServerProcess.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_process/AcctServerProcess.java	Mon May 04 11:15:38 2009 +0200
@@ -134,14 +134,19 @@
   }
 
   /**
-   * @param texto
+   * Adds a message to the log.
+   * 
+   * @param msg
+   *          to add to the log
    */
   public void addLog(String msg) {
     addLog(msg, true);
   }
 
   /**
-   * @param texto
+   * Add a message to the log.
+   * 
+   * @param msg
    * @param generalLog
    */
   public void addLog(String msg, boolean generalLog) {
@@ -159,9 +164,12 @@
   }
 
   /**
+   * Saves the log as a note.
+   * 
    * @param adNoteId
+   *          the note id, if passed as null then a new one is created
    * @param adClientId
-   * @return
+   * @return the id of the note if a new one is created (if passed as null)
    */
   public String saveLog(String adNoteId, String adClientId) {
     String strMessage = "", strNewMessage = "";
--- a/src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java	Mon May 04 11:15:38 2009 +0200
@@ -75,7 +75,7 @@
   }
 
   /**
-   * @return
+   * @return true if heart beat is enabled, false otherwise
    */
   public boolean isHeartbeatActive() {
     String isheartbeatactive = SystemInfo.get(SystemInfo.Item.ISHEARTBEATACTIVE);
@@ -85,7 +85,7 @@
 
   /**
    * @param connection
-   * @return
+   * @return true if there is a connection to the internet, false otherwise
    * @throws ServletException
    */
   public static boolean isInternetAvailable(ConnectionProvider connection) throws ServletException {
@@ -107,7 +107,7 @@
 
   /**
    * @param connection
-   * @return
+   * @return the system info as properties
    * @throws ServletException
    */
   public Properties getSystemInfo(ConnectionProvider connection) throws ServletException {
@@ -119,7 +119,7 @@
    * Converts properties into a UTF-8 encoded query string.
    * 
    * @param props
-   * @return
+   * @return the UTF-8 encoded query string
    */
   public String createQueryStr(Properties props) {
     logger.logln(logger.messageDb("HB_QUERY", ctx.getLanguage()));
@@ -140,7 +140,7 @@
    * Sends a query string to the heartbeat server. Returns the https response as a string.
    * 
    * @param queryStr
-   * @return
+   * @return the result of sending the info
    * @throws IOException
    * @throws GeneralSecurityException
    */
@@ -192,7 +192,7 @@
 
   /**
    * @param response
-   * @return
+   * @return the list of updates
    */
   public List<Alert> parseUpdates(String response) {
     logger.logln(logger.messageDb("HB_UPDATES", ctx.getLanguage()));
--- a/src/org/openbravo/erpCommon/businessUtility/AccountTree.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/businessUtility/AccountTree.java	Mon May 04 11:15:38 2009 +0200
@@ -59,7 +59,6 @@
    *          Array of accounts.
    * @param _elementValueParent
    *          String with the value of the parent element to evaluate.
-   * @var forms: Array of accounts with its operands.
    * @throws ServletException
    */
   public AccountTree(VariablesSecureApp _vars, ConnectionProvider _conn,
@@ -76,6 +75,7 @@
     resultantAccounts = updateTreeQuantitiesSign(null, 0, "D");
     // Calculating forms for every elements
     if (resultantAccounts != null && resultantAccounts.length > 0) {
+      // forms: Array of accounts with its operands.
       AccountTreeData[] forms = AccountTreeData.selectForms(conn, Utility.getContext(conn, vars,
           "#User_Org", "AccountTree"), Utility
           .getContext(conn, vars, "#User_Client", "AccountTree"));
@@ -97,7 +97,6 @@
    * @param _elementValueParent
    *          Array with the value of the parent elements to evaluate (For example, first expenses
    *          then revenues) Objective tree.
-   * @var forms: Array of accounts with its operands.
    * @throws ServletException
    */
   public AccountTree(VariablesSecureApp _vars, ConnectionProvider _conn,
@@ -115,6 +114,7 @@
     resultantAccounts = updateTreeQuantitiesSign(null, 0, "D");
 
     if (resultantAccounts != null && resultantAccounts.length > 0) {
+      // Array of accounts with its operands.
       // Calculating forms for every elements
       AccountTreeData[] forms = AccountTreeData.selectForms(conn, Utility.getContext(conn, vars,
           "#User_Org", "AccountTree"), Utility
@@ -690,8 +690,6 @@
 
   /**
    * Resets amounts of subaccounts which parents have been reset because of show value condition
-   * 
-   * @return
    */
   public void filterSVC() {
     if (log4j.isDebugEnabled())
--- a/src/org/openbravo/erpCommon/businessUtility/WindowTabs.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/businessUtility/WindowTabs.java	Mon May 04 11:15:38 2009 +0200
@@ -117,8 +117,8 @@
    *          Object with the database connection methods.
    * @param _vars
    *          Object with the session information.
-   * @param _className
-   *          String with the form's classname.
+   * @param adProcessId
+   *          the id of the process.
    * @throws Exception
    */
   public WindowTabs(ConnectionProvider _conn, VariablesSecureApp _vars, int adProcessId)
--- a/src/org/openbravo/erpCommon/modules/ImportModule.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/modules/ImportModule.java	Mon May 04 11:15:38 2009 +0200
@@ -129,7 +129,7 @@
   }
 
   /**
-   * Check the dependencies for a file name. See {@link checkDependenciesId}
+   * Check the dependencies for a file name. See {@link #checkDependenciesId(String[], String[])}.
    */
   public boolean checkDependenciesFileName(String fileName) throws Exception {
     final File file = new File(fileName);
@@ -176,7 +176,7 @@
   }
 
   /**
-   * Check the dependencies for a file. See {@link checkDependenciesId}
+   * Check the dependencies for a file. See {@link #checkDependenciesId(String[], String[])}.
    */
   public boolean checkDependenciesFile(InputStream file) throws Exception {
     if (installLocally) {
@@ -1006,7 +1006,7 @@
    * 
    * @param conn
    * @param vars
-   * @return
+   * @return the list of updates keyed by module id
    */
   public static HashMap<String, String> scanForUpdates(ConnectionProvider conn,
       VariablesSecureApp vars) {
@@ -1139,7 +1139,7 @@
    * Returns the module with the ID that is in the module to install or update.
    * 
    * @param moduleID
-   * @return
+   * @return the module with the moduleID, or null if not found
    */
   public Module getModule(String moduleID) {
     for (int i = 0; i < modulesToInstall.length; i++) {
--- a/src/org/openbravo/erpCommon/modules/ModuleReferenceDataClientTree.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/modules/ModuleReferenceDataClientTree.java	Mon May 04 11:15:38 2009 +0200
@@ -41,7 +41,7 @@
    * Constructor to generate a root tree
    * 
    * @param base
-   * @param small
+   * @param bSmall
    *          Normal size or small size (true)
    */
   public ModuleReferenceDataClientTree(HttpBaseServlet base, boolean bSmall) {
@@ -87,7 +87,7 @@
    * Returns a HTML with the description for the given node
    * 
    * @param node
-   * @return
+   * @return a HTML String with the description for the given node
    */
   public String getHTMLDescription(String node) {
     try {
--- a/src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree.java	Mon May 04 11:15:38 2009 +0200
@@ -57,12 +57,13 @@
    * Constructor to generate a root tree
    * 
    * @param base
-   * @param bSmall
-   *          Normal size or small size (true)
    * @param strClient
    *          Client ID
    * @param strOrg
    *          Org ID
+   * @param bAddLinks
+   *          if true then adds links to the current sets of nodes, these links can be Update or
+   *          Apply
    */
   public ModuleReferenceDataOrgTree(HttpBaseServlet base, String strClient, String strOrg,
       boolean bAddLinks) {
@@ -88,7 +89,7 @@
   }
 
   /**
-   * sets to data the root tree
+   * Sets to data the root tree.
    */
   public void setRootTree(String strClient, String strOrg, boolean bAddLinks) {
     try {
@@ -105,7 +106,7 @@
   }
 
   /**
-   * Adds links to the current sets of nodes, these links can be Update or Apply
+   * Adds links to the current sets of nodes, these links can be Update or Apply.
    */
   private void addLinks() {
     addLinks((ModuleReferenceDataOrgTreeData[]) data, false);
@@ -141,7 +142,7 @@
    * Returns a HTML with the description for the given node
    * 
    * @param node
-   * @return
+   * @return a HTML String with the description for the given node
    */
   public String getHTMLDescription(String node) {
     try {
--- a/src/org/openbravo/erpCommon/modules/ModuleTree.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/modules/ModuleTree.java	Mon May 04 11:15:38 2009 +0200
@@ -48,7 +48,7 @@
    * Constructor to generate a root tree
    * 
    * @param base
-   * @param small
+   * @param bSmall
    *          Normal size or small size (true)
    */
   public ModuleTree(HttpBaseServlet base, boolean bSmall) {
@@ -99,7 +99,7 @@
    * Returns a HTML with the description for the given node
    * 
    * @param node
-   * @return
+   * @return a HTML String with the description for the given node
    */
   public String getHTMLDescription(String node) {
     try {
--- a/src/org/openbravo/erpCommon/modules/UninstallModule.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/modules/UninstallModule.java	Mon May 04 11:15:38 2009 +0200
@@ -199,7 +199,7 @@
   /**
    * Returns a OBError instance obtained from the current log
    * 
-   * @return
+   * @return a new instance of OBError if the log has messages, null otherwise
    */
   public OBError getOBError() {
     if (log.length() != 0) {
--- a/src/org/openbravo/erpCommon/modules/VersionUtility.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/modules/VersionUtility.java	Mon May 04 11:15:38 2009 +0200
@@ -463,9 +463,7 @@
    * 
    * @param moduleVersionId
    *          In param. An String array with the modules version ids, that we want to install.
-   * @param modulesToInstall
-   *          Out param. New modules that is necessary to install.
-   * @param modulesToUpdate
+   * @param moduleVersionToUpdateId
    *          Out param. Modules that need an update.
    * @param obErrors
    *          Out param. Errors in dependencies. Null if no errors.
--- a/src/org/openbravo/erpCommon/utility/FieldProviderFactory.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/utility/FieldProviderFactory.java	Mon May 04 11:15:38 2009 +0200
@@ -88,7 +88,7 @@
    * Returns a FieldProvider for the getter methods of object
    * 
    * @param obj
-   * @return
+   * @return the FieldProvider for the passed obj.
    */
   public static FieldProvider getFieldProvider(Object obj) {
     return new FieldProviderFactory(obj);
@@ -98,7 +98,7 @@
    * Returns an array of FieldProvider objects for the getter methods of the objects
    * 
    * @param obj
-   * @return
+   * @return an array of FieldProviders for each of the objects in the passed array
    */
   public static FieldProvider[] getFieldProviderArray(Object[] obj) {
     FieldProvider[] rt = new FieldProviderFactory[obj.length];
--- a/src/org/openbravo/erpCommon/utility/GenericTree.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/utility/GenericTree.java	Mon May 04 11:15:38 2009 +0200
@@ -88,7 +88,7 @@
    * 
    * @param node
    *          Node ID to retrieve description
-   * @return: The String with the HTML for the description
+   * @return The String with the HTML for the description
    */
   public abstract String getHTMLDescription(String node);
 
@@ -146,9 +146,7 @@
   }
 
   /**
-   * Returns a String with the HTML with all the structure for the tree.
-   * 
-   * @return
+   * @return a String with the HTML with all the structure for the tree.
    */
   public String toHtml() {
     if (data == null || data.length == 0)
@@ -324,9 +322,7 @@
   }
 
   /**
-   * Returns data
-   * 
-   * @return
+   * @return the data
    */
   public FieldProvider[] getData() {
     return data;
--- a/src/org/openbravo/erpCommon/utility/SystemInfo.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/utility/SystemInfo.java	Mon May 04 11:15:38 2009 +0200
@@ -244,7 +244,7 @@
   }
 
   /**
-   * @return
+   * @return the all systemInfo properties
    */
   public static Properties getSystemInfo() {
     Properties props = new Properties();
@@ -265,7 +265,7 @@
    * return '1.7.0'
    * 
    * @param str
-   * @return
+   * @return the string representation of a numerical version from a longer string.
    */
   public static String getVersion(String str) {
     String version = "";
@@ -281,7 +281,7 @@
 
   /**
    * @param item
-   * @return
+   * @return the systemInfo of the passed item
    */
   public static String get(Item item) {
     return systemInfo.get(item);
--- a/src/org/openbravo/erpCommon/utility/TableSQLData.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/utility/TableSQLData.java	Mon May 04 11:15:38 2009 +0200
@@ -1047,7 +1047,7 @@
    * vector
    * 
    * @param v
-   * @return
+   * @return a cleaned vector of Strings
    */
   public Vector<String> cleanVector(Vector<String> v) {
     Vector<String> result = new Vector<String>();
--- a/src/org/openbravo/erpCommon/utility/Utility.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/utility/Utility.java	Mon May 04 11:15:38 2009 +0200
@@ -387,7 +387,7 @@
    *          Handler for the session info.
    * @param context
    *          String with the parameter to search.
-   * @param window
+   * @param strWindow
    *          String with the window id.
    * @param accessLevel
    * @return String with the value.
@@ -501,7 +501,7 @@
    * 
    * @param vars
    * @param currentOrg
-   * @return
+   * @return comma delimited Stirng of referenceable organizations.
    */
   public static String getReferenceableOrg(VariablesSecureApp vars, String currentOrg) {
     final OrgTree tree = (OrgTree) vars.getSessionObject("#CompleteOrgTree");
@@ -518,7 +518,7 @@
    * @param currentOrg
    * @param window
    * @param accessLevel
-   * @return
+   * @return the list of referenceable organizations, comma delimited
    */
   public static String getReferenceableOrg(ConnectionProvider conn, VariablesSecureApp vars,
       String currentOrg, String window, int accessLevel) {
@@ -541,7 +541,7 @@
    *          Handler for the database connection
    * @param vars
    * @param currentOrg
-   * @return
+   * @return the organization list for selectors
    */
   public static String getSelectorOrgs(ConnectionProvider conn, VariablesSecureApp vars,
       String currentOrg) {
@@ -564,7 +564,7 @@
    *          String with the parameter.
    * @param window
    *          String with the window id.
-   * @param defaultValueString
+   * @param defaultValue
    *          with the default value.
    * @param sessionData
    *          FieldProvider with the data stored in session
@@ -623,7 +623,7 @@
    * Returns a Vector<String> composed by the comma separated elements in String s
    * 
    * @param s
-   * @return
+   * @return the list of String obtained by converting the comma delimited String
    */
   public static Vector<String> getStringVector(String s) {
     final Vector<String> v = new Vector<String>();
@@ -641,7 +641,7 @@
    * 
    * @param v1
    * @param v2
-   * @return
+   * @return the combination of v1 and v2 without duplicates
    */
   public static Vector<String> getIntersectionVector(Vector<String> v1, Vector<String> v2) {
     final Vector<String> v = new Vector<String>();
@@ -656,7 +656,7 @@
    * Returns the elements in Vector v as an String separating with commas the elements
    * 
    * @param v
-   * @return
+   * @return a comma delimited String
    */
   public static String getVectorToString(Vector<String> v) {
     final StringBuffer s = new StringBuffer();
@@ -1027,7 +1027,6 @@
    * @deprecated
    * @param SQL
    * @param fields
-   * @return
    */
   @Deprecated
   public static String getOrderByFromSELECT(String[] SQL, Vector<String> fields) {
@@ -1450,7 +1449,7 @@
    * 
    * @param strList
    *          List to check in
-   * @param strClient
+   * @param strElement
    *          Element to check in the list
    * @return true in case the element is in the list
    */
@@ -1482,13 +1481,13 @@
   }
 
   /**
-   * Write the output to a file
+   * Write the output to a file. It creates a file in the file location writing the content of the
+   * outputstream.
    * 
    * @param fileLocation
    *          the file where you are going to write
    * @param outputstream
    *          the data source
-   * @return nothing. It creates a file in the file location writing the content of the outputstream
    */
   public static void dumpFile(String fileLocation, OutputStream outputstream) {
     final byte dataPart[] = new byte[4096];
@@ -1507,7 +1506,7 @@
    * Returns a string list comma separated as SQL strings.
    * 
    * @param list
-   * @return
+   * @return comma delimited quoted string
    */
   public static String stringList(String list) {
     String ret = "";
@@ -1779,10 +1778,10 @@
   }
 
   /**
-   * Trasnforms an ArrayList to a String comma separated
+   * Transforms an ArrayList to a String comma separated.
    * 
    * @param list
-   * @return
+   * @return a comma separated String containing the contents of the array.
    */
   public static String arrayListToString(ArrayList<String> list, boolean addQuotes) {
     String rt = "";
@@ -1797,7 +1796,7 @@
    * Transforms a comma separated String into an ArrayList
    * 
    * @param list
-   * @return
+   * @return the list representation of the comma delimited String
    */
   public static ArrayList<String> stringToArrayList(String list) {
     final ArrayList<String> rt = new ArrayList<String>();
@@ -1813,7 +1812,7 @@
    * Transforms a String[] into an ArrayList
    * 
    * @param list
-   * @return
+   * @return the list representation of the array
    */
   public static ArrayList<String> stringToArrayList(String[] list) {
     final ArrayList<String> rt = new ArrayList<String>();
@@ -2156,7 +2155,7 @@
    *          Id for the tab to obtain the url for
    * @param type
    *          "R" -> Relation, "E" -> Edition, "X" -> Excel
-   * @return
+   * @return the complete URL for a tab.
    */
   public static String getTabURL(HttpSecureAppServlet servlet, String tabId, String type) {
     if (!(type.equals("R") || type.equals("E") || type.equals("X")))
--- a/src/org/openbravo/erpCommon/utility/VerticalMenu.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/erpCommon/utility/VerticalMenu.java	Mon May 04 11:15:38 2009 +0200
@@ -375,7 +375,8 @@
    * 
    * @param vars
    * @param open
-   * @return
+   * @return the search folder and entries in case there is at least one accessible entrie, other
+   *         case it returns an empty string
    * @throws ServletException
    */
   public String generateMenuSearchs(VariablesSecureApp vars, boolean open) throws ServletException {
@@ -428,13 +429,13 @@
   }
 
   /**
-   * Generates a table of entries for all the accessible search entries
+   * Generates a table of entries for all the accessible search entries.
    * 
    * @param vars
    * @param direccion
    * @param open
    * @param data
-   * @return
+   * @return the table of entries for all accessible search entries
    * @throws ServletException
    */
   public String generateMenuSearchEntries(VariablesSecureApp vars, String direccion, boolean open,
--- a/src/org/openbravo/scheduling/DefaultJob.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/scheduling/DefaultJob.java	Mon May 04 11:15:38 2009 +0200
@@ -38,7 +38,7 @@
   static Logger log = Logger.getLogger(DefaultJob.class);
 
   /**
-   * {@inheritDoc}
+   * See the execute method of the Quartz Job class.
    */
   public void execute(JobExecutionContext jec) throws JobExecutionException {
     final ProcessBundle bundle = (ProcessBundle) jec.getMergedJobDataMap().get(ProcessBundle.KEY);
--- a/src/org/openbravo/scheduling/OBScheduler.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/scheduling/OBScheduler.java	Mon May 04 11:15:38 2009 +0200
@@ -69,7 +69,7 @@
   }
 
   /**
-   * @return
+   * @return the singleton instance of this class
    */
   public static final OBScheduler getInstance() {
     return INSTANCE;
@@ -151,8 +151,9 @@
    * saved to AD_PROCESS_REQUEST before reaching this method.
    * 
    * @param requestId
+   *          the id of the request, the Quartz jobDetail name
    * @param bundle
-   * @param jobClass
+   *          the context bundle
    * @throws SchedulerException
    */
   public void schedule(String requestId, ProcessBundle bundle) throws SchedulerException,
@@ -218,7 +219,7 @@
 
   /**
    * @param date
-   * @return
+   * @return the date as a formatted string
    */
   public static final String format(Date date) {
     return date == null ? null : new SimpleDateFormat(dateTimeFormat).format(date);
--- a/src/org/openbravo/scheduling/ProcessBundle.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/scheduling/ProcessBundle.java	Mon May 04 11:15:38 2009 +0200
@@ -282,7 +282,7 @@
    *          VariablesSecureApp to be converted into the ProcessContext
    * @param conn
    *          ConnectionProvider
-   * @return
+   * @return a new instance of this class created from the pInstance record in the db
    * @throws ServletException
    */
   public static final ProcessBundle pinstance(String pinstanceId, VariablesSecureApp vars,
--- a/src/org/openbravo/scheduling/ProcessContext.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/scheduling/ProcessContext.java	Mon May 04 11:15:38 2009 +0200
@@ -97,7 +97,11 @@
   }
 
   /**
-   * @return
+   * @return a new instance of {@link VariablesSecureApp} created from the client, organization and
+   *         user.
+   * @see #getClient()
+   * @see #getOrganization()
+   * @see #getUser()
    */
   public VariablesSecureApp toVars() {
     return new VariablesSecureApp(user, client, organization);
@@ -232,7 +236,8 @@
 
   /**
    * @param arg0
-   * @return
+   *          the xml to create the process context from
+   * @return a new instance created from the string argument (an xml definition)
    */
   public synchronized static ProcessContext newInstance(String arg0) {
     if (arg0 == null || arg0.trim().equals("")) {
--- a/src/org/openbravo/scheduling/ProcessLogger.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/scheduling/ProcessLogger.java	Mon May 04 11:15:38 2009 +0200
@@ -21,23 +21,37 @@
   }
 
   /**
+   * Returns an i18n-ed message String from the database.
+   * 
    * @param msgKey
-   * @return
+   *          the message id
+   * @param language
+   *          the language to be used to query for the message
+   * @return the message retrieved from the db, using the msgKey and language
    */
   public String messageDb(String msgKey, String language) {
     return Utility.messageBD(connection, msgKey, language);
   }
 
   /**
+   * Log a message.
+   * 
    * @param msg
-   * @param log
+   *          the message to log
+   * 
+   * @see #getLog()
    */
   public void log(String msg) {
     log.append(new Timestamp(System.currentTimeMillis()).toString() + " - " + msg);
   }
 
   /**
+   * Log a message with an additional newline character.
+   * 
    * @param msg
+   *          the message to log
+   * 
+   * @see #getLog()
    */
   public void logln(String msg) {
     log(msg + "\n");
--- a/src/org/openbravo/scheduling/ProcessMonitor.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/scheduling/ProcessMonitor.java	Mon May 04 11:15:38 2009 +0200
@@ -207,22 +207,24 @@
   }
 
   /**
-   * @return
+   * @return the database Connection Provider
    */
   public ConnectionProvider getConnection() {
     return (ConnectionProvider) context.get(ConnectionProviderContextListener.POOL_ATTRIBUTE);
   }
 
   /**
-   * @return
+   * @return the configuration parameters.
    */
   public ConfigParameters getConfigParameters() {
     return (ConfigParameters) context.get(ConfigParameters.CONFIG_ATTRIBUTE);
   }
 
   /**
+   * Formats a date according to the data time format.
+   * 
    * @param date
-   * @return
+   * @return a formatted date
    */
   public final String format(Date date) {
     final String dateTimeFormat = getConfigParameters().getJavaDateTimeFormat();
@@ -230,8 +232,11 @@
   }
 
   /**
+   * Converts a duration in millis to a String
+   * 
    * @param duration
-   * @return
+   *          the duration in millis
+   * @return a String representation of the duration
    */
   public static String getDuration(long duration) {
 
--- a/src/org/openbravo/scheduling/ProcessRunner.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/scheduling/ProcessRunner.java	Mon May 04 11:15:38 2009 +0200
@@ -47,9 +47,10 @@
   }
 
   /**
-   * @param process
-   * @param vars
+   * Execute this process.
+   * 
    * @param conn
+   *          the database connection
    * @throws ServletException
    */
   public String execute(ConnectionProvider conn) throws ServletException {
--- a/src/org/openbravo/service/dataset/DataSetService.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/service/dataset/DataSetService.java	Mon May 04 11:15:38 2009 +0200
@@ -183,7 +183,7 @@
   /**
    * Returns a list of DataSet tables instances on the basis of the DataSet
    * 
-   * @param DataSet
+   * @param dataSet
    *          the DataSet for which the list of tables is required
    * @return the DataSetTables of the DataSet
    * @deprecated use dataSet.getDataSetTableList()
@@ -209,7 +209,7 @@
   /**
    * Determines which objects are exportable using the DataSetTable whereClause.
    * 
-   * @param DataSetTable
+   * @param dataSetTable
    *          the dataSetTable defines the Entity and the whereClause to use
    * @param moduleId
    *          the moduleId is a parameter in the whereClause
--- a/src/org/openbravo/service/db/ClientImportEntityResolver.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/service/db/ClientImportEntityResolver.java	Mon May 04 11:15:38 2009 +0200
@@ -46,11 +46,19 @@
     return OBProvider.getInstance().get(ClientImportEntityResolver.class);
   }
 
-  // searches for a previous entity with the same id or an id retrieved from
-  // the ad_ref_data_loaded table. The resolving takes into account different
-  // access levels and
   /**
-   * @see @EntityResolver
+   * Searches for a existing entity with the same id. Only searches on system level.
+   * 
+   * @param entityName
+   *          the name of the entity to resolve
+   * @param id
+   *          the id
+   * @param referenced
+   *          is true if the entity needs to be resolved because it is referenced from imported
+   *          data, is false if the entity is part of the main imported dataset
+   * 
+   * @see BaseOBObject#getEntityName()
+   * @see EntityResolver#resolve(String, String, boolean)
    */
   @Override
   public BaseOBObject resolve(String entityName, String id, boolean referenced) {
--- a/src/org/openbravo/service/db/ClientImportProcessor.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/service/db/ClientImportProcessor.java	Mon May 04 11:15:38 2009 +0200
@@ -73,7 +73,7 @@
   /**
    * Always returns the importedValue without changing it.
    * 
-   * @see EntityXMLProcessor#replaceValue(BaseOBObject, String, Object)
+   * @see EntityXMLProcessor#replaceValue(BaseOBObject, Property, Object)
    */
   public Object replaceValue(BaseOBObject owner, Property property, Object importedValue) {
     return importedValue;
--- a/src/org/openbravo/service/db/DataExportService.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/service/db/DataExportService.java	Mon May 04 11:15:38 2009 +0200
@@ -112,8 +112,8 @@
    *          the parameter name ClientID (note is case sensitive)
    * @param out
    *          the xml is written to this writer
-   * @see CLIENT_DATA_SET_NAME
-   * @see CLIENT_ID_PARAMETER_NAME
+   * @see #CLIENT_DATA_SET_NAME
+   * @see #CLIENT_ID_PARAMETER_NAME
    */
   public void exportClientToXML(Map<String, Object> parameters, boolean exportAuditInfo, Writer out) {
     DataSet dataSet = null;
--- a/src/org/openbravo/service/db/DataImportService.java	Sun May 03 22:10:02 2009 -0400
+++ b/src/org/openbravo/service/db/DataImportService.java	Mon May 04 11:15:38 2009 +0200
@@ -127,11 +127,10 @@
    * client and organization of the data in the import file itself. In addition no unique-constraint
    * checking is done.
    * 
-   * @param xml
-   *          the xml string containing the objects to import
    * @param importProcessor
-   *          the importProcessor is called after the xml has been parsed and before the new/updated
-   *          objects are persisted in the database, is allowed to be null
+   *          the import processor which is called for each object after the import
+   * @param importAuditInfo
+   *          if true then the auditInfo (updated, updatedBy etc.) is also imported.
    * @param reader
    *          the xml stream
    *