Related to issue 33460: Temporary backout till API change is approved

Fixed issue 33460: code review improvements

Avoid NullPointerException in non-compartive mode
In JasperReport:
* Band height for details restored to 15, so we have the same number of lines as before the change
* Period N-1 label only shown in comparative mode

Fixes issue 33460 : New field for comparing ref year in Balance sheet & PL rep.

New field "Compare To" created to have reference year as optional
Code reference from org.openbravo.report.improved.balancesheet module.

Fixes issue 33489: Can't post CAD if period was created previous to 3.0PR14Q4

Cost Adjustments feature was included in Openbravo 3.0PR14Q4, so periods created in lower versions doesn't includes the Cost Adjustment Document. When the instance is upgrated, these periods was not updated and it causes that CAD can't be posted. To include this document to all these periods was updated the CreateAccountingConfiguration module script to take into account control periods that has not included the CAD. Also was updated the Module Script Execution Limits to the 29718 version.

Fixes issue 33620: Removes UNION ALL from view and merges it into one sentece

Fixes issue 33553: Avoid division by zero error in Standard Costs Report

A Division by zero error in Standard Costs Report was happening if Decrease or Rejected fields are 0 for produced products in the Process Plan. To avoid it, a validation was included to the report.

related to issue 33588: reverting field name wrongly changed

related to issue 33588: updated lazy filterting description and help

fixes issue 33588: extra DS calls having summary functions and lazy filtering

When working with the grid having summary functions, several flows were performing datasource requests for recalculating the summaries:
- Open a tab having a grid that already contains a summary function.
- After saving a new record
- After updating an existing record
- After deleting a record
- After switching into form view and saving the record
- After selecting/replacing a summary function

Having the summary row displayed during those actions, Smartclient was recalculating the grid automatically. Now, if the lazy filtering is enabled, the summary row is hidden to prevent the recalculation. Thus, the summary function will be recalculated once the filter/sorting action is requested by the user.

Fixes issue 33627: debug call in OBCriteria.count does trigger extra db query in some case
Wrap log.debug in if statement

Related to issue 33550: Code review improvements

Remove unused OrganizationStructureProvider.
Remove duplicated method.
Remove orgId1 parameter as it can be calculated inside the query.

Fixes issue 33550: Error voiding an invoice if bp doesn't have default account

Method used to get the default financial account (getFinancialAccountPaymentMethod) was not taking into account the natural tree of the organization of document being processed, always was ordering by "default" account and when the query returns more than one results, if the first record's account does not belong to the natural tree of the entity's organization (in this case invoice's organization) validation was failing and an error message was shown.

To avoid it, was overwritten the getFinancialAccountPaymentMethod method of the FIN_Utility class to also filtering by financial accounts belonging to the natural tree of the entity's organization. Was necessary to adapt other classes using this method to work correctly.

Related to issue 33544: Remove APRM tests from AllAntTaskTests until are stable

fixes issue 33618: Unneeded datasource requests having summary functions
After editing a record in grid view, having summary functions, several DS request were fired. This was happening when processing the FIC return: setting the values for each field was causing a datasource call for refreshing the summaries, because Smartclient detected that the grid summary record was displayed. This wrong behavior also affected when editing manually the fields in grid view.
To fix this problem, if the summary record is displayed, we prevent those calls by setting the showGridSummary property of the grid to false, therefore Smartclient will not fire those unneeded requests. And once the edit function has finished we restore the value.

Together with this, there were some additional requests being fired when saving/updating a record in grid view. This was happening because the getSummaryRow() was being used to refresh the summaries but at the same time, the dataChanged function of the grid was indeed doing the same.
To solve this second problem, we just invoke getSummaryRow() when saving a new record in grid view, because this is the only case where the dataChanged function was not firing the request for refreshing the summaries.

Fixes issue 33603 and related to issue 29414: Updated browser supported/recommended list for PR16Q3

* Chrome. Supported 50, Recommended 51 or higher.
* Firefox. Supported 38, Recommended 45 or higher.
* Internet Explorer. Supported 9, Recommended 11 or higher.
* EdgeHTML (MS Edge). Supported 12, Recommended 13 or higher.
* Safari. Supported 7, Recommended 8 or higher.

Fixes issue 33592: Import entry archive should be defined in the log cleanup window
Added log cleanup record for the import entry archive table into reference data

fixes issue 33577: Not possible to translate tooltip message of the date item

The pickerIconPrompt property is now defined for OBDateItem. This was already defined and working fine for the date item displayed in the filters. But the definition of the pickerIconPrompt, fromDateOnlyPrefix and toDateOnlyPrefix was being set twice. Now those properties are set just in the ob-form-styles.js file

Related to issue 33544: Comment some asserts to avoid errors in three tests

Fixes issue 33544: Update old sampledata IDs with new IDs in APRM JUnit tests

Related to issue 33544: Move APRM JUnit tests to src-test project

related to issue 33572: Updated copyright year

fixes issue 33572: Ability to define a Report Template as default

A new field is added to the Report Template tab in the Document Type window. It is a checkbox that can be used to mark a template as default. If a template is marked as default, is the one that will be selected when printing the document. Also a new trigger has been created in order to allow just one default template per document type.

Related to issue 33508: Code review improvements

Set invoiceTaxCashVAT_V variable as private.
Keep getInvoiceTaxCashVAT_V and setInvoiceTaxCashVAT_V methods as deprecated to avoid API change.
Add distinct to setInvoiceTaxCashVAT_V query to avoid retrieve duplicated ids.

Fixes issue 33508: Error posting Cash VAT payment if pays more than one invoice

When trying to post a Cash VAT payment that pays more than one invoice, process was failing and an error was shown. It was caused by a clearing of the session when iterating on the cash vat invoices list. To avoid it, list of cash vat ids are retrieved instead a list of InvoiceTaxCashVAT_V.

Fixed issue 33507: Incorrect Audit info was generated sometimes.

There was a problem when creating audit info data by some sqlc processes, sometimes wrong data was being created. The problem was that when the processes used the getTransactionConnection, the context information table was not correctly set. This table is set by the SessionInfo.setDBSessionInfo method.
To fix this, a call to this method has been added in the ConnectionProviderImpl.getTransactionConnection() and in the DalConnectionProvider.getTransactionConnection().

fixes issue 33476: Wrong behavior in created/updated by filter with saved view

After applying the saved view, regarding the 'Created By' field, the displayField property ('_identifier') of the filter editor was being replaced with the display field of the field itself ('createdBy'). Therefore, after applying the saved view the values being displayed within the filter drop-down were the 'Created By' values for the entity referenced by the 'Created By' field (User). The same applies for the 'Updated By' field.

The root cause of this problem was that the fkField property for 'Created By' and 'Updated By' fields was not set to true. This allows to configure properly the filterEditorProperties on the client side for those fields, including the displayField whose value is set to '_identifier'.

From now the displayField property is set for the 'Created By' and 'Updated By' on the prepareGridFields() function, this way it will not be overridden after applying the saved view.

Fixes issue 33494: Wrong Matched Invoice accounting entry when voiding invoice

"Invoice price variance" account was used because an incorrect way of calculate the expenses, multiplying by -1 was generating differences and accounting unbalances.

Fixes issue 32906: Cannot process an inventory amount update

The "name" field length in m_inventory table was increased to 100 to avoid errors when records are created or updated if the user is logged in with Spanish (Spain) language and translations have more than 60 characters.

fixed 33515: NPE in AQB with associated entities if entity has computed columns

When AdvancedQueryBuilder was used with the joinAssociatedEntities property set
to true and the queried entity included computed columns, a NPE was trhown.

Fixed by treating computed column property as an special case forcing always
a left join for it.

Fixes Issue 33320: Performance problems in Create Lines From process

Problem was with loading invoices and orders in the respective combos.
Changed both queries to improve the performance.