Thu, 18 Feb 2016 14:54:19 +0100fixed issue 32275: jUnit: add capability to assert on logs
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 14:54:19 +0100] rev 28617
fixed issue 32275: jUnit: add capability to assert on logs

TestLogAppender can be used in test cases extending OBBaseTest to perform
assertions on what is logged.

Wed, 10 Feb 2016 22:16:11 -0500Removing File BLOB reference from core
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Wed, 10 Feb 2016 22:16:11 -0500] rev 28616
Removing File BLOB reference from core

Tue, 16 Feb 2016 10:45:01 +0530Fixes Issue 31349:Mongolian language added in reference data.
Atul Gaware <atul.gaware@openbravo.com> [Tue, 16 Feb 2016 10:45:01 +0530] rev 28615
Fixes Issue 31349:Mongolian language added in reference data.

Wed, 17 Feb 2016 15:29:19 +0100fixed issue 32261: implement a typed version of OBDal.getProxy
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 15:29:19 +0100] rev 28614
fixed issue 32261: implement a typed version of OBDal.getProxy

New getProxy method returns a typed instance of the desired entity, making
unnecessary to cast it.

Wed, 17 Feb 2016 13:14:36 +0100fixed bug 32244: ORA error in log when setting an AD column to not null
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 13:14:36 +0100] rev 28613
fixed bug 32244: ORA error in log when setting an AD column to not null

Prevented trying to disable not-null constraints in case the column was already
set as nullable in DB.

Tue, 16 Feb 2016 16:45:34 +0100Merging Backed out changeset 8d06deadd164
Adrián Romero <adrianromero@openbravo.com> [Tue, 16 Feb 2016 16:45:34 +0100] rev 28612
Merging Backed out changeset 8d06deadd164

Tue, 16 Feb 2016 16:43:13 +0100Backed out changeset 8d06deadd164
Adrián Romero <adrianromero@openbravo.com> [Tue, 16 Feb 2016 16:43:13 +0100] rev 28611
Backed out changeset 8d06deadd164

Mon, 08 Feb 2016 22:15:23 +0530Fixes Issue 32136:Wrong warehouse combo validation in the 'Create Purchase
Atul Gaware <atul.gaware@openbravo.com> [Mon, 08 Feb 2016 22:15:23 +0530] rev 28610
Fixes Issue 32136:Wrong warehouse combo validation in the 'Create Purchase
Orders popup in the Purchasing Plan window

Tue, 09 Feb 2016 10:55:14 +0530Fixes Issue 32134:Price Including taxes is not supported by the Purchasing
Atul Gaware <atul.gaware@openbravo.com> [Tue, 09 Feb 2016 10:55:14 +0530] rev 28609
Fixes Issue 32134:Price Including taxes is not supported by the Purchasing
Plan (Create Purchase Orders process)

Wed, 10 Feb 2016 22:16:11 -0500Removing File BLOB reference from core
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Wed, 10 Feb 2016 22:16:11 -0500] rev 28608
Removing File BLOB reference from core

Fri, 12 Feb 2016 15:13:04 +0100Fixed bug 32216: Cash VAT tab with prepaid invoice
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 12 Feb 2016 15:13:04 +0100] rev 28607
Fixed bug 32216: Cash VAT tab with prepaid invoice

The C_INVOICETAX_CASHVAT_V view, which populates the Sales/Purchase Invoice | Cash VAT tab, has been rewritten to properly manage the scenarios of prepaid invoices where the invoice amount is lower than the original order, either because of a partial invoice or because of a cheaper invoice.

The view has been split in 2 queries merged with an union all to improve the performance:
1. The first one searches the Cash VAT records linked to a payment. In this part we only filter by the records linked to the invoice's FPS, which fixes the scenarios raised by the issue.
2. The second one searches the Cash VAT records linked to a manual cash vat settlement. In this part there is no need to join with the payment tables, so the global performance is better.

Tue, 16 Feb 2016 10:15:42 +0100fixes issue 32231: wrong number comparison when checking field access of a role
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 16 Feb 2016 10:15:42 +0100] rev 28606
fixes issue 32231: wrong number comparison when checking field access of a role

When checking the access of a numeric field, if it is an integer, the client sends the value without decimal places. This value is compared with the current value stored in the database which already stores the value with decimals. So, the comparison of the string values determines that they are different as for example we are comparing '100' with '100.00'.

To solve the problem, for this type of fields now the numeric value is compared instead of using its string representation.

Fri, 05 Feb 2016 14:06:10 +0100Fixes issue 31952: Avoid negative reservations
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Feb 2016 14:06:10 +0100] rev 28605
Fixes issue 31952: Avoid negative reservations

Set quantity to zero in case quantity + p_qty is less than zero when updating current m_reservation_stock in M_RESERVE_STOCK_MANUAL, to avoid create negative reservations.

Mon, 15 Feb 2016 19:01:37 +0100Fixes issue 32040: The ExportSampledata task can be extended
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 15 Feb 2016 19:01:37 +0100] rev 28604
Fixes issue 32040: The ExportSampledata task can be extended

The task can now be extended by:
- Defining the dataset to be exported
- Defining how to manage the where clause of the dataset tables
- Defining the DatabaseDataIO implementation to use to export a table to XML
- Defining the folder where the data should be exported to

It is also supported to define a table several times in the same dataset, and each of the dataset tables will be exported to their own xml file.

Tue, 09 Feb 2016 18:39:18 -0500Fixes Issue 32147: Transaction Type and Payment are set read only when the
Nono Carballo <f.carballo@nectus.com> [Tue, 09 Feb 2016 18:39:18 -0500] rev 28603
Fixes Issue 32147: Transaction Type and Payment are set read only when the
transaction is processed.

In Transaction tab of Financial Account window, once the transaction is processed
the fields Transaction Type and Payment are set read only.
The Read Only logic of those fields was set to @Processed@='Y'

Mon, 15 Feb 2016 18:51:09 +0100Related to Issue 31354. Updates copyright Issue.
David Miguelez <david.miguelez@openbravo.com> [Mon, 15 Feb 2016 18:51:09 +0100] rev 28602
Related to Issue 31354. Updates copyright Issue.

Thu, 11 Feb 2016 15:59:45 +0100Fixed bug 32206: Invoice reactivation with Manual Cash VAT Settlement
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 11 Feb 2016 15:59:45 +0100] rev 28601
Fixed bug 32206: Invoice reactivation with Manual Cash VAT Settlement

Avoid to reactivate an invoice linked to a Manual Cash VAT Settlement

Thu, 11 Feb 2016 13:42:35 +0100Fixed bug 32100: Reactivation control of a prepaid cash vat invoice
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 11 Feb 2016 13:42:35 +0100] rev 28600
Fixed bug 32100: Reactivation control of a prepaid cash vat invoice

When an invoice is linked to a payment, the system currently avoids to reactivate it. You first need to reactivate the payment, so the cash vat information is deleted, and then you can reactivate the invoice.
However for prepaid invoices, the system does allow to reactivate the invoice, but the cash vat information is wrongly kept.

Now we delete all the cash vat info records linked to a prepayment for this invoice at invoice reactivation time. When the invoice is latter on processed, the cash vat records will be calculated again.

Fri, 12 Feb 2016 11:04:34 +0100related to issue 32110: include version in fop library name
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 12 Feb 2016 11:04:34 +0100] rev 28599
related to issue 32110: include version in fop library name

Thu, 11 Feb 2016 09:50:00 +0100Related to issue 31354: Adapt TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 11 Feb 2016 09:50:00 +0100] rev 28598
Related to issue 31354: Adapt TestCosting

Fix foreign currency debit, foreign currency credit and currency checks for ReceiptInvoiceMatch document in assertDocumentPost method in testCostingMC444 and testCostingMC445 tests.

Tue, 09 Feb 2016 12:46:23 +0100Related to issue 31354: Difference for price variant calculation
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 09 Feb 2016 12:46:23 +0100] rev 28597
Related to issue 31354: Difference for price variant calculation

The difference for price variants is now calculated and posted in the Acct. Schema currency as it was originally done

Tue, 17 Nov 2015 17:32:11 +0100Fixed bug 31354: Wrong amtsourcedr and amtsourcecr when posting Matched Invoice
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 17 Nov 2015 17:32:11 +0100] rev 28596
Fixed bug 31354: Wrong amtsourcedr and amtsourcecr when posting Matched Invoice

The cost is always calculated and posted in the organization's currency.
The expense is calculated and posted in the invoice's currency.

The conversion date from the cost currency to the acct. schema currency uses the shipment accounting date.
The conversion date from the invoice currency to the acct. schema currency uses the invoice accounting date.

The difference for the price variant is calculated and posted in the cost currency.

In case there is a difference in the conversion rate between the order and the invoice, the usual currency balance entry is automatically created

Fri, 12 Feb 2016 09:01:15 +0100related to issue 31766: put correct location selector title
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 12 Feb 2016 09:01:15 +0100] rev 28595
related to issue 31766: put correct location selector title

Thu, 11 Feb 2016 16:31:20 +0100Fixed bug 32203: Not possible to post a remittance and the settlement of that remittance
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 11 Feb 2016 16:31:20 +0100] rev 28594
Fixed bug 32203: Not possible to post a remittance and the settlement of that remittance

The way to retrieve the payment detail object was wrong. Instead we can take it directly from the paymentDetails list

Thu, 11 Feb 2016 16:16:57 +0530Fixes Issue 0032157: Not possible to sort by unit price in Return from
Atul Gaware <atul.gaware@openbravo.com> [Thu, 11 Feb 2016 16:16:57 +0530] rev 28593
Fixes Issue 0032157: Not possible to sort by unit price in Return from
Customer p&e

In case of the Return From Customer for a numeric value of unit Price COALESCE
was being use with '' which should have been 0 instead, COALESCE for order no
was missing for RTC, additonal ReturnReasonLeftClause2 added to replace
EntityAlias.name in the transformeredHQL Query.

Thu, 11 Feb 2016 15:57:36 +0100fixes issue 32202: Error in add payment when editing the amount of a record
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 11 Feb 2016 15:57:36 +0100] rev 28592
fixes issue 32202: Error in add payment when editing the amount of a record

The entered value is being set on the changed method for number items. This is done in order to prevent placing the decimal separator in a wrong place. This problem only affects to standard windows.

To solve the problem we only set the number item value in the changed method when we are not in a pick and edit window but in a standard window.

Fri, 05 Feb 2016 12:02:24 +0100Fixes issue 32089: Reservations with stock in second UOM will not be created
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Feb 2016 12:02:24 +0100] rev 28591
Fixes issue 32089: Reservations with stock in second UOM will not be created

M_RESERVE_STOCK_AUTO will exclude lines from m_storage_detail with second uom to avoid create stock reservation lines for products with stock in second UOM, as it is done in M_CREATE_RESERVE_FROM_SOL.

Wed, 10 Feb 2016 17:08:23 +0100Related to issue 32038: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 10 Feb 2016 17:08:23 +0100] rev 28590
Related to issue 32038: code review improvements

* startingDate is a mandatory column, so there is no need to validate whether it's null or not
* The promotion is applied for the period of time between the Starting and Ending Dates (both inclusive). For example, for a promotion available only in a concrete date, the starting and ending dates must be equal.
The date received as parameter to this query might have a time (hours/minutes/seconds). To control that situation the comparation is truncating the promotion starting and ending date (that should already be truncated because it's linked to a Date reference), it adds 1 day to the promotion ending date and removes the equal clause. Thus we can properly control the scenario of a one-day promotion with a datetime parameter.

Mon, 01 Feb 2016 16:54:12 -0500Fixes Issue 32038: "Price Adjustment" promotion type is applied to a line only
Nono Carballo <f.carballo@nectus.com> [Mon, 01 Feb 2016 16:54:12 -0500] rev 28589
Fixes Issue 32038: "Price Adjustment" promotion type is applied to a line only
if the order/invoice date falls into the promotion period.

The HQL query was tuned to take into account the starting and ending date of the
promotion when selecting a product for a line in a purchase order/invoice.
The line only gets the promotion if the period encloses the order/invoice date,
start and end date included.
The line hql += "and (endingDate is null or endingDate>:date) "; was replaced with

hql += "and (endingDate is null or endingDate>=:date) ";
hql += "and (startingDate is null or startingDate<=:date) ";

Thu, 04 Feb 2016 12:24:30 +0100Fixes issue 32109: Review allow filtering and allow sorting in computed columns
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 04 Feb 2016 12:24:30 +0100] rev 28588
Fixes issue 32109: Review allow filtering and allow sorting in computed columns

Computed columns belonging to a table with high volumes or having a complex query have been disabled for filtering and sorting.
Only computed columns in low volume tables and with a simple query will allow filtering and sorting.