Wed, 09 Mar 2016 16:11:53 +0100Related to issue 32332. Removed wrong part of the diff.
Antonio Moreno Perez <antonio.moreno@openbravo.com> [Wed, 09 Mar 2016 16:11:53 +0100] rev 28797
Related to issue 32332. Removed wrong part of the diff.

Mon, 07 Mar 2016 15:46:50 +0100Fixes issue 32399: cannot filter grid when it is grouped by a column.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 07 Mar 2016 15:46:50 +0100] rev 28796
Fixes issue 32399: cannot filter grid when it is grouped by a column.

Having a column grouped, if a filter was applied in a grid, it was not possible to apply it.
A js error was thrown: Uncaught TypeError: this.data.willFetchData is not a function.

The problem was in "if (..... || (this.data.willFetchData(this.convertCriteria(criteria)))"
statement which incorrectly assumed this.data to be an object and willFetchData a function
within it. This is not true when in this situation where this.data is a Tree class.

It has been fixed by taking into account this case by checking that "this.data" defines the
function.

Tue, 01 Mar 2016 18:02:57 +0100Related to issue 32372: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 01 Mar 2016 18:02:57 +0100] rev 28795
Related to issue 32372: Code review improvements

Call line.getProductCosts only when line.transaction != null in DocInventory.java.

Mon, 29 Feb 2016 17:00:12 +0530Fixes Issue 32372:NullPointerException when posting a Physical Inventory
Atul Gaware <atul.gaware@openbravo.com> [Mon, 29 Feb 2016 17:00:12 +0530] rev 28794
Fixes Issue 32372:NullPointerException when posting a Physical Inventory
with a line without an associated transaction (not stocked product)

- Avoid insertion of zero quantity products in inventory line having
stocked flag as No.
- Code improvement to handle line with null transaction.

Mon, 29 Feb 2016 23:51:51 +0100Fixes issue 32237: Payment In and Payment Out lines are not exported to CSV.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 29 Feb 2016 23:51:51 +0100] rev 28793
Fixes issue 32237: Payment In and Payment Out lines are not exported to CSV.

The problem was that export to CSV does not work properly in some subtabs without
link to parent column (e.g.Lines subtab of Payment In/Out). Before, It was used
"tabId" to obtaing data for export to CSV and the value of the "tabId" was sent
in a variable called "tab". The Criteria that is run when it is displayed the tab
uses a property named "tabId" instead of "tab".

The solution for this case (and other related cases) is to adapt the code that
exports to CSV to use the same Criteria run when displaying the tab. Now export to
CSV uses tabId property. Besides it has been refactored some piece of code related
with export data in DataSourceServlet to use "tabId" instead of "tab".

Mon, 29 Feb 2016 17:34:08 +0100Fixed issue 32332. Added method to check if importentry has status 'Error'
Antonio Moreno <antonio.moreno@openbravo.com> [Mon, 29 Feb 2016 17:34:08 +0100] rev 28792
Fixed issue 32332. Added method to check if importentry has status 'Error'

Wed, 24 Feb 2016 18:05:08 +0530Fixes Issue 32327:"Generate invoice from receipt" button is not working
Atul Gaware <atul.gaware@openbravo.com> [Wed, 24 Feb 2016 18:05:08 +0530] rev 28791
Fixes Issue 32327:"Generate invoice from receipt" button is not working

In case tax not included in price list, gross std price and list price
was set will null value which is not allowed by db table. now they are
initiated to value zero first.

Thu, 25 Feb 2016 00:33:12 +0100Fixes issue 32247: Read only doesn't work on some columns in grid view
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 25 Feb 2016 00:33:12 +0100] rev 28790
Fixes issue 32247: Read only doesn't work on some columns in grid view

The problem is caused because it was not take into account read only when other
logic (e.g. display logic) was being applied in an editing grid view.

In order to prevent this, it take into account when a field is checks as read
only. In this case, the field is show properly.

Tue, 23 Feb 2016 16:37:30 +0100fixed bug 32309: error on update if an observer loaded current object in memory
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 23 Feb 2016 16:37:30 +0100] rev 28789
fixed bug 32309: error on update if an observer loaded current object in memory

In case an entity observer loaded current object in memory (ie. observing orderLine)
doing orderLine.getSalesOrder().getOrderLineList() there were two different instances
in memory representing the same DB row. This caused problems when trying to evict it.
Causing an exception to be thrown when updating from UI in this case.

As solution eviction is no longer performed, object is forced to be fetched from DB by
executing a Criteria.

Mon, 22 Feb 2016 15:33:27 +0530Fixes Issue 32298: Wrong payment status when unmatching bankstatement line
Atul Gaware <atul.gaware@openbravo.com> [Mon, 22 Feb 2016 15:33:27 +0530] rev 28788
Fixes Issue 32298: Wrong payment status when unmatching bankstatement line
manually matched against an invoice

Incase a finTransaction is unmatched which has finPayment,status of finPayment
is also updated accordingly as per isReceipt flag

Mon, 22 Feb 2016 10:43:16 +0100Related to issue 32219: fixed db consistency
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 22 Feb 2016 10:43:16 +0100] rev 28787
Related to issue 32219: fixed db consistency

Thu, 18 Feb 2016 17:47:53 +0530Fixes Issue 32219:Payment In & Out Window Lines Tab Order Payment Plan Field
Atul Gaware <atul.gaware@openbravo.com> [Thu, 18 Feb 2016 17:47:53 +0530] rev 28786
Fixes Issue 32219:Payment In & Out Window Lines Tab Order Payment Plan Field
navigation fails

Direct Navigation Rule applied to
- Window:Payment In, Tab:Lines, Field:Order Payment Plan navigate to
Sales Order | Payment Plan Tab
- Window:Payment Out, Tab:Lines, Field:Order Payment Plan navigate to
Purchase Order | Payment Plan Tab

Thu, 11 Feb 2016 16:16:57 +0530Fixes Issue 0032184: Not possible to sort by unit price in Return from
Atul Gaware <atul.gaware@openbravo.com> [Thu, 11 Feb 2016 16:16:57 +0530] rev 28785
Fixes Issue 0032184: Not possible to sort by unit price in Return from
Customer p&e

In case of the Return From Customer for a numeric value of unit Price COALESCE
was being use with '' which should have been 0 instead, COALESCE for order no
was missing for RTC, additonal ReturnReasonLeftClause2 added to replace
EntityAlias.name in the transformeredHQL Query.

Mon, 01 Feb 2016 18:49:06 +0100Fixes issue 31915 & Fixes issue 31907 & Fixes issue 31957: Cannot void shipment
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 01 Feb 2016 18:49:06 +0100] rev 28784
Fixes issue 31915 & Fixes issue 31907 & Fixes issue 31957: Cannot void shipment

Cannot void shipment related to reservation.
New reservation to replace the closed related one when voiding a shipment will be done after update m_storage_detail, in order to have voided shipment quantity available.
Reservation stock lines will be created with related shipment line movement quantity in case this quantity is less than pending order quantity.
Reservation will be created with the least quantity between ordered quantity and movement quantity.

Tue, 02 Feb 2016 13:45:46 -0500Fixes issue 32085: Process Price Difference adjustment breaks menu
Mark <m.molina@nectus.com> [Tue, 02 Feb 2016 13:45:46 -0500] rev 28783
Fixes issue 32085: Process Price Difference adjustment breaks menu

Were fixed the 3 problems of "Process Price Difference adjustment" menu entry found:

1. It is included into menu folder Warehouse Management | Setup
2. Was renamed to "Process Price Difference Adjustment" to follow the capitalization rule
3. Was included a description and help.

Fri, 05 Feb 2016 11:37:39 +0100Fixes issue 32098: Reserved quantity is not correct
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Feb 2016 11:37:39 +0100] rev 28782
Fixes issue 32098: Reserved quantity is not correct

In ManageReservationActionHandler, when clicking Done in Manage Reservation P&E, it was first reserving what the user was typing in the P&E, and if it was not processed the reservation, it was processing it. As the M_RESERVATION_POST tries always to reserve as much as possible, it was overriding the previously set amounts. In order to prevent this, now first the reservation is being processed and after that the values typed in the UI are being set to the reservation.
In case no stock reservation is created by m_reservation_post when processing the reservation, res_status will be Draft. To be sure reservation is set as completed, force status after call ReservationUtils.processReserve method.
Reservation will only be kept as draft in case it has no lines after execute manageReservedStockLines.

Mon, 25 Jan 2016 13:07:24 +0100Fixes issue 32003: Costing Migration Process does not set isprocessed flag
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 25 Jan 2016 13:07:24 +0100] rev 28781
Fixes issue 32003: Costing Migration Process does not set isprocessed flag

Set transaction isprocessed flag as true in updateTrxLegacyCosts, updateWithZeroCostRemainingTrx and calculateCosts methods in CostingMigrationProcess class.
Set also transaction isprocessed flag as true in updateInventoriesCostAndProcessInitInventories method in CostingRuleProcess class.

Mon, 25 Jan 2016 12:12:46 +0100Related to Issue 31997. Changed license year.
David Miguelez <david.miguelez@openbravo.com> [Mon, 25 Jan 2016 12:12:46 +0100] rev 28780
Related to Issue 31997. Changed license year.

Thu, 21 Jan 2016 14:27:39 +0100Fixes issue 31997: Wrong cost calculation in Costing Migration Process
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 21 Jan 2016 14:27:39 +0100] rev 28779
Fixes issue 31997: Wrong cost calculation in Costing Migration Process

HQL in insertTrxCosts method in CostingMigrationProcess class was doing an inner join between m_transaction and m_inoutline instead of a left join.

Thu, 21 Jan 2016 12:44:16 +0100fixed issue 31974: detect situation created by issue 31959
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 21 Jan 2016 12:44:16 +0100] rev 28778
fixed issue 31974: detect situation created by issue 31959

Added module script that creates alert when in this situation

Wed, 20 Jan 2016 19:02:18 +0100fixes issue 31960: Incorrect posting data using postgresql jdbc connection pool
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 20 Jan 2016 19:02:18 +0100] rev 28777
fixes issue 31960: Incorrect posting data using postgresql jdbc connection pool


There was a problem in the binary transfer of Dates performed by the postgresql library version 9.4-1201. This problem is not happening on version 9.4-1207 because when the queries are executed it now includes a mechanism to identify if the fields of the query need to update their format to binary.

For this reason, to fix the problem the postgresql jdbc driver has been upgraded to version 9.4-1207

Tue, 19 Jan 2016 17:49:23 +0100fixes issue 31946: Labels linked to a concrete file are not translated
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 19 Jan 2016 17:49:23 +0100] rev 28776
fixes issue 31946: Labels linked to a concrete file are not translated

The translation engine requires the base design path to retrieve the ad_textinterfaces linked to a particular report. This path was not being sent properly in ReportinUtils class. Now the path is generated correctly making use of a new method called getBaseDesignPath.

Fri, 15 Jan 2016 09:55:06 +0100related to issue 31884: code review improvement
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 15 Jan 2016 09:55:06 +0100] rev 28775
related to issue 31884: code review improvement

Wed, 13 Jan 2016 21:13:18 +0530Fixes Issue 31896:Cannot save a G/L Journal header with the date of the
Atul Gaware <atul.gaware@openbravo.com> [Wed, 13 Jan 2016 21:13:18 +0530] rev 28774
Fixes Issue 31896:Cannot save a G/L Journal header with the date of the
adjustment period if both periods are opened

c_chk_open_period returns value more than 1 in case standard period and
adjustment period is open in which the date of GL journal is included.
<> 1 check is failed in this case so check is changed to < 1 to show
error message in case period id not available

Thu, 14 Jan 2016 16:03:01 +0100fixes issue 31889: some reports are not exported using JDK 8
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 14 Jan 2016 16:03:01 +0100] rev 28773
fixes issue 31889: some reports are not exported using JDK 8

The library which contains the JDT compiler from the Eclipse Foundation has been upgraded to version 4.4.2. This compiler is used to compile jrxml -> jasper.

Using JDK 8 with the previous library version caused an error when exporting some reports. With this upgrade reports are exported correctly using JDK 8.

Thu, 14 Jan 2016 10:57:56 +0100fixes issue 31884: can not move tree nodes in classic mode
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 14 Jan 2016 10:57:56 +0100] rev 28772
fixes issue 31884: can not move tree nodes in classic mode

When moving tree nodes using the classic mode there is a point where the process tries to recover the tree type. This information is stored in the ADTable entity which can not be accessed by non system roles. To prevent this error now the part where the tree type is recovered is executed using the DAL admin mode.

Wed, 13 Jan 2016 17:35:14 +0100Related to issue 31875: Updated copyright year
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 13 Jan 2016 17:35:14 +0100] rev 28771
Related to issue 31875: Updated copyright year

Wed, 13 Jan 2016 12:44:01 +0100Fixes Issue 31875. Removes unnecessary code that makes the process fail with a NPE
David Miguelez <david.miguelez@openbravo.com> [Wed, 13 Jan 2016 12:44:01 +0100] rev 28770
Fixes Issue 31875. Removes unnecessary code that makes the process fail with a NPE
if the global variable has not been initized yet.

Wed, 13 Jan 2016 15:31:26 +0100Related to issue 31848: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 13 Jan 2016 15:31:26 +0100] rev 28769
Related to issue 31848: code review improvements

The old messages have been reverted because it could be used by external modules, so it could be considered as a functional API Change.
Create a new message instead and improve it to be more descriptive.

Modified pl/sql comment to reflect the new behavior and to avoid confusions in the future

Mon, 11 Jan 2016 17:23:56 +0100Fixes issue 31848: Not possible to change product to stocked
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 11 Jan 2016 17:23:56 +0100] rev 28768
Fixes issue 31848: Not possible to change product to stocked

Stocked flag in Product window will not be updatable in case product is present in any order, invoice or warehouse document.