Mon, 12 Jan 2015 18:07:06 +0100Fixed bug 28560 Cannot modify alternate taxableamt of invoice and order lines
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 12 Jan 2015 18:07:06 +0100] rev 25697
Fixed bug 28560 Cannot modify alternate taxableamt of invoice and order lines

Backout of commit that caused the regression(27562) and fixed taxable amount for not
stocked bom lines is not calculated in M_EXPLODEBOMNOTSTOCK
and M_INVEXPLODEBOMNOTSTOCK procedures

Mon, 12 Jan 2015 13:02:24 +0100related to bug 28545: added jUnit test case
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 12 Jan 2015 13:02:24 +0100] rev 25696
related to bug 28545: added jUnit test case

Mon, 12 Jan 2015 12:07:15 +0100Fixes bug 28563: Filters in Match LC Costs P&E now are working
Unai Martirena <unai.martirena@openbravo.com> [Mon, 12 Jan 2015 12:07:15 +0100] rev 25695
Fixes bug 28563: Filters in Match LC Costs P&E now are working

This grid has been implemented using an hql query based table. The entity alias field was empty for all this columns, and it is necessary to correct implementation of the filtering, so the left part of the select has been added on all of them.

Thu, 08 Jan 2015 22:40:37 -0500Fixed bug 27955: Improve error msg for invalid amounts in Modify Payment Plan.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Thu, 08 Jan 2015 22:40:37 -0500] rev 25694
Fixed bug 27955: Improve error msg for invalid amounts in Modify Payment Plan.

On change behaviour for the field Outstanding amount in Modify Payment Out Plan Pick and Execute window, was changed to take into account a javascript validation function named: validateModifyPaymentPlanAmounts.
This validation function launches an error when trying to submit a higher outstanding amount than invoice's total, during payment plan's modification.

Fri, 09 Jan 2015 15:18:45 +0100fixed bug 28552: big numbers are changed in some cases
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 09 Jan 2015 15:18:45 +0100] rev 25693
fixed bug 28552: big numbers are changed in some cases

Big numbers are modified in case their scientific notation represntation ends
with zeros, trailing zeros were removed. So, ie., 3.5E10 was changed to 3.5E1
this is: 3.5.

The problem was caused by fix for #26132 which tries to transform scientific to
decimal notation (and then remove trailing zeros, which is correct). But it
expected 3.5E+10 instead of 3.5E10, so in latter case, which is actually used
it didn't do the transformation.

The fix accepts scientific notation with both + and no +.

Fri, 09 Jan 2015 11:44:38 +0100fixed bug 28548: MMC shows null as current installed version if it has no label
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 09 Jan 2015 11:44:38 +0100] rev 25692
fixed bug 28548: MMC shows null as current installed version if it has no label

Fixed by showing current version number if the installed module version has no
label.

Fri, 09 Jan 2015 10:46:48 +0100fixed bug 28545: filters in HQL Query tables don't work in some cases
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 09 Jan 2015 10:46:48 +0100] rev 25691
fixed bug 28545: filters in HQL Query tables don't work in some cases

Filters in HQL Query tables didn't work for columns having a different column
name than its alias.

This was caused because the reaplcement was not properly done because it didn't
take into account the table alias.

Table alias was added when fixing issue #28432

Fri, 09 Jan 2015 07:48:24 +0100related to bug 28541: added FICTest.class to AllWebserviceTests suite
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 09 Jan 2015 07:48:24 +0100] rev 25690
related to bug 28541: added FICTest.class to AllWebserviceTests suite

Fri, 09 Jan 2015 07:45:56 +0100related to bug 28541: added test case
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 09 Jan 2015 07:45:56 +0100] rev 25689
related to bug 28541: added test case

Fri, 09 Jan 2015 07:44:53 +0100fixed bug 28541: date value in DateTime reference changes to current date
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 09 Jan 2015 07:44:53 +0100] rev 25688
fixed bug 28541: date value in DateTime reference changes to current date

When a DateTime reference column is hidden in grid, the date part was set to
current date when navigating to form view.

This was caused by an incorrect conversion to UTC where current date was set.

Fri, 09 Jan 2015 11:54:38 +0530Fixes Issue 28523: Code field change in "Product Characteristics - Value"
Atul Gaware <atul.gaware@openbravo.com> [Fri, 09 Jan 2015 11:54:38 +0530] rev 25687
Fixes Issue 28523: Code field change in "Product Characteristics - Value"
tab is not transferred to inactive records in the tab of Product window

Active Filter is set false when selecting Product Characteristics
Configuration records in Characteristics Value change event handler.

Wed, 07 Jan 2015 23:10:24 -0500Fixed bug 28012: Sales dimensional report is not showing some dimensions.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Wed, 07 Jan 2015 23:10:24 -0500] rev 25686
Fixed bug 28012: Sales dimensional report is not showing some dimensions.

New dimensions like project and ship to address were added to the Sales dimensional report to make possible to also organize data by them.
Now it is possible to also include project and ship to address dimensions when the report data is retrieved both in its version comparative and non-comparative.

Thu, 08 Jan 2015 13:08:27 +0100Related to issue 28534: Fix Copyright
Unai Martirena <unai.martirena@openbravo.com> [Thu, 08 Jan 2015 13:08:27 +0100] rev 25685
Related to issue 28534: Fix Copyright

Thu, 08 Jan 2015 12:50:05 +0100Related to Bug 28531: Fix backdated is not correctly set with big amount of data
Unai Martirena <unai.martirena@openbravo.com> [Thu, 08 Jan 2015 12:50:05 +0100] rev 25684
Related to Bug 28531: Fix backdated is not correctly set with big amount of data

createCostingRuleInits method inside CostingRuleProcess.java cleares session every 100 records, and if this happens then the reference to current Costing Rule is missed, so the code that sets the fix backdated from is not properly done (rule.setFixbackdatedfrom(startingDate)). To avoid this the Fix Backdated From is set before creating Costing Rule Inventories.

Thu, 08 Jan 2015 12:30:31 +0100Fixes Bug 28534: Fix Backdated From is now displayed properly.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 08 Jan 2015 12:30:31 +0100] rev 25683
Fixes Bug 28534: Fix Backdated From is now displayed properly.

'Fix Backdated From' now is only displayed when 'Backdated Transactions Fixed' is set to Yes.
Also a callout has been added to clear the value in 'Fix Backdated From' when is hidden.

Thu, 08 Jan 2015 17:07:41 +0100Fixes Issue 28544.
David Miguelez <david.miguelez@openbravo.com> [Thu, 08 Jan 2015 17:07:41 +0100] rev 25682
Fixes Issue 28544.

In Reset Unit Cost Process, now takes into account that Organization
parameter can be null in a Query.

Thu, 13 Nov 2014 13:15:11 -0500Fixed bug 27996: Users are able to void invoices in draft status.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Thu, 13 Nov 2014 13:15:11 -0500] rev 25681
Fixed bug 27996: Users are able to void invoices in draft status.

ActionButtonUtility class now also excludes from combo the void option for c_invoice table when process button is clicked and document is in draft status.
Now when processing a just created invoice, it is not possible to void the document.

Wed, 07 Jan 2015 19:31:01 +0100Fixes bug 28531: Fix Backdated fails when backdated from is before starting date.
Unai Martirena <unai.martirena@openbravo.com> [Wed, 07 Jan 2015 19:31:01 +0100] rev 25680
Fixes bug 28531: Fix Backdated fails when backdated from is before starting date.

A check has been added to be sure that fix backdated from date is not earlier than starting date of the costing rule.
Also some code has been changed to handle correctly the error messages and return them properly to the user.
Finally the reference of Fix Backdated From Parameter in Fix Backdated Transactions Process Definitio has been changed from Date to DateTime.

Wed, 07 Jan 2015 18:42:06 +0100Backed out changeset d9352a85fef4
Ander Iraceburu <ander.iraceburu@openbravo.com> [Wed, 07 Jan 2015 18:42:06 +0100] rev 25679
Backed out changeset d9352a85fef4
Breaks retail integration

Wed, 07 Jan 2015 17:52:31 +0100Unit Cost Reference Data & JUnit Test
Ander Iraceburu <ander.iraceburu@openbravo.com> [Wed, 07 Jan 2015 17:52:31 +0100] rev 25678
Unit Cost Reference Data & JUnit Test

Wed, 07 Jan 2015 16:02:36 +0100Fixes issue 28537: Grid is loaded properly after scrolling it and sorting it
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 07 Jan 2015 16:02:36 +0100] rev 25677
Fixes issue 28537: Grid is loaded properly after scrolling it and sorting it

In this changeset [1] a change was done to prevent modifying improperly the totalRows property of the grid after scrolling. This code was meant to be executed after scrolling the grid, and to check it the lastScrollTop property and the getScrollTop() function of the grid body were compared. This check works properly when event that triggered the datasource request was the grid being filtered or a new page being fetched due to scrolling the grid.

The problem was that the check did not work properly when the datasource request was triggered due to having sorted the grid. In this case, the totalRows property should be left as is. To fix this, a new flag is used to control when the datasource request has been triggered by a sorting event.

[1] https://code.openbravo.com/erp/devel/pi/rev/c51dce7e9fd3

Wed, 07 Jan 2015 12:42:34 +0100Fixes issue 28505: Document number field length is not always hardcoded to 20
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 07 Jan 2015 12:42:34 +0100] rev 25676
Fixes issue 28505: Document number field length is not always hardcoded to 20

In this changeset [1], that was included in the first release of Openbravo 3.0, the length of the document number field length for the grids is hardcoded to 20. The length of the form field is taken from the length of the column in the application dictionary.

Having a different length in the grid and form fields resulted in the value of the field being truncated when it is edited in the view with the shortest length. It is not possible to remove the hardcoded code because it is possible that some Openbravo instances depend on it (i.e. if the length of the document number column is set to 0). In order to fix this issue, now the hardcoded code only affects the fields whose length is 0. For all the other cases, the length of the grid field will be taken from the length of the column.

[1] https://code.openbravo.com/erp/devel/pi/rev/ae5c327c567f#l3.14

Wed, 07 Jan 2015 10:18:24 +0100Fixes bug 28519:OrganizationStructureProvider.initialize should be synchronized
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 07 Jan 2015 10:18:24 +0100] rev 25675
Fixes bug 28519:OrganizationStructureProvider.initialize should be synchronized

The method OrganizationStructureProvider.initialize should be synchronized, because otherwise it could be executed concurrently. The first thing the method does it to check if it the OrganizationStructureProvider has been already initialized, but this is not enough to prevent the concurrent initializations.

One of the consequences of the concurrent initializations is that the three maps used in that method (naturalTreesByOrgID, parentByOrganizationID and childByOrganizationID) can be left in an inconsistent state, resulting in the a 100% CPU usage when trying to access them.

Wed, 07 Jan 2015 09:43:52 +0100Merge with latest pi
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Wed, 07 Jan 2015 09:43:52 +0100] rev 25674
Merge with latest pi

Mon, 05 Jan 2015 17:48:58 +0100Fix issue in merge unit cost project.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Mon, 05 Jan 2015 17:48:58 +0100] rev 25673
Fix issue in merge unit cost project.

Mon, 05 Jan 2015 17:33:36 +0100Fix issue in merge unit cost project.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Mon, 05 Jan 2015 17:33:36 +0100] rev 25672
Fix issue in merge unit cost project.

Mon, 05 Jan 2015 16:47:23 +0100Merge unit cost project.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Mon, 05 Jan 2015 16:47:23 +0100] rev 25671
Merge unit cost project.

Mon, 05 Jan 2015 12:18:46 +0100Related to Issue 27395. Fix issue when calculating several trx
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Mon, 05 Jan 2015 12:18:46 +0100] rev 25670
Related to Issue 27395. Fix issue when calculating several trx

When calculating more than one transaction of the same product the first
transaction value amount is not considered.
Add a coalesce on the trigger for the cost amount
Do incremental updates instead of calculating the total amount.

Wed, 17 Dec 2014 19:06:50 +0100Related to Issue 27395. Compatibility issues with oracle. Reset on cur change
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Wed, 17 Dec 2014 19:06:50 +0100] rev 25669
Related to Issue 27395. Compatibility issues with oracle. Reset on cur change

- When the currency of a legal entity is changed the unit costs are deleted
and a message is prompt to the user to recalculate them again.
- Several performance issues in triggers and procedures.
- Modified organization selector to remove HQL query.

Tue, 11 Nov 2014 17:32:58 +0530Fixes Issue 27395. Implements feat. Req. to add info about Product Unit Cost.
David Miguelez <david.miguelez@openbravo.com> [Tue, 11 Nov 2014 17:32:58 +0530] rev 25668
Fixes Issue 27395. Implements feat. Req. to add info about Product Unit Cost.

*Adds a new Table named M_Stock_Valuation to store Stock, Stock Valuation
and Unit Cost of a Product.
*Adds ModuleScript to fill this Table for existing Data.
*Adds Process to Reset this Table
*Modifies M_Transaction_Trg and adds M_Transaction_Cost_Trg to Update
the values of M_Stock_Valuation Table when Stock is introduced
and when the Cost is calculated or adjusted.
*Modifes M_Product_Trg to initialize the information of this Table
when the Product is created.