Thu, 21 Jan 2016 14:27:39 +0100Fixes issue 31998: Wrong cost calculation in Costing Migration Process
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 21 Jan 2016 14:27:39 +0100] rev 28747
Fixes issue 31998: Wrong cost calculation in Costing Migration Process

HQL in insertTrxCosts method in CostingMigrationProcess class was doing an inner join between m_transaction and m_inoutline instead of a left join.

Fri, 22 Jan 2016 14:10:36 +0000Merge temporary head for 3.0PR15Q4.2
RM packaging bot <staff.rm@openbravo.com> [Fri, 22 Jan 2016 14:10:36 +0000] rev 28746
Merge temporary head for 3.0PR15Q4.2

Fri, 22 Jan 2016 05:17:24 +0000Added signature for changeset 13daf93202e0
RM packaging bot <staff.rm@openbravo.com> [Fri, 22 Jan 2016 05:17:24 +0000] rev 28745
Added signature for changeset 13daf93202e0

Fri, 22 Jan 2016 05:17:24 +0000Added tag 3.0PR15Q4.2 for changeset b6c50283d4a8
RM packaging bot <staff.rm@openbravo.com> [Fri, 22 Jan 2016 05:17:24 +0000] rev 28744
Added tag 3.0PR15Q4.2 for changeset b6c50283d4a8

Fri, 22 Jan 2016 05:17:24 +0000Update AD_MODULE version to 3.0PR15Q4.2 3.0PR15Q4.2
RM packaging bot <staff.rm@openbravo.com> [Fri, 22 Jan 2016 05:17:24 +0000] rev 28743
Update AD_MODULE version to 3.0PR15Q4.2

Thu, 21 Jan 2016 13:57:04 +0100fixed issue 31975: detect situation created by issue 31959
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 21 Jan 2016 13:57:04 +0100] rev 28742
fixed issue 31975: detect situation created by issue 31959

Added module script that creates alert when in this situation

Wed, 20 Jan 2016 19:01:04 +0100fixes issue 31961: Incorrect posting data using postgresql jdbc connection pool
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 20 Jan 2016 19:01:04 +0100] rev 28741
fixes issue 31961: Incorrect posting data using postgresql jdbc connection pool


There was a problem in the binary transfer of Dates performed by the postgresql library version 9.4-1201. This problem is not happening on version 9.4-1207 because when the queries are executed it now includes a mechanism to identify if the fields of the query need to update their format to binary.

For this reason, to fix the problem the postgresql jdbc driver has been upgraded to version 9.4-1207

Tue, 19 Jan 2016 17:51:29 +0100fixes issue 31947: Labels linked to a concrete file are not translated
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 19 Jan 2016 17:51:29 +0100] rev 28740
fixes issue 31947: Labels linked to a concrete file are not translated

The translation engine requires the base design path to retrieve the ad_textinterfaces linked to a particular report. This path was not being sent properly in ReportinUtils class. Now the path is generated correctly making use of a new method called getBaseDesignPath.

Fri, 15 Jan 2016 09:59:39 +0100related to issue 31885: code review improvement
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 15 Jan 2016 09:59:39 +0100] rev 28739
related to issue 31885: code review improvement

Wed, 13 Jan 2016 21:13:18 +0530Fixes Issue 31897:Cannot save a G/L Journal header with the date of the
Atul Gaware <atul.gaware@openbravo.com> [Wed, 13 Jan 2016 21:13:18 +0530] rev 28738
Fixes Issue 31897:Cannot save a G/L Journal header with the date of the
adjustment period if both periods are opened

c_chk_open_period returns value more than 1 in case standard period and
adjustment period is open in which the date of GL journal is included.
<> 1 check is failed in this case so check is changed to < 1 to show
error message in case period id not available

Thu, 14 Jan 2016 10:59:53 +0100fixes issue 31885: can not move tree nodes in classic mode
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 14 Jan 2016 10:59:53 +0100] rev 28737
fixes issue 31885: can not move tree nodes in classic mode

When moving tree nodes using the classic mode there is a point where the process tries to recover the tree type. This information is stored in the ADTable entity which can not be accessed by non system roles. To prevent this error now the part where the tree type is recovered is executed using the DAL admin mode.

Wed, 13 Jan 2016 15:31:26 +0100Related to issue 31849: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 13 Jan 2016 15:31:26 +0100] rev 28736
Related to issue 31849: code review improvements

The old messages have been reverted because it could be used by external modules, so it could be considered as a functional API Change.
Create a new message instead and improve it to be more descriptive.

Modified pl/sql comment to reflect the new behavior and to avoid confusions in the future

Mon, 11 Jan 2016 17:23:56 +0100Fixes issue 31849: Not possible to change product to stocked
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 11 Jan 2016 17:23:56 +0100] rev 28735
Fixes issue 31849: Not possible to change product to stocked

Stocked flag in Product window will not be updatable in case product is present in any order, invoice or warehouse document.

Mon, 04 Jan 2016 19:14:21 +0100Fixes issue 31813: Cannot void GoodsShipment if it has reservation associated
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 04 Jan 2016 19:14:21 +0100] rev 28734
Fixes issue 31813: Cannot void GoodsShipment if it has reservation associated

Generate uuid inside the loop to avoid create more than one M_Reservation with the same M_Reservation_ID in M_INOUT_POST.
Format code properly ("Add a reservation stock with the ordered quantity" section) in M_INOUT_POST.
Remove duplicated variable v_reservedqty in M_RESERVATION_POST to avoid set wrong Reservation Status to Order Line.
Take into account only Order Lines with qtyordered > 0 and with product of stocked and item type when setting Reservation Status to Order in M_RESERVATION_POST.
Set "Completely Reserved" reservation status to Order Line also when reservedqty > quantity in M_RESERVATION_POST and M_RESERVATION_TRG.

Thu, 24 Dec 2015 11:03:13 +0100Related to issue 31774: Avoid append a null description
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 24 Dec 2015 11:03:13 +0100] rev 28733
Related to issue 31774: Avoid append a null description

Wed, 23 Dec 2015 18:48:11 +0100Fixed bug 31774: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 23 Dec 2015 18:48:11 +0100] rev 28732
Fixed bug 31774: code review improvements

In case of removing a gl item from a transaction, the part of the transaction's description related to the GL Item (and everything else afterwards) will be deleted. The part of the transaction's description before the GL Item description
will be always kept.
The same behavior is applied when adding a new transaction from the Financial Account window and from the Match Statement --> Add transaction process

In case of removing a payment, the behavior is similar to the GL Item described above. However, since the payment description doesn't follow a constant structure (like in the case of GL Item's description), it's very hard to detect the description on the fly. That means that the flow will only work just after saving the transaction or in the first change after loading the transaction, which are the common flows. If the user selects different payments without saving the record, the system will append the different payment's description to the transaction.

The getFinAccTransactionDescription() method:
1. won't append multiple times the same description.
2. will add an extra empty line only when it's something to be appended
3. will work fine when the transaction already has a description with multiple lines
4. control any possible exception and returns the text to be append (if not blank), or the original description

Applied jsbeautifier to ob-aprm-addTransaction.js

Wed, 23 Dec 2015 01:08:07 +0530Fixes Issue 31774:Bank Statement Line description overwritten with GL Item's
Atul Gaware <atul.gaware@openbravo.com> [Wed, 23 Dec 2015 01:08:07 +0530] rev 28731
Fixes Issue 31774:Bank Statement Line description overwritten with GL Item's
or payment's description when adding gl item or payment in add transaction
of Match Statement Process.

This issue is fixed in two area's
1. Add Transaction Process Definition window in Match Statement.
2. Transaction Tab of Financial Account window.

Whenever there exists a description prior adding gl item or payment in above
both cases description is appended with either gl item description or
payment description.

Tue, 01 Dec 2015 18:20:18 +0100Fixes issue 31738: UniqueValidCombination modulescript is deactivating accounts
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 01 Dec 2015 18:20:18 +0100] rev 28730
Fixes issue 31738: UniqueValidCombination modulescript is deactivating accounts

Add group by c_acctschema_id in selectDuplicates and updateValidCombinationDeactivateDuplicated queries in UniqueValidCombination modulescript.

Wed, 16 Dec 2015 16:41:29 +0100fixes issue 31721: a date used to filter on a grid dissapears after enter it
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 Dec 2015 16:41:29 +0100] rev 28729
fixes issue 31721: a date used to filter on a grid dissapears after enter it

After solving issue 29554 the values of the date filters are completely removed when invoking the clearValue() method. For this reason, in order to prevent the clearing of the date filter it is necessary to call setValue().

This was already controlled when choosing the dates from the date pickers, but not after entering the date with the tab or enter keys or when using the 'Use as Filter' menu option.

Now this cases are controlled also, by calling setValue() on the setSingleDateValue() method.

Tue, 15 Dec 2015 14:54:22 +0100Fixed bug 31723: Return to vendor shipments can be selected in return to vendor
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 15 Dec 2015 14:54:22 +0100] rev 28728
Fixed bug 31723: Return to vendor shipments can be selected in return to vendor

The HQL query in charge of getting the shipment lines was wrongly including all the shipment documents. Instead it should be taking only the lines belonging to a non-return shipment document.

This feature was lost during the refactor to a manual datasource P&E

Fri, 22 Jan 2016 08:42:24 +0000Merge temporary head for 3.0PR15Q3.5
RM packaging bot <staff.rm@openbravo.com> [Fri, 22 Jan 2016 08:42:24 +0000] rev 28727
Merge temporary head for 3.0PR15Q3.5

Thu, 21 Jan 2016 09:06:30 +0000Added signature for changeset 6c3455925759
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 Jan 2016 09:06:30 +0000] rev 28726
Added signature for changeset 6c3455925759

Thu, 21 Jan 2016 09:06:30 +0000Added tag 3.0PR15Q3.5 for changeset 0c91d0ae09c3
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 Jan 2016 09:06:30 +0000] rev 28725
Added tag 3.0PR15Q3.5 for changeset 0c91d0ae09c3

Thu, 21 Jan 2016 09:06:30 +0000Update AD_MODULE version to 3.0PR15Q3.5 3.0PR15Q3.5
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 Jan 2016 09:06:30 +0000] rev 28724
Update AD_MODULE version to 3.0PR15Q3.5

Tue, 19 Jan 2016 17:53:22 +0100fixes issue 31948: Labels linked to a concrete file are not translated
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 19 Jan 2016 17:53:22 +0100] rev 28723
fixes issue 31948: Labels linked to a concrete file are not translated

The translation engine requires the base design path to retrieve the ad_textinterfaces linked to a particular report. This path was not being sent properly in ReportinUtils class. Now the path is generated correctly making use of a new method called getBaseDesignPath.

Fri, 15 Jan 2016 10:01:40 +0100related to issue 31886: code review improvement
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 15 Jan 2016 10:01:40 +0100] rev 28722
related to issue 31886: code review improvement

Wed, 13 Jan 2016 21:13:18 +0530Fixes Issue 31898:Cannot save a G/L Journal header with the date of the
Atul Gaware <atul.gaware@openbravo.com> [Wed, 13 Jan 2016 21:13:18 +0530] rev 28721
Fixes Issue 31898:Cannot save a G/L Journal header with the date of the
adjustment period if both periods are opened

c_chk_open_period returns value more than 1 in case standard period and
adjustment period is open in which the date of GL journal is included.
<> 1 check is failed in this case so check is changed to < 1 to show
error message in case period id not available

Thu, 14 Jan 2016 11:01:49 +0100fixes issue 31886: can not move tree nodes in classic mode
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 14 Jan 2016 11:01:49 +0100] rev 28720
fixes issue 31886: can not move tree nodes in classic mode

When moving tree nodes using the classic mode there is a point where the process tries to recover the tree type. This information is stored in the ADTable entity which can not be accessed by non system roles. To prevent this error now the part where the tree type is recovered is executed using the DAL admin mode.

Thu, 24 Dec 2015 11:03:13 +0100Related to issue 31775: Avoid append a null description
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 24 Dec 2015 11:03:13 +0100] rev 28719
Related to issue 31775: Avoid append a null description

Wed, 23 Dec 2015 18:48:11 +0100Fixed bug 31775: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 23 Dec 2015 18:48:11 +0100] rev 28718
Fixed bug 31775: code review improvements

In case of removing a gl item from a transaction, the part of the transaction's description related to the GL Item (and everything else afterwards) will be deleted. The part of the transaction's description before the GL Item description
will be always kept.
The same behavior is applied when adding a new transaction from the Financial Account window and from the Match Statement --> Add transaction process

In case of removing a payment, the behavior is similar to the GL Item described above. However, since the payment description doesn't follow a constant structure (like in the case of GL Item's description), it's very hard to detect the description on the fly. That means that the flow will only work just after saving the transaction or in the first change after loading the transaction, which are the common flows. If the user selects different payments without saving the record, the system will append the different payment's description to the transaction.

The getFinAccTransactionDescription() method:
1. won't append multiple times the same description.
2. will add an extra empty line only when it's something to be appended
3. will work fine when the transaction already has a description with multiple lines
4. control any possible exception and returns the text to be append (if not blank), or the original description

Applied jsbeautifier to ob-aprm-addTransaction.js