Wed, 24 Aug 2016 13:51:59 +0200Issue 33773. Apply review feedback replace .size() >0 with !isEmpty()
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 13:51:59 +0200] rev 29895
Issue 33773. Apply review feedback replace .size() >0 with !isEmpty()

Tue, 23 Aug 2016 17:58:45 +0200Fixed 33774. Fixed accidental double query by not calling .list() twice
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 17:58:45 +0200] rev 29894
Fixed 33774. Fixed accidental double query by not calling .list() twice

Tue, 23 Aug 2016 17:34:51 +0200Fixed 33773. Avoid double query by not calling .list() twice
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 17:34:51 +0200] rev 29893
Fixed 33773. Avoid double query by not calling .list() twice

First case reading from ad_language can be simplified to single .uniqueResult
call as filters are unique.

2nd case just saves list() result to avoid 2nd call easily.

Wed, 24 Aug 2016 11:54:52 +0200Fixed 33790. Avoid double query with .count() + .list(). Add limit 1 to query
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 11:54:52 +0200] rev 29892
Fixed 33790. Avoid double query with .count() + .list(). Add limit 1 to query

Query did .count() + then retrieve 1 record after adding extra order by.

This change removes the count as it only adds extra overhead and directly
does the real .list() query.
As the code only uses single row of result add extra limit 1 to reduce
number of result rows loaded into memory if many match the filter.
Simply code to use .uniqueResult() instead of .list().get(0)

Wed, 24 Aug 2016 11:08:58 +0200Fixed 33789. Avoid accidental double query by not calling .list() twice
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 11:08:58 +0200] rev 29891
Fixed 33789. Avoid accidental double query by not calling .list() twice

Wed, 24 Aug 2016 10:12:12 +0200related to issue 33622: apply correct format
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 24 Aug 2016 10:12:12 +0200] rev 29890
related to issue 33622: apply correct format

Wed, 24 Aug 2016 00:56:21 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 00:56:21 +0000] rev 29889
CI: merge back from main

Wed, 24 Aug 2016 00:42:26 +0000CI: update AD_MODULE to version 29887
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 00:42:26 +0000] rev 29888
CI: update AD_MODULE to version 29887

Tue, 23 Aug 2016 17:20:57 +0200Fixed 33772. Remove double query by saving .list() result
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 17:20:57 +0200] rev 29887
Fixed 33772. Remove double query by saving .list() result

instead of calling .count() and then .list() which does 2 selects for the same.

Tue, 23 Aug 2016 16:42:13 +0200Fixed 33769. Avoid double query in ModuleManagement window (settings tab)
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 16:42:13 +0200] rev 29886
Fixed 33769. Avoid double query in ModuleManagement window (settings tab)

Tue, 23 Aug 2016 17:13:10 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 23 Aug 2016 17:13:10 +0000] rev 29885
CI: merge back from main

Tue, 23 Aug 2016 16:59:11 +0000CI: update AD_MODULE to version 29881
RM packaging bot <staff.rm@openbravo.com> [Tue, 23 Aug 2016 16:59:11 +0000] rev 29884
CI: update AD_MODULE to version 29881

Tue, 23 Aug 2016 16:22:44 +0200Related to issue 33639: A "magic number" has been renamed.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 23 Aug 2016 16:22:44 +0200] rev 29883
Related to issue 33639: A "magic number" has been renamed.

There was a magic number and now it is a constant.

Tue, 23 Aug 2016 15:29:22 +0200Fixed 33605. Simplify & speedup OrgTree functions with many organizations.
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 15:29:22 +0200] rev 29882
Fixed 33605. Simplify & speedup OrgTree functions with many organizations.

Code in OrgTree.java used strange pattern to loop over its internal (Array)List
of notes.

- for (int i = 0; i < nodes.toArray().length; i++) {
+ for (int i = 0; i < nodes.size(); i++) {

That makes code harder to read and create/copy of those temporary arrays has
a noticable performanc cost in a system with many organizations.

Fri, 12 Aug 2016 17:54:08 +0200Fixed 33707. Avoid triple query use single .uniqueResult instead.
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 12 Aug 2016 17:54:08 +0200] rev 29881
Fixed 33707. Avoid triple query use single .uniqueResult instead.

Filter in that OBQuery is on 'value' field having uniqueConstraint. So not
checking for >1 rows in result is necessary as it can never happen, so remove
that check completely.

Collapse the other 2 .list() calls into a single .uniqueResult avoiding
yet another query.

Fri, 12 Aug 2016 17:43:20 +0200Fixed 33706. Replace triple .list() call by single query.
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 12 Aug 2016 17:43:20 +0200] rev 29880
Fixed 33706. Replace triple .list() call by single query.

Avoid 2 extra queries by saving .list() result instead of calling it 3 times.

Simplify query to OBDal.get (by primary key) as that is only filter which was
used in the OBCriteria.

Fri, 12 Aug 2016 17:27:25 +0200Fixed 33705. Avoid double query with .count() + .list(). Add limit 1 to query
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 12 Aug 2016 17:27:25 +0200] rev 29879
Fixed 33705. Avoid double query with .count() + .list(). Add limit 1 to query

Query did .count() + then retrieve 1 record after adding extra order by.

This change removes the count as it only adds extra overhead and directly
does the real .list() query.
As the code only uses single row of result add extra limit 1 to reduce
number of result rows loaded into memory if many match the filter.
Simply code to use .uniqueResult() instead of .list().get(0)

Fri, 12 Aug 2016 17:08:13 +0200Fixed 33704. Remove double query by saving .list() result
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 12 Aug 2016 17:08:13 +0200] rev 29878
Fixed 33704. Remove double query by saving .list() result

instead of calling .count() and then .list() which does 2 selects for the same.

Fri, 12 Aug 2016 17:02:22 +0200Fixed 33703. Avoid double query by using .uniqueResult instead of twice .list()
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 12 Aug 2016 17:02:22 +0200] rev 29877
Fixed 33703. Avoid double query by using .uniqueResult instead of twice .list()

Tue, 23 Aug 2016 12:25:06 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 23 Aug 2016 12:25:06 +0000] rev 29876
CI: merge back from main

Tue, 23 Aug 2016 12:11:07 +0000CI: update AD_MODULE to version 29874
RM packaging bot <staff.rm@openbravo.com> [Tue, 23 Aug 2016 12:11:07 +0000] rev 29875
CI: update AD_MODULE to version 29874

Thu, 18 Aug 2016 10:58:26 +0200Fixed issue 33639: Update Characteristic was not showing the correct data
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 18 Aug 2016 10:58:26 +0200] rev 29874
Fixed issue 33639: Update Characteristic was not showing the correct data

If there was a product with a subset of a product characteristic, the update characteristic process was not showing the correct data. Instead of showing the products of the subset of the product characteristic, it was showing every product of the product characteristic.
To fix this, the where clause of the selector reference has been changed, making it more restrictive in the case of having a subset.

Mon, 22 Aug 2016 14:26:46 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 22 Aug 2016 14:26:46 +0000] rev 29873
CI: merge back from main

Mon, 22 Aug 2016 14:12:56 +0000CI: update AD_MODULE to version 29869
RM packaging bot <staff.rm@openbravo.com> [Mon, 22 Aug 2016 14:12:56 +0000] rev 29872
CI: update AD_MODULE to version 29869

Mon, 22 Aug 2016 14:00:14 +0200related to issue 33412: prevent NPE
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 22 Aug 2016 14:00:14 +0200] rev 29871
related to issue 33412: prevent NPE

When refreshing a subtab in tree view, having a new record selected in the header, a NullPointerException was being thrown in the tree datasource because it was not possible to retrieve the tree information as no account id is provided in that case

Thu, 18 Aug 2016 12:08:06 -0400Fixes issue 33599: Can't validate a costing rule after one with FIFO algorithm
Nono Carballo <nonofce@gmail.com> [Thu, 18 Aug 2016 12:08:06 -0400] rev 29870
Fixes issue 33599: Can't validate a costing rule after one with FIFO algorithm

Can not validate a new Costing Rule after validating onw with FIFO algorithm if there exists negative stock.
Problem is that FIFO Costing Algorithm is not able to calculate the cost of the closing inventory transaction with negative stock, because there will be more quantity in the Output Stack than the available in the Input Stack.
In that case, "NoCostCalculated" error message will be shown when validating the new Costing Rule until negative stock is regularized.

Mon, 22 Aug 2016 11:13:39 +0200fixes issue 33736: 'Disable Notes For Read-Only' tabs not working properly
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 22 Aug 2016 11:13:39 +0200] rev 29869
fixes issue 33736: 'Disable Notes For Read-Only' tabs not working properly

'Disable Notes For Read-Only' preference was not working properly when a window was set in the visibility settings. This is because the window ID was not being retrieved properly within the OBNoteSectionItem class.

Wed, 17 Aug 2016 15:35:33 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 17 Aug 2016 15:35:33 +0000] rev 29868
CI: merge back from main

Wed, 17 Aug 2016 15:21:29 +0000CI: update AD_MODULE to version 29866
RM packaging bot <staff.rm@openbravo.com> [Wed, 17 Aug 2016 15:21:29 +0000] rev 29867
CI: update AD_MODULE to version 29866

Tue, 16 Aug 2016 22:53:24 +0530Fixes issue 33398: Performance problem in selectDocumentsDates method
Atul Gaware <atul.gaware@openbravo.com> [Tue, 16 Aug 2016 22:53:24 +0530] rev 29866
Fixes issue 33398: Performance problem in selectDocumentsDates method

Improved selectDocumentsDates method query using EXISTS clause.