Sun, 14 Jun 2015 17:41:48 +0000CI: update AD_MODULE to version 26914
RM packaging bot <staff.rm@openbravo.com> [Sun, 14 Jun 2015 17:41:48 +0000] rev 26915
CI: update AD_MODULE to version 26914

Sat, 13 Jun 2015 13:47:26 +0200Merged Heads
Martin Taal <martin.taal@openbravo.com> [Sat, 13 Jun 2015 13:47:26 +0200] rev 26914
Merged Heads

Sat, 13 Jun 2015 13:37:59 +0200Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Martin Taal <martin.taal@openbravo.com> [Sat, 13 Jun 2015 13:37:59 +0200] rev 26913
Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Added extra checks in the import entry processing so that sessions/transactions are really committed

Fri, 12 Jun 2015 14:56:58 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 12 Jun 2015 14:56:58 +0000] rev 26912
CI: merge back from main

Fri, 12 Jun 2015 14:40:46 +0000CI: update AD_MODULE to version 26904
RM packaging bot <staff.rm@openbravo.com> [Fri, 12 Jun 2015 14:40:46 +0000] rev 26911
CI: update AD_MODULE to version 26904

Fri, 12 Jun 2015 12:49:18 +0200Related to issue 30082: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 12 Jun 2015 12:49:18 +0200] rev 26910
Related to issue 30082: code review improvements

The invoice's payment schedules and payment monitor is only updated when all the payment schedule details are paid.

This changeset covers the scenario where an order is partially paid. Before this change, the invoice's payment schedules and payment monitor were wrongly updated considering that the payment schedule was fully paid when any of its payment schedule details was paid. That asumption may be wrong in some scenarios, for example when the order is associated to one or more payment schedule details not yet paid (isinvoicepaid=N) and at least one already paid.

Wed, 10 Jun 2015 13:09:56 +0200Fixed issue 30082: Payment plan is updating wrong in some circumstances
Jorge Garcia <jorge.garcia@openbravo.com> [Wed, 10 Jun 2015 13:09:56 +0200] rev 26909
Fixed issue 30082: Payment plan is updating wrong in some circumstances

Payment plan is updating wrong if Payment Method is set as Automatic Receipt
and a sales order is partially paid.

The problem was that the function duplicates the value of the received amount
created in the Complete process of the invoice, because the function searches
all the payment details of the payment plan that has an invoice paid
(invoicepaid column).

The solution is to search those payment details that are not pre-paid and then
update the payment plan.

Now, the values are filled correctly.

Fri, 12 Jun 2015 12:05:42 +0200Related to issue 29972: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 12 Jun 2015 12:05:42 +0200] rev 26908
Related to issue 29972: code review improvements
Reduced useless query complexity to update outstanding amount.
It's only necessary to check fin_payment_detail_id is null (not associated payment) or isinvoicepaid='N' (associated payment but in a non paid yet status)

Wed, 10 Jun 2015 10:52:18 +0200Fixed issue 29972: Outstanding amount of sales order payment plan is not updated
Jorge Garcia <jorge.garcia@openbravo.com> [Wed, 10 Jun 2015 10:52:18 +0200] rev 26907
Fixed issue 29972: Outstanding amount of sales order payment plan is not updated

The problem was that the outstanding amount of sales order payment plan is not
updated when payment method is set as automatic receipt.

Before the commit which introduces this regression, the function checked the
status of the payment. With the changes, the function checks if the payment
schedule detail is paid.

The problem was in the update of the payment plan of the sales order,
specifically in WHERE clause for outstanding amount.

Now, the where clause works as expected, and the outstanding amount is updated
properly.

Fri, 12 Jun 2015 11:48:26 +0200Merged Heads
Martin Taal <martin.taal@openbravo.com> [Fri, 12 Jun 2015 11:48:26 +0200] rev 26906
Merged Heads

Thu, 11 Jun 2015 17:17:02 +0200Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Martin Taal <martin.taal@openbravo.com> [Thu, 11 Jun 2015 17:17:02 +0200] rev 26905
Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Initialize organisation structure provider before processing

Fri, 12 Jun 2015 10:32:21 +0200Fixes issue 30132: Product Transactions tab not showing records after filtering
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 12 Jun 2015 10:32:21 +0200] rev 26904
Fixes issue 30132: Product Transactions tab not showing records after filtering

The problem happened on the client filtering. In this case, the id of the property that references the parent tab is included in the criteria (using the convertCriteria function of the OBViewGrid class).
For those tabs which does not have any property (column) marked as link to parent, the parent property was not being requested to the datasource and when applying the criteria on the local filter the value for the parent property in every record was undefined. That was the reason why the filtering was not returning any record.
Now if the tab does not have any property set as link to parent, we look for the property pointing to the parent tab and include it in the selected properties returned by the datasource.

Thu, 11 Jun 2015 20:40:59 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 11 Jun 2015 20:40:59 +0000] rev 26903
CI: merge back from main

Thu, 11 Jun 2015 20:23:04 +0000CI: update AD_MODULE to version 26898
RM packaging bot <staff.rm@openbravo.com> [Thu, 11 Jun 2015 20:23:04 +0000] rev 26902
CI: update AD_MODULE to version 26898

Thu, 11 Jun 2015 18:28:02 +0200Fixes Issue 29739. Adds Indexes for isProcess and IsCostCalculated columns
David Miguelez <david.miguelez@openbravo.com> [Thu, 11 Jun 2015 18:28:02 +0200] rev 26901
Fixes Issue 29739. Adds Indexes for isProcess and IsCostCalculated columns
to improve performance in Costing Background Process Queries.

Thu, 11 Jun 2015 17:13:36 +0200Merged heads
Martin Taal <martin.taal@openbravo.com> [Thu, 11 Jun 2015 17:13:36 +0200] rev 26900
Merged heads

Thu, 11 Jun 2015 12:37:01 +0200Related to issue Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Martin Taal <martin.taal@openbravo.com> [Thu, 11 Jun 2015 12:37:01 +0200] rev 26899
Related to issue Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Added comments, removed not needed flush, apparently there is a case that the executorservice queue is null, handle this

Wed, 10 Jun 2015 16:55:01 +0200Fixes issue 30138: Error when generating credit and adding a negative line
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 10 Jun 2015 16:55:01 +0200] rev 26898
Fixes issue 30138: Error when generating credit and adding a negative line

Add Payment was raising an error if credit used was greater than total amount.
Now, this comprobation will only be done if some record has been selected in Credit To Use grid.

Wed, 10 Jun 2015 22:46:44 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 10 Jun 2015 22:46:44 +0000] rev 26897
CI: merge back from main

Wed, 10 Jun 2015 22:31:01 +0000CI: update AD_MODULE to version 26892
RM packaging bot <staff.rm@openbravo.com> [Wed, 10 Jun 2015 22:31:01 +0000] rev 26896
CI: update AD_MODULE to version 26892

Wed, 10 Jun 2015 18:23:19 +0200Fixes issue 30119: ScrollableResults object should be closed
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 10 Jun 2015 18:23:19 +0200] rev 26895
Fixes issue 30119: ScrollableResults object should be closed

Wed, 10 Jun 2015 18:04:18 +0200Related to issue 28886: Applied JS Beautify
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 10 Jun 2015 18:04:18 +0200] rev 26894
Related to issue 28886: Applied JS Beautify

Wed, 03 Jun 2015 18:12:35 +0200Fixes issue 28886: Error in "Refund Payment" from Match Statement
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 03 Jun 2015 18:12:35 +0200] rev 26893
Fixes issue 28886: Error in "Refund Payment" from Match Statement

ob-aprm-addPayment.js has been changed to check if Overpayment Action field is visible in order to raise APRM_ZEROAMOUNTPAYMENTTRANSACTION or not.
AddPaymentActionHandler.java has been changed to do a commit at the end of createNewPayment method and avoid error when retrieving the created payment later.

Wed, 10 Jun 2015 17:02:19 +0200Related to issue 30120: Applied OB code format
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 10 Jun 2015 17:02:19 +0200] rev 26892
Related to issue 30120: Applied OB code format

Wed, 10 Jun 2015 09:56:13 +0530Fixes Issue 30120:ScrollableResults object should be closed
Atul Gaware <atul.gaware@openbravo.com> [Wed, 10 Jun 2015 09:56:13 +0530] rev 26891
Fixes Issue 30120:ScrollableResults object should be closed

ScrollableResults objects are closed in a finally block.

Wed, 10 Jun 2015 15:51:06 +0200Fixed issue 30092: the bo.xslt template is working wrong.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 10 Jun 2015 15:51:06 +0200] rev 26890
Fixed issue 30092: the bo.xslt template is working wrong.

The problem was that it was not possible to get the correct url by clicking
in the links. For example, if you went to the url:

https://livebuilds.openbravo.com/erp_main_pgsql/ws/dal/ADUser?template=bo.xslt

And you click in some link, the obtained url was:

https://livebuilds.openbravo.com/erp_main_pgsql/ws/ADUser/100?template=bo.xslt

instead of:

https://livebuilds.openbravo.com/erp_main_pgsql/ws/dal/ADUser/100?template=bo.xslt

The problem was in the bo.xslt template, in the href variable. It was being set wrong in some cases,
it removed one extra level from the url. This is OK when the url has the id after the entity name, like:

https://livebuilds.openbravo.com/erp_main_pgsql/ws/dal/ADUser/100?template=bo.xslt

But in the case of not having the id after the entity name in the url, it is wrong to substract a level
from the url.

In this case, that does not have the id after the entity name, didn't work well:

https://livebuilds.openbravo.com/erp_main_pgsql/ws/dal/ADUser?template=bo.xslt

The substraction of the level retuned a bad url, the "/dal" is missing:

https://livebuilds.openbravo.com/erp_main_pgsql/ws/ADUser/100?template=bo.xslt

To fix this the bo.xslt has been changed, now it takes into account if the url contains the id after
the entity name. If it does, a level is substracted. If not, no.

The WebServiceUtil.applyTemplate method has been changed too. Now the parameter hasId is set here and is
passed to the bo.xslt. This boolean parameter is true if the url has the id after the entity name,
and false if not.

Wed, 10 Jun 2015 13:12:40 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 10 Jun 2015 13:12:40 +0000] rev 26889
CI: merge back from main

Wed, 10 Jun 2015 12:55:27 +0000CI: update AD_MODULE to version 26887
RM packaging bot <staff.rm@openbravo.com> [Wed, 10 Jun 2015 12:55:27 +0000] rev 26888
CI: update AD_MODULE to version 26887

Wed, 10 Jun 2015 09:05:57 +0200Fixes issue 30096: Cannot filter the bp field by ' symbol in selector drop down
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 10 Jun 2015 09:05:57 +0200] rev 26887
Fixes issue 30096: Cannot filter the bp field by ' symbol in selector drop down

The CustomQuerySelectorDatasource was not handling the parameters of the query properly. For that reason characters like ' were not replaced as expected.
Now the parameters are mapped into a list, and replaced in the query using the setParameter() method

Tue, 09 Jun 2015 18:14:54 +0200Fixes issue 30060: Select Payments Pick&Edit window is not working properly
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 09 Jun 2015 18:14:54 +0200] rev 26886
Fixes issue 30060: Select Payments Pick&Edit window is not working properly

When selecting a record in a P&E grid, the request done to the FIC was not using the correct mode. Now, when selecting a record, the request is properly done using the EDIT mode.