Mon, 28 Aug 2017 14:45:28 +0200Related to issue 36675: Fix some logs
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 28 Aug 2017 14:45:28 +0200] rev 32604
Related to issue 36675: Fix some logs

Wed, 23 Aug 2017 14:16:09 -0400Fixes issue 36675: Transaction Cost not created for closing inventory lines
Mark <markmm82@gmail.com> [Wed, 23 Aug 2017 14:16:09 -0400] rev 32603
Fixes issue 36675: Transaction Cost not created for closing inventory lines

After cost was assigned to closing inventory lines transactions,
when calling to insertTrxCosts() from calculateCosts() method (second call),
CostingUtilsData.countTrxCosts(conn) was getting 0 in countTrx.
It was caused because closing inventory lines cost calculation
was done by OBDal connection, and methods invoked in CostingUtilsData are done
using different connection provided by SQLC, and the transactions are not available
at this moment. See: http://wiki.openbravo.com/wiki/Data_Access_Layer#Transaction_and_Session

To find the best solution for this issue and don't affect the performance (see issue 35959),
different solutions were tested to always use DAL and make process use the same connection.

1.- Doing a single insert-select query with limits is not supported in DAL. We tried it in two different ways (see attached TestCosting_v1.diff):
- Use setMaxResults(). It only works for selects but not for inserts/updates.
- Use setMaxResults() in select query and append it to insert query using getQueryString(). It appends the select without any limit.

2.- Another option could be to refactor insertTrxCosts() method to do a multiple insert query:
We can create the select query with limits using setMaxResults(), iterate it using an scroll
and create and save in each iteration a new TransactionCost. Flush won't be done in every iteration.
When flush is done, it raises every insert in multiple single-row inserts instead of only one multiple-row insert.
Single-row inserts performs worst than multiple-row insert, at least with not many rows (see attached TestCosting_v2.diff).

3.- Finally, we have refactor the process to avoid insertTrxCosts() method:
Our solution makes an insertion in M_Transaction_Cost table each
time we make the updation of related transaction cost in M_Transaction table.
We will do single-row inserts in two methods: updateTrxLegacyCosts() and calculateCosts(),
and multiple-row insert in one method: updateWithZeroCostRemainingTrx().
Thus, we split the number of TransactionCost records to be created in three different steps.

Tue, 29 Aug 2017 16:10:25 +0200Related to issue 36736: Revert changes in reports launched after creating a document
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 29 Aug 2017 16:10:25 +0200] rev 32602
Related to issue 36736: Revert changes in reports launched after creating a document
(post document, print document, etc.)

Tue, 29 Aug 2017 16:03:12 +0200Related to issue 36736: Use read only pool also in Aging reports
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 29 Aug 2017 16:03:12 +0200] rev 32601
Related to issue 36736: Use read only pool also in Aging reports

Mon, 28 Aug 2017 21:49:52 +0530Fixes issue 36736: Adapt read only pool connection provider in ob reports
Atul Gaware <atul.gaware@openbravo.com> [Mon, 28 Aug 2017 21:49:52 +0530] rev 32600
Fixes issue 36736: Adapt read only pool connection provider in ob reports

Tue, 29 Aug 2017 14:46:37 +0200fixes 36741: generate xml report for individual test execution with run.test
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 29 Aug 2017 14:46:37 +0200] rev 32599
fixes 36741: generate xml report for individual test execution with run.test

XML report will be generated in src directory with named like the executed test.

Tue, 29 Aug 2017 13:02:40 +0200fixes bug 36728: Can't use fields based on some properties in selector picklist
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 29 Aug 2017 13:02:40 +0200] rev 32598
fixes bug 36728: Can't use fields based on some properties in selector picklist

With the fix for issue #36268 the selector fields based on derived properties that are shown in the picklist are sent as 'extra properties' in order to calculate them properly.

The problem is that the fix was not complete when the derived properties were not primitive. In that case the DataToJsonConverter class was not calculating properly the referenced property.

Now that kind of properties are calculated properly.

Tue, 29 Aug 2017 10:10:18 +0200fixes bug 36716: Tree view stops working when returning back from form view
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 29 Aug 2017 10:10:18 +0200] rev 32597
fixes bug 36716: Tree view stops working when returning back from form view

When opening the form view of a tree view node, Smartclient copies the values of the node properties into the form but skipping the properties involved in the tree management (these properties the child nodes are also not copied).

When returning back from the form view, the tree node is refreshed with the values of the properties stored in the form. This caused the lost of the tree information of the child nodes because, as mentioned before, the tree properties were not copied when opening the form view.

Apart from the skipped properties, the tree information of the child nodes should not have changed in form view. Therefore, to fix the problem now we do not override the children information when returning from the form view.

Mon, 28 Aug 2017 17:25:36 -0400Fixes issue 36732: In the USA organization of QA Client the RFC Order and
Armaignac <collazoandy4@gmail.com> [Mon, 28 Aug 2017 17:25:36 -0400] rev 32596
Fixes issue 36732: In the USA organization of QA Client the RFC Order and
RFC Receipt Transaction Document is not available

The organization of RFC Order and RFC Receipt document type was changed
to * in QA sampledata.

Mon, 28 Aug 2017 10:50:55 -0400Fixes issue 36729: In the USA organization of QA Client the RTV Shipment and
Armaignac <collazoandy4@gmail.com> [Mon, 28 Aug 2017 10:50:55 -0400] rev 32595
Fixes issue 36729: In the USA organization of QA Client the RTV Shipment and
RTV Order Transaction Document is not available

The organization of RTV Shipment and RTV Order document type was changed
to * in QA sampledata.