Mon, 01 Dec 2014 16:49:43 +0100Fixes bug 28286 LandedCostLineAmt should always be created in the same order
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 01 Dec 2014 16:49:43 +0100] rev 25493
Fixes bug 28286 LandedCostLineAmt should always be created in the same order

In order to help JUnit tests assert landed cost, an orderBy clause has been added when creating Landed Cost Receipt Line Amount lines, to be always created in the same order.

Thu, 04 Dec 2014 16:58:28 +0100Related to Issue 28238: Clear Goods Shipment Lines when changing Goods Shipment.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 04 Dec 2014 16:58:28 +0100] rev 25492
Related to Issue 28238: Clear Goods Shipment Lines when changing Goods Shipment.

A callout has been implemented in Goods Shipment field.

Thu, 04 Dec 2014 13:09:42 +0100Fixes Issue 28234: Check in Costing Rule Validation that the org has Currency.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 04 Dec 2014 13:09:42 +0100] rev 25491
Fixes Issue 28234: Check in Costing Rule Validation that the org has Currency.

If the organization has no currency defined, the costing process will use the currency defined in the client. This could be wrong if the currency for the transactions of this organization should be different that the currency of the client, so before validating a costing rule the organization of it should have a currency defined.

Thu, 04 Dec 2014 16:58:28 +0100Fixes issue 28309: Editing a record in form by pressing Ctrl+F2 works properly
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 04 Dec 2014 16:58:28 +0100] rev 25490
Fixes issue 28309: Editing a record in form by pressing Ctrl+F2 works properly

Three changes have been done:
- When the record edition is canceled in the form view by pressing the Cancel toolbar button, the values restored are the unedited values, not the values from the edited grid row. These original values are
saved in the action of the Ctrl+<F2> shortcut, and removed when other record is edited in form view.
- When the X button is pressed in form view on an unsaved row that was originally created in grid view, the record is deleted from the grid view.
- When an existing row is modified in grid view, then showed in form view, and its changes canceled, both the form view and the grid view show the values previous to the edition.

Thu, 04 Dec 2014 12:20:59 +0100Fixes issue 28192: Net Unit Price now is properly calculated.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 04 Dec 2014 12:20:59 +0100] rev 25489
Fixes issue 28192: Net Unit Price now is properly calculated.

In order to calculate the Net Unit Price, the adjustments of the transaction are used, but it was not being used the signMultiplier of the transaction, and needs to be used.

Thu, 04 Dec 2014 12:12:34 +0100Related to Issue 28113: Revert a change on issue 28115.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 04 Dec 2014 12:12:34 +0100] rev 25488
Related to Issue 28113: Revert a change on issue 28115.

In this cases the net unit price is the cost of the transaction

Thu, 04 Dec 2014 11:37:10 +0100Fixes Issue 28301: Cost is properly calculated after two backdated transactions.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 04 Dec 2014 11:37:10 +0100] rev 25487
Fixes Issue 28301: Cost is properly calculated after two backdated transactions.

The problem was in updateBDCostingTimeRange function. While updating the backdated average costing time, if a previous costing record was found, the future ending date was assigned to backdated costing record, not to the current costing, leaving as current costing the backdated costing record, and this is wrong.

Thu, 04 Dec 2014 11:31:24 +0100Fixes Issue 28238: Cost Adjustment of Landed Cost type properly created.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 04 Dec 2014 11:31:24 +0100] rev 25486
Fixes Issue 28238: Cost Adjustment of Landed Cost type properly created.

Receipt tab of Landed Cost has been designed to work in the following way:
* either a Goods Receipt header is selected in 'Goods Receipt' field -> this option implies that specified landed cost are distributed among all Goods Receipt lines.
* or a Goods Receipt header is selected in Goods Receipt field and a Goods Receipt line 'of the very same Goods Receipt' is selected in the field 'Goods Receipt Line' -> this option implies that specified landed cost are distribute just for the Goods receipt line selected.
Above behaviour implies that Goods Receipt lines field lists only goods receipt lines of the goods receipt selected in Goods Receipt field. In order to do this a where clause has been added in Goods Receipt Lines selector to only display lines of the selected header, if no header is selected, no lines would be displayed.

Tue, 02 Dec 2014 13:44:23 +0530Fixed bug 27809: The Wrong sales invoice alert can not be properly deactivated.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Tue, 02 Dec 2014 13:44:23 +0530] rev 25485
Fixed bug 27809: The Wrong sales invoice alert can not be properly deactivated.

Method existsAlertRule on Alerts For Wrong Invoices module script xsql file was changed to not take into account if wrong invoice alert is active or not so when module script is executed and the mentioned alert is deactivated it is recognized as an existent rule and it is not inserted again as active.
Now it is possible to deactivate The Wrong sales invoice alert and conserves its status, no matter an update database is executed.

Mon, 01 Dec 2014 15:22:06 +0100Fixed issue 27877: No rollback is called in connection error catch.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 01 Dec 2014 15:22:06 +0100] rev 25484
Fixed issue 27877: No rollback is called in connection error catch.

It seemed to be possible to have a connection leak caused in the "UsageAudit.java" class.
That was because at the final function of this class in a try catch block there was no rollback done.
After some tests it seems not to be any connection leak even without the rollback. But the proper code
to make the rollback has been created, because it seems to be better that way.
For developing this, a new method has been created "releaseConnection". This method is called in the three
try catch blocks of the method "auditActionNoDal".
Now, if one of those excepcions are reached, a rollback will be done.