Fri, 10 Jun 2016 09:50:42 +0000Added signature for changeset 91b0a6cc5947
RM packaging bot <staff.rm@openbravo.com> [Fri, 10 Jun 2016 09:50:42 +0000] rev 29647
Added signature for changeset 91b0a6cc5947

Fri, 10 Jun 2016 09:50:42 +0000Added tag 3.0PR16Q2 for changeset cfff3c184b53
RM packaging bot <staff.rm@openbravo.com> [Fri, 10 Jun 2016 09:50:42 +0000] rev 29646
Added tag 3.0PR16Q2 for changeset cfff3c184b53

Fri, 10 Jun 2016 09:50:42 +0000Update AD_MODULE version to 3.0PR16Q2 3.0PR16Q2
RM packaging bot <staff.rm@openbravo.com> [Fri, 10 Jun 2016 09:50:42 +0000] rev 29645
Update AD_MODULE version to 3.0PR16Q2

Thu, 02 Jun 2016 12:51:40 +0200Related to issue 33086: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 02 Jun 2016 12:51:40 +0200] rev 29644
Related to issue 33086: Code review improvements

Thu, 02 Jun 2016 12:39:23 +0200Fixes issue 33086: Accounting info not loaded when login
Sanjota <sanjota.nelagi@promantia.com> [Thu, 02 Jun 2016 12:39:23 +0200] rev 29643
Fixes issue 33086: Accounting info not loaded when login

Unhomogeneous behavior depending on Org Access when role is defined at "Organization" user level.
Accounting info was not loaded when login with a role without access to any general ledger's organization.

Mon, 30 May 2016 18:33:13 +0200Related to issue 33053: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 30 May 2016 18:33:13 +0200] rev 29642
Related to issue 33053: Code review improvements

Fri, 27 May 2016 12:53:49 -0400Fixed issue 33053: Permissions problems after process payment solved.
Mark <markmm82@gmail.com> [Fri, 27 May 2016 12:53:49 -0400] rev 29641
Fixed issue 33053: Permissions problems after process payment solved.

Role defined for an specific org is not able to see data from sister orgs.

Regression was introduced by the commit associated to issue 28931:
http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4

Changes were rolled back.
Also this patch includes fix for the issue 28931, avoiding to remove from the Writable Organizations List of the OBContext object, the Organization of the sequence of the payment's document type, if this organization is already in the list of accesible organizations of the current logged role.

Mon, 23 May 2016 13:43:19 +0200Related to issue 32916: Update copyright year
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 23 May 2016 13:43:19 +0200] rev 29640
Related to issue 32916: Update copyright year

Thu, 19 May 2016 15:15:02 +0200Fixes issue 32916: Fix properly issue 31457
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 19 May 2016 15:15:02 +0200] rev 29639
Fixes issue 32916: Fix properly issue 31457

Change getOrderedPaymentScheduleDetails method in AddPaymentActionHandler class to order by absolute value of FIN_PaymentScheduleDetail.PROPERTY_AMOUNT property.
Change also the manage negative amounts check to recalculate remainingAmount if it is lower than outstandingAmount in case remainingAmount is negative.

Mon, 23 May 2016 13:31:02 +0200fixes issue 32838: Cannot export CSV from Widgets
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 23 May 2016 13:31:02 +0200] rev 29638
fixes issue 32838: Cannot export CSV from Widgets

The name of the parameter used to sent the tab ID when exporting to CSV changed, this
affected a check on DataSourceServlet that was always true when exporting widgets until now.

Created an utility method to check whether a json value can be considered as
empty which takes into account common cases of null and undefined literals.

Fri, 20 May 2016 10:08:11 +0200Fixes issue 33006: Stock before costing rule not shown in Valued Stock Report
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 20 May 2016 10:08:11 +0200] rev 29637
Fixes issue 33006: Stock before costing rule not shown in Valued Stock Report

Convert current costing rule starting date with to_timestamp instead of with to_date function to avoid date truncation.
Before, current costing rule starting date was truncated and closing and opening inventories created by costing rule validation were taken, so stock was zero.
Now, current costing rule starting date will not be truncated and only opening inventory created by costing rule validation will be taken, then stock will be the same as before the costing rule.

Fri, 20 May 2016 11:08:28 +0200fixed bug 33013: error in Instance Activation when using an expired license
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 20 May 2016 11:08:28 +0200] rev 29636
fixed bug 33013: error in Instance Activation when using an expired license

When using a license within an erroneous state (such as expired), message severity
was incorrectly obtained from the enum, causing an exception to be thrown.

Fixed by using MsgSeverity.forType method instead of valueOf. forType method
was designed with this purpose.

In addition, some other changes have been done on MsgSeverity enum:
* valueOf method is static so no need to invoke it on an instance (to may be
another one, which is weird).
* checking with actual type rather than with toString (which might change)
* reversed comparision order to prevent NPE in case param in null

Tue, 03 May 2016 11:36:04 +0200Related to issue 32982: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 03 May 2016 11:36:04 +0200] rev 29635
Related to issue 32982: Code review improvements

Mon, 02 May 2016 16:58:34 +0530Fixes issue 32982: Generate duplicate payment plan under some circumstances
Atul Gaware <atul.gaware@openbravo.com> [Mon, 02 May 2016 16:58:34 +0530] rev 29634
Fixes issue 32982: Generate duplicate payment plan under some circumstances

Before processing order, a check is done whether processed flag is N or not.

Tue, 26 Apr 2016 10:47:23 +0200fixed bug 32779: wrong values displayed in status bar on record creation
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 26 Apr 2016 10:47:23 +0200] rev 29633
fixed bug 32779: wrong values displayed in status bar on record creation

When a new record is created just after processing a previous one, status bar
displayed valued of the previous record instead of being in New mode.

Fixed by forcing status bar reset on FIC response for NEW.

Thu, 21 Apr 2016 22:38:45 +0200related to issue 32757: run missing synchronize terminology
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 21 Apr 2016 22:38:45 +0200] rev 29632
related to issue 32757: run missing synchronize terminology

Thu, 21 Apr 2016 18:57:19 +0200fixes issue 32757: Hide the 'Recalculate Permissions' button
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 21 Apr 2016 18:57:19 +0200] rev 29631
fixes issue 32757: Hide the 'Recalculate Permissions' button

Mon, 18 Apr 2016 18:51:42 +0200Fixes issue 32697: Applied Product Services Code Review
Unai Martirena <unai.martirena@openbravo.com> [Mon, 18 Apr 2016 18:51:42 +0200] rev 29630
Fixes issue 32697: Applied Product Services Code Review

Fri, 08 Apr 2016 14:51:17 +0530Fixes Issue 32594:Cash VAT field of document header is updated to 'N'
Atul Gaware <atul.gaware@openbravo.com> [Fri, 08 Apr 2016 14:51:17 +0530] rev 29629
Fixes Issue 32594:Cash VAT field of document header is updated to 'N'
when you insert a tax rate of 0

Added condition prior to update the order cash flag vat, to check
whether tax is non withholding tax and non zero tax.

Code is now shifted to C_OrderTax and C_InvoiceTax Triggers instead
of C_OrderLine and C_InvoiceLine Triggers.

Thu, 14 Apr 2016 17:49:21 +0200fixes issue 32628: cannot propagate privileges if a template role has been used
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 14 Apr 2016 17:49:21 +0200] rev 29628
fixes issue 32628: cannot propagate privileges if a template role has been used
Now the client/org check is skipped when propagating changes (create, remove, update) privileges. This is done by using the OBContext.setAdminMode(false).
Besides, the UINAVBA_MenuRecentList preference has been included into the preference black list, which is a list that prevents the propagation of all the preferences included within it.

Thu, 14 Apr 2016 17:45:28 +0200fixes issue 32630: template role cannot be used as session role
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 14 Apr 2016 17:45:28 +0200] rev 29627
fixes issue 32630: template role cannot be used as session role
Now the injector used for preferences returns the complete Role object and not a proxy, in order to prevent possible LazyInitializationException when using a template role as session role.
This was happening because some preferences are created at system level when a session role is making use of the UI. It is also verified that after fixing this issue, those preferences are not being propagated, thanks to the preference black list.

Mon, 11 Apr 2016 11:02:52 +0200Related to issue 32611: Update copyright
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 11 Apr 2016 11:02:52 +0200] rev 29626
Related to issue 32611: Update copyright

Wed, 06 Apr 2016 15:23:01 +0530Fixes bug 32611:Not possible to execute Automatic Deposit payment created in FA
Atul Gaware <atul.gaware@openbravo.com> [Wed, 06 Apr 2016 15:23:01 +0530] rev 29625
Fixes bug 32611:Not possible to execute Automatic Deposit payment created in FA

Before creating a record in financial account transaction, check is done: if transaction exists, get it so that no transactiom is created and the same is sent for processing

Tue, 05 Apr 2016 15:27:50 +0200Fixed bug 32586: fetch method does not retrieves data with a non active entity
Inigo Sanchez <inigo.sanchez@openbravo.com> [Tue, 05 Apr 2016 15:27:50 +0200] rev 29624
Fixed bug 32586: fetch method does not retrieves data with a non active entity

The problem here was that fetch method does not retrieves data with a non active
entity. (e.g., if it is tried to obtain a non active organization). It is not take
into account non active entities.

Now, the issues has been fixed by adding setFilterOnActive(false); to take into
account non active entities too.

Thu, 16 Jun 2016 07:25:32 +0200Related to issue Related to issue 0033267: Add JSBeautifier script
Miguel de Juana <miguel.dejuana@openbravo.com> [Thu, 16 Jun 2016 07:25:32 +0200] rev 29623
Related to issue Related to issue 0033267: Add JSBeautifier script

- Show a more clear error message

Wed, 15 Jun 2016 14:26:32 +0200Related to issue 33082: Improve method doc
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 15 Jun 2016 14:26:32 +0200] rev 29622
Related to issue 33082: Improve method doc

Wed, 15 Jun 2016 14:20:57 +0200Related to issue 33082: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 15 Jun 2016 14:20:57 +0200] rev 29621
Related to issue 33082: Code review improvements

Wed, 08 Jun 2016 11:58:42 +0530Fixes issue 33082: Payment Schedule Detail duplicated in "Modify Payment Plan"
Atul Gaware <atul.gaware@openbravo.com> [Wed, 08 Jun 2016 11:58:42 +0530] rev 29620
Fixes issue 33082: Payment Schedule Detail duplicated in "Modify Payment Plan"

Avoid creation of payment schedule detail for cancelled psd if there exists for a payment detail.

Wed, 15 Jun 2016 09:06:46 +0200fixed bug 33166: writable access is not checked when editing client/org
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 15 Jun 2016 09:06:46 +0200] rev 29619
fixed bug 33166: writable access is not checked when editing client/org

A role without access to organization A could edit it in Organization window.

Writable access was bypassed in this case both in UI and DAL.

This patch includes two fixes:
- DAL (SecurityChecker) treats instances of Client and Organization objects
as special cases getting the client or organization ids not from FK property
but directly as their id. In this manner checking for those entities is
performed.
- Grid UI. Similar implementation is done to decide whether a row should be
marked as ready only. In this case it is not possible to reuse previous code
as the checks are done on a json object instead of on a DAL object.

Wed, 15 Jun 2016 08:39:05 +0200related to bug 33166: writable access is not checked when editing client/org
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 15 Jun 2016 08:39:05 +0200] rev 29618
related to bug 33166: writable access is not checked when editing client/org

Code clean up: consolidated 3 implementations of checkWritable in one:
- SecurityChecker.checkWriteAccess duplicated code in SecurityChecker.isWritable
with the only difference of returning a boolean instead of throwing an
exception. Now isWritable invokes checkWriteAccess.
- FIC implemented again this check to make the UI readonly for non writable
rows, now it invokes SecurityChecker.isWritable method.