Tue, 17 Nov 2015 08:49:16 +0100fixes issue 29746: unneded FIC request on record selection in some windows
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 17 Nov 2015 08:49:16 +0100] rev 27907
fixes issue 29746: unneded FIC request on record selection in some windows

This problem happens on those windows which do not have buttons on the right side of the toolbar. The EDIT request was introduced to solve issue #18711 in order to set the session variables in grid mode. This called was done through this.view.setContextInfo();. Then after fixing issue #20522 the second call in SETSESSION mode was introduced.

To avoid the call in EDIT mode we have just removed the call to this.view.setContextInfo();. This way just the call in SETSESSION mode is performed.

Sat, 14 Nov 2015 14:34:45 +0100Fixed 31482: Fix Type Safety and Raw Types warnings
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 14:34:45 +0100] rev 27906
Fixed 31482: Fix Type Safety and Raw Types warnings

- AdvPaymentMngtDao, parametrize obc parameters as function
is private and only used with that specific paramtetric type
- ConvertQuotationIntoOrder
- Iterator+Entry usage of a already parametric Map
So no reason to abandon type info + later need manual casts
again.
- ProductionMultiple problem is older servlet api not having
a generic version of those methods so just silence this one
with a SupressWarnings

Sat, 14 Nov 2015 14:19:01 +0100Fixed 31481: Fix & improve javadoc generation
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 14:19:01 +0100] rev 27905
Fixed 31481: Fix & improve javadoc generation

- add modules src + src-test to generated javadoc to not miss all the
code in modules in the docs (convert to subelement sourcepath for this)
- fix referencing java sources in src-test by adding /src to the reference
- add modules/*/lib/test/*.jar to find referenced class in test code
- update link to standard java6 javadoc to use newer url

- 2-3 simple javadoc syntax fixes in java files

Sat, 14 Nov 2015 13:26:10 +0100Fixed 31480: Remove unnecessary casts in code
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 13:26:10 +0100] rev 27904
Fixed 31480: Remove unnecessary casts in code

A few distinct patterns:
- Cast from XX directly to XX just not needed at all
- sometimes from .uniqueResult()
- somtimes from i.e. reading from typed Map
- Cast from Object to XX then passing to API using object anyway
i.e. result of .uniqueResult() then passing to Restrictions.eq
- some misc ones like DalUtil.getId to String when not required

Sat, 14 Nov 2015 13:22:20 +0100Fixed 31479: Fix NPE with bdPriceList being null.
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 13:22:20 +0100] rev 27903
Fixed 31479: Fix NPE with bdPriceList being null.

Fix logic error in if-condition to ensure the bdPriceList != null
check works as intended.

Sat, 14 Nov 2015 13:12:53 +0100Fixed 31478: Fix all warnings to access static fields in a static way.
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 13:12:53 +0100] rev 27902
Fixed 31478: Fix all warnings to access static fields in a static way.

i.e. json.NULL -> JSONObject.NULL
with NULL being a static constant in that class

Fri, 13 Nov 2015 17:08:52 +0100Fixed 30681. Cleanup rest of warnings in src-core
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 13 Nov 2015 17:08:52 +0100] rev 27901
Fixed 30681. Cleanup rest of warnings in src-core

Cleanup all (but 2) warnings in src-core:

- HttpBaseServlet:
Fix NPE. Apparently wrong operator used as testing for ""
for a nullpointer does not make sense. But testing for not
null and not empty does.
- JNDIConnectionProvider.PoolInfo
Add default serialVersionUID constant
- TranslationHandler remove never read field. Add comment to (public)
setter about its value not being used.
- TranslationUtils
Remove local variable never being read

Fri, 13 Nov 2015 16:12:27 +0100Issue 30681: Fix all 'Parameter should not be assigned warnings' in src-core
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 13 Nov 2015 16:12:27 +0100] rev 27900
Issue 30681: Fix all 'Parameter should not be assigned warnings' in src-core

Same fix always in case parameter p is written to:
Rename parameter to _p
Create temporary variable p in first line of the method, assigning it
from the _p renamed parameter.

Additionally in file BuildValidationHandler:
Chaneg access to members basedir and module to be static and not via
this. as those are static fields.

Fri, 13 Nov 2015 16:02:57 +0100Issue 30681: Fix all 'Name Shadowing an Conflicts' warnings in src-core
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 13 Nov 2015 16:02:57 +0100] rev 27899
Issue 30681: Fix all 'Name Shadowing an Conflicts' warnings in src-core
Mostly 2 classes:
- parameter name same as field name
Solve by renaming parameter to be unique in all function
as it takes precendence over field name unless using this.
- Local variable having same name as field name
Solve by renaming local variable as it takes precedence over
field name unless using this.
Exceptions:
- Slqc.java remove parameter out completely as it was never used
in the function
- XmlTemplate: remove field uri as it was never used (so now only
local var in some methods without shading the field)
- XmlVectorValue
- Remove unused field xmlDocument and references writing to it
as it was never read
- remove function printStringBuffer(HaspMap...) completely as
it was never used

Mon, 09 Nov 2015 13:41:23 +0100Fixes issue 31144: Error in Costing Background
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 09 Nov 2015 13:41:23 +0100] rev 27898
Fixes issue 31144: Error in Costing Background

Costing Background process was failing when first costing rule of an organization was validated with a starting date in the future.
Transactions before this starting date were calculated at zero cost but they were not set as processed, and then Costing Background was wrongly taking those transactions into account to calculate their cost.