Tue, 15 Jan 2019 09:13:55 +0100[smt] Code Review changes: Fixed year in license and added final modifier
David Miguelez <david.miguelez@openbravo.com> [Tue, 15 Jan 2019 09:13:55 +0100] rev 35367
[smt] Code Review changes: Fixed year in license and added final modifier
to some variables.

Tue, 15 Jan 2019 09:13:28 +0100[smt] Code Review changes: Add a new line in the hql query clause
David Miguelez <david.miguelez@openbravo.com> [Tue, 15 Jan 2019 09:13:28 +0100] rev 35366
[smt] Code Review changes: Add a new line in the hql query clause
to make it more readable.

Mon, 14 Jan 2019 17:43:35 +0100[smt] Code Review changes:
David Miguelez <david.miguelez@openbravo.com> [Mon, 14 Jan 2019 17:43:35 +0100] rev 35365
[smt] Code Review changes:

* Fixed year in license
* Fixed identation

Mon, 14 Jan 2019 17:43:16 +0100[smt] Code Review changes:
David Miguelez <david.miguelez@openbravo.com> [Mon, 14 Jan 2019 17:43:16 +0100] rev 35364
[smt] Code Review changes:

* Variables that are a reference for an UUID should be of lenght 32
* Split some queries into several lines to improve redability
* Use joins with 'on' clauses instead of cross joins to improve redability
* Removed duplicated assignation of taxcategory_id to null
* Removed part of comment that was not necessary in the code
* Use uppercase always for SQL reserved keywords

Mon, 14 Jan 2019 17:09:09 +0100[smt] Code Review changes:
David Miguelez <david.miguelez@openbravo.com> [Mon, 14 Jan 2019 17:09:09 +0100] rev 35363
[smt] Code Review changes:

* Changed variable names in trigger to use more descriptive names
and to ensure that all variable names starts with 'v_' and the ones
that referece to an id column ends with '_id'

Mon, 14 Jan 2019 16:44:31 +0100[smt] Code Review Changes:
David Miguelez <david.miguelez@openbravo.com> [Mon, 14 Jan 2019 16:44:31 +0100] rev 35362
[smt] Code Review Changes:

* Updated year in license
* Corrected identation (make it consistent throughout the PL)

Tue, 15 Jan 2019 11:15:32 +0100Merging Service Taxes project
Adrián Romero <adrianromero@openbravo.com> [Tue, 15 Jan 2019 11:15:32 +0100] rev 35361
Merging Service Taxes project

Fri, 11 Jan 2019 09:30:33 +0100Services can modify taxes project
Adrián Romero <adrianromero@openbravo.com> [Fri, 11 Jan 2019 09:30:33 +0100] rev 35360
Services can modify taxes project

Thu, 24 Jan 2019 16:07:24 +0530Fixes Issue 39986:Invoice status in goods shipment is not correctly
Atul Gaware <atul.gaware@openbravo.com> [Thu, 24 Jan 2019 16:07:24 +0530] rev 35359
Fixes Issue 39986:Invoice status in goods shipment is not correctly
calculated in some circumstances

** When calculating invoice status sum of absolute value of quantities
should be considered to have proper invoice status values. If
quantities are combination of positive and negative values then simple
sum will produce wrong results.

Thu, 24 Jan 2019 10:25:44 +0100related to issue 40009: minor code cleanup
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 24 Jan 2019 10:25:44 +0100] rev 35358
related to issue 40009: minor code cleanup

- Use diamond operator
- Rename field "parameters" to prevent any misunderstanding/clash with field "PARAMETERS"
- Use a StringBuilder instead of String concatenation
- Renamed "_parameter" to follow standard name guidelines
- Remove commented-out code
- Remove condition that was always being evaluated to false
- Iterate over the "entrySet" instead of the "keySet"
- Add comment to explain the ignored exception
- Replaced if-then-else statement by a single return statement