Fri, 06 Jul 2018 13:28:36 +0000Update AD_MODULE version to 3.0PR18Q2.1 3.0PR18Q2.1
RM packaging bot <staff.rm@openbravo.com> [Fri, 06 Jul 2018 13:28:36 +0000] rev 34293
Update AD_MODULE version to 3.0PR18Q2.1

Thu, 05 Jul 2018 10:04:26 +0200fixes issue 38900: jaxbl-impl library should be included in the classpath
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 05 Jul 2018 10:04:26 +0200] rev 34292
fixes issue 38900: jaxbl-impl library should be included in the classpath

Thu, 05 Jul 2018 09:10:01 +0200fixes issue 38898: not necessary to include jaxws-api library
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 05 Jul 2018 09:10:01 +0200] rev 34291
fixes issue 38898: not necessary to include jaxws-api library

Wed, 04 Jul 2018 09:22:23 +0200related to issue 38879 added modulescript with default value of preference
Sandra Huguet <sandra.huguet@openbravo.com> [Wed, 04 Jul 2018 09:22:23 +0200] rev 34290
related to issue 38879 added modulescript with default value of preference

added modulescript with default value of hierarchical price list
preference depends on the openbravo version.

Mon, 25 Jun 2018 15:28:36 -0400Fixed issue 38879:The process "Create price list" increases the product price
Armaignac <collazoandy4@gmail.com> [Mon, 25 Jun 2018 15:28:36 -0400] rev 34289
Fixed issue 38879:The process "Create price list" increases the product price

The process Create Price List was increasing the product price when the price list
schema have two or more lines at product level.

Now the price list schema lines defined at product level is take into account in
the Create Price List process.

A new JUnit test was added to properly check this behavior.

A new preference was created to calculate the product price in a hierarchical way

Mon, 25 Jun 2018 18:16:41 +0200Related with issue 38828: Fixes log
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 25 Jun 2018 18:16:41 +0200] rev 34288
Related with issue 38828: Fixes log

Mon, 25 Jun 2018 14:52:03 +0200Fixes issue 38828: TriggerHandler.enable no longer leaves triggers disabled
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 25 Jun 2018 14:52:03 +0200] rev 34287
Fixes issue 38828: TriggerHandler.enable no longer leaves triggers disabled

The problem was that if the flush indie TriggerHandler.enable (invoked when retrieving DAL's connection) failed, the clear method was not
invoked, and the ThreadLocal was not reset. The next time the thread was reused, it would work with disabled triggers.

Now that doesn't happen anymore because the flush is done inside the try block.

Thu, 14 Jun 2018 19:20:21 -0400Fixes issue 38773:Index on M_MATCHPO to improve performance in Create Lines From
Mark <markmm82@gmail.com> [Thu, 14 Jun 2018 19:20:21 -0400] rev 34286
Fixes issue 38773:Index on M_MATCHPO to improve performance in Create Lines From

Caused by a query that is executed for every candidate order validating that exists lines that can be
invoiced requesting information from M_MATCHPO, the Create Lines From process on Invoice windows has
bad performance and to be improved waa needed to add a new index in C_ORDERLINE_ID and C_INVOICELINE_ID
columns taking into account those records where C_INVOICELINE_ID IS NOT NULL.

Thu, 14 Jun 2018 17:08:07 +0200fixed bug 38758: with write access to an org and one child, can't read siblings
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 14 Jun 2018 17:08:07 +0200] rev 34285
fixed bug 38758: with write access to an org and one child, can't read siblings

Having an organization A, with at least 2 child nodes B and C and a role with
write access to A and only one of its children B, randomly cannot read info in
C.

Readable organizations should be all the ones that are part of the natural tree
of each of the writable organizations. When calculating them there was a wrong
optimization that assumed if an organization was already calculated to be part
of the readable orgs, its natural tree would also be so there was no need to
recalculate it.

This is not true if it was included becuase it is part of natural tree of one
of its writable descendants, in this case if this org is also writable its natural
tree needs to be calculated.

As calculating natural tree on memory is not that expensive it is not worth to
include more complex logic to decide whether it requires to be calculated or not:
now it will be calculated for all writable organizations.

Wed, 30 May 2018 10:43:21 +0200fixes issue 38653: Wrong combo values if the org id is not received by the FIC
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 30 May 2018 10:43:21 +0200] rev 34284
fixes issue 38653: Wrong combo values if the org id is not received by the FIC

Before the changes on issue #37980 when retrieving an empty organization in the FIC, the query to calculate the selected combo value was filtering by every organization in the client. After that changes, the query to calculate the combo is filtering by an empty organization list, avoiding to retrieve the correct value.

This is eventually caused by a change on how the Utility.getReferenceableOrg() method behaves. It now returns an empty list ('') if no organization is provided.

To fix the problem we are now not including the org filtering in the query generated by UIDefinition.getValueInComboReference() method if an empty organization list is provided when building the query. In this case, filtering by client should be enough.