Wed, 10 Jun 2015 16:55:01 +0200Fixes issue 30139: Error when generating credit and adding a negative line
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 10 Jun 2015 16:55:01 +0200] rev 26995
Fixes issue 30139: Error when generating credit and adding a negative line

Add Payment was raising an error if credit used was greater than total amount.
Now, this comprobation will only be done if some record has been selected in Credit To Use grid.

Wed, 10 Jun 2015 17:14:48 +0200Fixes issue 30113: Critical bug with decimals only in PostgreSQL 9.3
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 10 Jun 2015 17:14:48 +0200] rev 26994
Fixes issue 30113: Critical bug with decimals only in PostgreSQL 9.3

A new build validation has been added. This way, when executing update.database the result returned by the to_number() procedure is evaluated.
In case it does not return the expected result, the task will fail, showing a message with the link to the documentation.

Wed, 10 Jun 2015 10:22:04 +0200Fixes issue 30090: Select Payments Pick&Edit window is not working properly
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 10 Jun 2015 10:22:04 +0200] rev 26993
Fixes issue 30090: Select Payments Pick&Edit window is not working properly

When selecting a record in a P&E grid, the request done to the FIC was not using the correct mode. Now, when selecting a record, the request is properly done using the EDIT mode.

Thu, 04 Jun 2015 17:47:14 +0200Fixes issue 30098: BP current balance not properly updated
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 04 Jun 2015 17:47:14 +0200] rev 26992
Fixes issue 30098: BP current balance not properly updated

Change condition in FIN_PaymentProcess to take into account when the paymend does not have order nor invoice related (when it only has a g/l item, when we are genereting credit or when we are refunding amount).

Thu, 04 Jun 2015 17:02:09 +0200Related to issue 30104: updated copyright
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 04 Jun 2015 17:02:09 +0200] rev 26991
Related to issue 30104: updated copyright

Tue, 02 Jun 2015 09:06:32 +0200Fixed issue 30104: Completed quantity in the Work Requirement is not updated
Jorge Garcia <jorge.garcia@openbravo.com> [Tue, 02 Jun 2015 09:06:32 +0200] rev 26990
Fixed issue 30104: Completed quantity in the Work Requirement is not updated

Completed quantity in the Work Requirement is not updated under some
circumstances.

The problem was that the ma_workeffort_validate wasn't updated the UPDATED
column of the ma_wrpahse table and you can save even if the line had changed in
the work effort window.

The solution is to update the column with the actual date. Now, when you try to
save it, a error appears in the grid and the save is canceled.

Thu, 04 Jun 2015 14:54:06 +0200Fixes issue 30063: Grid is properly loaded after refreshing with a selected row
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 04 Jun 2015 14:54:06 +0200] rev 26989
Fixes issue 30063: Grid is properly loaded after refreshing with a selected row

The problem was caused by this code (the this attribute is a ResultSet), which is contained in the fetchRemoteData function:

} else if (this.grid.refreshingWithSelectedRecord) {
// if the grid was refreshed with a record selected, use the range that contained that record
// instead of using targetRecordId to improve the performance
startRow = this.grid.selectedRecordInitInterval;
endRow = this.grid.selectedRecordEndInterval;
}

If the grid is refreshed while one of its records is selected, then the startRow and endRow will be set so that the requested page contains the selected record. The problem was that the ResultSet.localData attribute was not being properly set, as at this points it was expected to contain the 'loading' value for all the rows that are being requested. As a result of this the localData attribute became malformed when the response was processed, and this caused the grid to misbehave.

To fix this, the localData is configured to wait for the proper records:

this.localData = [];
this.setRangeLoading(startRow, endRow);

Thu, 28 May 2015 13:02:49 +0200Fixes issue 30019: Payment schedule amount incorrectly calculated.
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 28 May 2015 13:02:49 +0200] rev 26988
Fixes issue 30019: Payment schedule amount incorrectly calculated.

Payment schedule amount incorrectly calculated when adding a payment from reconcile window to a sales order.
FIN_TransactionProcess and PaidStatusEventHandler have been changed in order to set invoicepaid=true only when FIN_PaymentScheduleDetail has a related InvoicePaymentSchedule.
FIN_PaymentProcess.java has also been changed, in order to check invoicePaidAmounts only if FIN_PaymentScheduleDetail has a related InvoicePaymentSchedule.
In case of a payment to a order without an invoice, updatePaymentAmounts will be called only once.
Name of preference in UpdatePaymentPlan modulescript has been update to run it again and fix wrong data created by the issue.

Tue, 26 May 2015 18:20:34 +0200Fixed bug 30010: Error in Requisition To Order window
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 26 May 2015 18:20:34 +0200] rev 26987
Fixed bug 30010: Error in Requisition To Order window

When creating a purchase order from the Requisition To Order window, an error was raised when lines[i].quantityorder is empty.
Now the SQL query returns quantityorder = 0 when it's null. Then, when inserting the purchase order line, the process inserts "" if quantityorder = 0

Wed, 20 May 2015 14:06:47 +0200Fixes issue 29980: NPE in Add Payment process request
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 20 May 2015 14:06:47 +0200] rev 26986
Fixes issue 29980: NPE in Add Payment process request

When selecting a business partner with the magnifying glass in Add Payment process request, which does not match to the type of the document (a Vendor when the type is Received In); the payment method of the business partner was null and when accessing to its id, a NPE was raised.
Now, if payment method is null will be checked.

Fri, 22 May 2015 10:58:48 +0530Fixes Issue 29995:Role without access to currency entity can not post a
Atul Gaware <atul.gaware@openbravo.com> [Fri, 22 May 2015 10:58:48 +0530] rev 26985
Fixes Issue 29995:Role without access to currency entity can not post a
purchase invoice

Entity Currency not readable issue is fixed by using switching context
to Admin mode and restoring it back again.

Tue, 19 May 2015 13:26:52 +0200Fixes bug 29986: Correct trx status assigned while deleting from reconciliation
Unai Martirena <unai.martirena@openbravo.com> [Tue, 19 May 2015 13:26:52 +0200] rev 26984
Fixes bug 29986: Correct trx status assigned while deleting from reconciliation

while checking or unchecking lines in Reconcile popup 'updateTransactionStatus' method is called to assign the proper status to the transaction. While unchecking 'Withdrawn not Cleared' or 'Deposited not Cleared' statuses has to be assigned to the transactions. This part is was wrong. When the transaction was of BP Deposit 'Withdrawn not Cleared' was being assigned and when the transaction was BP Withdrawal 'Deposited not Cleared' was being assigned.

Thu, 21 May 2015 19:24:22 +0200Fixes issue 29973: Description not transferred from G/L Journal header to lines
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 21 May 2015 19:24:22 +0200] rev 26983
Fixes issue 29973: Description not transferred from G/L Journal header to lines

Default value was removed in Description column of GL_JournalLine table. Now, it is setted correctly.
Also, an auxiliary input has been added to have the same default value in Description field of Simple G/L Journal window - Lines tab.

Thu, 21 May 2015 09:39:04 +0200fixed bug 29951: ProcessBundle.setCloseConnection(false) closes connection
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 21 May 2015 09:39:04 +0200] rev 26982
fixed bug 29951: ProcessBundle.setCloseConnection(false) closes connection

When a process is invoked through ProcessRunner and its bundle is set as
setCloseConnection(false) there were 2 problems:
- connection was close after execution so it could not be reused by another
process invoking it
- ProcessRunner tried to update the process run status on a closed connection
causing an error

The problem is caused by the fix for issue #27878 which correctly closes the
connection in DalConnectionProvider when invoking releaseCommitConnection. But
when setCloseConnection it relied in that bug not closing the connection to
leave it open.

The solution consists in doing directly the commit or rollback in DalBaseProcess
without closing the connection.

Thu, 21 May 2015 17:44:34 +0200fixed bug 29960: field changes to Id in editable P&E when adding new rows
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 21 May 2015 17:44:34 +0200] rev 26981
fixed bug 29960: field changes to Id in editable P&E when adding new rows

In P&E with editable grid, if adding new records with default value for a drop
down reference, existing records with different values for that field were changed
from identifier to uuid.

The problem was in how value map was set in this case. Instead of setting it for
the edit form it was done at grid level.

It has been fixed by setting the value map only to the field in the edit form.

Fri, 19 Jun 2015 21:56:30 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 19 Jun 2015 21:56:30 +0000] rev 26980
CI: merge back from main

Fri, 19 Jun 2015 21:40:22 +0000CI: update AD_MODULE to version 26978
RM packaging bot <staff.rm@openbravo.com> [Fri, 19 Jun 2015 21:40:22 +0000] rev 26979
CI: update AD_MODULE to version 26978

Fri, 19 Jun 2015 13:39:11 +0200Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 19 Jun 2015 13:39:11 +0200] rev 26978
Merge back from main

Fri, 19 Jun 2015 11:31:57 +0000Merge temporary head for 3.0PR15Q1.5
RM packaging bot <staff.rm@openbravo.com> [Fri, 19 Jun 2015 11:31:57 +0000] rev 26977
Merge temporary head for 3.0PR15Q1.5

Thu, 18 Jun 2015 09:16:46 +0000Added signature for changeset 370bc5330580
RM packaging bot <staff.rm@openbravo.com> [Thu, 18 Jun 2015 09:16:46 +0000] rev 26976
Added signature for changeset 370bc5330580

Thu, 18 Jun 2015 09:16:45 +0000Added tag 3.0PR15Q1.5 for changeset d2f1dd0d0b4c
RM packaging bot <staff.rm@openbravo.com> [Thu, 18 Jun 2015 09:16:45 +0000] rev 26975
Added tag 3.0PR15Q1.5 for changeset d2f1dd0d0b4c

Thu, 18 Jun 2015 09:16:44 +0000Update AD_MODULE version to 3.0PR15Q1.5 3.0PR15Q1.5
RM packaging bot <staff.rm@openbravo.com> [Thu, 18 Jun 2015 09:16:44 +0000] rev 26974
Update AD_MODULE version to 3.0PR15Q1.5

Thu, 18 Jun 2015 09:15:31 +0000dummy commit to update obx version
RM packaging bot <staff.rm@openbravo.com> [Thu, 18 Jun 2015 09:15:31 +0000] rev 26973
dummy commit to update obx version

Wed, 17 Jun 2015 14:28:09 +0200Related to issue 30020: Backout changeset a8be86693dca
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 17 Jun 2015 14:28:09 +0200] rev 26972
Related to issue 30020: Backout changeset a8be86693dca

Wed, 17 Jun 2015 14:26:31 +0200Related to issue 30099: Backout changeset 4e160be010d7
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 17 Jun 2015 14:26:31 +0200] rev 26971
Related to issue 30099: Backout changeset 4e160be010d7

Tue, 16 Jun 2015 17:37:43 +0200Related to issue 30060: send null ROW_ID when selecting a record in P&E
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 16 Jun 2015 17:37:43 +0200] rev 26970
Related to issue 30060: send null ROW_ID when selecting a record in P&E

Send null ROW_ID to avoid the edit values be overriden by the FIC response

Mon, 15 Jun 2015 18:53:24 +0200Related to issue 30091: removed already existing condition
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 15 Jun 2015 18:53:24 +0200] rev 26969
Related to issue 30091: removed already existing condition

Mon, 15 Jun 2015 16:17:32 +0200Related to issue 30091: displayed value should be set in fk fields
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 15 Jun 2015 16:17:32 +0200] rev 26968
Related to issue 30091: displayed value should be set in fk fields

When the default value of a foreign key field in a new record does not exist already in the grid data, the display value can not be recovered in the setEditValue() method.
In order to ensure the display value is updated to reflect the new edit-value for this field, the display value is now explicitly set.

Fri, 12 Jun 2015 12:49:18 +0200Related to issue 30122: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 12 Jun 2015 12:49:18 +0200] rev 26967
Related to issue 30122: code review improvements

The invoice's payment schedules and payment monitor is only updated when all the payment schedule details are paid.

This changeset covers the scenario where an order is partially paid. Before this change, the invoice's payment schedules and payment monitor were wrongly updated considering that the payment schedule was fully paid when any of its payment schedule details was paid. That asumption may be wrong in some scenarios, for example when the order is associated to one or more payment schedule details not yet paid (isinvoicepaid=N) and at least one already paid.

Wed, 10 Jun 2015 13:09:56 +0200Fixed issue 30122: Payment plan is updating wrong in some circumstances
Jorge Garcia <jorge.garcia@openbravo.com> [Wed, 10 Jun 2015 13:09:56 +0200] rev 26966
Fixed issue 30122: Payment plan is updating wrong in some circumstances

Payment plan is updating wrong if Payment Method is set as Automatic Receipt
and a sales order is partially paid.

The problem was that the function duplicates the value of the received amount
created in the Complete process of the invoice, because the function searches
all the payment details of the payment plan that has an invoice paid
(invoicepaid column).

The solution is to search those payment details that are not pre-paid and then
update the payment plan.

Now, the values are filled correctly.