Mon, 09 Mar 2020 14:19:24 +0530Fixes BUG-0043438: Remove deprecated column DateAcct
Atul Gaware <atul.gaware@openbravo.com> [Mon, 09 Mar 2020 14:19:24 +0530] rev 37165
Fixes BUG 0043438: Remove deprecated column DateAcct
from GL_JournalLine & its references from

**AD_COLUMN & associated AD_FIELD
**Sample Data for F_B_International_Group & QA_Testing client.
**C_TAXPAYMENT_POST

Mon, 09 Mar 2020 14:29:51 +0530Fixes BUG-0043437: Remove deprecated column SHOWACCOUNTNO
Atul Gaware <atul.gaware@openbravo.com> [Mon, 09 Mar 2020 14:29:51 +0530] rev 37164
Fixes BUG 0043437: Remove deprecated column SHOWACCOUNTNO
and SHOWIBAN from C_BP_BANKACCOUNT table and its references
from

**Remove colums from C_BP_BANKACCOUNT, its reference
from AD_COLUMN & associated AD_FIELD
**Remove BusinessPartnerBankAccountHandler
**Remove usage from C_BP_BANKACCOUNTIBAN_TRG
**Remove ShowAccountNo & ShowIban data from Sample Data
from F_B_International_Group & QA_Testing client.

Mon, 09 Mar 2020 14:16:25 +0530Fixes BUG-43436:Remove deprecated column TaxAmt
Atul Gaware <atul.gaware@openbravo.com> [Mon, 09 Mar 2020 14:16:25 +0530] rev 37163
Fixes BUG 43436:Remove deprecated column TaxAmt
from C_invoiceLine

Remove references from
**C_INVOICELINE, AD_COLUMN, AD_FIELD
**C_CREATE_PINVOICE_FROM_OUTS, M_RAPPEL_INVOICE_CREATE,
C_INVOICE_POST, C_INVLINE_CHK_RESTRICTIONS_TRG
**CopyFromInvoice_data, DocLineInvoice_data, DocMatchInv_data
**Sample Data from F_B_International_Group & QA_Testing Client

Mon, 09 Mar 2020 14:13:41 +0530Fixes BUG-43435:Remove deprecated column PaymentRule
Atul Gaware <atul.gaware@openbravo.com> [Mon, 09 Mar 2020 14:13:41 +0530] rev 37162
Fixes BUG 43435:Remove deprecated column PaymentRule
from C_invoice

Remove references from
**C_INVOICE, C_INVOICE_V, C_INVOICE_V2
**AD_COLUMN, AD_FIELD
**APRM_GEN_PAYMENTSCHEDULE_INV, C_COMMISSIONRUN_PROCESS,
M_INOUT_CREATEINVOICE, M_RAPPEL_INVOICE_CREATE,
C_INVOICE_CREATE, C_INVOICE_POST, ExpenseAPInvoice,
ExpenseAPInvoice_data, C_CREATE_PINVOICE_FROM_OUTS,
C_INVOICE_TRG, C_ORDER_TRG2
**Sample Data from F_B_International_Group & QA_Testing
client.

Tue, 03 Mar 2020 16:54:16 +0100related to ISSUE-43404: Finals added
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 16:54:16 +0100] rev 37161
related to ISSUE 43404: Finals added

-Finals added

Tue, 03 Mar 2020 16:47:28 +0100fixes BUG-43404:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 16:47:28 +0100] rev 37160
fixes BUG 43404:Applied new HQL Style

Wed, 12 Feb 2020 17:48:12 +0100fixes BUG-43201: Inconsistent grid state after editing a child record
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 12 Feb 2020 17:48:12 +0100] rev 37159
fixes BUG 43201: Inconsistent grid state after editing a child record

After editing a child record of a tab that has an HQL where clause
with dynamic variables, the request to refresh the parent record was not
working fine.

This is because the HQL where clause could not be resolved because the
context information is not sent in this kind of request.

But in this case we do not need to include the tab HQL where clause at
all, as we want to refresh just the record and that means that we are
going to filter by the record ID.

Therefore, to fix this issue we are setting the _directNavigation and
_targetRecordId flags to avoid including additional filter clauses in
the request to the DefaultJSONDataService. Thus, in the request built to
refresh the current record we are now filtering just by the record ID.

Tue, 03 Mar 2020 13:38:25 +0100related to ISSUE-43400: Finals added
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 13:38:25 +0100] rev 37158
related to ISSUE 43400: Finals added

-Finals added

Tue, 03 Mar 2020 13:32:23 +0100fixes BUG-43400:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 13:32:23 +0100] rev 37157
fixes BUG 43400:Applied new HQL Style

Tue, 03 Mar 2020 12:43:14 +0100related to ISSUE-43397: Finals added and code refactored
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 12:43:14 +0100] rev 37156
related to ISSUE 43397: Finals added and code refactored

-Finals added
-Code refactored inside getOrderLines function.

Tue, 03 Mar 2020 12:30:08 +0100fixes BUG-43397:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 12:30:08 +0100] rev 37155
fixes BUG 43397:Applied new HQL Style

Tue, 03 Mar 2020 11:18:01 +0100related to ISSUE-43394: Finals added
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 11:18:01 +0100] rev 37154
related to ISSUE 43394: Finals added
-Finals added
-No sonarlint suggestions found

Tue, 03 Mar 2020 11:14:42 +0100fixes BUG-43394:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 11:14:42 +0100] rev 37153
fixes BUG 43394:Applied new HQL Style

Fri, 06 Mar 2020 14:20:35 +0100Related to ISSUE-43388. Code Review changes:
David Miguelez <david.miguelez@openbravo.com> [Fri, 06 Mar 2020 14:20:35 +0100] rev 37152
Related to ISSUE 43388. Code Review changes:
Retrieve first the query into an object and then do the !list.isEmpty() comparison.
The reason for this change is to make more obvius the list empty comparison
while reading the code.

Tue, 03 Mar 2020 09:59:55 +0100related to ISSUE-43388: Finals added
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 09:59:55 +0100] rev 37151
related to ISSUE 43388: Finals added

-Finals added
-No Sonarlint suggestions found

Tue, 03 Mar 2020 09:46:52 +0100fixes BUG-43388:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 03 Mar 2020 09:46:52 +0100] rev 37150
fixes BUG 43388:Applied new HQL Style

Mon, 02 Mar 2020 16:12:45 +0100related to ISSUE-43387: Applied Sonarlint suggestions and more
Iñigo Lerga <inigo.lerga@openbravo.com> [Mon, 02 Mar 2020 16:12:45 +0100] rev 37149
related to ISSUE 43387: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

Mon, 02 Mar 2020 15:59:28 +0100fixes BUG-43387:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Mon, 02 Mar 2020 15:59:28 +0100] rev 37148
fixes BUG 43387:Applied new HQL Style

Mon, 02 Mar 2020 14:43:26 +0100related to ISSUE-43381: Applied Sonarlint suggestions and more
Iñigo Lerga <inigo.lerga@openbravo.com> [Mon, 02 Mar 2020 14:43:26 +0100] rev 37147
related to ISSUE 43381: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

Mon, 02 Mar 2020 13:50:33 +0100fixes BUG-43381:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Mon, 02 Mar 2020 13:50:33 +0100] rev 37146
fixes BUG 43381:Applied new HQL Style

Fri, 06 Mar 2020 12:50:32 +0100Related to ISSUE-43376. Code Review changes:
David Miguelez <david.miguelez@openbravo.com> [Fri, 06 Mar 2020 12:50:32 +0100] rev 37145
Related to ISSUE 43376. Code Review changes:
Retrieve first the query into an object and then do the !list.isEmpty() comparison.
The reason for this change is to make more obvius the list empty comparison
while reading the code.

Mon, 02 Mar 2020 12:09:24 +0100related to ISSUE-43376: Applied Sonarlint suggestions and more
Iñigo Lerga <inigo.lerga@openbravo.com> [Mon, 02 Mar 2020 12:09:24 +0100] rev 37144
related to ISSUE 43376: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

Mon, 02 Mar 2020 10:46:16 +0100fixes BUG-43376:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Mon, 02 Mar 2020 10:46:16 +0100] rev 37143
fixes BUG 43376:Applied new HQL Style

Wed, 26 Feb 2020 13:46:14 +0100related to ISSUE-43336: Applied Sonarlint suggestions and more
Iñigo Lerga <inigo.lerga@openbravo.com> [Wed, 26 Feb 2020 13:46:14 +0100] rev 37142
related to ISSUE 43336: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

Wed, 26 Feb 2020 12:56:37 +0100fixes BUG-43336:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Wed, 26 Feb 2020 12:56:37 +0100] rev 37141
fixes BUG 43336:Applied new HQL Style

Fri, 06 Mar 2020 12:06:01 +0100Related to ISSUE-43324. Renamed variables
David Miguelez <david.miguelez@openbravo.com> [Fri, 06 Mar 2020 12:06:01 +0100] rev 37140
Related to ISSUE 43324. Renamed variables

Wed, 26 Feb 2020 09:40:47 +0100fixes BUG-43324:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Wed, 26 Feb 2020 09:40:47 +0100] rev 37139
fixes BUG 43324:Applied new HQL Style

Fri, 28 Feb 2020 09:05:35 +0100Related to ISSUE-43249: Code Review changes:
David Miguelez <david.miguelez@openbravo.com> [Fri, 28 Feb 2020 09:05:35 +0100] rev 37138
Related to ISSUE 43249: Code Review changes:
* Use id's instead of objects in hql queries
* Reorder methods
* Moved logic from methods into main flow as it is important
to understand the exceptions that are being managed, and those
were hidden in the new methods.

Tue, 18 Feb 2020 15:30:58 +0100related to ISSUE-43249: Applied Sonarlint suggestions and more
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 18 Feb 2020 15:30:58 +0100] rev 37137
related to ISSUE 43249: Applied Sonarlint suggestions and more

Sonarlint suggestions applied.
Finals added.
Code refactored to be more legible in different methods.

Tue, 18 Feb 2020 14:25:09 +0100fixes BUG-43249:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Tue, 18 Feb 2020 14:25:09 +0100] rev 37136
fixes BUG 43249:Applied new HQL Style