Wed, 15 Feb 2017 15:56:52 -0500Related to issue 34993: Update the invoice prepaiment amount with correct value
Mark <markmm82@gmail.com> [Wed, 15 Feb 2017 15:56:52 -0500] rev 31525
Related to issue 34993: Update the invoice prepaiment amount with correct value
if after create from a paid order line, it updates the line net amount to 0
or it changes from 0 to a another value.

If you create the invoice line from a paid order line, and then the line net amount
changes it value to 0 (by updating qty = 0 or price = 0, for instance), then
previously prepayment was remaining instead of be discarded. So, you may have an
invoice with Total Gross Amount of 0 and a prepayment different than 0.

When you are updating a line with a NEW line net amount = 0 or deleting the line,
it is needed to remove the prepayment of this line from the invoice.

If the OLD line net amount was zero (the prepayment was removed or not taken into
account when creating or updating the line) and it changes
to a non-zero new line net amount value, is necessary take into account the prepaid
order line amount to increase the invoice prepayment amount with its value.

In any other case it is not necessary update the prepayment amount of the invoice.

Tue, 14 Feb 2017 15:52:41 -0500Related to issue 34993: Code review improvements
Mark <markmm82@gmail.com> [Tue, 14 Feb 2017 15:52:41 -0500] rev 31524
Related to issue 34993: Code review improvements

Removed unnecessary variables and query.
If the invoice line will be deleted always the invoice must update it prepayment
amount. If the invoice line is related to a paid order line, then invoice
prepayment will be updated discounting the prepaid value of the order line, in
other hands the prepayment amount of the invoice will still with its value because
there are not any pay related to the order line.

Tue, 07 Feb 2017 18:24:43 +0530Fixes issue 34993: Update Prepaymentamt properly on changing the Invoicelines.
Sanjota <sanjota.nelagi@promantia.com> [Tue, 07 Feb 2017 18:24:43 +0530] rev 31523
Fixes issue 34993: Update Prepaymentamt properly on changing the Invoicelines.

Update the prepayment amount value in invoice as per updation of invoice lines referriing to orderlines.
Ex : If Order linked to invoice line is prepaid, the invoice prepayment is updated,
if the same invoiceline referring to orderline is deleted then the prepayment amount is updated properly.

Tue, 14 Feb 2017 14:44:17 +0100Fixed bug 35203: performance problem in DocInvoice with cashvat functionality
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 14 Feb 2017 14:44:17 +0100] rev 31522
Fixed bug 35203: performance problem in DocInvoice with cashvat functionality

Solution based on patch supplied by MAL.

Added three new columns to C_INVOICETAX_CASHVAT_V view: c_invoice_id, c_tax_id and isprepayment. Note that this won't create a performance issue, since the correspondent tables are already included in the view.
Redesign HQL query in CashVATUtil.calculatePrepaidPercentageForCashVATTax() method to use those new columns avoiding slow joins to external tables.

After the change the query for this method just uses the C_InvoiceTax_CashVAT_V view without joining with other tables thus improving the performance.

Tue, 14 Feb 2017 14:20:26 +0100fixed bug 35260: unneeded flushes in window settings action handler
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 14 Feb 2017 14:20:26 +0100] rev 31521
fixed bug 35260: unneeded flushes in window settings action handler

* No need to flush before querying with sqlc.
* This is a readonly process, so we can safelly clear session at the end so
that flush done when finalizing the thread don't require to check any object
for dirtiness

Tue, 14 Feb 2017 13:43:51 +0100related to bug 35258: updated dbsourcemanager library
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 14 Feb 2017 13:43:51 +0100] rev 31520
related to bug 35258: updated dbsourcemanager library

Mon, 13 Feb 2017 13:02:43 +0100Fixes issue 35241: Random failure in TestCosting when executing it in Oracle
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 13 Feb 2017 13:02:43 +0100] rev 31519
Fixes issue 35241: Random failure in TestCosting when executing it in Oracle

Mon, 13 Feb 2017 14:06:44 -0500Related to issue 35068: Code review improvements
Mark <markmm82@gmail.com> [Mon, 13 Feb 2017 14:06:44 -0500] rev 31518
Related to issue 35068: Code review improvements

Used a HQL query instead of a direct SQL query.

Mon, 13 Feb 2017 12:41:34 +0530Fixes Issue 35068: Valued Stock Report is showing warehouses that do not
Atul Gaware <atul.gaware@openbravo.com> [Mon, 13 Feb 2017 12:41:34 +0530] rev 31517
Fixes Issue 35068: Valued Stock Report is showing warehouses that do not
belong to the organization included in the filter

Selected warehouse or list of applicable warehouse for selected
organization sent as parameter to queries fetching valued stock
data.

Fri, 10 Feb 2017 10:11:34 -0500Related to issue 35157: Removed unused limit variable
Mark <markmm82@gmail.com> [Fri, 10 Feb 2017 10:11:34 -0500] rev 31516
Related to issue 35157: Removed unused limit variable

The limit var was declared but it values doesn't changes in any other area of the
code. So the validation to display the message will never be fulfilled.