Mon, 23 Feb 2015 05:31:09 +0000Added signature for changeset eeb462763177
RM packaging bot <staff.rm@openbravo.com> [Mon, 23 Feb 2015 05:31:09 +0000] rev 26062
Added signature for changeset eeb462763177

Mon, 23 Feb 2015 05:31:09 +0000Added tag 3.0PR14Q3.7 for changeset 949be1b4825e
RM packaging bot <staff.rm@openbravo.com> [Mon, 23 Feb 2015 05:31:09 +0000] rev 26061
Added tag 3.0PR14Q3.7 for changeset 949be1b4825e

Mon, 23 Feb 2015 05:31:08 +0000Update AD_MODULE version to 3.0PR14Q3.7 3.0PR14Q3.7
RM packaging bot <staff.rm@openbravo.com> [Mon, 23 Feb 2015 05:31:08 +0000] rev 26060
Update AD_MODULE version to 3.0PR14Q3.7

Thu, 19 Feb 2015 10:43:52 +0100Fixes issue 28985: Grid columns can be frozen
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 19 Feb 2015 10:43:52 +0100] rev 26059
Fixes issue 28985: Grid columns can be frozen

In this changeset [1], a function named fieldIsVisible was added to the OBViewGrid class, to control if a field was actually visible in the grid. The problem was that there was actually a function defined with that same name in the Smartclient's DataBoundComponent class, which is an OBViewGrid ancestor. This means that the fieldIsVisible function implemented in [1] is overwriting the original implementation, and this was not intended.

The fieldIsVisible function is invoked when a grid column is frozen, that is why the change made in [1] has created the current issue. To fix it, the name of OBViewGrid.fieldIsVisible function has been renamed to fieldIsVisibleInGrid. It has been checked that there is no function defined with that name in any OBViewGrid ancestor class.

[1] https://code.openbravo.com/erp/devel/pi/rev/25794

Tue, 17 Feb 2015 13:40:24 +0100Fixed bug 28956: Negative Cash VAT info when partially paying Credit Memo
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 17 Feb 2015 13:40:24 +0100] rev 26058
Fixed bug 28956: Negative Cash VAT info when partially paying Credit Memo

When there was a partial payment in cash vat, the calculated percentage had the wrong sign (negative, when it should be possitive).
Thus the tax and taxable amounts had also the opposite sign.

The fix negates the invoice's grand total amount in case of a "reversal" document (i.e. Credit Memo), so the percentage, tax and taxable amounts are OK.

Note that the tax and taxable amount sign must honor the correspondent c_invoicetax record.
(See testlink test case: "[cashVATe180] Sales Invoice AR Credit Memo (Cash VAT). Partial Payment. Transaction account" for more info)


For fixing previous wrong data, a module script will be available in Cash VAT module 1.0.8 or higher

Fri, 20 Feb 2015 11:42:25 +0100Applied Openbravo's code format
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 20 Feb 2015 11:42:25 +0100] rev 26057
Applied Openbravo's code format

Mon, 16 Feb 2015 14:35:52 +0530Fixes Issue 28914:Should be an option to use the UOM Standard precision for
Atul Gaware <atul.gaware@openbravo.com> [Mon, 16 Feb 2015 14:35:52 +0530] rev 26056
Fixes Issue 28914:Should be an option to use the UOM Standard precision for
production or not.

Flag is provided in Unit of Measurement window to decided whether ROUNDING is
to be done using StdPrecision or not, Default value is N. Based on the flag
Rounding is done in MA_PRODUCTIONRUN_STANDARD process.

Mon, 16 Feb 2015 18:45:16 +0100related to issue 28912 .class files are missing in last commit
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 16 Feb 2015 18:45:16 +0100] rev 26055
related to issue 28912 .class files are missing in last commit

Fri, 13 Feb 2015 09:24:33 +0100Fixed bug 28912 update modulescript Issue28591UpdatePSD
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 13 Feb 2015 09:24:33 +0100] rev 26054
Fixed bug 28912 update modulescript Issue28591UpdatePSD

Modulescript Issue28591UpdatePSD should be updated in order
to fix the payment proposal lines wrongly created because of 28591

Fri, 13 Feb 2015 13:44:15 +0100Backed out changeset da4a7752b467
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 13 Feb 2015 13:44:15 +0100] rev 26053
Backed out changeset da4a7752b467

Fri, 13 Feb 2015 09:24:33 +0100Fixed bug 28912 update modulescript Issue28591UpdatePSD
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 13 Feb 2015 09:24:33 +0100] rev 26052
Fixed bug 28912 update modulescript Issue28591UpdatePSD

Modulescript Issue28591UpdatePSD should be updated in order
to fix the payment proposal lines wrongly created because of 28591

Thu, 12 Feb 2015 13:35:34 +0100Related to bug 28896: Missing entry on group by clause
Unai Martirena <unai.martirena@openbravo.com> [Thu, 12 Feb 2015 13:35:34 +0100] rev 26051
Related to bug 28896: Missing entry on group by clause

Wed, 11 Feb 2015 19:01:27 +0100Fixes bug 28896: Purchase Invoices Supplier reference is shown in add payment.
Unai Martirena <unai.martirena@openbravo.com> [Wed, 11 Feb 2015 19:01:27 +0100] rev 26050
Fixes bug 28896: Purchase Invoices Supplier reference is shown in add payment.

A case has been added in AddPaymentOrderInvoicesTransformer to display the Supplier Reference instead of Invoice Number when is configured like that in Organization Info tab, only for Purchase Invoices

Tue, 10 Feb 2015 10:52:58 +0100fixed bug 28893: can't nullify fields in grid view using window personalization
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 10 Feb 2015 10:52:58 +0100] rev 26049
fixed bug 28893: can't nullify fields in grid view using window personalization

Using a saved view, if before any edition tab was opened in form view, and
record edited in grid view, it was not possible to nullify fields.

The problem was caused by changeset to fix #28454 which assumed view.formFields
was always set in order to compute the null fields that should be kept and the
ones that should be removed when sending data to data source. This assumption was
not correct in the case of having a saved view: when applying saved view, SmartClient
removes items in view.formFields.

The fix includes 2 modifications:
1. Restore view.formFields after applying saved view
2. When calculating columns don't assume view.formFields is always set, this part
wouldn't be necessary for flow 1, but it prevents any other unforeseen possible
flow

Thu, 05 Feb 2015 12:51:09 +0100related to issue 28859 applied jsbeautifier
Sandra Huguet <sandra.huguet@openbravo.com> [Thu, 05 Feb 2015 12:51:09 +0100] rev 26048
related to issue 28859 applied jsbeautifier

Wed, 04 Feb 2015 18:10:21 +0100Fixed issue 28859: Distribute amount in add payment does not work properly
Sandra Huguet <sandra.huguet@openbravo.com> [Wed, 04 Feb 2015 18:10:21 +0100] rev 26047
Fixed issue 28859: Distribute amount in add payment does not work properly

Distribute amount in add payment window does not work
correctly with more than one negative invoice

Tue, 24 Feb 2015 11:07:02 +0100Fixes issue 29032, related with issue 28712: Backs out changeset d061c9e837aa
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 24 Feb 2015 11:07:02 +0100] rev 26046
Fixes issue 29032, related with issue 28712: Backs out changeset d061c9e837aa

This changeset has been backed out as it is breaking the int-basic-pgsql and int-basic-oracle tests.

Tue, 24 Feb 2015 10:55:13 +0100Related with issue 29032: Use arguments keyword instead of parameter array
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 24 Feb 2015 10:55:13 +0100] rev 26045
Related with issue 29032: Use arguments keyword instead of parameter array

The achieved result is the same, but using the arguments keyword is better because it would not be affected by a change in the name of the parameters

Mon, 23 Feb 2015 18:20:43 +0100Fixes bug 29032: Arguments to the selectionChanged function are passed properly
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 23 Feb 2015 18:20:43 +0100] rev 26044
Fixes bug 29032: Arguments to the selectionChanged function are passed properly

Before this changeset [1] was committed, the OBPickAndExecuteGrid.selectionUpdated(record, selected) function did not take into account the second parameter. This parameter was set to true if the record was being selected and to false if it was being deselected.

Now that the selected parameter is being taking into account, some APRM logic that should be executed when a record in a P&E window is selected is not being run. The problem was that tje selection updated function was being called incorrectly, like this:

this.Super('selectionChanged', record, state);

When invoking the Super function, all the parameters that are to be passed to the function should be included in the second argument (as an array if there are more than one). This is the way it should be done:

this.Super('selectionChanged', [record, state]);

[1] https://code.openbravo.com/erp/devel/pi/rev/d061c9e837aa5a0ce0a7fb221e1ac8c822748988

Mon, 23 Feb 2015 15:29:20 +0100related to issue 28971
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 23 Feb 2015 15:29:20 +0100] rev 26043
related to issue 28971

prevent javascript errors when thisview is null

Mon, 02 Feb 2015 16:24:12 -0500Fixed bug 28691: It is possible to add discounts to documents already processed.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Mon, 02 Feb 2015 16:24:12 -0500] rev 26042
Fixed bug 28691: It is possible to add discounts to documents already processed.

One possible solution for this issue would be to configure the C_ORDERDISCOUNT_TRG to be executed ON INSERT action, but this trigger is launched also when inserting orders for business partners with discounts defined, so the trigger logic causes a "mutating table" oracle's error.
In this case a new event handler is developed, to launch an error message, when trying to insert discounts for a sales order already processed. This change also affects the following windows: Purchase Order, Return from Customer, Return to Vendor and Sales Quotation.

Mon, 23 Feb 2015 11:17:39 +0100fixed bug 28712: record selection lost in p&e grid if data has multiple pages
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 23 Feb 2015 11:17:39 +0100] rev 26041
fixed bug 28712: record selection lost in p&e grid if data has multiple pages

In P&E grid with data displayed in several pages, if part of the selection was
not in the 1st page two errors occured:

-If after selecting a record in 2nd page another one in the 1st page was selected,
selection of record in 2nd page was lost
-If record in 2nd page was selected by using a filter, the filter was removed, and
the p&e was submitted, the selection was not sent to backend

The problem is in SC grid.getSelectedRecords which returns records only in current
page.

To solve this a cache of selected/unselected records is completelly maintained for p&e
grids without using getSelectedRecords, this is used also to send the selected recors
on p&e submission.

Mon, 23 Feb 2015 04:09:31 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 23 Feb 2015 04:09:31 +0000] rev 26040
CI: merge back from main

Mon, 23 Feb 2015 03:50:05 +0000CI: update AD_MODULE to version 26038
RM packaging bot <staff.rm@openbravo.com> [Mon, 23 Feb 2015 03:50:05 +0000] rev 26039
CI: update AD_MODULE to version 26038

Fri, 20 Feb 2015 18:06:24 +0100Issue 28130: Backout cset: ed3b5179390b
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 20 Feb 2015 18:06:24 +0100] rev 26038
Issue 28130: Backout cset: ed3b5179390b
As the new index references a retail column it must be in a retail module
and not directly in pi

Fri, 20 Feb 2015 14:49:11 +0100Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 14:49:11 +0100] rev 26037
Merge back from main

Fri, 20 Feb 2015 13:34:43 +0000Merge temporary head for 3.0PR15Q1.1
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 13:34:43 +0000] rev 26036
Merge temporary head for 3.0PR15Q1.1

Fri, 20 Feb 2015 08:50:02 +0000Added signature for changeset 831f7c3e5429
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 08:50:02 +0000] rev 26035
Added signature for changeset 831f7c3e5429

Fri, 20 Feb 2015 08:50:01 +0000Added tag 3.0PR15Q1.1 for changeset 39f3bed2ed0e
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 08:50:01 +0000] rev 26034
Added tag 3.0PR15Q1.1 for changeset 39f3bed2ed0e

Fri, 20 Feb 2015 08:50:01 +0000Update AD_MODULE version to 3.0PR15Q1.1 3.0PR15Q1.1
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 08:50:01 +0000] rev 26033
Update AD_MODULE version to 3.0PR15Q1.1