Thu, 12 Nov 2015 13:02:15 +0100Fixes issue 31451: OBException logged when it should not
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 12 Nov 2015 13:02:15 +0100] rev 27865
Fixes issue 31451: OBException logged when it should not

DefaultJsonDataService will check if it is needed to log localThrowable exception, in case it is an OBException.
New method added in OBException to allow throw exceptions without throwable cause and without log them.

Fri, 30 Oct 2015 00:43:32 +0100Related to issue 31202: Added an automated test in TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 30 Oct 2015 00:43:32 +0100] rev 27864
Related to issue 31202: Added an automated test in TestCosting

Thu, 12 Nov 2015 11:48:27 +0100Related to Issue 31202. Code Review changes.
David Miguelez <david.miguelez@openbravo.com> [Thu, 12 Nov 2015 11:48:27 +0100] rev 27863
Related to Issue 31202. Code Review changes.

While looking for existing Processed Transactions for a Product
it now takes into account costing dimensions, such as Warehouse.

Mon, 26 Oct 2015 16:40:52 +0100Related to issue 31202: Run Costing Background process for QA Testing client
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 26 Oct 2015 16:40:52 +0100] rev 27862
Related to issue 31202: Run Costing Background process for QA Testing client

Mon, 26 Oct 2015 15:07:34 +0100Related to issue 31202: Update inventory types created by Costing Rule process
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 26 Oct 2015 15:07:34 +0100] rev 27861
Related to issue 31202: Update inventory types created by Costing Rule process

Mon, 26 Oct 2015 17:00:37 +0100Fixes issue 31202: NSC when you get into 0 stock
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 26 Oct 2015 17:00:37 +0100] rev 27860
Fixes issue 31202: NSC when you get into 0 stock

Negative Stock Correction adjustment should be created when you get into zero stock (only in case you do not get into zero stock by a Closing Inventory), as it is created when you get into negative stock.

Thu, 12 Nov 2015 11:25:47 +0100fixes issue 30825: Show in Status Bar doesn't honour the Active = N flag
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 12 Nov 2015 11:25:47 +0100] rev 27859
fixes issue 30825: Show in Status Bar doesn't honour the Active = N flag

Now the OBViewFieldHandler considers the active flag to decide whether the field should be added to the status bar or not

Thu, 12 Nov 2015 10:20:59 +0100Fixed issue 30721. Fixed issue 30724
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 12 Nov 2015 10:20:59 +0100] rev 27858
Fixed issue 30721. Fixed issue 30724

Now is possible to insert or delete records in product characteristic configuration tab.


When a variant characteristic is added to a generic product all its values are copied in the configuration tab.

Thu, 12 Nov 2015 09:56:28 +0100Fixed issue 30884: Improve Add Products to Characteristic Value
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 12 Nov 2015 09:56:28 +0100] rev 27857
Fixed issue 30884: Improve Add Products to Characteristic Value

Wed, 11 Nov 2015 19:20:24 +0100related to issue 31434: improvement to not execute the same method two times
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 11 Nov 2015 19:20:24 +0100] rev 27856
related to issue 31434: improvement to not execute the same method two times

Wed, 11 Nov 2015 19:12:51 +0100fixes issue 31434: Error after cancel record creation in grid view and refresh
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 11 Nov 2015 19:12:51 +0100] rev 27855
fixes issue 31434: Error after cancel record creation in grid view and refresh

The problem was that when refreshing after cancelling the record creation in grid view, the refresh request was done considering that an existing record was selected. To avoid this problem, now after canceling, the getSelectedRecord() is cleared if the canceled record is a new one.

Wed, 11 Nov 2015 16:42:20 +0100fixes issue 31070: Deleting pop-up is never closed under some circumnstances
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 11 Nov 2015 16:42:20 +0100] rev 27854
fixes issue 31070: Deleting pop-up is never closed under some circumnstances

The problem was that when removing a record that is being editing, the updateTabTitle function was crashing when trying to access to this.viewGrid.getEditForm().isNew because this.viewGrid.getEditForm() is undefined at that point.

Apart from this, the isEditingGrid is not restored to false when removing a record which is being edited. This caused new errors after removing, because the view is not marked as in non-editing state. For this reason, now the isEditingGrid value is set to false for this case also.

Wed, 11 Nov 2015 12:22:58 +0100Merged heads
Martin Taal <martin.taal@openbravo.com> [Wed, 11 Nov 2015 12:22:58 +0100] rev 27853
Merged heads

Tue, 10 Nov 2015 09:05:49 +0100Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Martin Taal <martin.taal@openbravo.com> [Tue, 10 Nov 2015 09:05:49 +0100] rev 27852
Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Added logging statements, add wait in ImportEntryManager loop, also make sure that the wait time computation does not round, add a catch block in ImportEntryProcessorRunnable, moved the inner loop to a separate method for readability

Tue, 10 Nov 2015 17:21:18 +0100fixes issue 31411: Not possible to install modules in Module Mgmt using Edge
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 10 Nov 2015 17:21:18 +0100] rev 27851
fixes issue 31411: Not possible to install modules in Module Mgmt using Edge

The problem is that on MS Edge browser, the window.opener was lost. Now it is recovered in the same way as it was done for IE9. This avoids the javascript error that was being fired when trying to hide the loading screen in that browser.

Together with this the cache revision number has been updated in the required files.

Tue, 10 Nov 2015 16:26:06 +0100fixed bug 29910: exporting grid to csv can fail if audit fields are included
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 10 Nov 2015 16:26:06 +0100] rev 27850
fixed bug 29910: exporting grid to csv can fail if audit fields are included

This error was caused by a partial initialization of audit elements in OBViewUtil,
when this occured and label for one of these elements was tried to be obtained,
LazyInitializationException was thrown.

It has been fixed by forcing complete initialization of the elements and their
translations.

Tue, 10 Nov 2015 15:26:40 +0100Fixed issue 31417: Add some methods to LoginUtils to be accessible from other clasess
Miguel de Juana <miguel.dejuana@openbravo.com> [Tue, 10 Nov 2015 15:26:40 +0100] rev 27849
Fixed issue 31417: Add some methods to LoginUtils to be accessible from other clasess

- Move readNumberFormat and saveLoginBD to LoginUtils to be accesible from other classes.

- Add getDefaultLanguage and isDefaultRtl to LoginUtils.

Tue, 10 Nov 2015 13:23:46 +0100Related to 0031384: Backout.
Miguel de Juana <miguel.dejuana@openbravo.com> [Tue, 10 Nov 2015 13:23:46 +0100] rev 27848
Related to 0031384: Backout.

- There is an API change

Tue, 15 Sep 2015 14:02:13 +0200Related to issue 30788: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 15 Sep 2015 14:02:13 +0200] rev 27847
Related to issue 30788: code review improvements

Minor modifications:
+ Run query in admin mode
+ Usage of StringUtils.isBlank to control whitespace
+ Usage of StringBuffer to avoid String concatenation
+ Control any possible exception and return null to avoid breaking the report
+ Avoid unnecessary indentation (removed else)
+ Avoid the need of getting the Client object and using directly the id instead
+ Exists clause removed from subquery related to accounts from/to filter because it's useless and affects performance
+ Set the right param to djConfig.searchIds.push

Mon, 14 Sep 2015 13:53:36 +0200Fixes issue 30788: Add filter by document no. in Journal Entries Report
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 14 Sep 2015 13:53:36 +0200] rev 27846
Fixes issue 30788: Add filter by document no. in Journal Entries Report

Document No. field has been added to Journal Entries Report.
It will be shown only in case of Document selected has a document number property. Otherwise, it will be hidden and its value will be empty.
If it is filled with any value, report query will retrieve only records of this document with selected document number.
Query to filter by documentno will be dynamically generated from ReportGeneralLedgerJournal.java and insterted into ReportGeneralLedgerJournalData.java query.

Mon, 09 Nov 2015 13:14:03 +0100Fixed issue 0031384: Multi-server: when a user has a different default org in different servers a context changed message is shown
Miguel de Juana <miguel.dejuana@openbravo.com> [Mon, 09 Nov 2015 13:14:03 +0100] rev 27845
Fixed issue 0031384: Multi-server: when a user has a different default org in different servers a context changed message is shown

Move common methods to LoginUtils

Mon, 09 Nov 2015 12:58:54 +0100Related with issue 31317: The condition when the command is ADD is removed.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 09 Nov 2015 12:58:54 +0100] rev 27844
Related with issue 31317: The condition when the command is ADD is removed.

The "else if (request.getServletPath().toLowerCase().indexOf(SEND_PATH) != -1) {"
Condition should be removed for the correct behaviour of the attachments in the email sending.

Mon, 09 Nov 2015 16:06:16 +0100Fixed issue 29422.Adds Fixed price or Cost plus margin.
Alberto Santos <alberto.santos@openbravo.com> [Mon, 09 Nov 2015 16:06:16 +0100] rev 27843
Fixed issue 29422.Adds Fixed price or Cost plus margin.

Fri, 06 Nov 2015 16:42:23 +0530Fixes Issue 31382:Purchase Order and Goods Receipt not shown in Invoice's
Atul Gaware <atul.gaware@openbravo.com> [Fri, 06 Nov 2015 16:42:23 +0530] rev 27842
Fixes Issue 31382:Purchase Order and Goods Receipt not shown in Invoice's
Create Lines From if the Customer Invoice Terms are Do Not Invoice

In case of purchase flow Immediate (I) is set as default value for
Invoice Rule.

Fri, 06 Nov 2015 13:56:58 +0100Related to Issue 31119: Changes done in the Code Review.
David Miguelez <david.miguelez@openbravo.com> [Fri, 06 Nov 2015 13:56:58 +0100] rev 27841
Related to Issue 31119: Changes done in the Code Review.

Modified call to execute Warehouse Rule in M_Get_Stock_Param
in order to properly retrieve the OUT Parameters.
Previously it was throwing an exception always.

Wed, 04 Nov 2015 21:20:09 +0100Fixes issue 31119: Warehouse rules should be adapted to type "Parameter"
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 04 Nov 2015 21:20:09 +0100] rev 27840
Fixes issue 31119: Warehouse rules should be adapted to type "Parameter"

Create new warehouse rule procedures of type Parameter: M_UNIQUEATTRIBUTE_RULE_PARAM, M_UNIQUELOCATOR_RULE_PARAM, M_WAREHOUSE_DEFAULT_RULE_PARAM.
Deprecate old warehouse rule procedures of type PInstance: M_UNIQUEATTRIBUTE_RULE, M_UNIQUELOCATOR_RULE, M_WAREHOUSE_DEFAULT_RULE.
Update warehouse rules in F&B International Group and QA Testing clients to the new ones.

Thu, 05 Nov 2015 18:24:21 +0100Fixed issue 31329: Update the Copyright year of ERP code sor 2016.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 05 Nov 2015 18:24:21 +0100] rev 27839
Fixed issue 31329: Update the Copyright year of ERP code sor 2016.

The year of the copyright of the ERP has been updated to 2016.

Fri, 06 Nov 2015 00:47:51 +0100Related to issue 31368: Add log in importprocess to get more information if it fails
Martin Taal <martin.taal@openbravo.com> [Fri, 06 Nov 2015 00:47:51 +0100] rev 27838
Related to issue 31368: Add log in importprocess to get more information if it fails
Don't wait the min 2 seconds in test mode

Thu, 05 Nov 2015 19:00:37 +0100fixes issue 31377: Combo value not selected after open drop-down with keyboard
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 05 Nov 2015 19:00:37 +0100] rev 27837
fixes issue 31377: Combo value not selected after open drop-down with keyboard

Now the behavior of the combos when opening the drop-down with the keyboard is the same as when clicking on the arrow button with the mouse.

To solve this problem the handleKeyPress function is overriden to select the current combo value when ALT + keyboard down shortcut is pressed. Also it is checked that the combo is on a valid state before showing the drop-down.

Thu, 05 Nov 2015 16:49:15 +0100Related to issue 30986:Check translation checkbox of translated columns
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 05 Nov 2015 16:49:15 +0100] rev 27836
Related to issue 30986:Check translation checkbox of translated columns

The problem was when it is tried to translated a "process definition". In
a "Role" window it can be added a "process definition" access and it is
not translated.

It is selected "translation" checkboxes in name, help and description
columns in "OBUIAPP_Process" table to translate properly.