Wed, 09 Mar 2016 18:53:24 -0500Fixes issue 32437: Wrong orders created by the Copy Record process
Mark <m.molina@nectus.com> [Wed, 09 Mar 2016 18:53:24 -0500] rev 28798
Fixes issue 32437: Wrong orders created by the Copy Record process

Fixed the wrong Tax Amount and Total Gross Amount calculation in orders created by the Copy Record process
if price list includes taxes. These amounts are calculated when related triggers are fired, due that when
the order is cloned from the original order was necessary to reset calculated amounts and then triggers updates
them again when lines are added to the cloned order.

Wed, 09 Mar 2016 16:11:53 +0100Related to issue 32332. Removed wrong part of the diff.
Antonio Moreno Perez <antonio.moreno@openbravo.com> [Wed, 09 Mar 2016 16:11:53 +0100] rev 28797
Related to issue 32332. Removed wrong part of the diff.

Mon, 07 Mar 2016 15:46:50 +0100Fixes issue 32399: cannot filter grid when it is grouped by a column.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 07 Mar 2016 15:46:50 +0100] rev 28796
Fixes issue 32399: cannot filter grid when it is grouped by a column.

Having a column grouped, if a filter was applied in a grid, it was not possible to apply it.
A js error was thrown: Uncaught TypeError: this.data.willFetchData is not a function.

The problem was in "if (..... || (this.data.willFetchData(this.convertCriteria(criteria)))"
statement which incorrectly assumed this.data to be an object and willFetchData a function
within it. This is not true when in this situation where this.data is a Tree class.

It has been fixed by taking into account this case by checking that "this.data" defines the
function.

Tue, 01 Mar 2016 18:02:57 +0100Related to issue 32372: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 01 Mar 2016 18:02:57 +0100] rev 28795
Related to issue 32372: Code review improvements

Call line.getProductCosts only when line.transaction != null in DocInventory.java.

Mon, 29 Feb 2016 17:00:12 +0530Fixes Issue 32372:NullPointerException when posting a Physical Inventory
Atul Gaware <atul.gaware@openbravo.com> [Mon, 29 Feb 2016 17:00:12 +0530] rev 28794
Fixes Issue 32372:NullPointerException when posting a Physical Inventory
with a line without an associated transaction (not stocked product)

- Avoid insertion of zero quantity products in inventory line having
stocked flag as No.
- Code improvement to handle line with null transaction.

Mon, 29 Feb 2016 23:51:51 +0100Fixes issue 32237: Payment In and Payment Out lines are not exported to CSV.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 29 Feb 2016 23:51:51 +0100] rev 28793
Fixes issue 32237: Payment In and Payment Out lines are not exported to CSV.

The problem was that export to CSV does not work properly in some subtabs without
link to parent column (e.g.Lines subtab of Payment In/Out). Before, It was used
"tabId" to obtaing data for export to CSV and the value of the "tabId" was sent
in a variable called "tab". The Criteria that is run when it is displayed the tab
uses a property named "tabId" instead of "tab".

The solution for this case (and other related cases) is to adapt the code that
exports to CSV to use the same Criteria run when displaying the tab. Now export to
CSV uses tabId property. Besides it has been refactored some piece of code related
with export data in DataSourceServlet to use "tabId" instead of "tab".

Mon, 29 Feb 2016 17:34:08 +0100Fixed issue 32332. Added method to check if importentry has status 'Error'
Antonio Moreno <antonio.moreno@openbravo.com> [Mon, 29 Feb 2016 17:34:08 +0100] rev 28792
Fixed issue 32332. Added method to check if importentry has status 'Error'

Wed, 24 Feb 2016 18:05:08 +0530Fixes Issue 32327:"Generate invoice from receipt" button is not working
Atul Gaware <atul.gaware@openbravo.com> [Wed, 24 Feb 2016 18:05:08 +0530] rev 28791
Fixes Issue 32327:"Generate invoice from receipt" button is not working

In case tax not included in price list, gross std price and list price
was set will null value which is not allowed by db table. now they are
initiated to value zero first.

Thu, 25 Feb 2016 00:33:12 +0100Fixes issue 32247: Read only doesn't work on some columns in grid view
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 25 Feb 2016 00:33:12 +0100] rev 28790
Fixes issue 32247: Read only doesn't work on some columns in grid view

The problem is caused because it was not take into account read only when other
logic (e.g. display logic) was being applied in an editing grid view.

In order to prevent this, it take into account when a field is checks as read
only. In this case, the field is show properly.

Tue, 23 Feb 2016 16:37:30 +0100fixed bug 32309: error on update if an observer loaded current object in memory
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 23 Feb 2016 16:37:30 +0100] rev 28789
fixed bug 32309: error on update if an observer loaded current object in memory

In case an entity observer loaded current object in memory (ie. observing orderLine)
doing orderLine.getSalesOrder().getOrderLineList() there were two different instances
in memory representing the same DB row. This caused problems when trying to evict it.
Causing an exception to be thrown when updating from UI in this case.

As solution eviction is no longer performed, object is forced to be fetched from DB by
executing a Criteria.