Thu, 17 Sep 2015 13:08:45 +0200[roleInheritance] Added basic propagation feature
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 17 Sep 2015 13:08:45 +0200] rev 27677
[roleInheritance] Added basic propagation feature

Fri, 11 Sep 2015 15:08:11 +0200[roleInheritance] Merge with pi
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 11 Sep 2015 15:08:11 +0200] rev 27676
[roleInheritance] Merge with pi

Fri, 11 Sep 2015 15:06:12 +0200[roleInheritance] Added basic functionallity
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 11 Sep 2015 15:06:12 +0200] rev 27675
[roleInheritance] Added basic functionallity

Fri, 11 Sep 2015 11:37:00 +0200[roleInheritance] Added help text for new fields
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 11 Sep 2015 11:37:00 +0200] rev 27674
[roleInheritance] Added help text for new fields

Mon, 07 Sep 2015 19:04:30 +0200[roleInheritance] Application Dictionary Infraestructure
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 07 Sep 2015 19:04:30 +0200] rev 27673
[roleInheritance] Application Dictionary Infraestructure

Mon, 07 Sep 2015 09:58:01 +0200fixed issue 30761: product characteristics popup shows all values
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 07 Sep 2015 09:58:01 +0200] rev 27672
fixed issue 30761: product characteristics popup shows all values

Filter out values in product characteristics popup when the parent grid is a
selector based on a custom HQL query.

Mon, 19 Oct 2015 09:41:59 +0200related to issue 30761: improved product characteristics selector
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 19 Oct 2015 09:41:59 +0200] rev 27671
related to issue 30761: improved product characteristics selector

Take into account grid configuration in product characteristics selector, to
make it work in the same manner other selectors do:
- By default grid filter critieria is applied
- It can be configured not to apply any criteria

Fri, 04 Sep 2015 13:43:38 +0200related to issue 30761: Product characteristics popup does not work properly
Naroa Iriarte <naroa.iriarte@openbravo.com> [Fri, 04 Sep 2015 13:43:38 +0200] rev 27670
related to issue 30761: Product characteristics popup does not work properly

If any FK filter is used, the values shown in the other filters are restricted by them. This was not
happening with the product characteristics popu. In this case the whole tree was shown.

To fix this some steps have been done.
First of all it was necessary to change the where clause to take into account the filters applied in the grid.
On the other hand it has been necessary to take into account when a filter was applied in the "Product Characteristics"
column, because if at first you choose a value of a product characteristic, the second time you open the popup of
product characteristics, it is not possible to see any other product characteristic but the one previously chosen. That
was not working fine, it only has to take into account the filters applied in the grid.
To fix this, the product characteristics criteria has been removed if it existed one, and these all changes make possible to
have the values of the product characteristics filtered applying the filters of the grid but not taking into account the value
chosen in the first moment in the product characteristics popup.

Fri, 16 Oct 2015 12:34:52 +0200Fixed issue 30933: Selectors with tree reference were not working fine.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Fri, 16 Oct 2015 12:34:52 +0200] rev 27669
Fixed issue 30933: Selectors with tree reference were not working fine.

Some classes have been changed; first of all, in the ob-formitem-tree-filter.js the problem was that there was no logic
for the selector windows and this logic has been added.

There was other problem, in SelectorComponent.java. This class is the one which handles the ftl of the selectors and
there was no logic for the tree references. The getFilterEditorProperties() has been modified for being able to show
the needed structure in the view. The Datasource Id, the treeGridFields and the treeReference were needed.
A new method called getTreeGridFieldsDefinition() has been created to get the correct structure with the correct data in the
tree grid fields.

Now it is possible to use a new selector with a column whose reference is a tree.

Fri, 16 Oct 2015 10:16:54 +0200Fixes issue 30877: U1 & U2 dimensions wrong defined
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 16 Oct 2015 10:16:54 +0200] rev 27668
Fixes issue 30877: U1 & U2 dimensions wrong defined

User1 and User2 accounting dimensions were wrongly defined when calculating isDisplayed value in DimensionDisplayUtility.

Thu, 15 Oct 2015 10:11:02 +0200Related with issue 30940: The condition has been changed.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 15 Oct 2015 10:11:02 +0200] rev 27667
Related with issue 30940: The condition has been changed.

The if condition which handles the invalidation of the value maps cache has been modified for getting the correct behaviour.

Wed, 14 Oct 2015 16:12:33 +0200Related to bug 30882: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 14 Oct 2015 16:12:33 +0200] rev 27666
Related to bug 30882: code review improvements

Applied proper format to HTML table

Tue, 13 Oct 2015 13:48:01 +0530Fixes Issue 30882:Trial Balance report filter "Include Zero Figures" moved to
Atul Gaware <atul.gaware@openbravo.com> [Tue, 13 Oct 2015 13:48:01 +0530] rev 27665
Fixes Issue 30882:Trial Balance report filter "Include Zero Figures" moved to
Dimensions filter as it is only suitable for sub account level report

Dimensions filter was only visible when level choosed is subaccount so the
Include Zero Figures check box moved in this section.

Tue, 13 Oct 2015 18:04:35 +0200Fixed issue 30940: Create a new record in a form was not working fine.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 13 Oct 2015 18:04:35 +0200] rev 27664
Fixed issue 30940: Create a new record in a form was not working fine.

The problem was that, if you create a new record in form view, and after fulfilling the form, you
click in the create a new record in a form button without previously saving the firstly created record,
it was not working fine. In Goods Movements lines tab, for example, the value of the product chosen in
the first record was shown. That wasn't correct, the product should be empty.

The problem was in the "ob-standard-view-datasource.js" the value map cache was being invalidated.

To fix this, some clases have been changed.
In the "ob-standard-view.js" in the "newDocument" function the parameters the isNewDocument parameter
has been added and it is set to true.
This parameter is passed to the request for being able to take it in the class "ob-standard-view-datasource.js"
and to use it in the logic that invalidates the value map cache.
Now, if this parameter is set to true, the value map cache is not invalidated.

Tue, 13 Oct 2015 11:02:08 +0200Fixed bug 31072: added missing setters and getters for DocInvoice class
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 13 Oct 2015 11:02:08 +0200] rev 27663
Fixed bug 31072: added missing setters and getters for DocInvoice class

Fri, 09 Oct 2015 13:57:19 +0200Related to issue 31026: Change from DateTime to Absolute DateTime
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 09 Oct 2015 13:57:19 +0200] rev 27662
Related to issue 31026: Change from DateTime to Absolute DateTime

Document date and Reference date references in Inventory Amount update have been changed from DateTime to Absolute DateTime, to avoid UTC conversion.
Also dateTimeFormat.java should be used instead of dateFormat.java for date formating.

Fri, 09 Oct 2015 14:08:51 -0700Fixes Issue 30844:Cannot edit the paid amount in a Payment Proposal
Atul Gaware <atul.gaware@openbravo.com> [Fri, 09 Oct 2015 14:08:51 -0700] rev 27661
Fixes Issue 30844:Cannot edit the paid amount in a Payment Proposal
after clearing the filter.

If allRows property of grid data is null then get information from
localData property of grid data

Thu, 08 Oct 2015 15:55:09 +0200Related to issue 30842: updated copyright
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 08 Oct 2015 15:55:09 +0200] rev 27660
Related to issue 30842: updated copyright

Thu, 08 Oct 2015 10:24:55 +0530Fixes Issue 30842: GL Item combo not working when using saved view which does
Atul Gaware <atul.gaware@openbravo.com> [Thu, 08 Oct 2015 10:24:55 +0530] rev 27659
Fixes Issue 30842: GL Item combo not working when using saved view which does
not have Organization field shown in grid

If session attribute Organization of financial window is not available due to
grid column visible option then get it from requestMap.

Thu, 08 Oct 2015 14:15:32 +0200Fixes issue 31026: Wrong warehouse in Inventory Amount Update Lines
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 08 Oct 2015 14:15:32 +0200] rev 27658
Fixes issue 31026: Wrong warehouse in Inventory Amount Update Lines

When current costing rule does not have Warehouse Dimension flag activated, warehouse field should be empty in Inventory Amount Update Lines.
In this case, SL_InvAmtUpd_ProductRefDate callout will return a null warehouseId.
Document date and Reference date references in Inventory Amount update have been changed from Date to DateTime, to get the correct value when checking the current costing rule.
Reference date will also have Document date value as default value instead of current date.

Thu, 08 Oct 2015 09:33:06 +0200Fixed issue 29763: Added columns to purchase invoice dimensional report
Asier Martirena <asier.martirena@openbravo.com> [Thu, 08 Oct 2015 09:33:06 +0200] rev 27657
Fixed issue 29763: Added columns to purchase invoice dimensional report

Wed, 07 Oct 2015 19:11:13 +0200Fixed issue 29762: Add columns to purchase and sales invoice dimensional report
Asier Martirena <asier.martirena@openbravo.com> [Wed, 07 Oct 2015 19:11:13 +0200] rev 27656
Fixed issue 29762: Add columns to purchase and sales invoice dimensional report

Wed, 30 Sep 2015 16:13:10 +0200Fixed bug 30815: Scheduled Organization for Costing background process
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 30 Sep 2015 16:13:10 +0200] rev 27655
Fixed bug 30815: Scheduled Organization for Costing background process

The Costing Background Process should only be scheduled for a legal entity or any of its ancestor.

The fix adds a validation in both the ProcessRequestEventHandler, so each time a record is saved/updated the validation is run, and in the CostingBackground class itself to control wrong process request scheduled before this validation.

Tue, 06 Oct 2015 09:42:44 +0200Fixes Issue 30855. When looking for Backdated Transactions,
David Miguelez <david.miguelez@openbravo.com> [Tue, 06 Oct 2015 09:42:44 +0200] rev 27654
Fixes Issue 30855. When looking for Backdated Transactions,
the ones that have it's cost not calculated yet must not be
taken into account.

Modified the query in order to exclude them.

Wed, 07 Oct 2015 16:04:13 +0200Fixes issue 30949: Variable shadowing in ConnectionProviderContextListener
Inigo Sanchez <inigo.sanchez@openbravo.com> [Wed, 07 Oct 2015 16:04:13 +0200] rev 27653
Fixes issue 30949: Variable shadowing in ConnectionProviderContextListener

The problem was that ConnectionProviderContextListener.java had static class field with same name than parameters in two methods.

Now it has been resolved by renaming the vars in the functions.

Tue, 06 Oct 2015 15:00:31 +0530Fixes Issue 30871: Dimensions are not shown in Simple G/L Journal window
Atul Gaware <atul.gaware@openbravo.com> [Tue, 06 Oct 2015 15:00:31 +0530] rev 27652
Fixes Issue 30871: Dimensions are not shown in Simple G/L Journal window

DOCBASETYPE = GLJ Auxiliar Input for Simple G/L Journal window is set for
header and line tab.

Wed, 07 Oct 2015 09:25:04 +0200Related to issue 30832: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 07 Oct 2015 09:25:04 +0200] rev 27651
Related to issue 30832: code review improvements

M_INOUTLINE_TRG:
+ Updated copyright
+ Added more conditions to the if clause when updating
+ Usage of MOVEMENTQTY and QUANTITYORDER instead of v_qtyold, v_qty, v_qtyorderold and v_qtyorder as these variables always make true the if condition (so the fix would useless)
+ In the update part, update first the inventory for the old product/locator as it was done before the refactor

M_inoutlinetrgTest.java:
+ Totally rewritten of the JUnit
+ Support for more scenarios: update locator, update attributesetinstance, work with several lines, purchase and sales flows, etc.
+ Fixed scenarios not properly working before
+ Avoid HQL injection

Mon, 05 Oct 2015 14:56:31 +0530Fixes Issue 30832:potential unneeded storage detail updates
Atul Gaware <atul.gaware@openbravo.com> [Mon, 05 Oct 2015 14:56:31 +0530] rev 27650
Fixes Issue 30832:potential unneeded storage detail updates
on changes for m_inoutlines

Check provided in M_InOutLine_Trg before update operation whether
any of the following is changed in M_InOutLine.

Organization, Product, UOM, AttributeSetInstance, Movement Quantity,
ProductUom, Order Quantity.

Junit test cases to test M_InoutLine_Trg covers following scenarios.
- Insert M_InOutLine.
- Set Product Null in the M_InOutLine.
- Set Product in M_InOutLine where Product was null.
- Set Description in M_InOutLine.
- Delete a M_InOutLine.

Fri, 02 Oct 2015 12:39:49 +0200Fixed bug 31015: hidden fields in several windows related to acct. dimensions
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 02 Oct 2015 12:39:49 +0200] rev 27649
Fixed bug 31015: hidden fields in several windows related to acct. dimensions

The display logic of some fields driven by the accounting dimension display logic utility was not working fine when the auxiliary input "DOCBASETYPE" (used by to calculate the acct. dimension display logic) was null.
This auxiliary input has a hardcoded value in some windows, however in other windows it is gotten from the DB using the selected document type. In the latter scenario, when the document type field is blank, the "DOCBASETYPE" auxiliary input was null, so the system was unable to detect the right configuration, thus hiding the fields.

The regression is caused by issue #29767. The business partner and organization fields were configured to use the accounting dimension display logic utility in the following windows:
* Sales Order
* Purchase Order
* Sales Invoice
* Purchase Invoice
* Payment In (not affected as it has a hardcoded "DOCBASETYPE")
* Payment Out (not affected as it has a hardcoded "DOCBASETYPE")

The fix improves the SQL for getting the "DOCBASETYPE" auxiliary input in the affected windows, so in case the document type is null, a generic value (the most commonly used) is returned depending on the window:
* Sales Order: SOO
* Purchase Order: POO
* Sales Invoice: ARI
* Purchase Invoice: API

Fri, 02 Oct 2015 12:24:48 +0200Fixes issue 31006: Credit consumed although payment not completed
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 02 Oct 2015 12:24:48 +0200] rev 27648
Fixes issue 31006: Credit consumed although payment not completed

When consuming a credit with a currency different than Business Partner's currency, an error is shown but credit was also consumed, which was wrong.
Now, this check will be also done before consuming credit in AddPaymentActionHandler addCredit method, as it was done in FIN_PaymentProcess doProcessPayment method.