Fri, 18 Dec 2015 08:46:20 +0100[ChangePassword] Updated date in trigger license.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 18 Dec 2015 08:46:20 +0100] rev 28647
[ChangePassword] Updated date in trigger license.

Fri, 18 Dec 2015 08:44:45 +0100[ChangePassword] Added license to trigger.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 18 Dec 2015 08:44:45 +0100] rev 28646
[ChangePassword] Added license to trigger.

Fri, 18 Dec 2015 08:37:26 +0100[ChangePassword] Fixed licenses of file.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 18 Dec 2015 08:37:26 +0100] rev 28645
[ChangePassword] Fixed licenses of file.

Wed, 16 Dec 2015 10:11:33 +0100[ChangePassword] Added messages in AD. Solved some problems with OBDAL default restrictions
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 16 Dec 2015 10:11:33 +0100] rev 28644
[ChangePassword] Added messages in AD. Solved some problems with OBDAL default restrictions

Thu, 10 Dec 2015 12:16:57 +0100[ChangePassword] Deleted retail script.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 10 Dec 2015 12:16:57 +0100] rev 28643
[ChangePassword] Deleted retail script.

Thu, 10 Dec 2015 12:08:33 +0100[ChangePassword] Added trigger to update date once password is changed
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 10 Dec 2015 12:08:33 +0100] rev 28642
[ChangePassword] Added trigger to update date once password is changed

Fri, 27 Nov 2015 12:44:36 +0100[ChangePassword] Added logic to client and server to update the password once validity date is reached
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 27 Nov 2015 12:44:36 +0100] rev 28641
[ChangePassword] Added logic to client and server to update the password once validity date is reached

Wed, 25 Nov 2015 12:50:59 +0100[ChangePassword] Changed query to validate password date
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 25 Nov 2015 12:50:59 +0100] rev 28640
[ChangePassword] Changed query to validate password date

Wed, 25 Nov 2015 10:35:15 +0100[ChangePassword] Solved some problems importing libraries.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 25 Nov 2015 10:35:15 +0100] rev 28639
[ChangePassword] Solved some problems importing libraries.

Mon, 23 Nov 2015 18:24:08 +0100[ChangePassword] Added more logic to client and server
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 23 Nov 2015 18:24:08 +0100] rev 28638
[ChangePassword] Added more logic to client and server

Thu, 19 Nov 2015 09:33:12 +0100[ChangePassword] Added columns/fields to ad_client and ad_user. Added some logic to login in client and server
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 19 Nov 2015 09:33:12 +0100] rev 28637
[ChangePassword] Added columns/fields to ad_client and ad_user. Added some logic to login in client and server

Wed, 24 Feb 2016 18:05:08 +0530Fixes Issue 32323:"Generate invoice from receipt" button is not working
Atul Gaware <atul.gaware@openbravo.com> [Wed, 24 Feb 2016 18:05:08 +0530] rev 28636
Fixes Issue 32323:"Generate invoice from receipt" button is not working

In case tax not included in price list, gross std price and list price
was set will null value which is not allowed by db table. now they are
initiated to value zero first.

Thu, 25 Feb 2016 11:22:36 +0100fixed bug 32244: ORA shows error in log when setting an AD column to not null
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 25 Feb 2016 11:22:36 +0100] rev 28635
fixed bug 32244: ORA shows error in log when setting an AD column to not null

Implemented a better condition to decide whether not nulls should be disabled,
now it is based on the flag set for deferred not nulls, covering in this manner
some cases that were not workding before and making the code clearer to understand

Wed, 24 Feb 2016 15:43:32 +0100Fixes issue 32240: Read only doesn't work on some columns in grid view
Inigo Sanchez <inigo.sanchez@openbravo.com> [Wed, 24 Feb 2016 15:43:32 +0100] rev 28634
Fixes issue 32240: Read only doesn't work on some columns in grid view

The problem is caused because it was not take into account read only when other
logic (e.g. display logic) was being applied in an editing grid view.

In order to prevent this, it take into account when a field is checks as read
only. In this case, the field is show properly.

Tue, 23 Feb 2016 16:05:13 +0530Fixes Issue 32280:Amortization Process / Unprocess should only update Fully
Atul Gaware <atul.gaware@openbravo.com> [Tue, 23 Feb 2016 16:05:13 +0530] rev 28633
Fixes Issue 32280:Amortization Process / Unprocess should only update Fully
Depreciated field of the assets included on it and need the update

Condition added in update query to only update those assets record on which
amortization process is being called

Tue, 23 Feb 2016 16:37:30 +0100fixed bug 32308: error on update if an observer loaded current object in memory
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 23 Feb 2016 16:37:30 +0100] rev 28632
fixed bug 32308: error on update if an observer loaded current object in memory

In case an entity observer loaded current object in memory (ie. observing orderLine)
doing orderLine.getSalesOrder().getOrderLineList() there were two different instances
in memory representing the same DB row. This caused problems when trying to evict it.
Causing an exception to be thrown when updating from UI in this case.

As solution eviction is no longer performed, object is forced to be fetched from DB by
executing a Criteria.

Tue, 23 Feb 2016 16:38:23 +0100related to bug 32308: added test cases covering observers with ds update
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 23 Feb 2016 16:38:23 +0100] rev 28631
related to bug 32308: added test cases covering observers with ds update

Fri, 19 Feb 2016 13:54:47 +0100Fixed issue 32291: ChildTabRecordCounterActionHandler class removed.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Fri, 19 Feb 2016 13:54:47 +0100] rev 28630
Fixed issue 32291: ChildTabRecordCounterActionHandler class removed.

The ChildTabRecordCounterActionHandler class has been removed because it
has not been used since 2011. And the only reference to it was removed by
the changeset https://code.openbravo.com/erp/devel/pi/rev/9c8382863b3b6af99529c91a8c29bc2fe922367d

Mon, 22 Feb 2016 15:33:27 +0530Fixes Issue 32268: Wrong payment status when unmatching bankstatement line
Atul Gaware <atul.gaware@openbravo.com> [Mon, 22 Feb 2016 15:33:27 +0530] rev 28629
Fixes Issue 32268: Wrong payment status when unmatching bankstatement line
manually matched against an invoice

Incase a finTransaction is unmatched which has finPayment,status of finPayment
is also updated accordingly as per isReceipt flag

Mon, 22 Feb 2016 10:43:16 +0100Related to issue 32218: fixed db consistency
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 22 Feb 2016 10:43:16 +0100] rev 28628
Related to issue 32218: fixed db consistency

Thu, 18 Feb 2016 17:47:53 +0530Fixes Issue 32218:Payment In & Out Window Lines Tab Order Payment Plan Field
Atul Gaware <atul.gaware@openbravo.com> [Thu, 18 Feb 2016 17:47:53 +0530] rev 28627
Fixes Issue 32218:Payment In & Out Window Lines Tab Order Payment Plan Field
navigation fails

Direct Navigation Rule applied to
- Window:Payment In, Tab:Lines, Field:Order Payment Plan navigate to
Sales Order | Payment Plan Tab
- Window:Payment Out, Tab:Lines, Field:Order Payment Plan navigate to
Purchase Order | Payment Plan Tab

Fri, 19 Feb 2016 14:01:00 +0100fixes issue 32227: Mark MS Edge as supported browser
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 19 Feb 2016 14:01:00 +0100] rev 28626
fixes issue 32227: Mark MS Edge as supported browser

Fri, 19 Feb 2016 13:22:52 +0100fixes issue 32292: access error in Field tab with specific role when saving
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 19 Feb 2016 13:22:52 +0100] rev 28625
fixes issue 32292: access error in Field tab with specific role when saving

The problem is caused because the Field tab has a field for the Creation audit column. This field should be removed as audit columns should not have a field in the AD. They are generated automatically.

Fri, 19 Feb 2016 13:09:01 +0100related to issue 32231: check if values are null
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 19 Feb 2016 13:09:01 +0100] rev 28624
related to issue 32231: check if values are null

Mon, 15 Feb 2016 19:53:12 +0100Fixes issue 32023 & Fixes issue 32190: Improve PriceDifference performance
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 15 Feb 2016 19:53:12 +0100] rev 28623
Fixes issue 32023 & Fixes issue 32190: Improve PriceDifference performance

Some improvements have been done in CostingUtils.getCurrentValuedStock, CostAdjustmentUtils.getValuedStockOnMovementDateByAttrAndLocator, CostAdjustmentUtils.getValuedStockOnTransactionDate and CostingMigrationProcess.getCurrentValuedStock methods:
- Use TransactionCost.PROPERTY_ACCOUNTINGDATE field instead of coalesce(ShipmentInOut.PROPERTY_ACCOUNTINGDATE, MaterialTransaction.PROPERTY_MOVEMENTDATE) to avoid join with ShipmentInOutLine and ShipmentInOut tables.
- Use a scroll instead of looping through a list.
- Loop can not be avoid due to the need of calculate conversion rate recursively.
- Clear every 100 loops will not be done as DAL objects will not be loaded in memory and to avoid session cleared errors.
Retrieve only one or two results in some queries where more results were not needed.
Use isEmpty() instead of size().
Retrieve only lineno field instead of full object in CostAdjustmentUtils.getNewLineNo method.
Improve CostAdjustmentUtils.getTrxCost method.
Do a clear every 100 loops in PriceDifferenceProcess.processPriceDifference method to improve performance.

Fri, 19 Feb 2016 11:31:51 +0100Related to Issue 32060: Updated year in copyright.
David Miguelez <david.miguelez@openbravo.com> [Fri, 19 Feb 2016 11:31:51 +0100] rev 28622
Related to Issue 32060: Updated year in copyright.

Wed, 17 Feb 2016 11:03:01 -0500Fixes issue 32060: Wrong Goods Receipt button status under some circumstances
Mark <m.molina@nectus.com> [Wed, 17 Feb 2016 11:03:01 -0500] rev 28621
Fixes issue 32060: Wrong Goods Receipt button status under some circumstances

Column process_goods_java inside M_INOUT table was updated correctly inside the process of a Pending Goods Receipts.
The button show the expected text.

Fri, 19 Feb 2016 11:21:21 +0100fixes issue 32287: Selection can be lost in P&E grids under some circumstances
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 19 Feb 2016 11:21:21 +0100] rev 28620
fixes issue 32287: Selection can be lost in P&E grids under some circumstances

If we refresh the grid, after selecting a record in a page different from the first one, Smartclient internally prepares the request to retrieve the records surrounding the selected one, in order to try to keep the position of the scroll.

This behavior in P&E can cause the losing of the selected records, because they are always loaded on the first page. In order to prevent this, we detect this situation in P&E grids before performing the request, and in that case we adapt it to force the retrieval of the first page which contains all the selected records.

Fri, 19 Feb 2016 10:44:55 +0100fixes issue 32193: Fix selection in P&E grids having filter on change disabled
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 19 Feb 2016 10:44:55 +0100] rev 28619
fixes issue 32193: Fix selection in P&E grids having filter on change disabled

Having filter on change disabled, the filtering is not performed until enter is pressed or the focus is moved out of the text filter. In this second case, there could be problems if the focus is lost when checking a pick and edit grid record: the filtering request is performed and at the same time the actions related to the record selection are fired. This can cause the selection actions not work as expected.

This problem also affects to numeric and date filters, because they always perform the filtering after losing the focus.

To avoid this problem a new mechanism has been included for pick and edit grids, the blur method for the filter elements is overridden to prevent the selection immediately after losing the focus.

Fri, 19 Feb 2016 08:52:30 +0100related to issue 32275: fixes typo
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 19 Feb 2016 08:52:30 +0100] rev 28618
related to issue 32275: fixes typo

Thu, 18 Feb 2016 14:54:19 +0100fixed issue 32275: jUnit: add capability to assert on logs
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 14:54:19 +0100] rev 28617
fixed issue 32275: jUnit: add capability to assert on logs

TestLogAppender can be used in test cases extending OBBaseTest to perform
assertions on what is logged.

Wed, 10 Feb 2016 22:16:11 -0500Removing File BLOB reference from core
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Wed, 10 Feb 2016 22:16:11 -0500] rev 28616
Removing File BLOB reference from core

Tue, 16 Feb 2016 10:45:01 +0530Fixes Issue 31349:Mongolian language added in reference data.
Atul Gaware <atul.gaware@openbravo.com> [Tue, 16 Feb 2016 10:45:01 +0530] rev 28615
Fixes Issue 31349:Mongolian language added in reference data.

Wed, 17 Feb 2016 15:29:19 +0100fixed issue 32261: implement a typed version of OBDal.getProxy
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 15:29:19 +0100] rev 28614
fixed issue 32261: implement a typed version of OBDal.getProxy

New getProxy method returns a typed instance of the desired entity, making
unnecessary to cast it.

Wed, 17 Feb 2016 13:14:36 +0100fixed bug 32244: ORA error in log when setting an AD column to not null
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 13:14:36 +0100] rev 28613
fixed bug 32244: ORA error in log when setting an AD column to not null

Prevented trying to disable not-null constraints in case the column was already
set as nullable in DB.

Tue, 16 Feb 2016 16:45:34 +0100Merging Backed out changeset 8d06deadd164
Adrián Romero <adrianromero@openbravo.com> [Tue, 16 Feb 2016 16:45:34 +0100] rev 28612
Merging Backed out changeset 8d06deadd164

Tue, 16 Feb 2016 16:43:13 +0100Backed out changeset 8d06deadd164
Adrián Romero <adrianromero@openbravo.com> [Tue, 16 Feb 2016 16:43:13 +0100] rev 28611
Backed out changeset 8d06deadd164

Mon, 08 Feb 2016 22:15:23 +0530Fixes Issue 32136:Wrong warehouse combo validation in the 'Create Purchase
Atul Gaware <atul.gaware@openbravo.com> [Mon, 08 Feb 2016 22:15:23 +0530] rev 28610
Fixes Issue 32136:Wrong warehouse combo validation in the 'Create Purchase
Orders popup in the Purchasing Plan window

Tue, 09 Feb 2016 10:55:14 +0530Fixes Issue 32134:Price Including taxes is not supported by the Purchasing
Atul Gaware <atul.gaware@openbravo.com> [Tue, 09 Feb 2016 10:55:14 +0530] rev 28609
Fixes Issue 32134:Price Including taxes is not supported by the Purchasing
Plan (Create Purchase Orders process)

Wed, 10 Feb 2016 22:16:11 -0500Removing File BLOB reference from core
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Wed, 10 Feb 2016 22:16:11 -0500] rev 28608
Removing File BLOB reference from core

Fri, 12 Feb 2016 15:13:04 +0100Fixed bug 32216: Cash VAT tab with prepaid invoice
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 12 Feb 2016 15:13:04 +0100] rev 28607
Fixed bug 32216: Cash VAT tab with prepaid invoice

The C_INVOICETAX_CASHVAT_V view, which populates the Sales/Purchase Invoice | Cash VAT tab, has been rewritten to properly manage the scenarios of prepaid invoices where the invoice amount is lower than the original order, either because of a partial invoice or because of a cheaper invoice.

The view has been split in 2 queries merged with an union all to improve the performance:
1. The first one searches the Cash VAT records linked to a payment. In this part we only filter by the records linked to the invoice's FPS, which fixes the scenarios raised by the issue.
2. The second one searches the Cash VAT records linked to a manual cash vat settlement. In this part there is no need to join with the payment tables, so the global performance is better.

Tue, 16 Feb 2016 10:15:42 +0100fixes issue 32231: wrong number comparison when checking field access of a role
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 16 Feb 2016 10:15:42 +0100] rev 28606
fixes issue 32231: wrong number comparison when checking field access of a role

When checking the access of a numeric field, if it is an integer, the client sends the value without decimal places. This value is compared with the current value stored in the database which already stores the value with decimals. So, the comparison of the string values determines that they are different as for example we are comparing '100' with '100.00'.

To solve the problem, for this type of fields now the numeric value is compared instead of using its string representation.

Fri, 05 Feb 2016 14:06:10 +0100Fixes issue 31952: Avoid negative reservations
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Feb 2016 14:06:10 +0100] rev 28605
Fixes issue 31952: Avoid negative reservations

Set quantity to zero in case quantity + p_qty is less than zero when updating current m_reservation_stock in M_RESERVE_STOCK_MANUAL, to avoid create negative reservations.

Mon, 15 Feb 2016 19:01:37 +0100Fixes issue 32040: The ExportSampledata task can be extended
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 15 Feb 2016 19:01:37 +0100] rev 28604
Fixes issue 32040: The ExportSampledata task can be extended

The task can now be extended by:
- Defining the dataset to be exported
- Defining how to manage the where clause of the dataset tables
- Defining the DatabaseDataIO implementation to use to export a table to XML
- Defining the folder where the data should be exported to

It is also supported to define a table several times in the same dataset, and each of the dataset tables will be exported to their own xml file.

Tue, 09 Feb 2016 18:39:18 -0500Fixes Issue 32147: Transaction Type and Payment are set read only when the
Nono Carballo <f.carballo@nectus.com> [Tue, 09 Feb 2016 18:39:18 -0500] rev 28603
Fixes Issue 32147: Transaction Type and Payment are set read only when the
transaction is processed.

In Transaction tab of Financial Account window, once the transaction is processed
the fields Transaction Type and Payment are set read only.
The Read Only logic of those fields was set to @Processed@='Y'

Mon, 15 Feb 2016 18:51:09 +0100Related to Issue 31354. Updates copyright Issue.
David Miguelez <david.miguelez@openbravo.com> [Mon, 15 Feb 2016 18:51:09 +0100] rev 28602
Related to Issue 31354. Updates copyright Issue.

Thu, 11 Feb 2016 15:59:45 +0100Fixed bug 32206: Invoice reactivation with Manual Cash VAT Settlement
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 11 Feb 2016 15:59:45 +0100] rev 28601
Fixed bug 32206: Invoice reactivation with Manual Cash VAT Settlement

Avoid to reactivate an invoice linked to a Manual Cash VAT Settlement

Thu, 11 Feb 2016 13:42:35 +0100Fixed bug 32100: Reactivation control of a prepaid cash vat invoice
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 11 Feb 2016 13:42:35 +0100] rev 28600
Fixed bug 32100: Reactivation control of a prepaid cash vat invoice

When an invoice is linked to a payment, the system currently avoids to reactivate it. You first need to reactivate the payment, so the cash vat information is deleted, and then you can reactivate the invoice.
However for prepaid invoices, the system does allow to reactivate the invoice, but the cash vat information is wrongly kept.

Now we delete all the cash vat info records linked to a prepayment for this invoice at invoice reactivation time. When the invoice is latter on processed, the cash vat records will be calculated again.

Fri, 12 Feb 2016 11:04:34 +0100related to issue 32110: include version in fop library name
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 12 Feb 2016 11:04:34 +0100] rev 28599
related to issue 32110: include version in fop library name

Thu, 11 Feb 2016 09:50:00 +0100Related to issue 31354: Adapt TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 11 Feb 2016 09:50:00 +0100] rev 28598
Related to issue 31354: Adapt TestCosting

Fix foreign currency debit, foreign currency credit and currency checks for ReceiptInvoiceMatch document in assertDocumentPost method in testCostingMC444 and testCostingMC445 tests.

Tue, 09 Feb 2016 12:46:23 +0100Related to issue 31354: Difference for price variant calculation
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 09 Feb 2016 12:46:23 +0100] rev 28597
Related to issue 31354: Difference for price variant calculation

The difference for price variants is now calculated and posted in the Acct. Schema currency as it was originally done

Tue, 17 Nov 2015 17:32:11 +0100Fixed bug 31354: Wrong amtsourcedr and amtsourcecr when posting Matched Invoice
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 17 Nov 2015 17:32:11 +0100] rev 28596
Fixed bug 31354: Wrong amtsourcedr and amtsourcecr when posting Matched Invoice

The cost is always calculated and posted in the organization's currency.
The expense is calculated and posted in the invoice's currency.

The conversion date from the cost currency to the acct. schema currency uses the shipment accounting date.
The conversion date from the invoice currency to the acct. schema currency uses the invoice accounting date.

The difference for the price variant is calculated and posted in the cost currency.

In case there is a difference in the conversion rate between the order and the invoice, the usual currency balance entry is automatically created

Fri, 12 Feb 2016 09:01:15 +0100related to issue 31766: put correct location selector title
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 12 Feb 2016 09:01:15 +0100] rev 28595
related to issue 31766: put correct location selector title

Thu, 11 Feb 2016 16:31:20 +0100Fixed bug 32203: Not possible to post a remittance and the settlement of that remittance
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 11 Feb 2016 16:31:20 +0100] rev 28594
Fixed bug 32203: Not possible to post a remittance and the settlement of that remittance

The way to retrieve the payment detail object was wrong. Instead we can take it directly from the paymentDetails list

Thu, 11 Feb 2016 16:16:57 +0530Fixes Issue 0032157: Not possible to sort by unit price in Return from
Atul Gaware <atul.gaware@openbravo.com> [Thu, 11 Feb 2016 16:16:57 +0530] rev 28593
Fixes Issue 0032157: Not possible to sort by unit price in Return from
Customer p&e

In case of the Return From Customer for a numeric value of unit Price COALESCE
was being use with '' which should have been 0 instead, COALESCE for order no
was missing for RTC, additonal ReturnReasonLeftClause2 added to replace
EntityAlias.name in the transformeredHQL Query.

Thu, 11 Feb 2016 15:57:36 +0100fixes issue 32202: Error in add payment when editing the amount of a record
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 11 Feb 2016 15:57:36 +0100] rev 28592
fixes issue 32202: Error in add payment when editing the amount of a record

The entered value is being set on the changed method for number items. This is done in order to prevent placing the decimal separator in a wrong place. This problem only affects to standard windows.

To solve the problem we only set the number item value in the changed method when we are not in a pick and edit window but in a standard window.

Fri, 05 Feb 2016 12:02:24 +0100Fixes issue 32089: Reservations with stock in second UOM will not be created
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Feb 2016 12:02:24 +0100] rev 28591
Fixes issue 32089: Reservations with stock in second UOM will not be created

M_RESERVE_STOCK_AUTO will exclude lines from m_storage_detail with second uom to avoid create stock reservation lines for products with stock in second UOM, as it is done in M_CREATE_RESERVE_FROM_SOL.

Wed, 10 Feb 2016 17:08:23 +0100Related to issue 32038: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 10 Feb 2016 17:08:23 +0100] rev 28590
Related to issue 32038: code review improvements

* startingDate is a mandatory column, so there is no need to validate whether it's null or not
* The promotion is applied for the period of time between the Starting and Ending Dates (both inclusive). For example, for a promotion available only in a concrete date, the starting and ending dates must be equal.
The date received as parameter to this query might have a time (hours/minutes/seconds). To control that situation the comparation is truncating the promotion starting and ending date (that should already be truncated because it's linked to a Date reference), it adds 1 day to the promotion ending date and removes the equal clause. Thus we can properly control the scenario of a one-day promotion with a datetime parameter.

Mon, 01 Feb 2016 16:54:12 -0500Fixes Issue 32038: "Price Adjustment" promotion type is applied to a line only
Nono Carballo <f.carballo@nectus.com> [Mon, 01 Feb 2016 16:54:12 -0500] rev 28589
Fixes Issue 32038: "Price Adjustment" promotion type is applied to a line only
if the order/invoice date falls into the promotion period.

The HQL query was tuned to take into account the starting and ending date of the
promotion when selecting a product for a line in a purchase order/invoice.
The line only gets the promotion if the period encloses the order/invoice date,
start and end date included.
The line hql += "and (endingDate is null or endingDate>:date) "; was replaced with

hql += "and (endingDate is null or endingDate>=:date) ";
hql += "and (startingDate is null or startingDate<=:date) ";

Thu, 04 Feb 2016 12:24:30 +0100Fixes issue 32109: Review allow filtering and allow sorting in computed columns
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 04 Feb 2016 12:24:30 +0100] rev 28588
Fixes issue 32109: Review allow filtering and allow sorting in computed columns

Computed columns belonging to a table with high volumes or having a complex query have been disabled for filtering and sorting.
Only computed columns in low volume tables and with a simple query will allow filtering and sorting.