Tue, 21 Jul 2015 08:59:53 +0200Related to issue 30286: Modulescript ERP Version Update Expose Project
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 21 Jul 2015 08:59:53 +0200] rev 27142
Related to issue 30286: Modulescript ERP Version Update Expose Project

Fri, 17 Jul 2015 15:04:27 +0200Related to Issue 30315: Do not take into account Transactions in Skip Status.
David Miguelez <david.miguelez@openbravo.com> [Fri, 17 Jul 2015 15:04:27 +0200] rev 27141
Related to Issue 30315: Do not take into account Transactions in Skip Status.
Remove them from the queries.
In Costing Server, set all Transactions as isProcessed=Y when they go through
doProcess() method.

Fri, 17 Jul 2015 09:43:31 +0200Related to issue 30376: M_PriceList_Create removed unreached code
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 17 Jul 2015 09:43:31 +0200] rev 27140
Related to issue 30376: M_PriceList_Create removed unreached code
At the beginning of the process an error is raised when v_Costbased = 'N' AND (v_PriceList_Version_Base_ID IS NULL OR v_PriceList_Version_Base_ID='').
In this changeset we delete the code afterwards that would be only executed when the previous condition is true

Fri, 17 Jul 2015 09:30:16 +0200Related to issue 30376: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 17 Jul 2015 09:30:16 +0200] rev 27139
Related to issue 30376: code review improvements
Removed piece of code where IsCurrentVendor is set to Y. This process shouldn't update this column

Thu, 16 Jul 2015 17:21:16 +0530Fixes Issue 30376:The Create Price List process is modifying the Current
Atul Gaware <atul.gaware@openbravo.com> [Thu, 16 Jul 2015 17:21:16 +0530] rev 27138
Fixes Issue 30376:The Create Price List process is modifying the Current
Vendor field when it should not

In case of multiple m_product_po register's for same product and same
business partner keeping iscurrentvendor flag active only for one register
is no more needed due to unique constraint applied on m_product_po for
m_product_id and c_bpartner_id during r2.5x merge into trunk.

Thu, 16 Jul 2015 14:00:19 +0200Adds copyright header in BOM Taxes tests
Adrián Romero <adrianromero@openbravo.com> [Thu, 16 Jul 2015 14:00:19 +0200] rev 27137
Adds copyright header in BOM Taxes tests

Thu, 16 Jul 2015 09:31:09 +0200BOM Taxes project
Adrián Romero <adrianromero@openbravo.com> [Thu, 16 Jul 2015 09:31:09 +0200] rev 27136
BOM Taxes project
This commit contains all the BOM Taxes project that implements the calculation of taxes for BOM products

Wed, 15 Jul 2015 17:49:30 +0200Fixed issue 30372: Added accounting date to Add Multiple Payments process
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 15 Jul 2015 17:49:30 +0200] rev 27135
Fixed issue 30372: Added accounting date to Add Multiple Payments process

A new process parameter called Accounting Date has been added to the Add Multiple Payments process. The transaction(s) created by this process will have the entered Accounting Date (in a similar way we already do for the transaction date).

Tue, 14 Jul 2015 17:13:47 +0200Fixes issue 30315: Sets each Transaction as isProcessed=Y after been processed.
David Miguelez <david.miguelez@openbravo.com> [Tue, 14 Jul 2015 17:13:47 +0200] rev 27134
Fixes issue 30315: Sets each Transaction as isProcessed=Y after been processed.

Tue, 14 Jul 2015 12:46:42 +0530Fixes Issue 27439:pl-function c_getwithholding has wrong datatype for variable
Atul Gaware <atul.gaware@openbravo.com> [Tue, 14 Jul 2015 12:46:42 +0530] rev 27133
Fixes Issue 27439:pl-function c_getwithholding has wrong datatype for variable

Withholding variable was wrongly defined as varchar during merge r2.5x into
trunk.

Wed, 15 Jul 2015 10:02:45 +0200fixed bug 30348: selecting language profile changes selected warehouse
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 15 Jul 2015 10:02:45 +0200] rev 27132
fixed bug 30348: selecting language profile changes selected warehouse

When items are changed in profile popup, warehouses are recaulated to match
current settings and selected item is set to 1st option. In case of language
change warehouse selection shouldn't be modified.

Mon, 13 Jul 2015 16:37:22 +0530Fixes Issue 27437: Trigger A_AMORTIZATIONLINE_TRG2 is useless and should be
Atul Gaware <atul.gaware@openbravo.com> [Mon, 13 Jul 2015 16:37:22 +0530] rev 27131
Fixes Issue 27437: Trigger A_AMORTIZATIONLINE_TRG2 is useless and should be
deleted

Removed trigger A_AMORIZATIONLINE_TRG2. Code to update DepreciatedPlan is
implemented in A_AMORTIZATIONLINE_TRG so there is no harm in removing this
trigger.

Fri, 10 Jul 2015 12:53:42 +0200Fixed 30338: Remove not needed pg_authid.rolcatupdate sql to fix pg9.5
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 10 Jul 2015 12:53:42 +0200] rev 27130
Fixed 30338: Remove not needed pg_authid.rolcatupdate sql to fix pg9.5

Postgresql 9.5 did remove the pg_authid.rolcatupdate column which is
explicitely set during db user creation by openbravo.
As that change is not needed anyway just delete the sql. It is not needed
as value for that boolean defaults to true for db superuser's anyway.

Mon, 13 Jul 2015 13:15:38 +0200Related to issue 30292: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 13 Jul 2015 13:15:38 +0200] rev 27129
Related to issue 30292: code review improvements

1. Ordered by dt.default desc to get first the records with default = Y
2. Ordered by dt.id desc as it was in the original code.
Note that this order is different from the one used at AD_GET_DOCTYPE. However I have kept this order to to get the same records as in the past (otherwise it could be considered as a functional regression)
3. Limit query to just 1 record to improve performance

Sat, 11 Jul 2015 10:35:43 +0530Fixes Issue 30292:Wrong Document Type calculation when there are types
Atul Gaware <atul.gaware@openbravo.com> [Sat, 11 Jul 2015 10:35:43 +0530] rev 27128
Fixes Issue 30292:Wrong Document Type calculation when there are types
configured in the legal entity and the store (generic child organization)

Instead of OBCriteria, OBQuery is implemented in order to sort record by
organization parent level using ad_isorgincluded function prior to default
flag and id.

Fri, 10 Jul 2015 13:19:36 +0200fixed bug 30337: pg version check prevents using 9.5ahpha1
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 10 Jul 2015 13:19:36 +0200] rev 27127
fixed bug 30337: pg version check prevents using 9.5ahpha1

The check compares version with 9.1 but it took 9.5alpha1 as whole version where
alpha1 string part should be removed.

Fixed by removing textual parts of the version (this was already done for Oracle)

Fri, 10 Jul 2015 11:56:32 +0200Related to issue 30260: Code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 10 Jul 2015 11:56:32 +0200] rev 27126
Related to issue 30260: Code review improvements

FIN_AddPaymentFromJournal.java:
1. Removed unused variables
2. Warning message improved to inform the user that the reactivation process was succesfull

GLJournalLineEventHandler.java:
1. Removed TODO comment
2. Moved check stuff to a separate method
3. Cast objects to compare to BigDecimal and Boolean and use the right comparator methods

Fri, 10 Jul 2015 11:24:17 +0530Fixes Issue 30260:It is not possible to Reactivate a GL Journal with any
Atul Gaware <atul.gaware@openbravo.com> [Fri, 10 Jul 2015 11:24:17 +0530] rev 27125
Fixes Issue 30260:It is not possible to Reactivate a GL Journal with any
line defined as "open items"

Reactivating of GL Journal is allowed when its line/s have related payment
with a warning message. If user tries to change credit / debit or open item
flag of line having related payment event handler takes care to avoid user
to update line. Warning/Error message guides user to reactivate and delete
related payment inorder to update credit/debit, financial account, payment
method, glitem, payment date of the line.

Thu, 09 Jul 2015 15:44:22 +0200Fixed bug 29242: Initial Balance incorrectly calculated in PDF
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 09 Jul 2015 15:44:22 +0200] rev 27124
Fixed bug 29242: Initial Balance incorrectly calculated in PDF
General Ledger Report when grouping by BP

The PDF format only was not grouping by the grouping criteria due to a typo when calling the AddTotals() constructor.
After the fix, both HTML and PDF formats show the same figures in the Initial Balance fields

Wed, 08 Jul 2015 12:59:54 +0200[cdi-test] fixed MenuTemplateTest test case and added to all ant tests
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 08 Jul 2015 12:59:54 +0200] rev 27123
[cdi-test] fixed MenuTemplateTest test case and added to all ant tests

It also fixes ambigous injection point when executing together with retail
caused by POSApplicationFormatComponent extending ApplicationComponent

Wed, 08 Jul 2015 11:26:06 +0200[cdi-junit fixed classpath for run.api.test.javascript task
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 08 Jul 2015 11:26:06 +0200] rev 27122
[cdi-junit fixed classpath for run.api.test.javascript task

Tue, 07 Jul 2015 15:44:10 +0530Fixes Issue 27126:Pending goods receipt - Receives goods even though periods
Atul Gaware <atul.gaware@openbravo.com> [Tue, 07 Jul 2015 15:44:10 +0530] rev 27121
Fixes Issue 27126:Pending goods receipt - Receives goods even though periods
are closed

Check period open is done prior to Goods Receipt creation using Pending Goods
Receipt form.

Tue, 07 Jul 2015 18:49:21 +0200Related to issue 30073: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 07 Jul 2015 18:49:21 +0200] rev 27120
Related to issue 30073: code review improvements

CreateFrom.java:
1. Use admin mode to get order line
2. Avoid possible NPE when getting data[i].cOrderlineId

C_INVOICE_CREATE:
1. Added rounding to currency precission
2. Tax Base Amount pro-rating support when running Generate Invoices and we select a partially shipped order

Tue, 07 Jul 2015 16:04:14 +0530Fixes Issue 30073:Different Alternate Tax Base Amount in a partial invoice
Atul Gaware <atul.gaware@openbravo.com> [Tue, 07 Jul 2015 16:04:14 +0530] rev 27119
Fixes Issue 30073:Different Alternate Tax Base Amount in a partial invoice
from order depending on the process used

Fix takes care to copy proportionate alternate taxable amount as per qty
being invoiced of the sales order line alternate tax amount. It applies
for both Create Lines From process in Sales Invoice and Create Invoices
From Order process.

Divide by zero is taken care of and cur precision is used
while division operation for rounding purpose.

Wed, 08 Jul 2015 08:13:50 +0200fixed issue 21765 fixed issue 28955: enabled cdi in jUnit test cases
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 08 Jul 2015 08:13:50 +0200] rev 27118
fixed issue 21765 fixed issue 28955: enabled cdi in jUnit test cases

Tue, 07 Jul 2015 14:14:49 +0200[cdi-junit] DynamicExpressionParserTest needs to extend WeldBaseTest
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 07 Jul 2015 14:14:49 +0200] rev 27117
[cdi-junit] DynamicExpressionParserTest needs to extend WeldBaseTest

in order to be able to execute it within a suite which already used cdi, if not
it tries to use injection resulting in NPE

Tue, 07 Jul 2015 14:11:46 +0200[cdi-junit] proper initialization of interceptors in WeldBaseTest
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 07 Jul 2015 14:11:46 +0200] rev 27116
[cdi-junit] proper initialization of interceptors in WeldBaseTest

to allow execution of test suites.

Mon, 06 Jul 2015 12:33:00 +0200[cdi-junit] paths for eclipse linked sources are relative
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 06 Jul 2015 12:33:00 +0200] rev 27115
[cdi-junit] paths for eclipse linked sources are relative

Thu, 02 Jul 2015 14:19:39 +0200[cdi-junit] fixed test class name
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 02 Jul 2015 14:19:39 +0200] rev 27114
[cdi-junit] fixed test class name

Thu, 02 Jul 2015 12:10:06 +0200[cdi-juni] fixed src-test/.project path
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 02 Jul 2015 12:10:06 +0200] rev 27113
[cdi-juni] fixed src-test/.project path